ipack: Rename ipack_bus_new_inplace() to ipack_bus_init()Rename ipack_bus_new_inplace() to ipack_bus_init(), to bring it in toline with a "_init for in-place init, _new for allocate-and-return"co
ipack: Rename ipack_bus_new_inplace() to ipack_bus_init()Rename ipack_bus_new_inplace() to ipack_bus_init(), to bring it in toline with a "_init for in-place init, _new for allocate-and-return"convention. Drop the 'name' argument, because the only caller doesnot pass in a name. If a future caller does need to specify the busname, we should create an ipack_bus_init_named() function at thatpoint.Signed-off-by: Peter Maydell <peter.maydell@linaro.org>Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>Reviewed-by: Michael S. Tsirkin <mst@redhat.com>Message-id: 20210923121153.23754-3-peter.maydell@linaro.org
show more ...
Use OBJECT_DECLARE_SIMPLE_TYPE when possibleThis converts existing DECLARE_INSTANCE_CHECKER usage toOBJECT_DECLARE_SIMPLE_TYPE when possible.$ ./scripts/codeconverter/converter.py -i \ --patte
Use OBJECT_DECLARE_SIMPLE_TYPE when possibleThis converts existing DECLARE_INSTANCE_CHECKER usage toOBJECT_DECLARE_SIMPLE_TYPE when possible.$ ./scripts/codeconverter/converter.py -i \ --pattern=AddObjectDeclareSimpleType $(git grep -l '' -- '*.[ch]')Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>Acked-by: Paul Durrant <paul@xen.org>Message-Id: <20200916182519.415636-6-ehabkost@redhat.com>Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
qom: Remove module_obj_name parameter from OBJECT_DECLARE* macrosOne of the goals of having less boilerplate on QOM declarationsis to avoid human error. Requiring an extra argument that isnever
qom: Remove module_obj_name parameter from OBJECT_DECLARE* macrosOne of the goals of having less boilerplate on QOM declarationsis to avoid human error. Requiring an extra argument that isnever used is an opportunity for mistakes.Remove the unused argument from OBJECT_DECLARE_TYPE andOBJECT_DECLARE_SIMPLE_TYPE.Coccinelle patch used to convert all users of the macros: @@ declarer name OBJECT_DECLARE_TYPE; identifier InstanceType, ClassType, lowercase, UPPERCASE; @@ OBJECT_DECLARE_TYPE(InstanceType, ClassType, - lowercase, UPPERCASE); @@ declarer name OBJECT_DECLARE_SIMPLE_TYPE; identifier InstanceType, lowercase, UPPERCASE; @@ OBJECT_DECLARE_SIMPLE_TYPE(InstanceType, - lowercase, UPPERCASE);Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>Reviewed-by: Cédric Le Goater <clg@kaod.org>Acked-by: Cornelia Huck <cohuck@redhat.com>Acked-by: Igor Mammedov <imammedo@redhat.com>Acked-by: Paul Durrant <paul@xen.org>Acked-by: Thomas Huth <thuth@redhat.com>Message-Id: <20200916182519.415636-4-ehabkost@redhat.com>Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Use OBJECT_DECLARE_TYPE where possibleReplace DECLARE_OBJ_CHECKERS with OBJECT_DECLARE_TYPE where thetypedefs can be safely removed.Generated running:$ ./scripts/codeconverter/converter.py -i
Use OBJECT_DECLARE_TYPE where possibleReplace DECLARE_OBJ_CHECKERS with OBJECT_DECLARE_TYPE where thetypedefs can be safely removed.Generated running:$ ./scripts/codeconverter/converter.py -i \ --pattern=DeclareObjCheckers $(git grep -l '' -- '*.[ch]')Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>Message-Id: <20200831210740.126168-16-ehabkost@redhat.com>Message-Id: <20200831210740.126168-17-ehabkost@redhat.com>Message-Id: <20200831210740.126168-18-ehabkost@redhat.com>Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Use DECLARE_*CHECKER* macrosGenerated using: $ ./scripts/codeconverter/converter.py -i \ --pattern=TypeCheckMacro $(git grep -l '' -- '*.[ch]')Reviewed-by: Daniel P. Berrangé <berrange@redha
Use DECLARE_*CHECKER* macrosGenerated using: $ ./scripts/codeconverter/converter.py -i \ --pattern=TypeCheckMacro $(git grep -l '' -- '*.[ch]')Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>Reviewed-by: Juan Quintela <quintela@redhat.com>Message-Id: <20200831210740.126168-12-ehabkost@redhat.com>Reviewed-by: Juan Quintela <quintela@redhat.com>Message-Id: <20200831210740.126168-13-ehabkost@redhat.com>Message-Id: <20200831210740.126168-14-ehabkost@redhat.com>Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Move QOM typedefs and add missing includesSome typedefs and macros are defined after the type check macros.This makes it difficult to automatically replace theirdefinitions with OBJECT_DECLARE_TY
Move QOM typedefs and add missing includesSome typedefs and macros are defined after the type check macros.This makes it difficult to automatically replace theirdefinitions with OBJECT_DECLARE_TYPE.Patch generated using: $ ./scripts/codeconverter/converter.py -i \ --pattern=QOMStructTypedefSplit $(git grep -l '' -- '*.[ch]')which will split "typdef struct { ... } TypedefName"declarations.Followed by: $ ./scripts/codeconverter/converter.py -i --pattern=MoveSymbols \ $(git grep -l '' -- '*.[ch]')which will:- move the typedefs and #defines above the type check macros- add missing #include "qom/object.h" lines if necessaryReviewed-by: Daniel P. Berrangé <berrange@redhat.com>Reviewed-by: Juan Quintela <quintela@redhat.com>Message-Id: <20200831210740.126168-9-ehabkost@redhat.com>Reviewed-by: Juan Quintela <quintela@redhat.com>Message-Id: <20200831210740.126168-10-ehabkost@redhat.com>Message-Id: <20200831210740.126168-11-ehabkost@redhat.com>Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Include hw/qdev-properties.h lessIn my "build everything" tree, changing hw/qdev-properties.h triggersa recompile of some 2700 out of 6600 objects (not counting tests andobjects that don't depend
Include hw/qdev-properties.h lessIn my "build everything" tree, changing hw/qdev-properties.h triggersa recompile of some 2700 out of 6600 objects (not counting tests andobjects that don't depend on qemu/osdep.h).Many places including hw/qdev-properties.h (directly or via hw/qdev.h)actually need only hw/qdev-core.h. Include hw/qdev-core.h thereinstead.hw/qdev.h is actually pointless: all it does is include hw/qdev-core.hand hw/qdev-properties.h, which in turn includes hw/qdev-core.h.Replace the remaining uses of hw/qdev.h by hw/qdev-properties.h.While there, delete a few superfluous inclusions of hw/qdev-core.h.Touching hw/qdev-properties.h now recompiles some 1200 objects.Cc: Paolo Bonzini <pbonzini@redhat.com>Cc: "Daniel P. Berrangé" <berrange@redhat.com>Cc: Eduardo Habkost <ehabkost@redhat.com>Signed-off-by: Markus Armbruster <armbru@redhat.com>Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>Message-Id: <20190812052359.30071-22-armbru@redhat.com>
ipack: Update e-mail addressI'm not really using the old one anymore.Signed-off-by: Alberto Garcia <berto@igalia.com>Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
ipack: Move IndustryPack out of hw/char/Move the header defining an IPackBus and IPackDevice base class intoa new include/ directory and move their implementation and aPCI-IndustryPack bridge out
ipack: Move IndustryPack out of hw/char/Move the header defining an IPackBus and IPackDevice base class intoa new include/ directory and move their implementation and aPCI-IndustryPack bridge out of hw/char/ directory into a new hw/ipack/.Acked-by: Alberto Garcia <agarcia@igalia.com>Signed-off-by: Andreas Färber <afaerber@suse.de>