Enable pycodestyle

Apply fix-ups and run pycodestyle during CI testing.

Change-Id: I1005495b11e228abdc8d40a51dbf81c4a6e6c92c
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

Port to python 3

Port code to python 3 yet remain backward compatible to python 2.
This port is in preparation for yocto 2.4 upgrade.

Change-Id: I564824b00c106a2c7ebd2f4a9607cd01eabf1322
Signed-off

Port to python 3

Port code to python 3 yet remain backward compatible to python 2.
This port is in preparation for yocto 2.4 upgrade.

Change-Id: I564824b00c106a2c7ebd2f4a9607cd01eabf1322
Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>

show more ...

Revert "Port obmc to python3.5"

Parse error with this change:
TypeError: iter() returned non-iterator of type 'PathTreeItemIterator'

This reverts commit f99783be6592130bbad2d0f69ada2b7ac61618f3.

C

Revert "Port obmc to python3.5"

Parse error with this change:
TypeError: iter() returned non-iterator of type 'PathTreeItemIterator'

This reverts commit f99783be6592130bbad2d0f69ada2b7ac61618f3.

Change-Id: Id2b7f4af5284d25d59e19905c7b873726b02f700
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Port obmc to python3.5

Change-Id: I1ed6c6bd914635485a697369048a8be9e5919fc6
Signed-off-by: Balaji B Rao <balajibapu@gmail.com>

dbuslib: Fix UnknownInterface error

The string "org.freedesktop.UnknownInterface" is not an
existing dbus error string, all errors are of format
*.DBus.Error.* so change this error string to the rig

dbuslib: Fix UnknownInterface error

The string "org.freedesktop.UnknownInterface" is not an
existing dbus error string, all errors are of format
*.DBus.Error.* so change this error string to the right one.

Also fix the error responses when dbus errors are raised.

Part of openbmc/openbmc#2463

Change-Id: I384393a6f81c5057173e2941cd109e2f952e1311
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

dbuslib: Add decorator for property only ifaces

The built-in Introspect method in dbus-python doesn't find
interfaces if the @method or @signal decorators aren't used
(property-only interfaces). Us

dbuslib: Add decorator for property only ifaces

The built-in Introspect method in dbus-python doesn't find
interfaces if the @method or @signal decorators aren't used
(property-only interfaces). Use this decorator on classes
derived from dbus.service.Object to help the dbus-python provided
Introspect method find these interfaces.

Change-Id: Icaf6fc3a32ce44a653a440ae5ca531cf67a4e1cf
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

dbuslib: Point OBJ_PREFIX at new xyz namespace

Resolves: openbmc/openbmc#1314

Change-Id: I20e1a64ceb9928c17cbd4217fa93941cf2912aa1
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

dbus-binding: Fix 'pop' error when no validator given

Fixes openbmc/openbmc#606.

Change-Id: Id39435f8177d053c317ebe2e48c1c3fd9d3a2385
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

Callback input validator function on property set

This will provide a way for subclasses to register a callback handler which will
then be called into whenever a property update is attempted. The c

Callback input validator function on property set

This will provide a way for subclasses to register a callback handler which will
then be called into whenever a property update is attempted. The callback will
validate the user inputs and then either throw exception or return success. On
an exception, its rethrown.

Change-Id: I4c1920adb7e4873f2c530752313dd3ebc2230dc2
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

show more ...

bindings: cooperative multiple inheritance

Update Properties and ObjectManager constructors
such that they cooperate in a multiple inheritance
hierarchy.

For details, see this blog post referenced

bindings: cooperative multiple inheritance

Update Properties and ObjectManager constructors
such that they cooperate in a multiple inheritance
hierarchy.

For details, see this blog post referenced by the
official python documentation:
https://rhettinger.wordpress.com/2011/05/26/super-considered-super

Change-Id: I586e6fa9f1a369693c73b9307786d3c8a05dd9a3
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

bindings: Add missing module imports

Change-Id: I498d6e2437b91263de825456125e3b805efa0179
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

bindings: remove unused methods

Change-Id: I99eb622d963d9bb8df6fd9072c482f71c8e881c2
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

propertycacher: context manager for file open

Change-Id: Ib75f3f5ccbd35d7e70d9c171c0642077930c4741
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

propertycacher: make parent directories

Change-Id: I4557ddab56f4cbea5b177e3b05ef28c367c6e602
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

Remove find_dbus_interfaces

Waffling yet again on where this should be located. Move back
to the mapper to discourage other applications from introspection
and encourage use of the mapper.

Change-

Remove find_dbus_interfaces

Waffling yet again on where this should be located. Move back
to the mapper to discourage other applications from introspection
and encourage use of the mapper.

Change-Id: I78dc815baeb46d6b2d155d02318fba230d7420d2
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Allow control of signal generation

Typically ObjectManager signals should remain masked
until a service has grabbed a well-known bus name to
avoid pointless dbus signal generation.

Change-Id: I2670

Allow control of signal generation

Typically ObjectManager signals should remain masked
until a service has grabbed a well-known bus name to
avoid pointless dbus signal generation.

Change-Id: I26703ec7a8b946128fe5aa8ed1c830a2e8f23c21
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Improve short-lived object handling

Its expected that services will appear on the bus and may or may
not be around log enough for introspection to take place. Catch
those exceptions and continue.

Improve short-lived object handling

Its expected that services will appear on the bus and may or may
not be around log enough for introspection to take place. Catch
those exceptions and continue.

Change-Id: I77963d5af9d8267d1813bd2197ff287f06f7d2cd
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Remove unnecessary variable

Change-Id: I64847ffa6a0078ce66c3117a51df0fd6188a0f8c
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

Remove name mangling from find_dbus_interfaces

Double underscore in Python mangles names and sometimes is
used as a way to make things private; however, in general
this isn't considered best practic

Remove name mangling from find_dbus_interfaces

Double underscore in Python mangles names and sometimes is
used as a way to make things private; however, in general
this isn't considered best practice and there isn't a compelling
reason for it here.

Rather, the convention for denoting a private interface is
to use a single leading underscore.

For more information:
http://www.artima.com/weblogs/viewpost.jsp?thread=211430

Change-Id: Id42b0dc670dc1f90ed52f38ac98a82ff8214ee47
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Add find_dbus_interfaces to introspection utils

This is a straight copy from phosphor-objmgr.

Change-Id: I4792be46b755774af4a29cb1d603253738db3e4a
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirre

Add find_dbus_interfaces to introspection utils

This is a straight copy from phosphor-objmgr.

Change-Id: I4792be46b755774af4a29cb1d603253738db3e4a
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Add alias for org.freedesktop.DBus.Error.NoReply

Change-Id: If112ed9db5c7fb8935daf2245736e039209d0798
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

Remove org.openbmc.Object.Enumerate interface

Everyone should be using the freedesktop ObjectManager for this.

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

Merge pull request #4 from bradbishop/sensors-propertycacher

Move sensors.py and propertycacher.py frm skeleton

Merge pull request #2 from bradbishop/set-multiple-bug

Fix bug injected during skeleton port

Move sensors.py and propertycacher.py frm skeleton

These skeleton module are somewhat general purpose so move them
here.
This is just a straight copy plus a pep8 run.

Signed-off-by: Brad Bishop <br

Move sensors.py and propertycacher.py frm skeleton

These skeleton module are somewhat general purpose so move them
here.
This is just a straight copy plus a pep8 run.

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...