platform-mc: Correct the discovered terminus condition

When the terminus is discovered, the terminus shared pointer will be
added to `termini` list. So `termini[tid]` will not be `nullptr`.
Correct

platform-mc: Correct the discovered terminus condition

When the terminus is discovered, the terminus shared pointer will be
added to `termini` list. So `termini[tid]` will not be `nullptr`.
Correct the discovered terminus condition.

Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>
Change-Id: I070e927d34a49d0fdbc02fcd9dbbcd4be2f897a7

show more ...

platform-mc: Support pollForPlatFormEventMessage

Supports polling all events synchronously when the terminus sends
`pldmMessagePollEvent` with the event id. BMC will use the received
event id as inp

platform-mc: Support pollForPlatFormEventMessage

Supports polling all events synchronously when the terminus sends
`pldmMessagePollEvent` with the event id. BMC will use the received
event id as input for `pollForPlatformEventMessage` command to retrieve
the event data.

Change-Id: If01f63f30d3f57f8423c863ec776e83dda8e3042
Signed-off-by: Dung Cao <dung@os.amperecomputing.com>
Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>

show more ...

configs: Add PCIe slot power states for Bonnell

Add the entries to Bonnell's 11.json so that the host can send down the
PCIE slot power states for the four PCIe slots. These are the same as
on Rain

configs: Add PCIe slot power states for Bonnell

Add the entries to Bonnell's 11.json so that the host can send down the
PCIE slot power states for the four PCIe slots. These are the same as
on Rainier and Everest.

Tested:
The power state in phosphor-inventory-manager is accurately reflected
for a plugged in card.

Change-Id: Ic04e6d11750add7656bc7ac40135e2bfa4b8490e
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

event-manager: Fix handling the event of undiscovered terminus

Currently, there are two event handlers, one from IBM `oem/ibm` and one
from `platform-mc` code. The event-manager in `platform-mc` sho

event-manager: Fix handling the event of undiscovered terminus

Currently, there are two event handlers, one from IBM `oem/ibm` and one
from `platform-mc` code. The event-manager in `platform-mc` should only
handles the event from the discovered termini by `platform-mc` code.
Add the valid TID checking before start handling the received events
from termini.

Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>
Change-Id: Idcbd33424a82c0cf7c9aebbd132435747534b2f8

show more ...

oem-ibm: Change in dynamic deallocation BIOS attribute

This commit enhances the display name and help text of
hb_predictive_mem_guard and hb_predictive_mem_guard_current bios enum
attributes.

Teste

oem-ibm: Change in dynamic deallocation BIOS attribute

This commit enhances the display name and help text of
hb_predictive_mem_guard and hb_predictive_mem_guard_current bios enum
attributes.

Tested: Verified the change with redfish BIOS registry and verified with
dbus BIOS config manager.

Change-Id: I33fc426b92a90a826403142bb85e0db3de094b0a
Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>

show more ...

platform-mc: Init `hysteresis` value for compact numeric sensors

The Compact numeric sensor PDRs do not include `hysteresis` field in
the PDRs `Table 103 - Compact Numeric Sensor PDR format` in DSP0

platform-mc: Init `hysteresis` value for compact numeric sensors

The Compact numeric sensor PDRs do not include `hysteresis` field in
the PDRs `Table 103 - Compact Numeric Sensor PDR format` in DSP0248
V1.3.0. The `hysteresis` is used for checking the sensor threshold so it
should be initialized when constructing the sensors object for compact
numeric sensor PDRs.

Tested:
1. Disable `sensorEvent` event handling.
2. Change sensor thresholds use PLDM `SetSensorThresholds` command.
3. Restart `pldmd` service to apply new threshold in sensor D-Bus.
3. When the sensor reading value reaches the threshold condition check
the Ipmitool/Redfish SEL log.

Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>
Change-Id: I1187c44fc6b9b4b38ef953e72db7d9f96eb7e0bd

show more ...

oem-ibm: Add the dbus timeout while setting UAK

This commit adds the dbus timeout while setting the changed firmware
UAK value.

Tested:
Verified that UAK update is getting reflected in the correspo

oem-ibm: Add the dbus timeout while setting UAK

This commit adds the dbus timeout while setting the changed firmware
UAK value.

Tested:
Verified that UAK update is getting reflected in the corresponding
UTIL D8 VPD keyword and the redfish

Change-Id: I86e75a51e324b8ac0df8684cd005ceddada85bce
Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>

show more ...

Revert "Fix invalid read by adjusting request size"

This reverts commit 35f25949fe4d982f389db6de13c86d5838147399.

The related libpldm commit [1] has also been reverted, as it poses the
risk of affe

Revert "Fix invalid read by adjusting request size"

This reverts commit 35f25949fe4d982f389db6de13c86d5838147399.

The related libpldm commit [1] has also been reverted, as it poses the
risk of affecting other users of libpldm beyond just pldm. Addressing
the issue solely within pldm would only provide a limited fix.

Therefore, we have decided to revert the changes in order to explore a
more comprehensive solution within libpldm, ensuring compatibility for
all users.

[1] https://gerrit.openbmc.org/c/openbmc/libpldm/+/75123

Change-Id: If4b0f91195f9defe7f015f9e3fb686f33931fa01
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

platform-mc: sensor: Support none-telemetry base unit

As [1], The sensor D-Bus object path `/xyz/openbmc_project/sensors/` and
`xyz.openbmc_project.Sensor.Value` interface are only used for the
tele

platform-mc: sensor: Support none-telemetry base unit

As [1], The sensor D-Bus object path `/xyz/openbmc_project/sensors/` and
`xyz.openbmc_project.Sensor.Value` interface are only used for the
telemetry sensor types which are listed. The non-telemetry PLDM sensor
with the `baseUnit` type `count`, `corrected_errors`,
`uncorrected_errors` and `oemunit` are none-telemetry types and are not
belong to that list.
Those unit types are metric types which are count of somethings so the
metric D-Bus object path `/xyz/openbmc_project/metric/` and D-Bus
`xyz.openbmc_project.Metric.Value` should be used as [2]. Support
creating D-Bus object path and polling sensor values for the numeric
sensor/compact numeric sensor PDRs with the BaseUnit type is
none-telemetry.

[1] https://github.com/openbmc/phosphor-dbus-interfaces/blob/90cfce16584253a5f524c718ce5a6ae7c33f7b8c/yaml/xyz/openbmc_project/Sensor/Value.interface.yaml#L1
[2] https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/yaml/xyz/openbmc_project/Sensor/Value.interface.yaml

Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>
Change-Id: Iaf8d842e6ec0cb082b139d15da1a1bd10a701acf

show more ...

Fix invalid read by adjusting request size

The recent changes in `libpldm`[1] introduced a modification in the
size definitions for PLDM requests. Specifically, the size for
`PLDM_SET_EVENT_RECEIVER

Fix invalid read by adjusting request size

The recent changes in `libpldm`[1] introduced a modification in the
size definitions for PLDM requests. Specifically, the size for
`PLDM_SET_EVENT_RECEIVER_REQ_BYTES` was changed from 5 bytes to 3
bytes, with the addition of a new definition
`PLDM_SET_EVENT_RECEIVER_REQ_HEARTBEAT_BYTES` (2 bytes).

Previously, the event manager code used the
`PLDM_SET_EVENT_RECEIVER_REQ_BYTES` definition directly, which
accounted for 5 bytes. However, after the update in `libpldm`, the test
cases began failing when run under Valgrind due to invalid reads, as
the total request size was no longer correctly accounted for.

This commit resolves the issue by adjusting the size of the request in
the `setEventReceiver` method, using both the
`PLDM_SET_EVENT_RECEIVER_REQ_BYTES` and
`PLDM_SET_EVENT_RECEIVER_REQ_HEARTBEAT_BYTES` definitions to ensure the
proper size is used.

Tested by:
```bash
meson test -t 10 -C build --print-errorlogs --wrapper "valgrind --error-exitcode=1"
```

[1]: https://github.com/openbmc/libpldm/commit/8c43abb70aeadde39d99af2c1b6b5d4a1416fc47

Change-Id: Ieb86d764b0c60a79d0a7f0f92f60ddf8812e6e84
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

platform-mc: Set synchrony mode to enableAsyncKeepAlive as default

BMC uses PLDM `EventMessageSupported` command to get
`synchronyConfigurationSupported` by terminus as `16.8
EventMessageSupported C

platform-mc: Set synchrony mode to enableAsyncKeepAlive as default

BMC uses PLDM `EventMessageSupported` command to get
`synchronyConfigurationSupported` by terminus as `16.8
EventMessageSupported Command` in DSP0248 V1.3.0. When the PLDM terminus
does not support this command, BMC will not know the supported
`synchronyConfiguration` type.

Change default `synchronyConfigurationSupported` of termini from
`disabled` to `enableAsyncKeepAlive`. This allows BMC still logs the
events from the terminus whenever it is willing to send the event to
BMC.

With this changing, BMC will call PLDM `SetEventReceiver` command to set
`synchronyConfiguration` mode of terminus to `enableAsyncKeepAlive`
(Asynchronous messaging with heartbeat). The default heartbeat is 120
and can be configured thru `heartbeat-timeout-seconds` option. This
allows BMC still logs the events from the terminus whenever it is
willing to send the event to BMC.

Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>
Change-Id: I0c76e2867800da50ca2b795b022bde223db29f2d

show more ...

platform-mc: Support CPER Event handler

Handle CPER event(0x07) which is defined in `Table 11 - PLDM Event
Type` and section `16.17 eventData format for CPEREvent` in DSP0248
v1.3.0.

The code suppo

platform-mc: Support CPER Event handler

Handle CPER event(0x07) which is defined in `Table 11 - PLDM Event
Type` and section `16.17 eventData format for CPEREvent` in DSP0248
v1.3.0.

The code supports:
1. Handle the PLDM event which has eventClass as CPEREvent (0x07).
2. Store the CPER data in PLDM CPER event to file at `/var/cper/`.
3. Call `CreateDump` method of `xyz.openbmc_project.Dump.Manager` D-Bus
service to create dump fault log.
4. The user can find the dump fault logs in Redfish FaultLog entries
thru URL `/redfish/v1/Managers/bmc/LogServices/FaultLog/Entries`. Each
CPER entry includes the URL to download the created CPER data file
`/redfish/v1/Managers/bmc/LogServices/FaultLog/Entries/<id>/attachment`.
5. The user can use `cper-parser` in `libcper` to parse the CPER data in
the attached file.

Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>
Change-Id: I85c53933183178c6b5acdfc12c805e8a4cf1ca2a

show more ...

platform-mc: correct the PLDM sensor operational state handling

As we discussed in gerrit 51489 before, we reached consensus for the
pldm sensor state as following states:

PLDM_SENSOR_ENABLED

platform-mc: correct the PLDM sensor operational state handling

As we discussed in gerrit 51489 before, we reached consensus for the
pldm sensor state as following states:

PLDM_SENSOR_ENABLED : Functional True, Available True
PLDM_SENSOR_DISABLED : Functional True, Available False
PLDM_SENSOR_UNAVAILABLE : Functional False, Available False
PLDM_SENSOR_FAILED : Functional False, Available True
PLDM_SENSOR_INITIALIZING : Functional False, Available False

Correct the states handling for PLDM_SENSOR_DISABLED and
PLDM_SENSOR_FAILED.

Change-Id: I0cab9ab59a1e9c0f5c6d841c529a64cc4bb8caee
Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Change-Id: I10cbc1d55e259c972eac765b28b8c73281b1b42c
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

platform-mc: Added EventManager

Added eventManager to handle sensor event class(00h) which is defined in
table 11 of DSP0248 v1.3.0. In this commit, the eventManager supports to
receive event asynch

platform-mc: Added EventManager

Added eventManager to handle sensor event class(00h) which is defined in
table 11 of DSP0248 v1.3.0. In this commit, the eventManager supports to
receive event asynchronously. The commit will also log the Ipmitool SEL
log and Redfish log for PLDM sensor event messages.

Change-Id: I1b337ccae454067841ffbbd8754631216a995542
Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>
Signed-off-by: Gilbert Chen <gilbertc@nvidia.com>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Change-Id: I0e907f161bc6aec5e2253893f4ad7189cb8d5705
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

tools/visualize-pdr: bump paramiko to 3.4.0

Bumps paramiko[1] from 2.10.1 to 3.4.0. Below are the list
of commits[2] from 2.10.1 to 3.4.0.

[1]: https://github.com/paramiko/paramiko
[2]: https://git

tools/visualize-pdr: bump paramiko to 3.4.0

Bumps paramiko[1] from 2.10.1 to 3.4.0. Below are the list
of commits[2] from 2.10.1 to 3.4.0.

[1]: https://github.com/paramiko/paramiko
[2]: https://github.com/paramiko/paramiko/compare/2.10.1...3.4.0

Change-Id: I10b98730ae91c8273b1ac713925c9d7d0cc8a4a9
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

oem_ibm: Add Slot enable infrastructure in BMC

With this commit PDRs are created for each of these
PCIe slots and adapters which have a corresponding
entry in the entity associate map. The sensor/ef

oem_ibm: Add Slot enable infrastructure in BMC

With this commit PDRs are created for each of these
PCIe slots and adapters which have a corresponding
entry in the entity associate map. The sensor/effector
states are monitored and accordingly D-Bus calls are
sent for enabling a slot, process property change
of a PCIe slot, etc.

Tested By: SIMICS power on/off and reset reload.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I51b79b75c909ddf2cc29872fec6aa01c2d56b418

show more ...

bump cryptography in /tools/visualize-pdr

Bumps cryptography dependency to latest.

Look Changelog[1] and commits list[2] for more information.

[1]: https://github.com/pyca/cryptography/blob/main/C

bump cryptography in /tools/visualize-pdr

Bumps cryptography dependency to latest.

Look Changelog[1] and commits list[2] for more information.

[1]: https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst
[2]: https://github.com/pyca/cryptography/compare/39.0.1...43.0.1

Change-Id: I141cbffd61f3edd1114c2b61549a4adee3c588c5
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: Ia7dbb04ead7565d63437a5878fd8a543029d9a93
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

pldm: Move off get_fru_record_by_option_check()

Generated with:

```
$ ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/v0.9.1/get_fru_record_by_option_check.yaml
```

Ch

pldm: Move off get_fru_record_by_option_check()

Generated with:

```
$ ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/v0.9.1/get_fru_record_by_option_check.yaml
```

Change-Id: I9b0f6748e2007bfa4d0b2db244bfd5e7444271d0
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

clang-tidy: Enable modernize-deprecated-headers check

Some headers from C library were deprecated in C++ and are no
longer welcome in C++ codebases. Some have no effect in C++ [1].

[1]: https://rel

clang-tidy: Enable modernize-deprecated-headers check

Some headers from C library were deprecated in C++ and are no
longer welcome in C++ codebases. Some have no effect in C++ [1].

[1]: https://releases.llvm.org/13.0.1/tools/clang/tools/extra/docs/clang-tidy/checks/modernize-deprecated-headers.html

Change-Id: Ia3b1df10175e2e661c8fffb82e357c9db81b2e9c
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Add some modernize and misc checks

This commit adds some modernize tidy checks to enable usage of
modern way of using c++ styles.

Change-Id: I815210abe304f3224f29ac90845788d415945ceb
Si

clang-tidy: Add some modernize and misc checks

This commit adds some modernize tidy checks to enable usage of
modern way of using c++ styles.

Change-Id: I815210abe304f3224f29ac90845788d415945ceb
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

requester: Fix pldmd crash

Add a check to see if the key is exist in the queue of remove request
, to prevent calling the response handler twice after the request has
timed out.

Change-Id: Iafe061d

requester: Fix pldmd crash

Add a check to see if the key is exist in the queue of remove request
, to prevent calling the response handler twice after the request has
timed out.

Change-Id: Iafe061d71a6ae7e04a11f462acf00423bd52f4b6
Signed-off-by: SeanCChuang <sean.chuang.wiwynn@gmail.com>

show more ...

platform-mc: Set the local terminus as event receiver

Send `SetEventReceiver` to the discoveried terminus with the
configurable local EID to set the local terminus as event receiver.
Before send `Se

platform-mc: Set the local terminus as event receiver

Send `SetEventReceiver` to the discoveried terminus with the
configurable local EID to set the local terminus as event receiver.
Before send `SetEventReceiver` the local terminus also send
`EventMessageSupported` to get the `synchronyConfigurationSupported`.
The `eventMessageGlobalEnable` and `heartbeatTimer` options in the
`SetEventReceiver` command will depend on the responded
`synchronyConfigurationSupported`.

Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>
Signed-off-by: Gilbert Chen <gilbertc@nvidia.com>
Change-Id: Ia798c1cd5d946ac519933bca60620e970fe10b0a

show more ...