pldmtool: Update defines according to libpldm changes

Update several entity/state set defines according to the recent libpldm
changes that fixed typos in define names.

Change-Id: I67c2d270c2eeec81b

pldmtool: Update defines according to libpldm changes

Update several entity/state set defines according to the recent libpldm
changes that fixed typos in define names.

Change-Id: I67c2d270c2eeec81b793d1651bf301a6d5b597cd
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

Silence systemd warning for unset PLDMD_ARGS

Predefine PLDMD_ARGS as empty in the service file to avoid warnings
when the variable is not provided, while keeping support for overrides
via /etc/defau

Silence systemd warning for unset PLDMD_ARGS

Predefine PLDMD_ARGS as empty in the service file to avoid warnings
when the variable is not provided, while keeping support for overrides
via /etc/default/pldmd.

Tested:

pldmd runs as expected in both verbose & non-verbose mode & the
following warning from systemd is suppressed:

```
pldmd.service: Referenced but unset environment variable evaluates
to an empty string: PLDMD_ARGS
```

Change-Id: I46824bddc30b7c459d824494d606063a74edfa0b
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

pldm: add ObjectManager for metric sensors

When pldmd adds a new metric sensor,
it will register it to the ObjectMapper.

Tested:

busctl introspect xyz.openbmc_project.PLDM /xyz/openbmc_project/met

pldm: add ObjectManager for metric sensors

When pldmd adds a new metric sensor,
it will register it to the ObjectMapper.

Tested:

busctl introspect xyz.openbmc_project.PLDM /xyz/openbmc_project/metric
NAME TYPE SIGNATURE RESULT/VALUE F
org.freedesktop.DBus.Introspectable interface - - -
.Introspect method - s -
org.freedesktop.DBus.ObjectManager interface - - -
.GetManagedObjects method - a{oa{sa{sv}}} -
.InterfacesAdded signal oa{sa{sv}} - -
.InterfacesRemoved signal oas - -
org.freedesktop.DBus.Peer interface - - -
.GetMachineId method - s -
.Ping method - - -
org.freedesktop.DBus.Properties interface - - -
.Get method ss v -
.GetAll method s a{sv} -
.Set method ssv - -
.PropertiesChanged signal sa{sv}as - -

Change-Id: I1a84696aea6e5c5cca09b754ee3a302eb499d5b5
Signed-off-by: Marshall Zhan <marshall.zhan.wiwynn@gmail.com>

show more ...

pldmtool: Print all available commands in GetPLDMCommands output

Currently GetPLDMCommands command prints only the commands for which
it has a description mapping. Support printing types without the

pldmtool: Print all available commands in GetPLDMCommands output

Currently GetPLDMCommands command prints only the commands for which
it has a description mapping. Support printing types without the
description mapping as well.

Tested:
Currently pldmtool doesn't have a description for the PLDM commands
from the "PLDM for Redfish Device Enablement" specification (PLDM type
6), therefore a device with a support for such type was used for
testing purposes.

Before:
pldmtool: Tx: 80 00 05 06 00 f0 f1 f1
pldmtool: Rx: 00 00 05 00 fe 0f 7b 00 00 00 03 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[
null,
null,
<...>
null,
null
]

After:
pldmtool: Tx: 80 00 05 06 00 f0 f1 f1
pldmtool: Rx: 00 00 05 00 fe 0f 7b 00 00 00 03 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[
{
"PLDM Command": "unknown",
"PLDM Command Code": 1
},
{
"PLDM Command": "unknown",
"PLDM Command Code": 2
},
<...>
{
"PLDM Command": "unknown",
"PLDM Command Code": 48
},
{
"PLDM Command": "unknown",
"PLDM Command Code": 49
}
]

Change-Id: Ia309ae1b21c38b95c889023b44b8c69b66fa39dd
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

pldmtool: Update PLDM type codes descriptions

Add all PLDM type code descriptions that are present in the current
version of the "PLDM IDs and Codes Specification" (DSP0245 1.4.0).

Change-Id: I9c1c

pldmtool: Update PLDM type codes descriptions

Add all PLDM type code descriptions that are present in the current
version of the "PLDM IDs and Codes Specification" (DSP0245 1.4.0).

Change-Id: I9c1c129251917917d47eefaf47fe1f3ac9c031fb
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

pldmtool: Print all available types in GetPLDMTypes command

Currently GetPLDMTypes command prints only the types for which it has
a description mapping. Support printing types without the descriptio

pldmtool: Print all available types in GetPLDMTypes command

Currently GetPLDMTypes command prints only the types for which it has
a description mapping. Support printing types without the description
mapping as well.

Tested:
Currently pldmtool doesn't have a description for the PLDM type "PLDM
for Redfish Device Enablement", therefore a device with a support for
such type was used for testing purposes.

Before:
{
"CompletionCode": "SUCCESS",
"PLDMTypes": [
{
"PLDM Type": "base",
"PLDM Type Code": 0
},
{
"PLDM Type": "platform",
"PLDM Type Code": 2
},
{
"PLDM Type": "fru",
"PLDM Type Code": 4
},
{
"PLDM Type": "firmware update",
"PLDM Type Code": 5
}
]
}

After:
{
"CompletionCode": "SUCCESS",
"PLDMTypes": [
{
"PLDM Type": "base",
"PLDM Type Code": 0
},
{
"PLDM Type": "platform",
"PLDM Type Code": 2
},
{
"PLDM Type": "fru",
"PLDM Type Code": 4
},
{
"PLDM Type": "firmware update",
"PLDM Type Code": 5
},
{
"PLDM Type": "unknown",
"PLDM Type Code": 6
}
]
}

Change-Id: I54fa53eabc3c8f54ffb4918a2ada13f8a6bb7029
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

pldmtool: Remove IBM specifics from PLDM OEM type

According to the PLDM IDs and Codes Specification DSP0245 1.4.0
one of the possible PLDM Types is "OEM Specific" (Reserved for
OEM-specific PLDM com

pldmtool: Remove IBM specifics from PLDM OEM type

According to the PLDM IDs and Codes Specification DSP0245 1.4.0
one of the possible PLDM Types is "OEM Specific" (Reserved for
OEM-specific PLDM commands). This is a general code for OEM types
and not something IBM specific.

Change-Id: I4262e06394feeab82408f967cafd295b27652b44
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

utils: Add missing unit tests

There are few functions in utils.cpp that lacks unit tests, this commit
adds them.

Change-Id: I095ed5590dafc3af4967fa14ce1cdaa11eafe0c1
Signed-off-by: Manojkiran Eda <

utils: Add missing unit tests

There are few functions in utils.cpp that lacks unit tests, this commit
adds them.

Change-Id: I095ed5590dafc3af4967fa14ce1cdaa11eafe0c1
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

pldmtool: Fix GetStateSensorReadings output

Currently presentState, previousState and eventState fields from the
GetStateSensorReadings command output are parsed as they were from the
numeric sensor

pldmtool: Fix GetStateSensorReadings output

Currently presentState, previousState and eventState fields from the
GetStateSensorReadings command output are parsed as they were from the
numeric sensor GetSensorReading command. This is incorrect. In case of
state sensors these fields should be interpreted as state values
from a PLDM State Set that is associated with the sensor.
Since in the GetStateSensorReadings response we don't have the
necessary PDR information about the relevant state set, that should be
used for interpretation, display state values as a raw integers.

Tested:
The following example shows change in the output of the Link State
sensor (stateSetID = 33).

According to the DSP0249 1.4.0:
Link State - For any entity that has a data link to another entity.
1 – Connected The link is in the connected state.
2 – Disconnected The link is in the disconnected state.

Before:
~# pldmtool platform GetStateSensorReadings --sensor_id=203 --rearm=0
-m 10
{
"compositeSensorCount": 1,
"sensorOpState[0]": "Sensor Enabled",
"presentState[0]": "Sensor Warning",
"previousState[0]": "Sensor Unknown",
"eventState[0]": "Sensor Warning"
}

After:
~# pldmtool platform GetStateSensorReadings --sensor_id=203 --rearm=0
-m 10
{
"compositeSensorCount": 1,
"sensorOpState[0]": "Sensor Enabled",
"presentState[0]": "2",
"previousState[0]": "0",
"eventState[0]": "2"
}

Change-Id: I77ff441c8e1a8bf24cdde664a63a9de8e5fcb02b
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

pldm: PDR and FRU VPD additions in Huygens system

This commit contains below changes related to Huygens system
1. Addition of PDR folder and added the required FRUs for
switch board and three ot

pldm: PDR and FRU VPD additions in Huygens system

This commit contains below changes related to Huygens system
1. Addition of PDR folder and added the required FRUs for
switch board and three other chassis
2. Added new FRU VPD keywords for System, Chassis and Board
a. System - Added full set of UTIL and VSBP keywords
b. Chassis - Missing keywords DR, RB, RG and TM are added
c. Board - Newly added full set of keywords such as VCFG,
VINI, VMPU, VR10, VW10 and Location Code
3. Updated the FRU master json with core entity id and the
pldmtool with processor core name

Tested By:
Verified the changes in the Huygens simics setup

Change-Id: I89bb59d04a9372345bb73af3610f29d0a0115eb1
Signed-off-by: Jayashankar Padath <jayashankarpadath@gmail.com>

show more ...

platform-mc: Fix setSupportedTypeVersions function

Since the structure used for storing PLDM supported type versions is a
map, incoming type shouldn't be compared to structure size.

Tested:
Now sup

platform-mc: Fix setSupportedTypeVersions function

Since the structure used for storing PLDM supported type versions is a
map, incoming type shouldn't be compared to structure size.

Tested:
Now supportedTypeVersions are correctly populated to terminus.

Change-Id: I63e9c0718ec37937561245eebbb581215d4085c3
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

platform-mc: Handle exceptions while UTF-16 to UTF-8 conversion

This commit wraps `std::wstring_convert` operations in try-catch blocks
in `parseSensorAuxiliaryNamesPDR()` and `parseEntityAuxiliaryN

platform-mc: Handle exceptions while UTF-16 to UTF-8 conversion

This commit wraps `std::wstring_convert` operations in try-catch blocks
in `parseSensorAuxiliaryNamesPDR()` and `parseEntityAuxiliaryNamesPDR()`
to handle potential conversion exceptions gracefully. When an exception
occurs, log an error message and skip the problematic name instead of
crashing the application.

Tested. pldmd no longer crashes when an exception is thrown while
`std::wstring_convert` operations.

Change-Id: I246479899110ff371aec6bc89419a5d6937a0a2e
Signed-off-by: Aditya Kurdunkar <adityakurdunkar2@gmail.com>

show more ...

oem: meta: http boot: Migrate away from libpldm/utils.h

Use more precise includes where we can.

Change-Id: Ice4c66e83ef0f287c187b6b4b487639636a562a5
Signed-off-by: Andrew Jeffery <andrew@codeconstr

oem: meta: http boot: Migrate away from libpldm/utils.h

Use more precise includes where we can.

Change-Id: Ice4c66e83ef0f287c187b6b4b487639636a562a5
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldmtool: fix ComponentActivationMethods check

According to the firmware update specification,
ComponentActivationMethods is a 16-bit bitmap that indicates the
activation capabilities supported by t

pldmtool: fix ComponentActivationMethods check

According to the firmware update specification,
ComponentActivationMethods is a 16-bit bitmap that indicates the
activation capabilities supported by the FD, and multiple activation
methods can be enabled simultaneously. So fix the code to properly
support and interpret multiple activation methods instead of treating
it as a single-value field.

Change-Id: I02032e5317d488f376e7678ba75288b4f1098a25
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

pldmtool: pldm_bios_cmd: Migrate away from libpldm/utils.h

Be more precise where we can.

Change-Id: Id9d3f7a6140efe668ed61b6ee7b05b6d266687af
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com

pldmtool: pldm_bios_cmd: Migrate away from libpldm/utils.h

Be more precise where we can.

Change-Id: Id9d3f7a6140efe668ed61b6ee7b05b6d266687af
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldmtool: Move off deprecated ver2str()

Switch to pldm_base_ver2str().

Change-Id: I81d863d5f68413c178abd3fa04a712877ad1cacb
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

pldmtool: bios: Move off deprecated bcd2dec16()

Switch to pldm_bcd_bcd2dec16().

Change-Id: I71ea69b500cae7d7543474b8b8f55c9da026a0aa
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

pldmtool: bios: Move off deprecated bcd2dec8()

Switch to pldm_bcd_bcd2dec8().

Change-Id: I8a5c465966f037081ef9c4333f2dc4ef4f429cdb
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

meson: Describe dependencies as system includes

Avoid static analysis penalizing the pldm build for issues in
dependencies.

Change-Id: I0da511e090e9b3d6738e9d28e593da7551bef22c
Signed-off-by: Andre

meson: Describe dependencies as system includes

Avoid static analysis penalizing the pldm build for issues in
dependencies.

Change-Id: I0da511e090e9b3d6738e9d28e593da7551bef22c
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

Revert "platform-mc: Add 64-bit numeric sensor support"

This reverts commit e1e59bc6ebf461d7f125a526004ac9c98b7af4bb.

The corresponding libpldm commit[1] has not yet been merged. pldm now
fails to

Revert "platform-mc: Add 64-bit numeric sensor support"

This reverts commit e1e59bc6ebf461d7f125a526004ac9c98b7af4bb.

The corresponding libpldm commit[1] has not yet been merged. pldm now
fails to build with e.g:

```
../platform-mc/sensor_manager.cpp: In member function ‘exec::task<int> pldm::platform_mc::SensorManager::getSensorReading(std::shared_ptr<pldm::platform_mc::NumericSensor>)’:
../platform-mc/sensor_manager.cpp:336:30: error: ‘PLDM_SENSOR_DATA_SIZE_SINT64’ was not declared in this scope; did you mean ‘PLDM_SENSOR_DATA_SIZE_SINT8’?
336 | uint8_t sensorDataSize = PLDM_SENSOR_DATA_SIZE_SINT64;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
| PLDM_SENSOR_DATA_SIZE_SINT8
```

[1]: https://gerrit.openbmc.org/c/openbmc/libpldm/+/84665

Change-Id: I1f9d33dd813bc65b4f5bc932cebd7b51cd41ca00
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

fw-update: make percentage reporting more granular

This makes percentage completion reporting more granular.
Previously issues were seen around devices that took
longer than five minutes to update,

fw-update: make percentage reporting more granular

This makes percentage completion reporting more granular.
Previously issues were seen around devices that took
longer than five minutes to update, since xfering the firmware
wasn't counted as progress. This adds a new class
UpdateProgress, which tracks the stages of update,
including how far into a transfer we are

Tested: loaded onto nvl32-obmc and performed a full fwpkg update
The percentage complete increases monotonically and doesn't
time out as it did previously for updates that take longer
than 5 min
```
{
"@odata.id": "/redfish/v1/TaskService/Tasks/0",
"@odata.type": "#Task.v1_4_3.Task",
"EndTime": "2026-01-06T21:49:01+00:00",
"HidePayload": false,
"Id": "0",
"Messages": [
{
"@odata.type": "#Message.v1_1_1.Message",
"Message": "The task with Id '0' has started.",
"MessageArgs": [
"0"
],
"MessageId": "TaskEvent.1.0.TaskStarted",
"MessageSeverity": "OK",
"Resolution": "None."
},
{
"@odata.type": "#Message.v1_1_1.Message",
"Message": "The task with Id '0' has changed to progress 1 percent complete.",
"MessageArgs": [
"0",
"1"
],
"MessageId": "TaskEvent.1.0.TaskProgressChanged",
"MessageSeverity": "OK",
"Resolution": "None."
},
{
"@odata.type": "#Message.v1_1_1.Message",
"Message": "The task with Id '0' has changed to progress 2 percent complete.",
"MessageArgs": [
"0",
"2"
],
"MessageId": "TaskEvent.1.0.TaskProgressChanged",
"MessageSeverity": "OK",
"Resolution": "None."
},
{
"@odata.type": "#Message.v1_1_1.Message",
"Message": "The task with Id '0' has changed to progress 3 percent complete.",
"MessageArgs": [
"0",
"3"
],
"MessageId": "TaskEvent.1.0.TaskProgressChanged",
"MessageSeverity": "OK",
"Resolution": "None."
},
{
"@odata.type": "#Message.v1_1_1.Message",
"Message": "The task with Id '0' has changed to progress 4 percent complete.",
"MessageArgs": [
"0",
"4"
],
"MessageId": "TaskEvent.1.0.TaskProgressChanged",
"MessageSeverity": "OK",
"Resolution": "None."
},
{
"@odata.type": "#Message.v1_1_1.Message",
"Message": "The task with Id '0' has changed to progress 5 percent complete.",
"MessageArgs": [
"0",
"5"
],
"MessageId": "TaskEvent.1.0.TaskProgressChanged",
"MessageSeverity": "OK",
"Resolution": "None."
},
{
"@odata.type": "#Message.v1_1_1.Message",
"Message": "The task with Id '0' has changed to progress 6 percent complete.",
"MessageArgs": [
"0",
"6"
],
"MessageId": "TaskEvent.1.0.TaskProgressChanged",
"MessageSeverity": "OK",
"Resolution": "None."
},
{
"@odata.type": "#Message.v1_1_1.Message",
"Message": "The task with Id '0' has changed to progress 7 percent complete.",
"MessageArgs": [
"0",
"7"
],
"MessageId": "TaskEvent.1.0.TaskProgressChanged",
"MessageSeverity": "OK",
"Resolution": "None."
},
...
{
"@odata.type": "#Message.v1_1_1.Message",
"Message": "The task with Id '0' has changed to progress 100 percent complete.",
"MessageArgs": [
"0",
"100"
],
"MessageId": "TaskEvent.1.0.TaskProgressChanged",
"MessageSeverity": "OK",
"Resolution": "None."
},
{
"@odata.type": "#Message.v1_1_1.Message",
"Message": "The task with Id '0' has completed.",
"MessageArgs": [
"0"
],
"MessageId": "TaskEvent.1.0.TaskCompletedOK",
"MessageSeverity": "OK",
"Resolution": "None."
}
],
```

Change-Id: Ib2d5b6b9e2dbf025fd1391a5ba63c78937186122
Signed-off-by: Marc Olberding <molberding@nvidia.com>

show more ...

platform-mc: Add 64-bit numeric sensor support

Add UINT64/SINT64 sensor data type support as specified in
DSP0248 v1.3.0. This enables proper representation of 64-bit
sensor readings without truncat

platform-mc: Add 64-bit numeric sensor support

Add UINT64/SINT64 sensor data type support as specified in
DSP0248 v1.3.0. This enables proper representation of 64-bit
sensor readings without truncation.

Tested: Verified on Alon8 platform, all sensors show correctly.

Change-Id: I23fad4a47e59194c22e07526a1effdbf319b72e2
Signed-off-by: Apparao Puli <apuli@nvidia.com>

show more ...

pldm: Use std::expected for instance ID allocation

Refactor InstanceIdDb::next() to return
std::expected<uint8_t, InstanceIdError> instead of throwing exceptions.
With this change, errors are no lon

pldm: Use std::expected for instance ID allocation

Refactor InstanceIdDb::next() to return
std::expected<uint8_t, InstanceIdError> instead of throwing exceptions.
With this change, errors are no longer thrown by default.
Instead, the caller can inspect allocation errors as values, extract
the error message or code as needed, or explicitly throw the error
further up the stack if appropriate.
This approach allows for more flexible and explicit error handling, and
reduces reliance on exception-based control flow.

Motivation:
This change aims to improve robustness by enabling explicit error
handling and reducing the risk of uncaught exceptions that could lead
to a pldmd core dump if an instance ID allocation fails for a single
EID. Such a core dump could disrupt ongoing operations such as sensor
polling or firmware updates for other EIDs

Note:
Currently, some call sites are still void-returning functions and
cannot propagate errors via return values.
As a result, errors from InstanceIdDb::next() are thrown as
InstanceIdError at these locations to avoid silent failures.
Ideally, it would be preferable for these functions to propagate errors
by value (for example, using std::expected), so that errors can always
be handled explicitly without relying on exceptions.

Change-Id: I7189e97f206bae1eed5c8db44ebbbcd4393c8f8d
Signed-off-by: Eric Yang <eric.yang.wiwynn@gmail.com>

show more ...

oem-nvidia: Add support for legacy CPER event handling

Add OEM support to handle legacy CPER events using event class 0xFA for
existing NVIDIA platforms.

Prior to DSP0248 V1.3.0, NVIDIA used OEM ev

oem-nvidia: Add support for legacy CPER event handling

Add OEM support to handle legacy CPER events using event class 0xFA for
existing NVIDIA platforms.

Prior to DSP0248 V1.3.0, NVIDIA used OEM event class 0xFA to report CPER
events. The spec later standardized CPER events as class 0x07
(PLDM_CPER_EVENT). This change maintains backwards compatibility by
registering handlers for both the legacy 0xFA and the standardized 0x07
event classes.

This ensures continued support for NVIDIA platforms using older firmware
while being compatible with the current PLDM specification.

Tested.

This patch was tested on Nvidia GB200 Platform on Grace CPU Terminus.
The CPER payload was generated in /var/cper

'''
$ ls /var/cper/*
/var/cper/cper-lSaBc
'''

Change-Id: Ia0bb6c78b6abdc2c9ac2ea9249f180177d4aabcf
Signed-off-by: Aditya Kurdunkar <adityakurdunkar2@gmail.com>

show more ...

fru: Function to remove the individual FRU Record

When there is a concurrent maintenance operation a FRU can be
removed or added. When the FRU is removed we must make sure that
the associated FRU Re

fru: Function to remove the individual FRU Record

When there is a concurrent maintenance operation a FRU can be
removed or added. When the FRU is removed we must make sure that
the associated FRU Record set PDRs, State Effecter PDRs, State
Sensor PDRs, EntityAssociation PDRs need to be removed from the
repository. This commit adds the function that does the required
functionality.

Tested: Removal of a FRU say a Fan by making the present property
of the FRU as false. This action removes the corresponding
FRURecordSet PDRs, State effecter PDRs, State sensor PDRs and
also the Entity association PDRs from the repo. This also removes
the node corresponding to that FRU from the entity association
tree.
This behavior is observed for other FRUs as well.

Change-Id: I6c6e17e21807940ce6d4a230dbceafd9f7c5c958
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...