host-bmc: host_pdr_handler: Remove unused fields

```
../host-bmc/host_pdr_handler.hpp:277:9: error: private field 'mctp_fd' is not used [-Werror,-Wunused-private-field]
277 | int mctp_fd;

host-bmc: host_pdr_handler: Remove unused fields

```
../host-bmc/host_pdr_handler.hpp:277:9: error: private field 'mctp_fd' is not used [-Werror,-Wunused-private-field]
277 | int mctp_fd;
| ^
../host-bmc/host_pdr_handler.hpp:292:35: error: private field 'bmcEntityTree' is not used [-Werror,-Wunused-private-field]
292 | pldm_entity_association_tree* bmcEntityTree;
| ^
```

Change-Id: I62a948dff51b184bf44f1053b48d3b512e3e2b72
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

host-bmc: dbus_to_event_handler: Remove unused mctp_fd

```
../host-bmc/dbus_to_event_handler.hpp:89:9: error: private field 'mctp_fd' is not used [-Werror,-Wunused-private-field]
89 | int mct

host-bmc: dbus_to_event_handler: Remove unused mctp_fd

```
../host-bmc/dbus_to_event_handler.hpp:89:9: error: private field 'mctp_fd' is not used [-Werror,-Wunused-private-field]
89 | int mctp_fd;
| ^
```

Change-Id: Ia17471784594bf0abfc7ec5fca4c37aff274ecd0
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

host-bmc: cpu_core: Delete move methods

```
In file included from ../host-bmc/host_pdr_handler.cpp:7:
In file included from ../host-bmc/dbus/custom_dbus.hpp:5:
../host-bmc/dbus/cpu_core.hpp:24:5: er

host-bmc: cpu_core: Delete move methods

```
In file included from ../host-bmc/host_pdr_handler.cpp:7:
In file included from ../host-bmc/dbus/custom_dbus.hpp:5:
../host-bmc/dbus/cpu_core.hpp:24:5: error: explicitly defaulted move constructor is implicitly deleted [-Werror,-Wdefaulted-function-deleted]
24 | CPUCore(CPUCore&&) = default;
| ^
../host-bmc/dbus/cpu_core.hpp:17:17: note: move constructor of 'CPUCore' is implicitly deleted because base class 'CoreIntf' (aka 'object<sdbusplus::server::xyz::openbmc_project::inventory::item::CpuCore>') has a deleted move constructor
17 | class CPUCore : public CoreIntf
| ^
../subprojects/sdbusplus/include/sdbusplus/server/object.hpp:54:5: note: 'object' has been explicitly marked deleted here
54 | object(object&&) = delete;
| ^
../host-bmc/dbus/cpu_core.hpp:24:26: note: replace 'default' with 'delete'
24 | CPUCore(CPUCore&&) = default;
| ^~~~~~~
| delete
../host-bmc/dbus/cpu_core.hpp:25:14: error: explicitly defaulted move assignment operator is implicitly deleted [-Werror,-Wdefaulted-function-deleted]
25 | CPUCore& operator=(CPUCore&&) = default;
| ^
../host-bmc/dbus/cpu_core.hpp:17:17: note: move assignment operator of 'CPUCore' is implicitly deleted because base class 'CoreIntf' (aka 'object<sdbusplus::server::xyz::openbmc_project::inventory::item::CpuCore>') has a deleted move assignment operator
17 | class CPUCore : public CoreIntf
| ^
../subprojects/sdbusplus/include/sdbusplus/server/object.hpp:55:13: note: 'operator=' has been explicitly marked deleted here
55 | object& operator=(object&&) = delete;
| ^
../host-bmc/dbus/cpu_core.hpp:25:37: note: replace 'default' with 'delete'
25 | CPUCore& operator=(CPUCore&&) = default;
| ^~~~~~~
| delete
```

Change-Id: I190cf07cce199945df1b527b355c41091860a95a
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

host-bmc: motherboard: Delete move methods

```
In file included from ../host-bmc/host_pdr_handler.cpp:7:
In file included from ../host-bmc/dbus/custom_dbus.hpp:6:
../host-bmc/dbus/motherboard.hpp:29

host-bmc: motherboard: Delete move methods

```
In file included from ../host-bmc/host_pdr_handler.cpp:7:
In file included from ../host-bmc/dbus/custom_dbus.hpp:6:
../host-bmc/dbus/motherboard.hpp:29:5: error: explicitly defaulted move constructor is implicitly deleted [-Werror,-Wdefaulted-function-deleted]
29 | Motherboard(Motherboard&&) = default;
| ^
../host-bmc/dbus/motherboard.hpp:22:21: note: move constructor of 'Motherboard' is implicitly deleted because base class 'ItemMotherboard' (aka 'object<sdbusplus::server::xyz::openbmc_project::inventory::item::board::Motherboard>') has a deleted move constructor
22 | class Motherboard : public ItemMotherboard
| ^
../subprojects/sdbusplus/include/sdbusplus/server/object.hpp:54:5: note: 'object' has been explicitly marked deleted here
54 | object(object&&) = delete;
| ^
../host-bmc/dbus/motherboard.hpp:29:34: note: replace 'default' with 'delete'
29 | Motherboard(Motherboard&&) = default;
| ^~~~~~~
| delete
../host-bmc/dbus/motherboard.hpp:30:18: error: explicitly defaulted move assignment operator is implicitly deleted [-Werror,-Wdefaulted-function-deleted]
30 | Motherboard& operator=(Motherboard&&) = default;
| ^
../host-bmc/dbus/motherboard.hpp:22:21: note: move assignment operator of 'Motherboard' is implicitly deleted because base class 'ItemMotherboard' (aka 'object<sdbusplus::server::xyz::openbmc_project::inventory::item::board::Motherboard>') has a deleted move assignment operator
22 | class Motherboard : public ItemMotherboard
| ^
../subprojects/sdbusplus/include/sdbusplus/server/object.hpp:55:13: note: 'operator=' has been explicitly marked deleted here
55 | object& operator=(object&&) = delete;
| ^
../host-bmc/dbus/motherboard.hpp:30:45: note: replace 'default' with 'delete'
30 | Motherboard& operator=(Motherboard&&) = default;
| ^~~~~~~
| delete
```

Change-Id: If739f3d044c559f56dab143d5c53800a9d6f5082
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

host-bmc: host_pdr_handler: Drop unused fruJson

```
../host-bmc/host_pdr_handler.cpp:33:16: error: unused variable 'fruJson' [-Werror,-Wunused-const-variable]
33 | constexpr auto fruJson = "host_

host-bmc: host_pdr_handler: Drop unused fruJson

```
../host-bmc/host_pdr_handler.cpp:33:16: error: unused variable 'fruJson' [-Werror,-Wunused-const-variable]
33 | constexpr auto fruJson = "host_frus.json";
| ^~~~~~~
```

Change-Id: Ia04cb6beba4465fa0fa872b84c5b58f05c90ca36
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

host-bmc: host_pdr_handler: Drop unused emptyJsonList

```
../host-bmc/host_pdr_handler.cpp:35:25: error: unused variable 'emptyJsonList' [-Werror,-Wunused-const-variable]
35 | const std::vector<J

host-bmc: host_pdr_handler: Drop unused emptyJsonList

```
../host-bmc/host_pdr_handler.cpp:35:25: error: unused variable 'emptyJsonList' [-Werror,-Wunused-const-variable]
35 | const std::vector<Json> emptyJsonList{};
| ^~~~~~~~~~~~~
```

Change-Id: I25d48daea746ab61caa5c582225ef5ae7ae1c4a3
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldmd: Remove unused MCTP_MSG_TYPE_PLDM

```
../pldmd/pldmd.cpp:67:19: error: unused variable 'MCTP_MSG_TYPE_PLDM' [-Werror,-Wunused-const-variable]
67 | constexpr uint8_t MCTP_MSG_TYPE_PLDM = 1;

pldmd: Remove unused MCTP_MSG_TYPE_PLDM

```
../pldmd/pldmd.cpp:67:19: error: unused variable 'MCTP_MSG_TYPE_PLDM' [-Werror,-Wunused-const-variable]
67 | constexpr uint8_t MCTP_MSG_TYPE_PLDM = 1;
| ^~~~~~~~~~~~~~~~~~
```

Change-Id: I12724e6639ad359b9b8cba4cf523ce86b8bd6d24
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

Adding exception handling while hosting Dbus path

This commit add support to check if Dbus interface are hosted by other
application or not. If Dbus interface hosted by other app then PLDM
will skip

Adding exception handling while hosting Dbus path

This commit add support to check if Dbus interface are hosted by other
application or not. If Dbus interface hosted by other app then PLDM
will skip the hosting and take existing path.

Tested:
Tested motherboard interface which is hosted by other app:
` DICT_ENTRY "sas" {
STRING "xyz.openbmc_project.Inventory.Manager";
ARRAY "s" {
STRING "xyz.openbmc_project.Inventory.Item";
STRING "xyz.openbmc_project.Inventory.Item.Board.Motherboard";
};
};

DICT_ENTRY "sas" {
STRING "xyz.openbmc_project.PLDM";
ARRAY "s" {
STRING "org.freedesktop.DBus.Introspectable";
STRING "org.freedesktop.DBus.Peer";
STRING "org.freedesktop.DBus.Properties";
};
};
};
};
`

Change-Id: Ia0bacf38bf1dc796e649de39169cab5d3526e913
Signed-off-by: Kamalkumar Patel <kamalkumar.patel@ibm.com>

show more ...

pldmtool: GetPLDMCommand: Support version option

`GetPLDMCommands` in DSP0240 v1.1.0 requires the PLDM supported type
version. In the current implementation, `pldmtool` always send `0xff
0xff 0xff 0

pldmtool: GetPLDMCommand: Support version option

`GetPLDMCommands` in DSP0240 v1.1.0 requires the PLDM supported type
version. In the current implementation, `pldmtool` always send `0xff
0xff 0xff 0xff` version to `GetPLDMCommand` with the assumption that the
terminus will response for the request with any version of PLDM type.

Some termini don't accept `0xff 0xff 0xff 0xff` as input
version to `GetPLDMCommands` command because value `0xff` only has
meaning `A value of 0xFF in the "update" field indicates that the field
to be ignored.` in the `Section 12.6.1 Version field encoding` in `MCTP
Base spec` DSP0236 v1.3.1 but not in `PLDM base spec` DSP0240 v1.1.0
where `GetPLDMCommand` is detailed.

Add `-d` option to allow the user input the PLDM supported type version
which is responded by terminus in `GetPLDMVersion` command. The input
version will be in hex format. eg version 1.1.0 will be input as `0x00
0xf0 0xf1 0xf1`.

Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>
Change-Id: I42a940ac6d8976b3630613211fcdbe1290895014

show more ...

pldmtool: Add GetStateEffecterStates command

Add GetStateEffecterStates command in pldmtool.
Used to get state effecter current and pending states
by supplying an effecter ID.

Tested:
```
root@bmc:

pldmtool: Add GetStateEffecterStates command

Add GetStateEffecterStates command in pldmtool.
Used to get state effecter current and pending states
by supplying an effecter ID.

Tested:
```
root@bmc:~# pldmtool platform GetStateEffecterStates -h
get the state effecter states
Usage: pldmtool platform GetStateEffecterStates [OPTIONS]

Options:
-h,--help Print this help message and exit
-m,--mctp_eid UINT MCTP endpoint ID
-v,--verbose
-n,--retry-count UINT Number of retry when PLDM request message is failed
-i,--effecter_id UINT REQUIRED
Effecter ID that is used to identify and access the effecter
root@bmc:~# pldmtool platform GetStateEffecterStates -m 9 -i 348
{
"compositeEffecterCount": 1,
"effecterOpState[0])": "Effecter Enabled No Update Pending",
"pendingState[0]": 1,
"presentState[0]": 1
}
```

Change-Id: Ib72d2181dec955367310d6218628bb26952346b2
Signed-off-by: Tal Yacobi <talycb8@gmail.com>

show more ...

pldmtool: support GetNextPart for GetPDR command

Current pldmtool assumes GetPDR command always have one PDR from each
response which causing incompleted PDR data if the devices have smaller
packet

pldmtool: support GetNextPart for GetPDR command

Current pldmtool assumes GetPDR command always have one PDR from each
response which causing incompleted PDR data if the devices have smaller
packet size limitation.

Add GetNextPart support for collecting a full PDR from multiple
commands.

Change-Id: Idf6805751e3870c65daf3e411c011b021992a912
Signed-off-by: Potin Lai <potin.lai@quantatw.com>
Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>

show more ...

requester: Use return code instead of throwing exception

The coroutine API should only forward error code and response data
to the caller when sends/receives PLDM message instead check the
response

requester: Use return code instead of throwing exception

The coroutine API should only forward error code and response data
to the caller when sends/receives PLDM message instead check the
response and thrown exception.

The `sendRecvMsg` API will response tuple of error code, response and
response length as below:

+ [error_code, _, _] if registerRequest fails with `error_code`.
+ [PLDM_ERROR_NOT_READY, nullptr, 0] if the request is timed out.
+ [PLDM_SUCCESS, resp, len] if succeeded.

Signed-off-by: Khang Nguyen Duy <khangng@amperecomputing.com>
Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>
Change-Id: Id8262d147e9fed50af8f55f1c611a3a3b153b6e3

show more ...

pldmd: fix crash when re-request D-Bus name

`bus.request_name("xyz.openbmc_project.PLDM")` throws D-Bus exception
when the name `xyz.openbmc_project.PLDM` is already requested. This
causes the `pldm

pldmd: fix crash when re-request D-Bus name

`bus.request_name("xyz.openbmc_project.PLDM")` throws D-Bus exception
when the name `xyz.openbmc_project.PLDM` is already requested. This
causes the `pldmd` service will be crashed when build pldm source with
`oem-ibm` disabled & `system-specific-bios-json` disabled. Add
`try...catch...` to prevent the crash of `pldmd`.

Tested:
Was able to successfully start pldm service and see that the bus name
`xyz.openbmc_project.PLDM` was claimed with these options setups:
+ `oem-ibm` disabled & `system-specific-bios-json` enabled.
+ `oem-ibm` disabled & `system-specific-bios-json` disabled.

Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>
Change-Id: I2ac70b686d1468b9c7484d5bf2543db2b4f33ded

show more ...

platform-mc: PDR handling

Get PDRs of new terminus if it supports GetPDR PLDM command. It doesn't
handle the event receiver related initialization steps, and either
doesn't support primary PDR repos

platform-mc: PDR handling

Get PDRs of new terminus if it supports GetPDR PLDM command. It doesn't
handle the event receiver related initialization steps, and either
doesn't support primary PDR repository to maintain terminus locator PDR
information yet.
Added parse PDR member functions to terminus class for parsing Numeric
sensor PDR and sensor auxiliary names PDR.
Added sensor auxiliary names PDR and numeric sensor PDR struct in
libpldm/platform.h

Signed-off-by: Gilbert Chen <gilbert.chen@arm.com>
Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>
Change-Id: I30a0cc594a3c08fc17f2dad861b5c5d41c80ebdd

show more ...

OWNERS: Add `Thu Nguyen` as a reviewer

I have been actively contributing to OpenBMC/pldm source, especially for
`platform-mc/` folder. Attached is a summary of my contributions to
the repository [1]

OWNERS: Add `Thu Nguyen` as a reviewer

I have been actively contributing to OpenBMC/pldm source, especially for
`platform-mc/` folder. Attached is a summary of my contributions to
the repository [1].

I would like to learn and help out on pldm reviews.

[1] https://github.com/openbmc/pldm/commits?author=ThuBaNguyen

Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>
Change-Id: I2e9b769bacff96c91a0f2f211a1a3b4c41bc9411

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Change-Id: I9be2bd75eae5c5098b6206b900b9956e764cf03a
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

terminus_manager: fix spelling of Terminus

The function `findTerminusPtr` was missing an "r".

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id5e9eefa6031f459caae076833c6c64161a13d71

Implementing Motherboard interface

This commit adds support to host motherboard interface which can be
used to generate Dbus Object paths. The Dbus object paths will be
represents the hardware compo

Implementing Motherboard interface

This commit adds support to host motherboard interface which can be
used to generate Dbus Object paths. The Dbus object paths will be
represents the hardware components within the system architecture and
help to understand the architecture better way. The motherboard will
represent the system board and other entity are connected to it.
The interface is implemented at:[1]

[1] https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/yaml/xyz/openbmc_project/Inventory/Item/Board/Motherboard.interface.yaml

Change-Id: Ie7987ea0fb03d2d6ffd9e485924cfea7446d97d9
Signed-off-by: Kamalkumar Patel <kamalkumar.patel@ibm.com>

show more ...

Add support for the coreCount property in DBus

This commit introduces support for counting the number of CPU cores
during BMC power-on and populates this information to a DBus property
named coreCou

Add support for the coreCount property in DBus

This commit introduces support for counting the number of CPU cores
during BMC power-on and populates this information to a DBus property
named coreCount. Upon BMC power-on, the remote terminus detects the
number of CPU cores and send this data and PLDM will updates the
coreCount property accordingly.

Tested:
tested on simulator for hosting DBus property

Change-Id: I37adbe399414fcff3f089fb819349ca4bb537edd
Signed-off-by: Kamalkumar Patel <kamalkumar.patel@ibm.com>

show more ...

oem-ibm: Implement Host lamp test interface

IBM has a feature called LampTest and what it does is this:
- BMC would set the state of LEDs to [ON] on all the BMC accessible
LEDs.
- For LEDs t

oem-ibm: Implement Host lamp test interface

IBM has a feature called LampTest and what it does is this:
- BMC would set the state of LEDs to [ON] on all the BMC accessible
LEDs.
- For LEDs that are not accessible by BMC, a message is sent to the
Host, so that the Host can exercise all the LEDs on the connected
drawers and anything else that the BMC does not have access to.

This commit adds support to send message to Host when BMC has to tell
the Host to exercise LEDs accessible by host.

When Host sees the effector is set, it goes ahead and turns [ON] all
the LEDs for a specified time and automatically restores the states
at timer expiration. BMC does not have to tell the Host to stop the
test and it is part of Host's lamp test requirement.

TESTED: By setting the asserted property of the LED groups object

busctl set-property xyz.openbmc_project.LED.GroupManager
/xyz/openbmc_project/led/groups/lamp_test
xyz.openbmc_project.Led.Group Asserted b true

And verifying that the setEffecterStates call was made to the
remote state effecter to turn on all LEDs

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I990dce28d3017f20c73ff9029fced0e7ac84868f

show more ...

host-bmc: Logging PEL for PDR Exchange Failure

This commit logs PEL when BMC fails to collect PDR from remote endpoint.
GetPDR returns no response because of BMC PDR exchange failure after
three tri

host-bmc: Logging PEL for PDR Exchange Failure

This commit logs PEL when BMC fails to collect PDR from remote endpoint.
GetPDR returns no response because of BMC PDR exchange failure after
three tries get exhausted and timeout occurs.

Tested: Verified that the new PEL is reported when the pdr response
pointer is null

Change-Id: I862693a7e0fe2405af625010f2862d25af1f11e2
Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>

show more ...

skip asking for PDR's from remote endpoint

The PDR exchange is always triggered from the remote end point. Hence
BMC should never ask for GetPDR by itself.

Change-Id: Ibc90cdd5118ad1bc7665bc681b0aa

skip asking for PDR's from remote endpoint

The PDR exchange is always triggered from the remote end point. Hence
BMC should never ask for GetPDR by itself.

Change-Id: Ibc90cdd5118ad1bc7665bc681b0aa89994a5e400
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Skip endpoint check when responding to GetPDR requests

Bypassing the remote endpoint status check before responding to GetPDR
requests prevents potential issues due to the variable behavior of
remot

Skip endpoint check when responding to GetPDR requests

Bypassing the remote endpoint status check before responding to GetPDR
requests prevents potential issues due to the variable behavior of
remote PLDM termini. If a remote terminus sends a GetPDR request before
responding to the GetPLDMVersion command, a race condition may occur.
Therefore, it is safer to skip the remote endpoint alive check.

Change-Id: I9b2a186fee7f8d3a382b1573d872596728c9f7d4
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

libpldmresponder: fix an eternal hang in requesting bus name

If oem-ibm is disabled, but system-specific-bios-json option is enabled
pldmd fails to start since its timing out waiting to request the

libpldmresponder: fix an eternal hang in requesting bus name

If oem-ibm is disabled, but system-specific-bios-json option is enabled
pldmd fails to start since its timing out waiting to request the bus
name. This fix also breaks the dependency between the above two meson
options.

Tested:
- Was able to successfully start pldm service and see that the bus
name was claimed with oem-ibm disabled & system-specific-bios-json
enabled.

Change-Id: Ie78521017ea20b7503b4425bf4c2f605c884ef1d
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

platform-mc: add more exception type

Fix PLDMD crash if endpoint device doesn't response.

Change-Id: I13c0292bdb681567593fbc4a62685e6393f88a82
Signed-off-by: Jerry C Chen <jerry.c.chen.wiwynn@gmail

platform-mc: add more exception type

Fix PLDMD crash if endpoint device doesn't response.

Change-Id: I13c0292bdb681567593fbc4a62685e6393f88a82
Signed-off-by: Jerry C Chen <jerry.c.chen.wiwynn@gmail.com>

show more ...