black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: I0acc99c570b2a51

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: I0acc99c570b2a51383f46c62a04367e50f7c42b9
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Fix pycodestyle errors

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: If9e9fc799062c207e74afdf07f018f325fb5a373

pldm_visualise_pdrs: check for tty

Check for a tty before using a carriage return. This yields sane
behavior when redirecting output to something other than a shell e.g.
more, less,

pldm_visualise_pdrs: check for tty

Check for a tty before using a carriage return. This yields sane
behavior when redirecting output to something other than a shell e.g.
more, less, etc...

Change-Id: I250fefc531a2aaced9bee433388e25fccb4952ce
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

pldm_visualise_pdrs: run pldmtool directly

Add support for running pldm_visualise_pdrs locally on the same system
as pldmtool. This is roughly equivalent to:

pldm_visualise_pdr

pldm_visualise_pdrs: run pldmtool directly

Add support for running pldm_visualise_pdrs locally on the same system
as pldmtool. This is roughly equivalent to:

pldm_visualise_pdrs.py --bmc localhost

but without the SSH overhead.

To invoke pldm_visualise_pdrs in this manner, run it without any command
line options. If pldmtool is found in PATH it will be used to fetch the
PDRs. If it is not, an error message is displayed instructing the user
to either install pldmtool or use the --bmc option and connect to a
remote target. A side effect of this is that the --bmc and --password
parameters are now optional.

Change-Id: I1befdb19d4eaa1fb6d685e84b14926530238b20d
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

pldm_visualise_pdrs: add process abstraction

Wrap the paramiko process control and access methods in a process
abstraction to facilitate new ways of running pldmtool.

Change-Id:

pldm_visualise_pdrs: add process abstraction

Wrap the paramiko process control and access methods in a process
abstraction to facilitate new ways of running pldmtool.

Change-Id: Ibacc45dd3a09022c420b76a5828583e84ffd63e1
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

pldm_visualise_pdrs: Add executor abstraction

Wrap the paramiko connection logic into an executor abstraction to
facilitate new ways of running pldmtool.

Change-Id: Ief7cc9bd926

pldm_visualise_pdrs: Add executor abstraction

Wrap the paramiko connection logic into an executor abstraction to
facilitate new ways of running pldmtool.

Change-Id: Ief7cc9bd926ca0ca96a595fd8051f940316c7aa9
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

pldm_visualise_pdrs.py: add jump host support

A jump host allows tunneling an ssh connection through an intermediate
server. Enabling this means using any ProxyCommand host directives f

pldm_visualise_pdrs.py: add jump host support

A jump host allows tunneling an ssh connection through an intermediate
server. Enabling this means using any ProxyCommand host directives from
an ssh config if one exists, and feeding that to paramiko.

Change-Id: Ic4aa6c765a6fe9a0bcb790d1bce23fa9c49de419
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

pldm_visualise_pdrs.py: add support for ssh_config

Add support for parsing user ssh_configs. For now, this lets users
specify an ssh_config host entry with the --bmc parameter and the s

pldm_visualise_pdrs.py: add support for ssh_config

Add support for parsing user ssh_configs. For now, this lets users
specify an ssh_config host entry with the --bmc parameter and the script
will pick up the hostname and user directives if they are specified in
the host entry. Like ssh itself, a --user option on the command line
overrides any user specified in the ssh_config host entry.

Change-Id: I4d564677424e984de033a1d15ca6d51342091772
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

pldm_visualise_pdrs.py: make use of --all

pldmtool platform getpdr has a new --all option that dumps all the PDRS.
Probe pldmtool to see if it supports the --all option and if it does,

pldm_visualise_pdrs.py: make use of --all

pldmtool platform getpdr has a new --all option that dumps all the PDRS.
Probe pldmtool to see if it supports the --all option and if it does,
use it, as it is at least an order of magnitude faster than invoking
pldmtool once for each PDR.

The pldmtool error handling code is complicated significantly, because
with the much larger json documents being printed by --all, it becomes
important that the json decoder be able to start decoding the document
before pldmtool has sent all the pdrs.

get_pdrs is restructured as a generator selection method, given that
different versions of pldmtool have different capabilities.

Change-Id: I01a3dccad3a85d701cd86ab35d8908ef7fc772ac
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

pldm_visualise_pdrs.py: add some error handling

If pldmtool exits with non-zero status it will likely cause a json
decoder error to be thrown because it didn't write anything to stdout.

pldm_visualise_pdrs.py: add some error handling

If pldmtool exits with non-zero status it will likely cause a json
decoder error to be thrown because it didn't write anything to stdout.
This is misleading, so check the pldmtool exit status before attempting
to read the json document it prints.

Change-Id: I8e6d1008a054bc6ed0699f051fb537be8785c863
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

pldm_visualise_pdrs.py: use a generator

Factor the logic and implementation of iterating over PDRs out from the
logic of sorting data into the various pdr type containers in
fetch_pd

pldm_visualise_pdrs.py: use a generator

Factor the logic and implementation of iterating over PDRs out from the
logic of sorting data into the various pdr type containers in
fetch_pdrs_from_bmc. Move the factored-out logic to a new generator
method get_pdrs. This facilitates new ways of getting PDRs into the
program without disturbing the code that processes them.

Change-Id: I23e9b56b3ec1d275f93fef51edeed11d6de696bd
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

pldm_visualise_pdrs.py: make --user optional

Most ssh clients (ssh, scp, etc) will default to the currently logged in
user if unspecified elsewhere, including paramiko itself.

M

pldm_visualise_pdrs.py: make --user optional

Most ssh clients (ssh, scp, etc) will default to the currently logged in
user if unspecified elsewhere, including paramiko itself.

Make --user optional and default to the currently logged in user to be
consistant with the behavior of other ssh client applications. This
also avoids the unusual sitation where --user is only required if it
does not appear in an ssh configuration file host entry (useful if
support for parsing ssh configurations were to be added in the future).

Change-Id: I0d4fdd51d03c205b1457ea199934fda2e3a2ab29
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

pldm_visualise_pdrs.py: remove impossible branch

These arguments are marked as required. Given that, this branch can
never evaluate to false, so just remove it.

Change-Id: I403

pldm_visualise_pdrs.py: remove impossible branch

These arguments are marked as required. Given that, this branch can
never evaluate to false, so just remove it.

Change-Id: I403cf561b121b28e3fe161f810fc6c8ba26317ee
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Initial version of pldm-visualization-pdr tool

- The pldmtool for GetPDR command lacks to display all PDRs at
once. It fetches only one PDR at a time.

- With a lot of sensors/

Initial version of pldm-visualization-pdr tool

- The pldmtool for GetPDR command lacks to display all PDRs at
once. It fetches only one PDR at a time.

- With a lot of sensors/effecters & with a lot of Host FRU pdrs
coming in due to concurrent maintenance of the system,where
the fru's are added/removed at runtime, it's really necessary
to have a full system view.

- The Intent behind this tool is to fire ssh commands to getPDR
command on BMC and use the obtained json output to parse and to
construct a tabular summary.

- This tool also parses the entity association PDR's and generates
a [picture](https://cdn.discordapp.com/attachments/778790638563885086/850269035827298304/entity_association2021-06-04_123122.pdf)
that explains the entity association hierarchy at any
given point in time.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I37c05233cff1574c7f49d68a3388c2b4ed3dc2a7

show more ...