fix markdownlint issues reported in CI

There are a lot of warnings reported by markdownlint in the CI, this
commit aims at fixing all of them.

Tested :

No more warnings reported by markdownlint in

fix markdownlint issues reported in CI

There are a lot of warnings reported by markdownlint in the CI, this
commit aims at fixing all of them.

Tested :

No more warnings reported by markdownlint in the CI.

Change-Id: I92d24bc0efd230dd0974ff49853ef928caf1febd
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

tools: fw-update: allow ISO 8610 date formats

Currently, the ReleaseDateTime data is expected to be in a
"%d/%m/%Y %H:%M:%S" format.

However, this is ambiguous (ie., is locale-specific).

This chan

tools: fw-update: allow ISO 8610 date formats

Currently, the ReleaseDateTime data is expected to be in a
"%d/%m/%Y %H:%M:%S" format.

However, this is ambiguous (ie., is locale-specific).

This change adds supoort to allow an ISO 8601 format of:

"%Y-%m-%dT%H:%M:%S"

and a relaxed version with the 'T' separator replaced with a space:

"%Y-%m-%d %H:%M:%S"

Update the readme and example json to switch to the preferred format.

Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Change-Id: Ica3ae824979df6b666b8abb619ceaedffd90b374

show more ...

tools: fw-update: Don't wrap datetime parsing in a catch KeyError block

Currently, all of the datetime parse is wrapped in a `catch KeyError`
block. However, the only part of this that would raise a

tools: fw-update: Don't wrap datetime parsing in a catch KeyError block

Currently, all of the datetime parse is wrapped in a `catch KeyError`
block. However, the only part of this that would raise a KeyError is
where we extract the PackageReleaseDateTime from the metadata dict.

Instead, just do the key lookup separately, and parse outside of the
catch block.

Then, since we're handling a default anyway, just use .get() and then we
don't need to catch the KeyError.

Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Change-Id: Iae6b92383af4fe49770e77005fcb575faa125703

show more ...

fwupdate-tools: Support for multiple components

At present ComponentIdentifier is used in
ApplicableComponents field to select images that
apply for a firmware device. Which restricts to
have same C

fwupdate-tools: Support for multiple components

At present ComponentIdentifier is used in
ApplicableComponents field to select images that
apply for a firmware device. Which restricts to
have same ComponentIdentifier for multiple
components. This patch will enable to use
ComponentImageInformationArea index in
ApplicableComponents field.

Unit Tests:
1. Modify ApplicableComponents with index and
verify the package with previous package.
There should not be any difference
2. Verify multiple components with same
component identifier
3. Test out of index for ApplicableComponents

Signed-off-by: Chinmay Shripad Hegde <hosmanechinmay@gmail.com>
Change-Id: Ibf5069d568f0a922d52db261219c2557d2d2f715

show more ...

fwupdate-tools: Add support for user specified ComponentComparisonStamp from metadata file.

Currently, ComponentComparisonStamp is not supported in metadata file
and the value is hardcoded in the sc

fwupdate-tools: Add support for user specified ComponentComparisonStamp from metadata file.

Currently, ComponentComparisonStamp is not supported in metadata file
and the value is hardcoded in the script. This change will enable to
specify ComponentComparisonStamp in metadata file when ComponentOptions
is set to 1.

Unit Tests:
1. ComponentOptions values other than 1. verify Default
ComponentComparisonStamp used
2. ComponentOptions is 1 and component comparison stamp is missing,
verify error message
3. ComponentOptions is 1, ComponentComparisonStamp provided in the
metadata file. Verify the package with hexdump
4. Verify error messages for invalid value for ComponentComparisonStamp

Signed-off-by: Chinmay Shripad Hegde <hosmanechinmay@gmail.com>
Change-Id: I772d30ebe5d80e2cdca365ad4025cca774db218d

show more ...

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: I0d25f27a5e449578967915d9f570cc29246927d7
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: I0acc99c570b2a51

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: I0acc99c570b2a51383f46c62a04367e50f7c42b9
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

tools: Extend support for ComponentOptions

Add support for both Force Update and Use Component Comparison Stamp.

Signed-off-by: Tom Joseph <rushtotom@gmail.com>
Change-Id: Ief6e56e8a167a989c27b6b22

tools: Extend support for ComponentOptions

Add support for both Force Update and Use Component Comparison Stamp.

Signed-off-by: Tom Joseph <rushtotom@gmail.com>
Change-Id: Ief6e56e8a167a989c27b6b2244b340ed0956d799

show more ...

tools: Extend pldm_fwup_pkg_creator

Extend the pldm_fwup_pkg_creator script to handle multiple record
descriptors in the firmware device ID record. The metadata json also
handles vendor defined desc

tools: Extend pldm_fwup_pkg_creator

Extend the pldm_fwup_pkg_creator script to handle multiple record
descriptors in the firmware device ID record. The metadata json also
handles vendor defined descriptors.

Tested: Verified this change by using the updated json in the patch
and sample images to create a package. The fields of the package
header were verified for accuracy.

Signed-off-by: Tom Joseph <rushtotom@gmail.com>
Change-Id: I9efde5689e551170b46a4e6ee4ea1e5624173420

show more ...

tools: Fix bug in pldm_fwup_pkg_creator.py

The fix is to generate the package header checksum after updating
the package header size, which includes the checksum.

Signed-off-by: Tom Joseph <rushtot

tools: Fix bug in pldm_fwup_pkg_creator.py

The fix is to generate the package header checksum after updating
the package header size, which includes the checksum.

Signed-off-by: Tom Joseph <rushtotom@gmail.com>
Change-Id: I3364ddcb1fa1d20c5abc3ae1be7562c9d9c2ed78

show more ...

Initial version of pldm_fwup_pkg_creator.py

pldm_fwup_pkg_creator.py is a python script that can generate a PLDM
firmware update package out of one or more image files, given a
corresponding metadat

Initial version of pldm_fwup_pkg_creator.py

pldm_fwup_pkg_creator.py is a python script that can generate a PLDM
firmware update package out of one or more image files, given a
corresponding metadata JSON file.

Signed-off-by: Deepak Kodihalli <deepak.kodihalli.83@gmail.com>
Change-Id: I7655ab2be72731332afc686b1c55b1312455ba1a
Signed-off-by: Tom Joseph <rushtotom@gmail.com>

show more ...