clang-tidy: Enable modernize-deprecated-headers check

Some headers from C library were deprecated in C++ and are no
longer welcome in C++ codebases. Some have no effect in C++ [1].

[1]: https://rel

clang-tidy: Enable modernize-deprecated-headers check

Some headers from C library were deprecated in C++ and are no
longer welcome in C++ codebases. Some have no effect in C++ [1].

[1]: https://releases.llvm.org/13.0.1/tools/clang/tools/extra/docs/clang-tidy/checks/modernize-deprecated-headers.html

Change-Id: Ia3b1df10175e2e661c8fffb82e357c9db81b2e9c
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

Format meson files with meson.format

Meson 1.5.0 introduced a new feature to format all the meson
files. Formatting all the meson files is now as simple as running
`meson format -i -r` command in th

Format meson files with meson.format

Meson 1.5.0 introduced a new feature to format all the meson
files. Formatting all the meson files is now as simple as running
`meson format -i -r` command in the repository root folder.

more details : https://mesonbuild.com/Commands.html#format

Change-Id: I9c5468cc502ae78b7a055e2de2a10296930cb9ec
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

clang-diagnostic error: no member in the namespace 'std'

Clang was throwing no member named in 'std' error due to missing
inclusions.

Change-Id: I50d12ff604f2e9050b1d19891d3dbb80b878736f
Signed-off

clang-diagnostic error: no member in the namespace 'std'

Clang was throwing no member named in 'std' error due to missing
inclusions.

Change-Id: I50d12ff604f2e9050b1d19891d3dbb80b878736f
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

Deprecate the support for x86 sdk

OpenBMC as a project has moved away from using yocto x86 sdks for unit
testing. Instead now the preferred way to build and test code is by two
ways:

1. Leveraging

Deprecate the support for x86 sdk

OpenBMC as a project has moved away from using yocto x86 sdks for unit
testing. Instead now the preferred way to build and test code is by two
ways:

1. Leveraging the meson subproject support
2. Using openbmc docker container

Since x86 sdks needed some weird hacks in the code base like figuring
out the linker arguments ourselves & running custom bash commands from
the meson build files. Also with changing yocto code base, its a large
maintainer burden to make sure this support works.

Tested:
Code builds & unit tests are passed with both the approaches mentioned
above.

Change-Id: Iaf55e2c003ffd9ee1a295de5bdfd14d81222e94b
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Refactor: Handler expands TID parameter

Adding tid as a parameter to each handler so that the handler
can know the message sent from which device

Tested:
- Unit Tests passed.

Change-Id: Ida37bf611

Refactor: Handler expands TID parameter

Adding tid as a parameter to each handler so that the handler
can know the message sent from which device

Tested:
- Unit Tests passed.

Change-Id: Ida37bf61146d2f59ea11ebc7bf009f7837ed496d
Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>

show more ...

meson: adjust nlohmann-json dependency

Simplify the meson dependency for nlohmann-json, use the consistent
dependency name, and align the wrap file name with other repositories.

Signed-off-by: Patr

meson: adjust nlohmann-json dependency

Simplify the meson dependency for nlohmann-json, use the consistent
dependency name, and align the wrap file name with other repositories.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I3a682a3e07e38d0a1bfe35858e24f1bb74b4ec34

show more ...

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer retur

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and auto.

Switch all uses of `enabled` to `allowed`.

Change-Id: I794c658531483266bfce6f9b28127a166ed01490
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

InstanceIdDb: Move header from pldmd/ to common/

The header is used across all executables produced by the project, which
makes it "common".

Change-Id: I022b179fad1de8dba2ef39fd33bc240ec73a2d33
Sig

InstanceIdDb: Move header from pldmd/ to common/

The header is used across all executables produced by the project, which
makes it "common".

Change-Id: I022b179fad1de8dba2ef39fd33bc240ec73a2d33
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldmd: move to libpldm instance ID alloc/free

Refactor the dbus_api::Requester class to be implemented in terms of
libpldm's instance ID database. To make that easier to deal with we
introduce a lig

pldmd: move to libpldm instance ID alloc/free

Refactor the dbus_api::Requester class to be implemented in terms of
libpldm's instance ID database. To make that easier to deal with we
introduce a light-weight RAII C++ binding along with a helper class for
unit tests.

Change-Id: Ia03de8245dfb114e6266ba36dcf26ca4398a4ce0
Signed-off-by: Rashmica Gupta <rashmica@linux.ibm.com>
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I61b093f75011417cc9c7acf9605200f4fa429bac
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

libpldm: Correct reference to libpldm header files

When relying on header files from external libraries, #include<> should
be used instead of #include "" to avoid ambiguity.

Tested: Built pldm succ

libpldm: Correct reference to libpldm header files

When relying on header files from external libraries, #include<> should
be used instead of #include "" to avoid ambiguity.

Tested: Built pldm successfully after enabling ibm-oem

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ia1997de7e0f61564055bbd837f4e24c8f14e55a5

show more ...

Add missing dependencies

There are multiple places where the dependencies are
explicitly missing & its working as of today because
of the way the code was organised.

The intent behind this commit i

Add missing dependencies

There are multiple places where the dependencies are
explicitly missing & its working as of today because
of the way the code was organised.

The intent behind this commit is add the missing dependencies
explicitly. This commit fixes :
1. common tests depends on header files in common folder, but
it is not added as a dependency, fixing this by adding libpldmutils
as the dependency.
2. fw-update tests depends on header files in common folder as well,
but it is not added as a dependency , fixing this by adding libpldmutils
as the dependency.
3. requester test code includes header files in the pldmd folder, but
that is not added as a dependency as well, fixing this by adding
include_directories and making it a dependency.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I102ea5096dd9edfc876fd60df7628fc061e085f2

show more ...

meson: add missing nlohmann dependencies to tests

Without it there are build failures because the include search path is
wrong in subproject mode.

Change-Id: I49ee9aab900a41ae91dccc43eccc68321f9d97

meson: add missing nlohmann dependencies to tests

Without it there are build failures because the include search path is
wrong in subproject mode.

Change-Id: I49ee9aab900a41ae91dccc43eccc68321f9d973a
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

tests: Organize the test code to make it modular

The unit test code for libpldmresponder, host-bmc and common is
in a shared test directory. This patch separates the test code
to the respective dire

tests: Organize the test code to make it modular

The unit test code for libpldmresponder, host-bmc and common is
in a shared test directory. This patch separates the test code
to the respective directory.

Tested: Ran the unit test and tests passed.

Signed-off-by: Tom Joseph <rushtotom@gmail.com>
Change-Id: I31d53681fa6c0d8bc6eb7c4e3341aaff4bc341ee

show more ...

build: add wrapfile for gtest/gmock

Copy support from sdbusplus for loading googletest and gmock as
a meson subproject, if it is not found in the host distribution.

Signed-off-by: Patrick Williams

build: add wrapfile for gtest/gmock

Copy support from sdbusplus for loading googletest and gmock as
a meson subproject, if it is not found in the host distribution.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4aa1f6cdc97dc5db038950d81e551113463b1ffb

show more ...

build: add wrapfiles for dependencies

Add wrapfiles for all dependencies and update meson.build
files to ensure dependencies are requested in all cases.
This enables out-of-bitbake/out-of-sdk builds

build: add wrapfiles for dependencies

Add wrapfiles for all dependencies and update meson.build
files to ensure dependencies are requested in all cases.
This enables out-of-bitbake/out-of-sdk builds for this
repository and enables it to be used as a meson subproject.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0f2f7eed98f7f7555cafefc2605e1031a7f0adaf

show more ...

build: rename dependency variable

Per [1], the conventions for dependency variables are to
be named '<project or lib>_dep'. This allows consistency
when using this project as a meson-subproject els

build: rename dependency variable

Per [1], the conventions for dependency variables are to
be named '<project or lib>_dep'. This allows consistency
when using this project as a meson-subproject elsewhere.

Switch the name from 'libpldm' to 'libpldm_dep'.

1. https://mesonbuild.com/Subprojects.html#naming-convention-for-dependency-variables

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I98c8e2148610b45755b45029d1d38206bac5b885

show more ...

Fix: create a deferred event for tasks after GetPDR

There are certain tasks that need to be performed when a GetPDR is
received. That should be done after sending response to GetPDR

before fix:
Rec

Fix: create a deferred event for tasks after GetPDR

There are certain tasks that need to be performed when a GetPDR is
received. That should be done after sending response to GetPDR

before fix:
Received Msg
09 01 86 02 51 00 00 00 00 00 00 00 00 01 ff 7f 00 00
Sending Msg
06 02 51 05

after fix:
Received Msg
09 01 9e 02 51 34 00 00 00 00 00 00 00 01 ff 7f 00 00
Sending Msg
1e 02 51 00 35 00 00 00 00 00 00 00 05 1d 00 34 00 00
00 01 0b 00 00 13 00 02 00 03 00 43 00 04 00 01 00 00 00 00 00 01 c0 00 01 0c

Change-Id: I9590a8365177d5f0e31bad3b67be7e6fbd302822
Signed-off-by: Sampa Misra <sampmisr@in.ibm.com>

show more ...

Fix the getStateSensorReadings command

It should be return all the composite sensors when set the sensorRearm
and reserved to 0.
When the sensorRearm property is set to 0, all composite sensors
shou

Fix the getStateSensorReadings command

It should be return all the composite sensors when set the sensorRearm
and reserved to 0.
When the sensorRearm property is set to 0, all composite sensors
should be returned.

Also, update the presentState property value.
s/PLDM_SENSOR_UNKNOWN/PLDM_SENSOR_NORMAL

Tested:
When the D-Bus object is not present, opState = PLDM_SENSOR_UNAVAILABLE
./pldmtool raw -v -d 0x80 0x02 0x21 0x01 0x00 0x01 0x00
Request Message:
08 01 80 02 21 01 00 01 00
Success in creating the socket : RC = 4
Success in connecting to socket : RC = 0
Success in sending message type as pldm to mctp : RC = 0
Write to socket successful : RC = 9
sd_bus_call: xyz.openbmc_project.Common.Error.ResourceNotFound: path or object not found
Total length:11
Shutdown Socket successful : RC = 0
Response Message:
08 01 00 02 21 00 01 02 01 00 00

When the D-Bus object is present: opState = PLDM_SENSOR_ENABLED
/pldmtool raw -v -d 0x80 0x02 0x21 0x01 0x00 0x01 0x00
Request Message:
08 01 80 02 21 01 00 01 00
Success in creating the socket : RC = 4
Success in connecting to socket : RC = 0
Success in sending message type as pldm to mctp : RC = 0
Write to socket successful : RC = 9
Total length:11
Shutdown Socket successful : RC = 0
Response Message:
08 01 00 02 21 00 01 00 01 00 01

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I3513c469e87cf3a080d01a749eaf7f574c8cafd2

show more ...

oem ibm: infrastructure for oem handlers

1. This commit adds the framework for an oem handler
which can be used by specific oem use-cases
for implementing various commands.

2. This commit adds impl

oem ibm: infrastructure for oem handlers

1. This commit adds the framework for an oem handler
which can be used by specific oem use-cases
for implementing various commands.

2. This commit adds implementation for getStateSensorReadings
and setStateEffecterStates commands for oem state sets.

3. Also adds implementation for inband code update.

Change-Id: Ib38a66ee381dd06b93f6a9313d51de1c23e6ee65
Signed-off-by: Sampa Misra <sampmisr@in.ibm.com>

show more ...

bios: Initialise the bios attributes from bios-settings-manager

The bios-settings-manager is persisting the current value for the PLDM
BIOS attributes. The PLDM daemon will lookup the bios-settings-

bios: Initialise the bios attributes from bios-settings-manager

The bios-settings-manager is persisting the current value for the PLDM
BIOS attributes. The PLDM daemon will lookup the bios-settings-manager
for the current value and create the BIOS attribute value table.

Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
Change-Id: I6a7a9ff9c3766189e6a64ab88c5c5e438881151f

show more ...

Refactor the platform event message handler code

This commit makes slight code change to use some functions both
in BMC requester and responder flow.

Tested : Using pldmtool platformEventMessage is

Refactor the platform event message handler code

This commit makes slight code change to use some functions both
in BMC requester and responder flow.

Tested : Using pldmtool platformEventMessage is sent and D-Bus
property is verified.

Change-Id: Id433f136ad4c7be0d94817deed1d6b60df36b3e4
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

show more ...

Remove redundant dependency calls

- In the current state, the build system has too many
dependency calls, because of which meson tries to find
the same dependendency mutiple times & prints a tra

Remove redundant dependency calls

- In the current state, the build system has too many
dependency calls, because of which meson tries to find
the same dependendency mutiple times & prints a trace
on the console.This would have been an ideal solution
when all the subdirectories are subprojects in meson but
in the current context it is not.

- Even though meson uses the cached dependency objects
rather than fetching them every time, it might not
give any added advantage on the performance front.

- But checking for the same dependency mutiple times gives
a false impression to the users & this can be avoided by
re-using the dependency objects across subdirectories.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: Ic428b2ab1897e4dc4a0024164c07fd416c927da1

show more ...

FRU: simplify BMC FRU table construction

We should be able to map standard D-Bus FRU inventory properties to
standard FRU properties from the PLDM FRU spec.
This commit will simplify things by remov

FRU: simplify BMC FRU table construction

We should be able to map standard D-Bus FRU inventory properties to
standard FRU properties from the PLDM FRU spec.
This commit will simplify things by removing JSONs for standard FRUs.

The standard FRU jsons are not going to be installed, we have mandated
the default DBUS lookup and setup Default Fru record map.
If OEM FRU JSONs are present then only those will be parsed by the
parser.

Tested on rainier with the pldmtool.

Change-Id: I53cd3cd98a0552e3faa42d50c9ae93280218ad28
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>

show more ...

BIOS: Implement HelpText and DisplayName properties

Introduce HelpText and DisplayName fields in the PLDM BIOS JSONs, these should
be parsed and passed to the D-Bus APIs that populates the BIOS tabl

BIOS: Implement HelpText and DisplayName properties

Introduce HelpText and DisplayName fields in the PLDM BIOS JSONs, these should
be parsed and passed to the D-Bus APIs that populates the BIOS table.
https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/BIOSConfig/Manager.interface.yaml#L68
Also, they have the same names in the Redfish schema.
https://redfish.dmtf.org/schemas/v1/AttributeRegistry.v1_3_3.json

Tested: test with JSON
https://gist.github.com/lxwinspur/2afffff2e445fddf90dfed6eceef4014

busctl get-property xyz.openbmc_project.BIOSConfigManager
/xyz/openbmc_project/bios_config/manager
xyz.openbmc_project.BIOSConfig.Manager BaseBIOSTable

a{s(sbsssvva(sv))} 5

"CodeUpdatePolicy"
"xyz.openbmc_project.BIOSConfig.Manager.AttributeType.Enumeration"
true "CodeUpdatePolicy DisplayName" "CodeUpdatePolicy HelpText" "" s
"Concurrent" s "Concurrent" 2
"xyz.openbmc_project.BIOSConfig.Manager.BoundType.OneOf" s "Concurrent"
"xyz.openbmc_project.BIOSConfig.Manager.BoundType.OneOf" s "Disruptive"

"Led"
"xyz.openbmc_project.BIOSConfig.Manager.AttributeType.Enumeration"
false "Led DisplayName" "Led HelpText" "" s "Off" s "Off" 2
"xyz.openbmc_project.BIOSConfig.Manager.BoundType.OneOf" s "On"
"xyz.openbmc_project.BIOSConfig.Manager.BoundType.OneOf" s "Off"

"Model"
"xyz.openbmc_project.BIOSConfig.Manager.AttributeType.String"
false "Model DisplayName" "Model HelpText" "" s "powersupply0" s "FP5280G2" 2
"xyz.openbmc_project.BIOSConfig.Manager.BoundType.MinStringLength" x 1
"xyz.openbmc_project.BIOSConfig.Manager.BoundType.MaxStringLength" x 100

"OUTLET"
"xyz.openbmc_project.BIOSConfig.Manager.AttributeType.Integer"
false "OUTLET DisplayName" "OUTLET HelpText" "" x 9127925392260618112 x 0 3
"xyz.openbmc_project.BIOSConfig.Manager.BoundType.LowerBound" x 0
"xyz.openbmc_project.BIOSConfig.Manager.BoundType.UpperBound" x 68002
"xyz.openbmc_project.BIOSConfig.Manager.BoundType.ScalarIncrement" x 1

"str_example3"
"xyz.openbmc_project.BIOSConfig.Manager.AttributeType.String"
true "str_example3 DisplayName" "str_example3 HelpText" "" s "ef" s "ef" 2
"xyz.openbmc_project.BIOSConfig.Manager.BoundType.MinStringLength" x 1
"xyz.openbmc_project.BIOSConfig.Manager.BoundType.MaxStringLength" x 100

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I4e0e28a6fbaeb409b4d57dfcb54d79aee1c5b211

show more ...