clang-tidy: Enable modernize-deprecated-headers check

Some headers from C library were deprecated in C++ and are no
longer welcome in C++ codebases. Some have no effect in C++ [1].

[1]: https://rel

clang-tidy: Enable modernize-deprecated-headers check

Some headers from C library were deprecated in C++ and are no
longer welcome in C++ codebases. Some have no effect in C++ [1].

[1]: https://releases.llvm.org/13.0.1/tools/clang/tools/extra/docs/clang-tidy/checks/modernize-deprecated-headers.html

Change-Id: Ia3b1df10175e2e661c8fffb82e357c9db81b2e9c
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-diagnostic error: error: use of undeclared identifiers

Clang was throwing use of undeclared identifiers for 'std',
'uint8_t', 'uint16_t' and expected unqualified-id errors
due to missing inclu

clang-diagnostic error: error: use of undeclared identifiers

Clang was throwing use of undeclared identifiers for 'std',
'uint8_t', 'uint16_t' and expected unqualified-id errors
due to missing inclusions.

Change-Id: I072eb27ee7a89e215afdd10f095b82c12be62599
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

pldm: Use modern libpldm OEM header paths

Fixed with:

```
sed -Ei 's/libpldm\/([a-z_]+)_oem_ibm\.h/libpldm\/oem\/ibm\/\1.h/' $(git ls-files)
sed -Ei 's/libpldm\/file_io.h/libpldm\/oem\/ibm\/file_io

pldm: Use modern libpldm OEM header paths

Fixed with:

```
sed -Ei 's/libpldm\/([a-z_]+)_oem_ibm\.h/libpldm\/oem\/ibm\/\1.h/' $(git ls-files)
sed -Ei 's/libpldm\/file_io.h/libpldm\/oem\/ibm\/file_io.h/' $(git ls-files)
sed -Ei 's/libpldm\/host.h/libpldm\/oem\/ibm\/host.h/' $(git ls-files)
```

Change-Id: Idbe61dcc53754d7e6005b34ae21bec8ab6ed45da
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

libpldm: Correct reference to libpldm header files

When relying on header files from external libraries, #include<> should
be used instead of #include "" to avoid ambiguity.

Tested: Built pldm succ

libpldm: Correct reference to libpldm header files

When relying on header files from external libraries, #include<> should
be used instead of #include "" to avoid ambiguity.

Tested: Built pldm successfully after enabling ibm-oem

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ia1997de7e0f61564055bbd837f4e24c8f14e55a5

show more ...

libpldm: Migrate to subproject

Organize files in libpldm to make it a subproject

In the current state, libpldm is not readily consumable
as a subproject.This commit does all the necessary re-organi

libpldm: Migrate to subproject

Organize files in libpldm to make it a subproject

In the current state, libpldm is not readily consumable
as a subproject.This commit does all the necessary re-organisation
of the source code to make it work as a subproject.

There are no .c/.h files changes in this commit, only meson
changes and re-organising the code structure.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I20a71c0c972b1fd81fb359d604433618799102c6

show more ...

pldmtool: Fix tool to show the oem entities

START & END are meant to be used as range to figure out if an
entity/state_set is OEM or not.They are not entity & state set
names.

This commit fixes abo

pldmtool: Fix tool to show the oem entities

START & END are meant to be used as range to figure out if an
entity/state_set is OEM or not.They are not entity & state set
names.

This commit fixes above mentioned issue & also removes TPM entity
from the common fru_master configuration as the entity type is in
OEM range as per DSP0249_1.1.0 specification.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: Iba4fadabf1ae4f94cee8f2f47632731de0bfd85f

show more ...

pldmtool: oem: ibm: untangle header dependencies

With the oem-ibm meson option enabled, pldm_platform_command.cpp has the
following header dependency chain:

requester/handler.hp

pldmtool: oem: ibm: untangle header dependencies

With the oem-ibm meson option enabled, pldm_platform_command.cpp has the
following header dependency chain:

requester/handler.hpp
host-bmc/dbus_to_event_handler.hpp
libpldmresponder/platform.hpp
oem/ibm/libpldmresponder/inband_code_update.hpp
oem/ibm/libpldmresponder/oem_ibm_handler.hpp
pldmtool/oem/ibm/oem_ibm_state_set.hpp
pldmtool/pldm_platform_cmd.cpp

requester/handler.hpp has a dependency on sd_event. Since sd_event is
not listed as a dependency of pldmtool, this results in a compile
failure when building in subproject mode.

Clearly it isn't appropriate to add sd_event as a pldmtool dependency.
To fix the compile failure, break the include dependency chain between
oem_ibm_state_set.hpp and oem_ibm_handler.hpp. This is likely an
intra-pldm domain violation anyway (pldmtool <-> libpldmresponder).

oem_ibm_state_set.hpp includes oem_ibm_handler.hpp to make use of a
single constant: PLDM_OEM_IBM_ENTITY_FIRMWARE_UPDATE. To break the
dependency chain, PLDM_OEM_IBM_ENTITY_FIRMWARE_UPDATE is moved to an oem
version of entity.h.

Change-Id: I2b54ad9a7559ecf5fbe01c6a52a24428e56df77e
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

pldmtool: oem: ibm: add missing header

Add a missing include of libpldm/entity.h for PLDM_ENTITY enumerations.

Change-Id: I08b03d98185e5dc18c42a24242064e198f56c597
Signed-off-by

pldmtool: oem: ibm: add missing header

Add a missing include of libpldm/entity.h for PLDM_ENTITY enumerations.

Change-Id: I08b03d98185e5dc18c42a24242064e198f56c597
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Fix renamed IBM OEM state set header in pldmtool

The pldmtool oem headers weren't updated with the renamed state
set header.

Signed-off-by: Eddie James <eajames@linux.ibm.com>

Fix renamed IBM OEM state set header in pldmtool

The pldmtool oem headers weren't updated with the renamed state
set header.

Signed-off-by: Eddie James <eajames@linux.ibm.com>
Change-Id: I306c58a923997b6049837532192ffad5ce9abe96

show more ...

PLDM: Refactor the code

This commit refactors the code as IBM's OEM state
sets where moved to oem/ibm/libpldm/state_set.h
and 7f9523cda174e2c6b0b05c7446a9a8799d302c97 commit
had

PLDM: Refactor the code

This commit refactors the code as IBM's OEM state
sets where moved to oem/ibm/libpldm/state_set.h
and 7f9523cda174e2c6b0b05c7446a9a8799d302c97 commit
had broken the compilation of pldm master with
oem-ibm enabled.

Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>
Change-Id: I676e105ed549b6d19874e6077d1f5dbe0f9b9675

show more ...

treewide: remove 'using namespace' from headers

Using namespace at global scope in a header file violates the cpp core
guidelines. Quoting the guidelines:

"Doing so takes awa

treewide: remove 'using namespace' from headers

Using namespace at global scope in a header file violates the cpp core
guidelines. Quoting the guidelines:

"Doing so takes away an #includer’s ability to effectively
disambiguate and to use alternatives. It also makes #included headers
order-dependent as they might have different meaning when included in
different orders."

For further reading:
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rs-using-directive

The guidelines don't call out using using namespace from namespace
scope, but it is only marginally less problematic and still unexpected,
so this patch removes those as well.

The process used to do the update is roughly:

1 - git grep 'using namespace' **.hpp
2 - For each instance, remove the offending 'using namespace' line
3 - build
4 - add 'using namespace' to cpp files or fully resolve types in hpp
files until the project builds again.

Further cleanup is possible - for example cpp files could be scrubbed
for unnecessary namespace qualification - this was not done here to make
review as simple as possible.

Change-Id: I4931f5e78a1b5b74b4a4774c035a549f4d59b91a
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

pldmtool: Display GetPDR state set ID possible state names in an array

Note: Also, displays OEM state set and their possible states.
Created new oem_ibm_state_set.hpp for OEM IBM P

pldmtool: Display GetPDR state set ID possible state names in an array

Note: Also, displays OEM state set and their possible states.
Created new oem_ibm_state_set.hpp for OEM IBM PDR's possible states.

Example:

{
"nextRecordHandle": 115,
"responseCount": 27,
"recordHandle": 114,
"PDRHeaderVersion": 1,
"PDRType": "State Sensor PDR",
"recordChangeNumber": 0,
"dataLength": 17,
"PLDMTerminusHandle": 0,
"sensorID": 93,
"entityType": "[Physical] Unspecified",
"entityInstanceNumber": 0,
"containerID": 0,
"sensorInit": "noInit",
"sensorAuxiliaryNamesPDR": false,
"compositeSensorCount": 1,
"stateSetID[0]": "Identify State(17)",
"possibleStatesSize[0]": 1,
"possibleStates[0]": [
"Identify State Unasserted(1)",
"Identify State Asserted(2)"
]
}

{
"nextRecordHandle": 125,
"responseCount": 27,
"recordHandle": 124,
"PDRHeaderVersion": 1,
"PDRType": "State Sensor PDR",
"recordChangeNumber": 0,
"dataLength": 17,
"PLDMTerminusHandle": 0,
"sensorID": 103,
"entityType": "[Physical] System chassis (main enclosure)",
"entityInstanceNumber": 1,
"containerID": 0,
"sensorInit": "noInit",
"sensorAuxiliaryNamesPDR": false,
"compositeSensorCount": 1,
"stateSetID[0]": "Operational Fault Status(10)",
"possibleStatesSize[0]": 1,
"possibleStates[0]": [
"Normal(1)",
"Stressed(2)"
]
}

{
"nextRecordHandle": 249,
"responseCount": 30,
"recordHandle": 248,
"PDRHeaderVersion": 1,
"PDRType": "State Effecter PDR",
"recordChangeNumber": 0,
"dataLength": 16,
"PLDMTerminusHandle": 1,
"effecterID": 116,
"entityType": "[Physical] OEM IBM Firmware Update",
"entityInstanceNumber": 1,
"containerID": 0,
"effecterSemanticID": 0,
"effecterInit": "noInit",
"effecterDescriptionPDR": false,
"compositeEffecterCount": 1,
"stateSetID[0]": "OEM IBM Boot State(32769)",
"possibleStatesSize[0]": 2,
"possibleStates[0]": [
"P Side(1)",
"T side(2)"
]
}

Signed-off-by: Sridevi Ramesh <sridevra@in.ibm.com>
Change-Id: Iae44b14dab071683c86fd65c95e984b9287eca80

show more ...