clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I8c84201cb2343a8c8a5507a49de0721a1bee7063
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

pldm: Remove unnecessary type casting in logs

This commit removes the unnecessary type casting of values of the
journal logs based on supported types mentioned in LG2 documentation
[1].

Testing: Ve

pldm: Remove unnecessary type casting in logs

This commit removes the unnecessary type casting of values of the
journal logs based on supported types mentioned in LG2 documentation
[1].

Testing: Verified the debug traces to correct.

'''
For Instance:
Earlier -
error(”TYPE = {TYPE} “, “TYPE”, static_cast<unsigned>(PLDM_STATE_EFFECTER_PDR));
Journal trace -
May 27 08:16:51 p10bmc pldmd[931]: TYPE = 11

After Correction -
error(”TYPE = {TYPE}“, “TYPE”, PLDM_STATE_EFFECTER_PDR);
Journal trace -
May 27 08:16:51 p10bmc pldmd[931]: TYPE = Enum(11)
'''

[1]: https://github.com/openbmc/phosphor-logging/blob/master/docs/structured-logging.md#lg2

Change-Id: Ia649ecd4ecbb73c421f7844885f58a6835805719
Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>

show more ...

oem-ibm: Improving logs (lg2)

This commit corrects the severity level of logs and also formats the
message string, fixing the ill-defined message string of the logs as
mentioned in the anti-pattern

oem-ibm: Improving logs (lg2)

This commit corrects the severity level of logs and also formats the
message string, fixing the ill-defined message string of the logs as
mentioned in the anti-pattern document [1]. Additionally, based on the
requirement this commit adds more debug information to logs.

[1]: https://github.com/openbmc/docs/blob/master/anti-patterns.md#ill-defined-data-structuring-in-lg2-message-strings

Change-Id: I24ca21de35d5a1a9b3cc64b28a149e4c213055f9
Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>

show more ...

Remove iostream references

With the adoption of LG2 we do not need iostream
prints to the journal. The library was referred but
never used in these cases.

Signed-off-by: Sagar Srinivas <sagar.srini

Remove iostream references

With the adoption of LG2 we do not need iostream
prints to the journal. The library was referred but
never used in these cases.

Signed-off-by: Sagar Srinivas <sagar.srinivas@ibm.com>
Change-Id: I11d3f00284e4f16b63cddb8da2fed14d59672ba1

show more ...

simplify convert_from_string calls

There were a few sdbusplus convert_from_string calls added with
commit 7b4d59aa8f6020b919d41415bece7f0651304b00. Simplify these
to reduce the duplicate string-con

simplify convert_from_string calls

There were a few sdbusplus convert_from_string calls added with
commit 7b4d59aa8f6020b919d41415bece7f0651304b00. Simplify these
to reduce the duplicate string-conversion calls and to improve
readability.

Change-Id: Iec688fb88dc2513d42583af110abd4c04aeb9fa0
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Reducing the dbus string constants

There are a large number of dbus constants scattered throughout the
code that could/should be obtained from phosphor-dbus-interface values.
Some of the minor refac

Reducing the dbus string constants

There are a large number of dbus constants scattered throughout the
code that could/should be obtained from phosphor-dbus-interface values.
Some of the minor refactoring is done in this commit to reduce the
dbus string constants.

Change-Id: I2a8441e9ab275e8f2a72c3c79a6ed80e6e444f46
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

show more ...

PLDM:Catching exception precisely and printing it

Correcting catch block in PLDM repo to print all
exception precisely so pldm trace can be more
useful to identify defect easily.

Change-Id: If2e86d

PLDM:Catching exception precisely and printing it

Correcting catch block in PLDM repo to print all
exception precisely so pldm trace can be more
useful to identify defect easily.

Change-Id: If2e86dcb031ddc2e927e7836d7f4359f5b44cdec
Signed-off-by: Kamalkumar Patel <kamalkumar.patel@ibm.com>

show more ...

pldm: Use modern libpldm OEM header paths

Fixed with:

```
sed -Ei 's/libpldm\/([a-z_]+)_oem_ibm\.h/libpldm\/oem\/ibm\/\1.h/' $(git ls-files)
sed -Ei 's/libpldm\/file_io.h/libpldm\/oem\/ibm\/file_io

pldm: Use modern libpldm OEM header paths

Fixed with:

```
sed -Ei 's/libpldm\/([a-z_]+)_oem_ibm\.h/libpldm\/oem\/ibm\/\1.h/' $(git ls-files)
sed -Ei 's/libpldm\/file_io.h/libpldm\/oem\/ibm\/file_io.h/' $(git ls-files)
sed -Ei 's/libpldm\/host.h/libpldm\/oem\/ibm\/host.h/' $(git ls-files)
```

Change-Id: Idbe61dcc53754d7e6005b34ae21bec8ab6ed45da
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Convert to using libpldm transport APIs

A significant amount of logic can be removed by exploiting the new
transport APIs provided by libpldm. Switch the pldm repository over to
use these by i

pldm: Convert to using libpldm transport APIs

A significant amount of logic can be removed by exploiting the new
transport APIs provided by libpldm. Switch the pldm repository over to
use these by introducing an RAII wrapper for the APIs. The current
stance is to continue using the legacy mctp-demux transport
implementation, but we also provide a build option to switch to the
AF_MCTP transport.

We don't currently have the infrastructure in place to get the correct
TIDs, so to keep everything working as before use the EID as the TID in
the EID-to-TID mapping.

Change-Id: I366f079082b102cfc0e90db0f62208581eb8693e
Signed-off-by: Rashmica Gupta <rashmica@linux.ibm.com>
Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

pldmd: Migrate instance ID allocation to pldm::InstanceIdDb

This removes use of `pldm::dbus_api::Requester` from around the
code-base. This makes progress towards removing the DBus API entirely
once

pldmd: Migrate instance ID allocation to pldm::InstanceIdDb

This removes use of `pldm::dbus_api::Requester` from around the
code-base. This makes progress towards removing the DBus API entirely
once all its consumers are converted to the libpldm instance ID APIs.

There was never a good reason for the code using the class to have
knowledge that it was related to DBus anyway, so this is, in-effect, a
double clean up improving separation of concerns.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I2d9397cae1b3c8c251c32e36ca520aad9c9b8cf6

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I61b093f75011417cc9c7acf9605200f4fa429bac
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

oem-ibm: remove OSStart as indication host is running

This logic is checking whether PHYP is at standby or runtime. The
OSStart was never implemented by PHYP so it should not be looked at to
determi

oem-ibm: remove OSStart as indication host is running

This logic is checking whether PHYP is at standby or runtime. The
OSStart was never implemented by PHYP so it should not be looked at to
determine this state. The hostboot team is going to utilize this
BootProgress to indicate when they are starting PHYP.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Iebb1260232c60ae77a0f0e25e79fd2fa354238ba

show more ...

PLDM: Implementing Phosphor-Logging/LG2 logging

This commit adds changes in PLDM for implementing
structured LG2 logging, thereby moving away from
std::cout/cerr practice of logging which are
output

PLDM: Implementing Phosphor-Logging/LG2 logging

This commit adds changes in PLDM for implementing
structured LG2 logging, thereby moving away from
std::cout/cerr practice of logging which are
output streams and not logging mechanism.

PLDM now can make use of lg2 features like accurate
CODE LINE Number and CODE_FUNCTION Name and better
detailing in json object values which can be used in
log tracking.

More detailed logging change:
https://gist.github.com/riyadixitagra/c251685c1ba84248181891f7bc282395

Tested:
Ran a power off, on, cycle, and reset-reload.

Change-Id: I0485035f15f278c3fd172f0581b053c1c37f3a5b
Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>

show more ...

libpldm: Correct reference to libpldm header files

When relying on header files from external libraries, #include<> should
be used instead of #include "" to avoid ambiguity.

Tested: Built pldm succ

libpldm: Correct reference to libpldm header files

When relying on header files from external libraries, #include<> should
be used instead of #include "" to avoid ambiguity.

Tested: Built pldm successfully after enabling ibm-oem

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ia1997de7e0f61564055bbd837f4e24c8f14e55a5

show more ...

libpldm: Migrate to subproject

Organize files in libpldm to make it a subproject

In the current state, libpldm is not readily consumable
as a subproject.This commit does all the necessary re-organi

libpldm: Migrate to subproject

Organize files in libpldm to make it a subproject

In the current state, libpldm is not readily consumable
as a subproject.This commit does all the necessary re-organisation
of the source code to make it work as a subproject.

There are no .c/.h files changes in this commit, only meson
changes and re-organising the code structure.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I20a71c0c972b1fd81fb359d604433618799102c6

show more ...

OEM-IBM:Remove misleading trace in case of BMC reboot

In case of BMC reboot state manager starts after pldm,
so while sending bios attribute update event it doesn't get
boot progress state and cause

OEM-IBM:Remove misleading trace in case of BMC reboot

In case of BMC reboot state manager starts after pldm,
so while sending bios attribute update event it doesn't get
boot progress state and causes exception. This is not considered
as error and pldm sends attribute update events to host.
So removed the trace.

Change-Id: Id00815d6b224783941cfebb1a92bb852cf101e48
Signed-off-by: ArchanaKakani <archana.kakani@ibm.com>

show more ...

oem-ibm: Fix the bios event message

bios event is an oem platform event message & as per the PLDM
platform spec DSP0248_1.2.0 (Table 15),the event message should have
that TID of the terminus that o

oem-ibm: Fix the bios event message

bios event is an oem platform event message & as per the PLDM
platform spec DSP0248_1.2.0 (Table 15),the event message should have
that TID of the terminus that originated the event message, not the EID.

This commit would also remove unwanted tracing in the BIOS event
path.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I7d7a9d1bc05ed2fc4869d61a44634436164edfc0

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8e2242adb79be342562c9b7f3d2153dfdf578085

show more ...

support a BootProgress of SystemSetup for host running

SystemSetup is a BootProgress that indicates the host is booted, but in
a state where user interaction is needed. On an IBM system, this state

support a BootProgress of SystemSetup for host running

SystemSetup is a BootProgress that indicates the host is booted, but in
a state where user interaction is needed. On an IBM system, this state
is entered when VMI needs some configuration or when PHYP's NVRAM has
been cleared.

pldm needs to consider the host running in this scenario because it's
needed to send user configuration information like the VMI IP and
static vs. dhcp information.

Tested:
- Verified that pldm properly communicates with the host firmware when
it is in SystemSetup

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I3072919569572c4eecc71cd8cd44352f5474c2b6

show more ...

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic8c3ff9b8b0fa64ef1d17ba305b9030284a1ee68

show more ...

dos2unix conversion

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I78a4c2f28285ea30d66895b352402bfd12f95c00

implement async handlers for all requester commands

this commit makes use of 74f27c730ef3925a0f2a3adfaa04f8790f931372 to
convert the existing blocking requester commands in pldm to async

implement async handlers for all requester commands

this commit makes use of 74f27c730ef3925a0f2a3adfaa04f8790f931372 to
convert the existing blocking requester commands in pldm to async
ones.
this is tested with Host code and seems to work fine

Change-Id: I8d4762c3cd5bce49f854b30f8325bfcd1dcb4ff9
Signed-off-by: Sampa Misra <sampmisr@in.ibm.com>

show more ...

Change the interface for host firmware state

The BootProgress property is used to update the state of the host OS.
This patch uses the BootProgress property in the case of BIOS attribute

Change the interface for host firmware state

The BootProgress property is used to update the state of the host OS.
This patch uses the BootProgress property in the case of BIOS attributes
hot update and D-Bus to effecter mapping.

Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
Change-Id: I9ee16b74a16e25ad3fa7661ef5cdeb9ddc55347a

show more ...

oem-ibm: Send the event to host when BIOS attribute changes

IBM has the requirement to send a hot update to host when the
BIOS attribute changes. This patch enables sending an OEM platfo

oem-ibm: Send the event to host when BIOS attribute changes

IBM has the requirement to send a hot update to host when the
BIOS attribute changes. This patch enables sending an OEM platform
event message to host with the details of the BIOS attributes that
changed on the BMC. Once the host acknowledges the event, then BMC
updates the BaseBiosTable in the bios-config-manager. The host comes
down and reads the changed BIOS attributes by calling the command
GetBIOSAttribute value.

Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
Change-Id: Id1579bfed1967e653da743313c825b765d227681

show more ...