oem-ibm: Improving logs (lg2)

This commit corrects the severity level of logs and also formats the
message string, fixing the ill-defined message string of the logs as
mentioned in the anti-pattern

oem-ibm: Improving logs (lg2)

This commit corrects the severity level of logs and also formats the
message string, fixing the ill-defined message string of the logs as
mentioned in the anti-pattern document [1]. Additionally, based on the
requirement this commit adds more debug information to logs.

[1]: https://github.com/openbmc/docs/blob/master/anti-patterns.md#ill-defined-data-structuring-in-lg2-message-strings

Change-Id: I24ca21de35d5a1a9b3cc64b28a149e4c213055f9
Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>

show more ...

oem-ibm: Fix size corruption during DMA transfer

When the remote terminus performs read/write operations on BMC
utilizing DMA(Direct Memory Access), the BMC verifies the data length
to be transferre

oem-ibm: Fix size corruption during DMA transfer

When the remote terminus performs read/write operations on BMC
utilizing DMA(Direct Memory Access), the BMC verifies the data length
to be transferred and segments it into chunks if the length exceeds
the maximum allowable size (8384512 byte) by DMA. This modification
addresses an issue in PLDM where it incorrectly reports data transfer
status to the remote terminus, including the leftover length in its
response, which is erroneous. With this enhancement, PLDM now delivers
accurate responses with the appropriate length specified.

Tested:
Tested IPL flow on simulator.

Change-Id: I48d4f825f1e049b06f291e401a02f8dacc1ad970
Signed-off-by: Kamalkumar Patel <kamalkumar.patel@ibm.com>

show more ...

Enhance traces for File Size Exceeds Offset

This commit adds changes to enhance or give context
to the generic error traces related to errors for
file size exceeding file offset provided by remote
t

Enhance traces for File Size Exceeds Offset

This commit adds changes to enhance or give context
to the generic error traces related to errors for
file size exceeding file offset provided by remote
terminus.

Signed-off-by: Sagar Srinivas <sagar.srinivas@ibm.com>
Change-Id: Ic088a54190c2f990d07609a35c9b45bab637a15b

show more ...

pldm: Include config.h via compiler argument

This removes any ambiguity about which config.h is being included.
Subprojects such as libpldm and phosphor-logging also generate config.h
files, and the

pldm: Include config.h via compiler argument

This removes any ambiguity about which config.h is being included.
Subprojects such as libpldm and phosphor-logging also generate config.h
files, and these are exposed in the include path.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I3e0ccd6339f088380ffa29d41167b07aefc7dd16

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I61b093f75011417cc9c7acf9605200f4fa429bac
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

PLDM: Implementing Phosphor-Logging/LG2 logging

This commit adds changes in PLDM for implementing
structured LG2 logging, thereby moving away from
std::cout/cerr practice of logging which are
output

PLDM: Implementing Phosphor-Logging/LG2 logging

This commit adds changes in PLDM for implementing
structured LG2 logging, thereby moving away from
std::cout/cerr practice of logging which are
output streams and not logging mechanism.

PLDM now can make use of lg2 features like accurate
CODE LINE Number and CODE_FUNCTION Name and better
detailing in json object values which can be used in
log tracking.

More detailed logging change:
https://gist.github.com/riyadixitagra/c251685c1ba84248181891f7bc282395

Tested:
Ran a power off, on, cycle, and reset-reload.

Change-Id: I0485035f15f278c3fd172f0581b053c1c37f3a5b
Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>

show more ...

treewide: remove 'using namespace' from headers

Using namespace at global scope in a header file violates the cpp core
guidelines. Quoting the guidelines:

"Doing so takes awa

treewide: remove 'using namespace' from headers

Using namespace at global scope in a header file violates the cpp core
guidelines. Quoting the guidelines:

"Doing so takes away an #includer’s ability to effectively
disambiguate and to use alternatives. It also makes #included headers
order-dependent as they might have different meaning when included in
different orders."

For further reading:
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rs-using-directive

The guidelines don't call out using using namespace from namespace
scope, but it is only marginally less problematic and still unexpected,
so this patch removes those as well.

The process used to do the update is roughly:

1 - git grep 'using namespace' **.hpp
2 - For each instance, remove the offending 'using namespace' line
3 - build
4 - add 'using namespace' to cpp files or fully resolve types in hpp
files until the project builds again.

Further cleanup is possible - for example cpp files could be scrubbed
for unnecessary namespace qualification - this was not done here to make
review as simple as possible.

Change-Id: I4931f5e78a1b5b74b4a4774c035a549f4d59b91a
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

oem-ibm: Support system reboot after inband code update

This commit adds a bmc effecter that causes a system reboot(
phyp, chassis and bmc)

After bmc sends an end update success

oem-ibm: Support system reboot after inband code update

This commit adds a bmc effecter that causes a system reboot(
phyp, chassis and bmc)

After bmc sends an end update successful event, Host will
set this new effecter. Upon getting the setStateEffecterStates
call bmc-pldm does the following:
1. Set the power restore to reboot the host once the BMC
is rebooted
2. power off Host and Chassis
3. reboot the bmc

Tested with pldmtool
Steps after patching changes:
1. Boot host to STANDBY
2. Fetch the effecter to note the effecterId
Ex: ./pldmtool platform GetPDR -d 28
3. Trigger the system reboot by toggling the effecter
./pldmtool platform SetStateEffecterStates -i 10 -c 1
-d 1 1

Signed-off-by: Sagar Srinivas <sagar.srinivas@ibm.com>
Change-Id: Id2d4201a7d61ae335adc64f2583571a37dc7879d

show more ...

PLDM:Fix for file I/O by type (lids) writes returning error

This commit fixes the issue where file I/O by Type (lids)
writes were returning generic PLDM_ERROR.

Tested on a raini

PLDM:Fix for file I/O by type (lids) writes returning error

This commit fixes the issue where file I/O by Type (lids)
writes were returning generic PLDM_ERROR.

Tested on a rainier.

Before the fix:
Sending Msg
08 3f 0c 01 00 00 00 00

Afetr the fix:
Sending Msg
09 3f 0c 00 ff 03 00 00

Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>
Change-Id: Icc64c3a7c101700fdd626f9b9c9837c141e97648

show more ...

oem ibm: marker LID validation

This commit adds code for writing marker LID
from Host and also send a PlatformEventMessage
after validation.

This commit also subscribes for

oem ibm: marker LID validation

This commit adds code for writing marker LID
from Host and also send a PlatformEventMessage
after validation.

This commit also subscribes for the interface added
signal to fetch the new image id and sends the relevant
sensor event to host

Change-Id: I92476beca18e6dd255f372dd82d6eaeca18e282c
Signed-off-by: Sampa Misra <sampmisr@in.ibm.com>

show more ...

oem ibm: support reading LIDs based on type

This commit reads the LIDs requested by Host. Host
sends request as T or P side. This commit evaluates the
current boot side and reads the

oem ibm: support reading LIDs based on type

This commit reads the LIDs requested by Host. Host
sends request as T or P side. This commit evaluates the
current boot side and reads the appropriate LIDs.

Also this commit stores the image LIDs sent by Host
during an inband code update

Change-Id: Ia4bae68fa95f19bc228ef7002493d54abab3dc93
Signed-off-by: Sampa Misra <sampmisr@in.ibm.com>

show more ...

oem-ibm: LID handler: change patch LID dir

Support patching running and alternate LIDs - running side and alternate
side patches will exist in their own directories.

Signed-off-

oem-ibm: LID handler: change patch LID dir

Support patching running and alternate LIDs - running side and alternate
side patches will exist in their own directories.

Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
Change-Id: I1dc6ead6164d45ccb5168862c6d955891d4b94e8

show more ...

oem-ibm: apply patched LIDs only for running side

Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
Change-Id: I04243cbbafa61a1f4d207afbc537bf8b1933a336

file_io_type_lid.hpp: Update LID paths

The eMMC will create symlinks to the running version of host fw
and to the alternate (non-running) version. Update the
paths for those and the

file_io_type_lid.hpp: Update LID paths

The eMMC will create symlinks to the running version of host fw
and to the alternate (non-running) version. Update the
paths for those and the patch path. Rename them because T and P
are just labels and can be renamed, but the host fw version does
not change until a BMC reboot is issued.

Default running to T. At a later time, pldm can make changes to
determine if P/T is the running or non-running sides.

Change-Id: I72e374bf33cab59bd258adef713446af624161a9
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

file_io_type_lid.hpp: Support patch path

Add the ability to patch lid files by having pldm check first if the
lid file exists in the patch directory.

Tested: Verified the expect

file_io_type_lid.hpp: Support patch path

Add the ability to patch lid files by having pldm check first if the
lid file exists in the patch directory.

Tested: Verified the expected lid path by printing it out:
- Without lid patches:
Dec 12 18:16:50 witherspoon-128-YL30UF74T00E-YL30UF74T00E-YL30UF74T00E pldmd[363]: LidHandler: lidPath=/usr/share/host-fw/81e002ff.lid
- With lid patches:
Dec 12 18:21:04 witherspoon-128-YL30UF74T00E-YL30UF74T00E-YL30UF74T00E pldmd[363]: LidHandler: lidPath=/usr/local/share/host-fw/81e002ff.lid

Change-Id: I5c70ef69d7be02d090a4516f27c11132e3fff29f
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

clang-format: update to latest from docs repo

Since `Cpp11` is an alias for `Latest` and we should tend towards using the
latest C++ standard, update the C++ standard to Latest.

clang-format: update to latest from docs repo

Since `Cpp11` is an alias for `Latest` and we should tend towards using the
latest C++ standard, update the C++ standard to Latest.

https://github.com/llvm/llvm-project/commit/e5032567903de19962333c4bf7d2edceaf4f9824#diff-b49a097415dff2837d9626d422c58ba8R82
https://github.com/openbmc/docs/blob/master/style/cpp/.clang-format

Also, other OpenBMC repos are doing the same.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I449e88bb4e1e262060110e1a8f3e8db3ddfc74cf

show more ...

implement commands for dump xfer

This commit implements the writeFile command
for dumpHandler in PLDM oem. This is for offloading
the dump from host memory to an external location

implement commands for dump xfer

This commit implements the writeFile command
for dumpHandler in PLDM oem. This is for offloading
the dump from host memory to an external location
via bmc. Also it implements the newfileAvailable
notification handler in libpldmresponder.This caters
to the new dump notification coming from the Host

Change-Id: Ibf7c1facea282ec4f772dfee646cca9f7877bb7d
Signed-off-by: Sampa Misra <sampmisr@in.ibm.com>

show more ...

ibm-oem: add FileAck handler for PELs

Extend the FileAck* commands to let the host firmware to ack PELs it has
received from the BMC.

Signed-off-by: vkaverap <vkaverap@in.ibm.co

ibm-oem: add FileAck handler for PELs

Extend the FileAck* commands to let the host firmware to ack PELs it has
received from the BMC.

Signed-off-by: vkaverap <vkaverap@in.ibm.com>
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
Change-Id: Iafc1c92c64c8ea7a51367c2c36842613af1f46b5

show more ...

oem-ibm: add readFileByType handler

Add a handler for file type 'LID', to be able to read LID files over the
LPC channel.

Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>

oem-ibm: add readFileByType handler

Add a handler for file type 'LID', to be able to read LID files over the
LPC channel.

Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
Change-Id: I9db77f78b0aa4e289fb0ab940121569b431f4dfe

show more ...

oem-ibm: add readFileByTypeIntoMemory handler

Add a handler for file type 'LID', which are host firmware image files
on IBM systems. These would be read by the host firmware as it boots.

oem-ibm: add readFileByTypeIntoMemory handler

Add a handler for file type 'LID', which are host firmware image files
on IBM systems. These would be read by the host firmware as it boots.

Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
Change-Id: I83e3ee398a4c6a4198a40b8b2188a3c11d0e55c4

show more ...