clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I8c84201cb2343a8c8a5507a49de0721a1bee7063
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: I539a0c5baa63be240fc1c76367c0af338dd89c7b
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

oem-ibm : File I/O read-write with length 0

This commit implements pldm to dishonor file I/O read/write for length
zero. Additional changes: - Implemented check for response code of
encode/decode AP

oem-ibm : File I/O read-write with length 0

This commit implements pldm to dishonor file I/O read/write for length
zero. Additional changes: - Implemented check for response code of
encode/decode APIs and along with appropriate error message. - Added
check for performing read operation from a file size 0.

Tested: Functional testing passed.

Change-Id: Ibab1981202775b672b3d50040884e9db4c16d5c2
Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>

show more ...

oem-ibm: Improving logs (lg2)

This commit corrects the severity level of logs and also formats the
message string, fixing the ill-defined message string of the logs as
mentioned in the anti-pattern

oem-ibm: Improving logs (lg2)

This commit corrects the severity level of logs and also formats the
message string, fixing the ill-defined message string of the logs as
mentioned in the anti-pattern document [1]. Additionally, based on the
requirement this commit adds more debug information to logs.

[1]: https://github.com/openbmc/docs/blob/master/anti-patterns.md#ill-defined-data-structuring-in-lg2-message-strings

Change-Id: I24ca21de35d5a1a9b3cc64b28a149e4c213055f9
Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>

show more ...

Remove iostream references

With the adoption of LG2 we do not need iostream
prints to the journal. The library was referred but
never used in these cases.

Signed-off-by: Sagar Srinivas <sagar.srini

Remove iostream references

With the adoption of LG2 we do not need iostream
prints to the journal. The library was referred but
never used in these cases.

Signed-off-by: Sagar Srinivas <sagar.srinivas@ibm.com>
Change-Id: I11d3f00284e4f16b63cddb8da2fed14d59672ba1

show more ...

PLDM:Catching exception precisely and printing it

Correcting catch block in PLDM repo to print all
exception precisely so pldm trace can be more
useful to identify defect easily.

Change-Id: If2e86d

PLDM:Catching exception precisely and printing it

Correcting catch block in PLDM repo to print all
exception precisely so pldm trace can be more
useful to identify defect easily.

Change-Id: If2e86dcb031ddc2e927e7836d7f4359f5b44cdec
Signed-off-by: Kamalkumar Patel <kamalkumar.patel@ibm.com>

show more ...

Enhance traces for File Size Exceeds Offset

This commit adds changes to enhance or give context
to the generic error traces related to errors for
file size exceeding file offset provided by remote
t

Enhance traces for File Size Exceeds Offset

This commit adds changes to enhance or give context
to the generic error traces related to errors for
file size exceeding file offset provided by remote
terminus.

Signed-off-by: Sagar Srinivas <sagar.srinivas@ibm.com>
Change-Id: Ic088a54190c2f990d07609a35c9b45bab637a15b

show more ...

pldm: Include config.h via compiler argument

This removes any ambiguity about which config.h is being included.
Subprojects such as libpldm and phosphor-logging also generate config.h
files, and the

pldm: Include config.h via compiler argument

This removes any ambiguity about which config.h is being included.
Subprojects such as libpldm and phosphor-logging also generate config.h
files, and these are exposed in the include path.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I3e0ccd6339f088380ffa29d41167b07aefc7dd16

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I61b093f75011417cc9c7acf9605200f4fa429bac
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

PLDM: Implementing Phosphor-Logging/LG2 logging

This commit adds changes in PLDM for implementing
structured LG2 logging, thereby moving away from
std::cout/cerr practice of logging which are
output

PLDM: Implementing Phosphor-Logging/LG2 logging

This commit adds changes in PLDM for implementing
structured LG2 logging, thereby moving away from
std::cout/cerr practice of logging which are
output streams and not logging mechanism.

PLDM now can make use of lg2 features like accurate
CODE LINE Number and CODE_FUNCTION Name and better
detailing in json object values which can be used in
log tracking.

More detailed logging change:
https://gist.github.com/riyadixitagra/c251685c1ba84248181891f7bc282395

Tested:
Ran a power off, on, cycle, and reset-reload.

Change-Id: I0485035f15f278c3fd172f0581b053c1c37f3a5b
Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>

show more ...

libpldm: Correct reference to libpldm header files

When relying on header files from external libraries, #include<> should
be used instead of #include "" to avoid ambiguity.

Tested: Built pldm succ

libpldm: Correct reference to libpldm header files

When relying on header files from external libraries, #include<> should
be used instead of #include "" to avoid ambiguity.

Tested: Built pldm successfully after enabling ibm-oem

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ia1997de7e0f61564055bbd837f4e24c8f14e55a5

show more ...

oem-ibm: FFDC enhancement changes

Added fine tuned first failure data capture traces in the system
and resource dump related paths.

Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>

oem-ibm: FFDC enhancement changes

Added fine tuned first failure data capture traces in the system
and resource dump related paths.

Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>
Change-Id: I484853eb1fa79e166daa87dd374966d94faa36f6

show more ...

oem-ibm:Unmap the memory selectively

These changes will handle the case where host crashes in the
middle of outofband DMA transfer.

With the existing code, after the DMA transfer PLDM unmaps
the me

oem-ibm:Unmap the memory selectively

These changes will handle the case where host crashes in the
middle of outofband DMA transfer.

With the existing code, after the DMA transfer PLDM unmaps
the memory and closes the file handler(XDMA FD).
Closing the XDMA file handler will reset the XDMA Driver which
internally will unmap the memory if not already unmapped.

But when the host crashes during the DMA transfer,
PLDM receives EINTR(interrupt) and it unmaps the memory.
XDMA driver doesn't know that the operation is interrupted,
it still thinks that operation is in progress.
munmap will hang if xdma driver thinks the operation is in progress.

To solve the PLDM Hang in munmap, in case of EINTR during DMA transfer
PLDM should skip munmap and just close the file handler.
Once PLDM closes the file handler driver gets reset and
it munmaps the memory which is not unmapped yet.

Tested: Powered on the host and confirmed if the munmap is
called for all possitive cases.
Hardcoded return value to EINTR and confirmed that memory
is not getting unmapped.

Change-Id: Ic4ad78e705c6377534cbcb36e924858db4ab8b68
Signed-off-by: ArchanaKakani <archana.kakani@ibm.com>

show more ...

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6a2316d11f1dd70d8dc2368c2aa01d88cf1cdb26

oem ibm: support reading LIDs based on type

This commit reads the LIDs requested by Host. Host
sends request as T or P side. This commit evaluates the
current boot side and reads the

oem ibm: support reading LIDs based on type

This commit reads the LIDs requested by Host. Host
sends request as T or P side. This commit evaluates the
current boot side and reads the appropriate LIDs.

Also this commit stores the image LIDs sent by Host
during an inband code update

Change-Id: Ia4bae68fa95f19bc228ef7002493d54abab3dc93
Signed-off-by: Sampa Misra <sampmisr@in.ibm.com>

show more ...

oem-ibm: Modified to write system dump data on unix domain socket.

Currently pldm writes dump data on nbd device.

This commit is to enable dump offload using UNIX socket
On dump

oem-ibm: Modified to write system dump data on unix domain socket.

Currently pldm writes dump data on nbd device.

This commit is to enable dump offload using UNIX socket
On dump offload request, pldm setup a UNIX socket and
write data on socket, webserver connects to this socket
and reads data to offload

Tested By:
1. Offloaded system dump
2. Ran below pldmtool commands for performance test
while offloading system dump, i don't see an delay
pldmtool bios GetBIOSTable -t 1
pldmtool bios GetBIOSTable -t 2

Signed-off-by: Ravi Teja <raviteja28031990@gmail.com>
Change-Id: Iad8863d87c3b04a8dd588f1f0239f65fcb59f38b

show more ...

common: code re-org

Move common files under a common/ directory.

Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
Change-Id: I0eaf91d4ee94c1e78228da0c50892f82e91912fa

clang-format: update to latest from docs repo

Since `Cpp11` is an alias for `Latest` and we should tend towards using the
latest C++ standard, update the C++ standard to Latest.

clang-format: update to latest from docs repo

Since `Cpp11` is an alias for `Latest` and we should tend towards using the
latest C++ standard, update the C++ standard to Latest.

https://github.com/llvm/llvm-project/commit/e5032567903de19962333c4bf7d2edceaf4f9824#diff-b49a097415dff2837d9626d422c58ba8R82
https://github.com/openbmc/docs/blob/master/style/cpp/.clang-format

Also, other OpenBMC repos are doing the same.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I449e88bb4e1e262060110e1a8f3e8db3ddfc74cf

show more ...

oem-ibm: fixup error codes as per spec

Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
Change-Id: If460b3d8ad5863de5437aa727bf30ec4c7715717

pldm oem: implement certificate handler

This commit adds code to handle the ceritificate request and
certificate transfer between the host and bmc following pldm oem
file i/o protoco

pldm oem: implement certificate handler

This commit adds code to handle the ceritificate request and
certificate transfer between the host and bmc following pldm oem
file i/o protocol

Change-Id: I8095e0f5ad8c3c5cc796da1cfbe4bb9946af31cf
Signed-off-by: Sampa Misra <sampmisr@in.ibm.com>

show more ...

implement commands for dump xfer

This commit implements the writeFile command
for dumpHandler in PLDM oem. This is for offloading
the dump from host memory to an external location

implement commands for dump xfer

This commit implements the writeFile command
for dumpHandler in PLDM oem. This is for offloading
the dump from host memory to an external location
via bmc. Also it implements the newfileAvailable
notification handler in libpldmresponder.This caters
to the new dump notification coming from the Host

Change-Id: Ibf7c1facea282ec4f772dfee646cca9f7877bb7d
Signed-off-by: Sampa Misra <sampmisr@in.ibm.com>

show more ...

oem/pldm: Implement GetAlertStatus command

Implement the GetAlertStatus PLDM OEM command on BMC, the command can
just return the hardcoded data:
00 (PLDM_SUCCESS)
FF 00 00 30

oem/pldm: Implement GetAlertStatus command

Implement the GetAlertStatus PLDM OEM command on BMC, the command can
just return the hardcoded data:
00 (PLDM_SUCCESS)
FF 00 00 30
00 00 80 30

Tested:
./pldmtool raw -d 0x80 0x3f 0xf0 0x00
Request Message:
08 01 80 3f f0 00
Response Message:
08 01 00 3f f0 00 30 00 00 ff 30 80 00 00

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I9d231fcc5a7bb77e1abdfaa1b46ba044c6e8bbe8

show more ...

pldm: Moving utils function into the common directory

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I4fbd0da4bc6f27e9a9ed711962bd8737d8b55ebf

ibm-oem: add FileAck handler for PELs

Extend the FileAck* commands to let the host firmware to ack PELs it has
received from the BMC.

Signed-off-by: vkaverap <vkaverap@in.ibm.co

ibm-oem: add FileAck handler for PELs

Extend the FileAck* commands to let the host firmware to ack PELs it has
received from the BMC.

Signed-off-by: vkaverap <vkaverap@in.ibm.com>
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
Change-Id: Iafc1c92c64c8ea7a51367c2c36842613af1f46b5

show more ...

ibm-oem: add handler to read PELs

Extend ReadFileByType* commands to let the host firmware read PELs off
of the BMC.

Signed-off-by: vkaverap <vkaverap@in.ibm.com>
Signed-off

ibm-oem: add handler to read PELs

Extend ReadFileByType* commands to let the host firmware read PELs off
of the BMC.

Signed-off-by: vkaverap <vkaverap@in.ibm.com>
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
Change-Id: I3721e1ffe61a66d0f011535504a6915e0c16764b

show more ...