#
6492f524 |
| 15-Jun-2020 |
George Liu <liuxiwei@inspur.com> |
clang-format: update to latest from docs repo Since `Cpp11` is an alias for `Latest` and we should tend towards using the latest C++ standard, update the C++ standard to Latest.
clang-format: update to latest from docs repo Since `Cpp11` is an alias for `Latest` and we should tend towards using the latest C++ standard, update the C++ standard to Latest. https://github.com/llvm/llvm-project/commit/e5032567903de19962333c4bf7d2edceaf4f9824#diff-b49a097415dff2837d9626d422c58ba8R82 https://github.com/openbmc/docs/blob/master/style/cpp/.clang-format Also, other OpenBMC repos are doing the same. Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: I449e88bb4e1e262060110e1a8f3e8db3ddfc74cf
show more ...
|
#
45fed20f |
| 01-Apr-2020 |
John Wang <wangzqbj@inspur.com> |
bios_table: Implement find attr entry by string handle Implement find attribute table entry by string handle Signed-off-by: John Wang <wangzqbj@inspur.com> Change-Id: I884043df1
bios_table: Implement find attr entry by string handle Implement find attribute table entry by string handle Signed-off-by: John Wang <wangzqbj@inspur.com> Change-Id: I884043df1b75e48d737bb37b8f0f724c32bb3334
show more ...
|
#
3be7085e |
| 13-Feb-2020 |
John Wang <wangzqbj@inspur.com> |
bios: Implement BIOSEnumAttribute Implement BIOSEnumAttribute, most of the code is copied from bios/bios_parser.cpp. Implement SetAttrValueOnDbus and constructEntry for enum att
bios: Implement BIOSEnumAttribute Implement BIOSEnumAttribute, most of the code is copied from bios/bios_parser.cpp. Implement SetAttrValueOnDbus and constructEntry for enum attribute Signed-off-by: John Wang <wangzqbj@inspur.com> Change-Id: Ia6230485fd2d6d05f9f2ddb3a80b81f6556aee9f
show more ...
|
#
95e6b3c1 |
| 12-Feb-2020 |
John Wang <wangzqbj@inspur.com> |
bios: Implement BIOSIntegerAttribute Implement BIOSIntegerAttribute, most of the code is copied from bios/bios_parser.cpp. Implement SetAttrValueOnDbus and constructEntry for in
bios: Implement BIOSIntegerAttribute Implement BIOSIntegerAttribute, most of the code is copied from bios/bios_parser.cpp. Implement SetAttrValueOnDbus and constructEntry for integer attribute Signed-off-by: John Wang <wangzqbj@inspur.com> Change-Id: I57d5b5dbcb74f9a404f5133426208f4c6851dea2
show more ...
|
#
d965934f |
| 27-Feb-2020 |
John Wang <wangzqbj@inspur.com> |
bios: Implement BIOSConfig Load the parsed json configs into memory. And provid APIs to get/set on bios tables. Signed-off-by: John Wang <wangzqbj@inspur.com> Change-Id: Ida
bios: Implement BIOSConfig Load the parsed json configs into memory. And provid APIs to get/set on bios tables. Signed-off-by: John Wang <wangzqbj@inspur.com> Change-Id: Ida1fedc923d31afc61dd2d4aec70d81bb6a90ae9
show more ...
|
#
29683b53 |
| 27-Feb-2020 |
John Wang <wangzqbj@inspur.com> |
bios: Implement BIOSStringAttribute Implement BIOSStringAttribute, most of the code is copied from bios/bios_parser.cpp. Implement SetAttrValueOnDbus and constructEntry for stri
bios: Implement BIOSStringAttribute Implement BIOSStringAttribute, most of the code is copied from bios/bios_parser.cpp. Implement SetAttrValueOnDbus and constructEntry for string attribute Signed-off-by: John Wang <wangzqbj@inspur.com> Change-Id: Ic7c6b35d32738d698d7649f97cb7843606b8a2ba
show more ...
|
#
e2efdcce |
| 12-Feb-2020 |
John Wang <wangzqbj@inspur.com> |
bios: Implement BIOSAttribute BIOS tables are built based on json entry. When a bios attribute is set by pldm, the corresponding dbus backend should be synchronized. Then, the B
bios: Implement BIOSAttribute BIOS tables are built based on json entry. When a bios attribute is set by pldm, the corresponding dbus backend should be synchronized. Then, the BIOSAttribute class is abstracted, and it provides the following two interfaces 1. constructEntry: Construct the entry of the attribute/attribute-value table 2. setAttrValueOnDbus: Update the corresponding dbus backend Specific types of attributes are implemented based on BIOSAttribute. eg BIOSStringAttribute, BIOSEnumAttribute, BIOSIntegerAttribute. Once the BIOS Handler is loaded, all attributes would be constructed from json. We use BIOSConfig(class) to persist all attributes in ram. BIOSConfig provides the following methods. - buildTables: Build tables - removeTables: Remove the persistent tables - setAttrValue: Set attribute value on dbus and update the bios table - getBIOSTable: Get bios table by table type After we implemented BIOSConfig/BIOSSIntegerAttribute/BIOSStringAttribute/BIOSEnumAttribute, we will use the new interface(BIOSConfig) in BIOS Handler. It will have the following advantages 1. Different types of attribute implementations are placed in different files, improving readability 2. Logic to operate bios tables is no longer coupled with BIOS Handler. In addition, added a c++ wrapper for string table. After completing this refactor, will move the implementation to a common place. It's useful for pldmtool. Signed-off-by: John Wang <wangzqbj@inspur.com> Change-Id: I11e304c470360ca5fde23e4969494bb03de475c0
show more ...
|
#
e297b9f4 |
| 02-Feb-2020 |
John Wang <wangzqbj@inspur.com> |
Remove findStringName/Handle functions Use the `find` functions in BiosStringTable. Tested: all the code changes are about building bios tables. tested on fp5280g2, with json
Remove findStringName/Handle functions Use the `find` functions in BiosStringTable. Tested: all the code changes are about building bios tables. tested on fp5280g2, with json https://gist.github.com/wangzqbj/b24558331cb35d14fca3b555ef03e458 saw the built tables are as expected. $ pldmtool bios GetBIOSTable -t 0 ... ... PLDM StringTable: BIOSStringHandle : BIOSString 0 : CodeUpdatePolicy 1 : Concurrent 2 : Disruptive 3 : Led 4 : Model 5 : OUTLET 6 : Off 7 : On 8 : str_example3 $ pldmtool bios GetBIOSTable -t 1 ... ... PLDM AttributeTable: AttributeHandle: 0, AttributeNameHandle: 0(CodeUpdatePolicy) AttributeType: BIOSEnumerationReadOnly NumberOfPossibleValues: 2 PossibleValueStringHandle[0] = 1(Concurrent) PossibleValueStringHandle[1] = 2(Disruptive) NumberOfDefaultValues: 1 DefaultValueStringHandleIndex[0] = 0, StringHandle = 1(Concurrent) AttributeHandle: 1, AttributeNameHandle: 3(Led) AttributeType: BIOSEnumeration NumberOfPossibleValues: 2 PossibleValueStringHandle[0] = 7(On) PossibleValueStringHandle[1] = 6(Off) NumberOfDefaultValues: 1 DefaultValueStringHandleIndex[0] = 1, StringHandle = 6(Off) AttributeHandle: 2, AttributeNameHandle: 5(OUTLET) AttributeType: BIOSInteger LowerBound: 0 UpperBound: 68002 ScalarIncrement: 1 DefaultValue: 0 AttributeHandle: 3, AttributeNameHandle: 4(Model) AttributeType: BIOSString StringType: 0x01 MinimumStringLength: 1 MaximumStringLength: 100 DefaultStringLength: 8 DefaultString: FP5280G2 AttributeHandle: 4, AttributeNameHandle: 8(str_example3) AttributeType: BIOSStringReadOnly StringType: 0x00 MinimumStringLength: 1 MaximumStringLength: 100 DefaultStringLength: 2 DefaultString: ef $ pldmtool bios GetBIOSTable -t 2 ... ... PLDM AttributeValueTable: AttributeHandle: 0 AttributeType: BIOSEnumerationReadOnly NumberOfCurrentValues: 1 CurrentValueStringHandleIndex[0] = 0, StringHandle = 1(Concurrent) AttributeHandle: 1 AttributeType: BIOSEnumeration NumberOfCurrentValues: 1 CurrentValueStringHandleIndex[0] = 1, StringHandle = 6(Off) AttributeHandle: 2 AttributeType: BIOSInteger CurrentValue: 0 AttributeHandle: 3 AttributeType: BIOSString CurrentStringLength: 12 CurrentString: powersupply0 AttributeHandle: 4 AttributeType: BIOSStringReadOnly CurrentStringLength: 2 CurrentString: ef Signed-off-by: John Wang <wangzqbj@inspur.com> Change-Id: Iba775caffcdfa51d780cd9c211572d3a359b80b4
show more ...
|
#
f719f3bf |
| 16-Jan-2020 |
John Wang <wangzqbj@inspur.com> |
libpldmresponder: Add BIOSStringTable s/BIOSStringTable/biosStringTable/g, make the variable begin with a lowercase letter. Added a BIOSStringTable class and implemented a comma
libpldmresponder: Add BIOSStringTable s/BIOSStringTable/biosStringTable/g, make the variable begin with a lowercase letter. Added a BIOSStringTable class and implemented a command method(find string by handle). Signed-off-by: John Wang <wangzqbj@inspur.com> Change-Id: I1e8fbf97025f68a87246e8661d9fdb14cbb62ecf
show more ...
|
#
cb7f2d44 |
| 19-Jun-2019 |
Deepak Kodihalli <dkodihal@in.ibm.com> |
Add APIs to store/load BIOS tables This commit implements C++ APIs to store a PLDM BIOS table into persistent storage, and to load the same back into memory. This commit also defines
Add APIs to store/load BIOS tables This commit implements C++ APIs to store a PLDM BIOS table into persistent storage, and to load the same back into memory. This commit also defines C structs representing the different BIOS tables. Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com> Change-Id: I4a771a368c6931464f45ae4a8f467b579c7a5d74
show more ...
|