clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I8c84201cb2343a8c8a5507a49de0721a1bee7063
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

pldm: Move off pldm_bios_table_append_pad_checksum_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_tabl

pldm: Move off pldm_bios_table_append_pad_checksum_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_append_pad_checksum_check.yaml
```

Change-Id: If9fd3e8e96a7889051b879e292e67223f2757fc3
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Move off pldm_bios_table_attr_value_entry_encode_integer_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pl

pldm: Move off pldm_bios_table_attr_value_entry_encode_integer_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_attr_value_entry_encode_integer_check.yaml
```

Change-Id: Ifdae4ebf848a43d9bd997292b35426b26dbf558c
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Move off pldm_bios_table_attr_value_entry_encode_string_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pld

pldm: Move off pldm_bios_table_attr_value_entry_encode_string_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_attr_value_entry_encode_string_check.yaml
```

Change-Id: If3454dc8a7b2036c035d49b1e6d9ba1b23547138
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Move off pldm_bios_table_attr_value_entry_encode_enum_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_

pldm: Move off pldm_bios_table_attr_value_entry_encode_enum_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_attr_value_entry_encode_enum_check.yaml
```

Change-Id: Id989540d8ad4ea114ee059992be4293254e1ecc2
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Move off pldm_bios_table_attr_entry_integer_encode_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bio

pldm: Move off pldm_bios_table_attr_entry_integer_encode_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_attr_entry_integer_encode_check.yaml
```

Change-Id: I1b5616570862b7069028fb3e4481a5fcd2db1a57
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Move off pldm_bios_table_attr_entry_string_decode_def_string_length_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions

pldm: Move off pldm_bios_table_attr_entry_string_decode_def_string_length_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_attr_entry_string_decode_def_string_length_check.yaml
```

gitlint-ignore: T1,B1
Change-Id: Ib7b44820870da32109981c8a8d44657214cf1d61
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Move off pldm_bios_table_attr_entry_string_encode_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios

pldm: Move off pldm_bios_table_attr_entry_string_encode_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_attr_entry_string_encode_check.yaml
```

Change-Id: I5cbbedd1ef855ead2048b25b35bb9c3e5547175e
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Move off pldm_bios_table_attr_entry_enum_decode_pv_hdls_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pld

pldm: Move off pldm_bios_table_attr_entry_enum_decode_pv_hdls_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_attr_entry_enum_decode_pv_hdls_check.yaml
```

Change-Id: I6dd0cf34f023aa1d4f806d0a24eb45ce5e822d12
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Move off pldm_bios_table_attr_entry_enum_decode_def_num_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pld

pldm: Move off pldm_bios_table_attr_entry_enum_decode_def_num_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_attr_entry_enum_decode_def_num_check.yaml
```

Change-Id: I4a1777cf6b29ed8f1cf47770d058a3dd0b7c8e7b
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Move off pldm_bios_table_attr_entry_enum_decode_pv_num_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm

pldm: Move off pldm_bios_table_attr_entry_enum_decode_pv_num_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_attr_entry_enum_decode_pv_num_check.yaml
```

Change-Id: I749ac6dd0423a82e16dc1a6d35bfec5a9041b565
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Move off pldm_bios_table_attr_entry_enum_encode_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_t

pldm: Move off pldm_bios_table_attr_entry_enum_encode_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_attr_entry_enum_encode_check.yaml
```

Change-Id: Id8e99a4561ac4568baf6a961177bd5b4820fdff6
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Move off pldm_bios_table_string_entry_decode_string_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bi

pldm: Move off pldm_bios_table_string_entry_decode_string_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_string_entry_decode_string_check.yaml
```

Change-Id: I085a4b6bbd8a08db19156ab404d5dde6a20d32ba
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Move off pldm_bios_table_string_entry_encode_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_tabl

pldm: Move off pldm_bios_table_string_entry_encode_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_bios_table_string_entry_encode_check.yaml
```

Change-Id: I254f11a4002c3a6308acb1e59473dc5bbf367afc
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

libpldmresponder: Improving Logs (lg2)

This commit corrects the severity level of logs and also formats the
message string, fixing the ill-defined message string of the logs as
mentioned in the anti

libpldmresponder: Improving Logs (lg2)

This commit corrects the severity level of logs and also formats the
message string, fixing the ill-defined message string of the logs as
mentioned in the anti-pattern document [1]. Additionally, based on the
requirement this commit adds more debug information to logs.

[1]: https://github.com/openbmc/docs/blob/master/anti-patterns.md#ill-defined-data-structuring-in-lg2-message-strings

Change-Id: I7dc5c308a8cd76573995e07d01d1a6037bca31ba
Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>

show more ...

PLDM:Catching exception precisely and printing it

Correcting catch block in PLDM repo to print all
exception precisely so pldm trace can be more
useful to identify defect easily.

Change-Id: If2e86d

PLDM:Catching exception precisely and printing it

Correcting catch block in PLDM repo to print all
exception precisely so pldm trace can be more
useful to identify defect easily.

Change-Id: If2e86dcb031ddc2e927e7836d7f4359f5b44cdec
Signed-off-by: Kamalkumar Patel <kamalkumar.patel@ibm.com>

show more ...

pldm: Migrate to pldm_bios_table_attr_value_entry_encode_integer_check()

pldm_bios_table_attr_value_entry_encode_integer() is deprecated in
libpldm as it uses assert() to sanitize its parameters. Us

pldm: Migrate to pldm_bios_table_attr_value_entry_encode_integer_check()

pldm_bios_table_attr_value_entry_encode_integer() is deprecated in
libpldm as it uses assert() to sanitize its parameters. Use
pldm_bios_table_attr_value_entry_encode_integer_check() instead, which
returns a value indicating success or failure.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ic308d24a83fe3371a7ef074cb1d20092a06a1291

show more ...

libpldmresponder: pldm_bios_table_append_pad_checksum() is deprecated

Migrate to pldm_bios_table_append_pad_checksum_check() which does not
sanitize its behaviour with assert().

Signed-off-by: Andr

libpldmresponder: pldm_bios_table_append_pad_checksum() is deprecated

Migrate to pldm_bios_table_append_pad_checksum_check() which does not
sanitize its behaviour with assert().

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ide288bb40e5acabd2bf85870849bf176ddcbc621

show more ...

pldm: Migrate off deprecated libpldm BIOS table entry encoding APIs

libpldm has deprecated the affected APIs. Prefer using their `*_check()`
variants as these return an error code rather than preven

pldm: Migrate off deprecated libpldm BIOS table entry encoding APIs

libpldm has deprecated the affected APIs. Prefer using their `*_check()`
variants as these return an error code rather than prevent misbehaviour
with assert().

1. pldm_bios_table_attr_entry_integer_encode()
2. pldm_bios_table_attr_value_entry_encode_enum()
3. pldm_bios_table_attr_value_entry_encode_string()
4. pldm_bios_table_attr_value_entry_encode_integer()

Tested: Successfully booted a p10bmc host, dumped each of the BIOS
tables with pldmtool without issue

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I823b24884e518f8c53fd153b3bc30569595ecd86

show more ...

pldm: Convert to pldm_bios_table_*_check() APIs

The pldm_bios_table_*_check() APIs wrap around unchecked equivalents
that only sanitize their parameters using assert(). The checks included
in the pl

pldm: Convert to pldm_bios_table_*_check() APIs

The pldm_bios_table_*_check() APIs wrap around unchecked equivalents
that only sanitize their parameters using assert(). The checks included
in the pldm_bios_table_*_check() APIs test the same conditions that
would trigger the assert()s in the unchecked APIs but instead return an
error code on failure.

Use of the unchecked APIs has the potential to blow up the pldmd
process, but also requires that libpldm continue to be built with
`-UNDEBUG` to avoid undefined behaviour (by aborting the process). This
impacts the performance of the library in addition to be a bit of a UX
disaster.

The unchecked APIs are deprecated in libpldm as a step improve its
safety and code generation:

https://gerrit.openbmc.org/c/openbmc/libpldm/+/64179

Tested: Booted the host on a p10bmc system with the patch applied.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I9677a7fa5ca59d04865963b367f3bb55c8676cfb

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I61b093f75011417cc9c7acf9605200f4fa429bac
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

libpldm: Correct reference to libpldm header files

When relying on header files from external libraries, #include<> should
be used instead of #include "" to avoid ambiguity.

Tested: Built pldm succ

libpldm: Correct reference to libpldm header files

When relying on header files from external libraries, #include<> should
be used instead of #include "" to avoid ambiguity.

Tested: Built pldm successfully after enabling ibm-oem

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ia1997de7e0f61564055bbd837f4e24c8f14e55a5

show more ...

Fixed compilation error

Fixed the compilation error caused due to libpldm changes.

Change-Id: I63c6a015ac626114cfbe15681facbfbf14c2abf4
Signed-off-by: ArchanaKakani <archana.kakani@ibm.com>

Fix libpldm includes in the responder

The header files from libpldm are installed in
libpldm/<.h> pattern, so fixing the header includes to
have folder name prepended.

Signed-off-by: Manojkiran Eda

Fix libpldm includes in the responder

The header files from libpldm are installed in
libpldm/<.h> pattern, so fixing the header includes to
have folder name prepended.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I0c1c326b3bac4e328d679253c60ac69f2082041e

show more ...

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6a2316d11f1dd70d8dc2368c2aa01d88cf1cdb26