InstanceIdDb: Move header from pldmd/ to common/

The header is used across all executables produced by the project, which
makes it "common".

Change-Id: I022b179fad1de8dba2ef39fd33bc240ec73a2d33
Sig

InstanceIdDb: Move header from pldmd/ to common/

The header is used across all executables produced by the project, which
makes it "common".

Change-Id: I022b179fad1de8dba2ef39fd33bc240ec73a2d33
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

Maintain consistency of entity instance variable

In order to maintain the consistency of variable names
across PDR structures, change the entity_instance_num
of pldm_pdr_fru_record_set to entity_ins

Maintain consistency of entity instance variable

In order to maintain the consistency of variable names
across PDR structures, change the entity_instance_num
of pldm_pdr_fru_record_set to entity_instance in
accordance to the changes done in libpldm -
https://gerrit.openbmc.org/c/openbmc/libpldm/+/65146/7
https://gerrit.openbmc.org/c/openbmc/libpldm/+/65150/6

Signed-off-by: Sagar Srinivas <sagar.srinivas@ibm.com>
Change-Id: Icbd340495957d90c5c43273d1f3f0eae2de83697

show more ...

host-bmc: fix compile error for non-IBM platforms

There is code that attempts to use
PLDM_OEM_FRU_FIELD_TYPE_LOCATION_CODE, which is an IBM-OEM enum. Wrap
this code in the appropriate ifdef so that

host-bmc: fix compile error for non-IBM platforms

There is code that attempts to use
PLDM_OEM_FRU_FIELD_TYPE_LOCATION_CODE, which is an IBM-OEM enum. Wrap
this code in the appropriate ifdef so that it compiles correctly on
non-IBM platforms.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I83699096aa2edf2af2986b5a7f1956e2aae2fd4f

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Change-Id: Iac76ba81d91fe61aa24de8d50774b5fa7349cae9
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Handle FRU records from host

- Get FRU record table from host and traverse the entity structure
from the FRU record set PDR, and create D-Bus object.

- When the FRU field type is a PLDM_OEM_FRU_F

Handle FRU records from host

- Get FRU record table from host and traverse the entity structure
from the FRU record set PDR, and create D-Bus object.

- When the FRU field type is a PLDM_OEM_FRU_FIELD_TYPE_LOCATION_CODE
, the location code is used to populate the
xyz.openbmc_project.Inventory.Decorator.LocationCode D-Bus
interface for the corresponding FRU.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I482c4d371f76b4881109ef420dfd9543e1aa810b

show more ...

Update pldm_entity_association_tree_add method

Update to the signature changes for
pldm_entity_association_tree_add method to
pldm_entity_association_tree_add_entity and add necessary
arguments for

Update pldm_entity_association_tree_add method

Update to the signature changes for
pldm_entity_association_tree_add method to
pldm_entity_association_tree_add_entity and add necessary
arguments for the same as per the libpldm changes done for
the method.

Reference: https://gerrit.openbmc.org/c/openbmc/libpldm/+/65484

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Iaf233da29d4250c9139d2dd7e630fe796a62719c

show more ...

Handle entity association records from host

- Get the PDRs from host, traverse the entity association structure
and construct the D-Bus object path according to the entity type ID
and container

Handle entity association records from host

- Get the PDRs from host, traverse the entity association structure
and construct the D-Bus object path according to the entity type ID
and container type ID.

- eg:
/xyz/openbmc_project/inventory/system1/chassis1/io_board1/powersupply1
/xyz/openbmc_project/inventory/system1/chassis1/io_board1/powersupply2
/xyz/openbmc_project/inventory/system1/chassis2/io_board2/powersupply1
/xyz/openbmc_project/inventory/system1/chassis2/io_board2/powersupply2

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I1c606ea943624f2601be4f5f6b5c30d1bf71cd11

show more ...

Update mergeEntityAssociations logic

- The intent behind this commit is to update the logic of
the mergeEntityAssociations method.

- When we extract PDRs data to vector<entities>, according to

Update mergeEntityAssociations logic

- The intent behind this commit is to update the logic of
the mergeEntityAssociations method.

- When we extract PDRs data to vector<entities>, according to
DSP0248_1.2.0 Table 94, the first element in vector is
`Container Entity`, and the others are `Contained Entity`.
Therefore, for Contained Entity, their parent must be the first
element(Container Entity), which does not need to be obtained from
the getParent method, and only the first element Container Entity
needs to be obtained from the getParent method(hosts-fru.json).

This commit is dependant on the libpldm changes:
https://gerrit.openbmc.org/c/openbmc/libpldm/+/60584

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I117a4fc465c8daabd72d5826fef788a03900e975

show more ...

pldm: Enhance the find & add pdr utilities

Change the names of pldm_entity_association_tree_find() and
pldm_entity_association_tree_add() in accordance with
the changes in libpldm to
pldm_entity_ass

pldm: Enhance the find & add pdr utilities

Change the names of pldm_entity_association_tree_find() and
pldm_entity_association_tree_add() in accordance with
the changes in libpldm to
pldm_entity_association_tree_find_with_locality() and
pldm_entity_association_tree_add_entity. As per -
https://gerrit.openbmc.org/c/openbmc/libpldm/+/63585 and
https://gerrit.openbmc.org/c/openbmc/libpldm/+/65623. Also,
change by adding parameters according to the newly changed
signatures.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: Ib721c496314c963759a1d51eed481356cb296006

show more ...

clang-error: fix clang-diagnostic-overloaded-virtual error

The error clang-diagnostic-overloaded-virtual is generated
when a function hides the overloaded virtual function.

Change-Id: I87fdabb4ea9

clang-error: fix clang-diagnostic-overloaded-virtual error

The error clang-diagnostic-overloaded-virtual is generated
when a function hides the overloaded virtual function.

Change-Id: I87fdabb4ea9efd0c69d1b030127a6a9782cd3b23
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

show more ...

pldmd: Migrate to pldm_pdr_add_check()

pldm_pdr_add() is deprecated in libpldm as it uses assert() to
communicate to the caller that an error occurred. pldm_pdr_add_check()
instead returns a value t

pldmd: Migrate to pldm_pdr_add_check()

pldm_pdr_add() is deprecated in libpldm as it uses assert() to
communicate to the caller that an error occurred. pldm_pdr_add_check()
instead returns a value that indicates success or failure.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Icca92fd742f07fb935202a9d9e62f5648916b12b

show more ...

host-bmc: Migrate to pldm_entity_association_pdr_add_from_node_check()

pldm_entity_association_pdr_add_from_node() is deprecated in libpldm as
it relied on assert() to communicate failures from the

host-bmc: Migrate to pldm_entity_association_pdr_add_from_node_check()

pldm_entity_association_pdr_add_from_node() is deprecated in libpldm as
it relied on assert() to communicate failures from the implementation.
pldm_entity_association_pdr_add_from_node_check() instead returns a
value indicating success or failure.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: If5ef1f372f0e835e8d97affcaab7a9abc2625d97

show more ...

pldmd: Account for pldm_pdr_init() returning NULL

Historically, libpldm's pldm_pdr_init() has internall used assert() to
enforce that the returned value is not NULL. Efforts are underway to
remove t

pldmd: Account for pldm_pdr_init() returning NULL

Historically, libpldm's pldm_pdr_init() has internall used assert() to
enforce that the returned value is not NULL. Efforts are underway to
remove this reliance on assert() in libpldm to ensure consumers aren't
ungracefully terminated.

This change chooses to return an appropriate error to the
caller of pldmd's internal APIs where possible. However, in a number of
circumstances there was either not a sensible value that could be
returned, or it was not possible to return a value without further
refactoring. In these circumstances we choose to throw
`std::runtime_error`, which will at least do what it can to unwind.
While it may feel like it falls short of proper error handling, the
reality is the calling code is already structured such that it pretends
allocation failures never occur. The switch to throwing a runtime error
makes a strict improvement over the immediate termination implemented by
assert().

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ibb6bc3abf62e32f05ac079453853873298db6c4f

show more ...

pldm: Include config.h via compiler argument

This removes any ambiguity about which config.h is being included.
Subprojects such as libpldm and phosphor-logging also generate config.h
files, and the

pldm: Include config.h via compiler argument

This removes any ambiguity about which config.h is being included.
Subprojects such as libpldm and phosphor-logging also generate config.h
files, and these are exposed in the include path.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I3e0ccd6339f088380ffa29d41167b07aefc7dd16

show more ...

remove OSStart as indication host is running

The host firmware (at least for IBM) never implemented this boot
progress when starting the OS. Instead, another host firmware team is
utilizing it to in

remove OSStart as indication host is running

The host firmware (at least for IBM) never implemented this boot
progress when starting the OS. Instead, another host firmware team is
utilizing it to indicate an earlier part of the boot.

Therefore this boot progress code should not be treated as if the host
is running.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I453ec41af804db880a99b62105b510464b147efa

show more ...

pldmd: Migrate instance ID allocation to pldm::InstanceIdDb

This removes use of `pldm::dbus_api::Requester` from around the
code-base. This makes progress towards removing the DBus API entirely
once

pldmd: Migrate instance ID allocation to pldm::InstanceIdDb

This removes use of `pldm::dbus_api::Requester` from around the
code-base. This makes progress towards removing the DBus API entirely
once all its consumers are converted to the libpldm instance ID APIs.

There was never a good reason for the code using the class to have
knowledge that it was related to DBus anyway, so this is, in-effect, a
double clean up improving separation of concerns.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I2d9397cae1b3c8c251c32e36ca520aad9c9b8cf6

show more ...

pldmd: move to libpldm instance ID alloc/free

Refactor the dbus_api::Requester class to be implemented in terms of
libpldm's instance ID database. To make that easier to deal with we
introduce a lig

pldmd: move to libpldm instance ID alloc/free

Refactor the dbus_api::Requester class to be implemented in terms of
libpldm's instance ID database. To make that easier to deal with we
introduce a light-weight RAII C++ binding along with a helper class for
unit tests.

Change-Id: Ia03de8245dfb114e6266ba36dcf26ca4398a4ce0
Signed-off-by: Rashmica Gupta <rashmica@linux.ibm.com>
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I61b093f75011417cc9c7acf9605200f4fa429bac
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

host-bmc: test: Avoid -Werror=overloaded-virtual

Drop the const qualifier for the createHostEffecterMatch() mock to
resolve the following error:

```
In file included from ../host-bmc/test/dbus_to_h

host-bmc: test: Avoid -Werror=overloaded-virtual

Drop the const qualifier for the createHostEffecterMatch() mock to
resolve the following error:

```
In file included from ../host-bmc/test/dbus_to_host_effecter_test.cpp:3:
../host-bmc/dbus_to_host_effecters.hpp:169:18: error: ‘virtual void pldm::host_effecters::HostEffecterParser::createHostEffecterMatch(const std::string&, const std::string&, size_t, size_t, uint16_t)’ was hidden [-Werror=overloaded-virtual=]
169 | virtual void createHostEffecterMatch(const std::string& objectPath,
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from ../subprojects/googletest/googlemock/include/gmock/gmock-actions.h:147,
from ../subprojects/googletest/googlemock/include/gmock/gmock.h:56,
from ../common/test/mocked_utils.hpp:3,
from ../host-bmc/test/dbus_to_host_effecter_test.cpp:1:
../host-bmc/test/dbus_to_host_effecter_test.cpp:28:23: note: by ‘testing::internal::Function<void(const std::__cxx11::basic_string<char>&, const std::__cxx11::basic_string<char>&, long unsigned int, long unsigned int, short unsigned int)>::Result MockHostEffecterParser::createHostEffecterMatch(testing::internal::ElemFromList<0, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, long unsigned int, long unsigned int, short unsigned int>::type, testing::internal::ElemFromList<1, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, long unsigned int, long unsigned int, short unsigned int>::type, testing::internal::ElemFromList<2, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, long unsigned int, long unsigned int, short unsigned int>::type, testing::internal::ElemFromList<3, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, long unsigned int, long unsigned int, short unsigned int>::type, testing::internal::ElemFromList<4, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, long unsigned int, long unsigned int, short unsigned int>::type) const’
28 | MOCK_METHOD(void, createHostEffecterMatch,
| ^~~~~~~~~~~~~~~~~~~~~~~
../subprojects/googletest/googlemock/include/gmock/internal/gmock-pp.h:17:31: note: in definition of macro ‘GMOCK_PP_IDENTITY’
17 | #define GMOCK_PP_IDENTITY(_1) _1
| ^~
../subprojects/googletest/googlemock/include/gmock/gmock-function-mocker.h:132:3: note: in expansion of macro ‘GMOCK_INTERNAL_MOCK_METHOD_IMPL’
132 | GMOCK_INTERNAL_MOCK_METHOD_IMPL( \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../subprojects/googletest/googlemock/include/gmock/internal/gmock-pp.h:152:39: note: in expansion of macro ‘GMOCK_INTERNAL_MOCK_METHOD_ARG_4’
152 | #define GMOCK_PP_INTERNAL_CAT(_1, _2) _1##_2
| ^~
../subprojects/googletest/googlemock/include/gmock/gmock-function-mocker.h:114:3: note: in expansion of macro ‘GMOCK_PP_VARIADIC_CALL’
114 | GMOCK_PP_VARIADIC_CALL(GMOCK_INTERNAL_MOCK_METHOD_ARG_, __VA_ARGS__) \
| ^~~~~~~~~~~~~~~~~~~~~~
../host-bmc/test/dbus_to_host_effecter_test.cpp:28:5: note: in expansion of macro ‘MOCK_METHOD’
28 | MOCK_METHOD(void, createHostEffecterMatch,
| ^~~~~~~~~~~
../host-bmc/dbus_to_host_effecters.hpp:145:9: error: ‘virtual int pldm::host_effecters::HostEffecterParser::setHostStateEffecter(size_t, std::vector<state_field_for_state_effecter_set>&, uint16_t)’ was hidden [-Werror=overloaded-virtual=]
145 | setHostStateEffecter(size_t effecterInfoIndex,
| ^~~~~~~~~~~~~~~~~~~~
../host-bmc/test/dbus_to_host_effecter_test.cpp:24:23: note: by ‘testing::internal::Function<void(long unsigned int, std::vector<state_field_for_state_effecter_set>&, short unsigned int)>::Result MockHostEffecterParser::setHostStateEffecter(testing::internal::ElemFromList<0, long unsigned int, std::vector<state_field_for_state_effecter_set, std::allocator<state_field_for_state_effecter_set> >&, short unsigned int>::type, testing::internal::ElemFromList<1, long unsigned int, std::vector<state_field_for_state_effecter_set, std::allocator<state_field_for_state_effecter_set> >&, short unsigned int>::type, testing::internal::ElemFromList<2, long unsigned int, std::vector<state_field_for_state_effecter_set, std::allocator<state_field_for_state_effecter_set> >&, short unsigned int>::type) const’
24 | MOCK_METHOD(void, setHostStateEffecter,
| ^~~~~~~~~~~~~~~~~~~~
../subprojects/googletest/googlemock/include/gmock/internal/gmock-pp.h:17:31: note: in definition of macro ‘GMOCK_PP_IDENTITY’
17 | #define GMOCK_PP_IDENTITY(_1) _1
| ^~
../subprojects/googletest/googlemock/include/gmock/gmock-function-mocker.h:132:3: note: in expansion of macro ‘GMOCK_INTERNAL_MOCK_METHOD_IMPL’
132 | GMOCK_INTERNAL_MOCK_METHOD_IMPL( \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../subprojects/googletest/googlemock/include/gmock/internal/gmock-pp.h:152:39: note: in expansion of macro ‘GMOCK_INTERNAL_MOCK_METHOD_ARG_4’
152 | #define GMOCK_PP_INTERNAL_CAT(_1, _2) _1##_2
| ^~
../subprojects/googletest/googlemock/include/gmock/gmock-function-mocker.h:114:3: note: in expansion of macro ‘GMOCK_PP_VARIADIC_CALL’
114 | GMOCK_PP_VARIADIC_CALL(GMOCK_INTERNAL_MOCK_METHOD_ARG_, __VA_ARGS__) \
| ^~~~~~~~~~~~~~~~~~~~~~
../host-bmc/test/dbus_to_host_effecter_test.cpp:24:5: note: in expansion of macro ‘MOCK_METHOD’
24 | MOCK_METHOD(void, setHostStateEffecter,
| ^~~~~~~~~~~
```

The warning was triggered by g++ on Fedora 38:

```
$ ( . /etc/os-release && echo $PRETTY_NAME )
Fedora Linux 38 (Server Edition)
$ g++ --version
g++ (GCC) 13.0.1 20230401 (Red Hat 13.0.1-0)
Copyright (C) 2023 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
```

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I138e73d733f9c220e62534815b5a2d1ddcb85b8a

show more ...

PLDM: Implementing Phosphor-Logging/LG2 logging

This commit adds changes in PLDM for implementing
structured LG2 logging, thereby moving away from
std::cout/cerr practice of logging which are
output

PLDM: Implementing Phosphor-Logging/LG2 logging

This commit adds changes in PLDM for implementing
structured LG2 logging, thereby moving away from
std::cout/cerr practice of logging which are
output streams and not logging mechanism.

PLDM now can make use of lg2 features like accurate
CODE LINE Number and CODE_FUNCTION Name and better
detailing in json object values which can be used in
log tracking.

More detailed logging change:
https://gist.github.com/riyadixitagra/c251685c1ba84248181891f7bc282395

Tested:
Ran a power off, on, cycle, and reset-reload.

Change-Id: I0485035f15f278c3fd172f0581b053c1c37f3a5b
Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>

show more ...

Populate correct terminusId

Hardcoded terminus id 0 is used at multiple places in the current code.
Made changes to populate correct terminus id instead of hardcoded one.

Change-Id: I63cedcb38fb2d9

Populate correct terminusId

Hardcoded terminus id 0 is used at multiple places in the current code.
Made changes to populate correct terminus id instead of hardcoded one.

Change-Id: I63cedcb38fb2d993e2e4a2b45846c19531d55839
Signed-off-by: ArchanaKakani <archana.kakani@ibm.com>

show more ...

Handle Dbus query exception gracefully

For every Dbus query PLDM uses new_method_call defined in
Sdbusplus. Any error during dbus query it throws an exception.
Modifying code to handle the exception

Handle Dbus query exception gracefully

For every Dbus query PLDM uses new_method_call defined in
Sdbusplus. Any error during dbus query it throws an exception.
Modifying code to handle the exception thrown by new_method_call

Change-Id: Ie474e1d230773cb184127b71d333846090ad6c84
Signed-off-by: Archana Kakani <archana.kakani@ibm.com>

show more ...

libpldm: Correct reference to libpldm header files

When relying on header files from external libraries, #include<> should
be used instead of #include "" to avoid ambiguity.

Tested: Built pldm succ

libpldm: Correct reference to libpldm header files

When relying on header files from external libraries, #include<> should
be used instead of #include "" to avoid ambiguity.

Tested: Built pldm successfully after enabling ibm-oem

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ia1997de7e0f61564055bbd837f4e24c8f14e55a5

show more ...

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: I0d25f27a5e449578967915d9f570cc29246927d7
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Fix the Sensor Offset in the host_pdr_handler

The commit fixes the issue being faced by composite state
sensor for more than one element.

Prior to the fix the sensor offset was hardcoded to the las

Fix the Sensor Offset in the host_pdr_handler

The commit fixes the issue being faced by composite state
sensor for more than one element.

Prior to the fix the sensor offset was hardcoded to the last
sensor which works for the case when only one element is
there but for more than one element issue arises as always
the last sensor is updated.

The commit updates the sensor offset value iteratively.

RESOLVES : https://github.com/openbmc/pldm/issues/35

Change-Id: I94ce27af44266f3d10158e35d2b8caa366a8f3aa
Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>

show more ...