Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: Ia7dbb04ead7565d63437a5878fd8a543029d9a93
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

clang-tidy: Enable modernize-deprecated-headers check

Some headers from C library were deprecated in C++ and are no
longer welcome in C++ codebases. Some have no effect in C++ [1].

[1]: https://rel

clang-tidy: Enable modernize-deprecated-headers check

Some headers from C library were deprecated in C++ and are no
longer welcome in C++ codebases. Some have no effect in C++ [1].

[1]: https://releases.llvm.org/13.0.1/tools/clang/tools/extra/docs/clang-tidy/checks/modernize-deprecated-headers.html

Change-Id: Ia3b1df10175e2e661c8fffb82e357c9db81b2e9c
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Enable bugprone-too-small-loop-variable check

This check detects those for loops that have a loop variable
with a “too small” type which means this type can’t represent
all values which

clang-tidy: Enable bugprone-too-small-loop-variable check

This check detects those for loops that have a loop variable
with a “too small” type which means this type can’t represent
all values which are part of the iteration range.

Change-Id: I9052bfd819ab78970b929411a08d77796c353465
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

show more ...

Support numeric effecters in dbus-to-host-effecter

Adds support of the numeric effecter PDR (section `28.11 Numeric
Effecter PDR` DSP0248 V1.3.0) type in dbus-to-host-effecter handler.
This handler

Support numeric effecters in dbus-to-host-effecter

Adds support of the numeric effecter PDR (section `28.11 Numeric
Effecter PDR` DSP0248 V1.3.0) type in dbus-to-host-effecter handler.
This handler will be applied for all PLDM termini but not only host.
The setting for one numeric effecter of one device can be:
{
"mctp_eid": 20,
"effecter_info": {
"effecterPdrType": 9,
"effecterID": 2,
"entityType": 32903,
"entityInstance": 2,
"containerID": 2,
"compositeEffecterCount": 1,
"checkHostState": false
},
"effecters": [
{
"dbus_info": {
"object_path": "/xyz/openbmc_project/sensors/power/A",
"interface": "xyz.openbmc_project.Sensor.Value",
"property_name": "Value",
"property_type": "double"
},
"effecterDataSize": 5,
"resolution": 1,
"offset": 0,
"unitModifier": 0
}
]
}

Where:
+ effecterPdrType to difference state/numeric effecter type. Default
is state effecter.
+ effecterID should be effecter ID and should not empty.
+ checkHostState can be set to false to bypass checking host state.
+ effecterDataSize, resolution, offset, unitModifier are from numeric
effecter PDR (section `28.11 Numeric Effecter PDR` DSP0248 V1.3.0)

Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>
Change-Id: I438d7f204643edd4066e8a6ba28d53a97503fc4b

show more ...

Format meson files with meson.format

Meson 1.5.0 introduced a new feature to format all the meson
files. Formatting all the meson files is now as simple as running
`meson format -i -r` command in th

Format meson files with meson.format

Meson 1.5.0 introduced a new feature to format all the meson
files. Formatting all the meson files is now as simple as running
`meson format -i -r` command in the repository root folder.

more details : https://mesonbuild.com/Commands.html#format

Change-Id: I9c5468cc502ae78b7a055e2de2a10296930cb9ec
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I8c84201cb2343a8c8a5507a49de0721a1bee7063
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

pldm: Move off pldm_entity_association_pdr_add_from_node_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_ent

pldm: Move off pldm_entity_association_pdr_add_from_node_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_entity_association_pdr_add_from_node_check.yaml
```

Change-Id: I1d68f53f8b76c48f564c110a1d2a7ec8d42e7483
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Move off pldm_pdr_add_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_pdr_add_check.yaml
```

Change-I

pldm: Move off pldm_pdr_add_check()

Generated with:

```
$ CLANG_VERSION=18 ./subprojects/libpldm/scripts/apply-renames ./subprojects/libpldm/evolutions/current/pldm_pdr_add_check.yaml
```

Change-Id: I4982195e97c25567b35f77ee7dcf795629d259b4
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

pldm: Drop pessimizing moves

Fixes issues such as:

```
../host-bmc/host_pdr_handler.cpp:684:9: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
684 | st

pldm: Drop pessimizing moves

Fixes issues such as:

```
../host-bmc/host_pdr_handler.cpp:684:9: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
684 | std::move(std::vector<uint8_t>(1, PLDM_PDR_ENTITY_ASSOCIATION)),
| ^
../host-bmc/host_pdr_handler.cpp:684:9: note: remove std::move call here
684 | std::move(std::vector<uint8_t>(1, PLDM_PDR_ENTITY_ASSOCIATION)),
| ^~~~~~~~~~ ~
```

Change-Id: Id26f0d6fc21837e1eb76ae3c294c222782a4e69f
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

host-bmc: host_pdr_handler: Remove unused fields

```
../host-bmc/host_pdr_handler.hpp:277:9: error: private field 'mctp_fd' is not used [-Werror,-Wunused-private-field]
277 | int mctp_fd;

host-bmc: host_pdr_handler: Remove unused fields

```
../host-bmc/host_pdr_handler.hpp:277:9: error: private field 'mctp_fd' is not used [-Werror,-Wunused-private-field]
277 | int mctp_fd;
| ^
../host-bmc/host_pdr_handler.hpp:292:35: error: private field 'bmcEntityTree' is not used [-Werror,-Wunused-private-field]
292 | pldm_entity_association_tree* bmcEntityTree;
| ^
```

Change-Id: I62a948dff51b184bf44f1053b48d3b512e3e2b72
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

host-bmc: dbus_to_event_handler: Remove unused mctp_fd

```
../host-bmc/dbus_to_event_handler.hpp:89:9: error: private field 'mctp_fd' is not used [-Werror,-Wunused-private-field]
89 | int mct

host-bmc: dbus_to_event_handler: Remove unused mctp_fd

```
../host-bmc/dbus_to_event_handler.hpp:89:9: error: private field 'mctp_fd' is not used [-Werror,-Wunused-private-field]
89 | int mctp_fd;
| ^
```

Change-Id: Ia17471784594bf0abfc7ec5fca4c37aff274ecd0
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

host-bmc: cpu_core: Delete move methods

```
In file included from ../host-bmc/host_pdr_handler.cpp:7:
In file included from ../host-bmc/dbus/custom_dbus.hpp:5:
../host-bmc/dbus/cpu_core.hpp:24:5: er

host-bmc: cpu_core: Delete move methods

```
In file included from ../host-bmc/host_pdr_handler.cpp:7:
In file included from ../host-bmc/dbus/custom_dbus.hpp:5:
../host-bmc/dbus/cpu_core.hpp:24:5: error: explicitly defaulted move constructor is implicitly deleted [-Werror,-Wdefaulted-function-deleted]
24 | CPUCore(CPUCore&&) = default;
| ^
../host-bmc/dbus/cpu_core.hpp:17:17: note: move constructor of 'CPUCore' is implicitly deleted because base class 'CoreIntf' (aka 'object<sdbusplus::server::xyz::openbmc_project::inventory::item::CpuCore>') has a deleted move constructor
17 | class CPUCore : public CoreIntf
| ^
../subprojects/sdbusplus/include/sdbusplus/server/object.hpp:54:5: note: 'object' has been explicitly marked deleted here
54 | object(object&&) = delete;
| ^
../host-bmc/dbus/cpu_core.hpp:24:26: note: replace 'default' with 'delete'
24 | CPUCore(CPUCore&&) = default;
| ^~~~~~~
| delete
../host-bmc/dbus/cpu_core.hpp:25:14: error: explicitly defaulted move assignment operator is implicitly deleted [-Werror,-Wdefaulted-function-deleted]
25 | CPUCore& operator=(CPUCore&&) = default;
| ^
../host-bmc/dbus/cpu_core.hpp:17:17: note: move assignment operator of 'CPUCore' is implicitly deleted because base class 'CoreIntf' (aka 'object<sdbusplus::server::xyz::openbmc_project::inventory::item::CpuCore>') has a deleted move assignment operator
17 | class CPUCore : public CoreIntf
| ^
../subprojects/sdbusplus/include/sdbusplus/server/object.hpp:55:13: note: 'operator=' has been explicitly marked deleted here
55 | object& operator=(object&&) = delete;
| ^
../host-bmc/dbus/cpu_core.hpp:25:37: note: replace 'default' with 'delete'
25 | CPUCore& operator=(CPUCore&&) = default;
| ^~~~~~~
| delete
```

Change-Id: I190cf07cce199945df1b527b355c41091860a95a
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

host-bmc: motherboard: Delete move methods

```
In file included from ../host-bmc/host_pdr_handler.cpp:7:
In file included from ../host-bmc/dbus/custom_dbus.hpp:6:
../host-bmc/dbus/motherboard.hpp:29

host-bmc: motherboard: Delete move methods

```
In file included from ../host-bmc/host_pdr_handler.cpp:7:
In file included from ../host-bmc/dbus/custom_dbus.hpp:6:
../host-bmc/dbus/motherboard.hpp:29:5: error: explicitly defaulted move constructor is implicitly deleted [-Werror,-Wdefaulted-function-deleted]
29 | Motherboard(Motherboard&&) = default;
| ^
../host-bmc/dbus/motherboard.hpp:22:21: note: move constructor of 'Motherboard' is implicitly deleted because base class 'ItemMotherboard' (aka 'object<sdbusplus::server::xyz::openbmc_project::inventory::item::board::Motherboard>') has a deleted move constructor
22 | class Motherboard : public ItemMotherboard
| ^
../subprojects/sdbusplus/include/sdbusplus/server/object.hpp:54:5: note: 'object' has been explicitly marked deleted here
54 | object(object&&) = delete;
| ^
../host-bmc/dbus/motherboard.hpp:29:34: note: replace 'default' with 'delete'
29 | Motherboard(Motherboard&&) = default;
| ^~~~~~~
| delete
../host-bmc/dbus/motherboard.hpp:30:18: error: explicitly defaulted move assignment operator is implicitly deleted [-Werror,-Wdefaulted-function-deleted]
30 | Motherboard& operator=(Motherboard&&) = default;
| ^
../host-bmc/dbus/motherboard.hpp:22:21: note: move assignment operator of 'Motherboard' is implicitly deleted because base class 'ItemMotherboard' (aka 'object<sdbusplus::server::xyz::openbmc_project::inventory::item::board::Motherboard>') has a deleted move assignment operator
22 | class Motherboard : public ItemMotherboard
| ^
../subprojects/sdbusplus/include/sdbusplus/server/object.hpp:55:13: note: 'operator=' has been explicitly marked deleted here
55 | object& operator=(object&&) = delete;
| ^
../host-bmc/dbus/motherboard.hpp:30:45: note: replace 'default' with 'delete'
30 | Motherboard& operator=(Motherboard&&) = default;
| ^~~~~~~
| delete
```

Change-Id: If739f3d044c559f56dab143d5c53800a9d6f5082
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

host-bmc: host_pdr_handler: Drop unused fruJson

```
../host-bmc/host_pdr_handler.cpp:33:16: error: unused variable 'fruJson' [-Werror,-Wunused-const-variable]
33 | constexpr auto fruJson = "host_

host-bmc: host_pdr_handler: Drop unused fruJson

```
../host-bmc/host_pdr_handler.cpp:33:16: error: unused variable 'fruJson' [-Werror,-Wunused-const-variable]
33 | constexpr auto fruJson = "host_frus.json";
| ^~~~~~~
```

Change-Id: Ia04cb6beba4465fa0fa872b84c5b58f05c90ca36
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

host-bmc: host_pdr_handler: Drop unused emptyJsonList

```
../host-bmc/host_pdr_handler.cpp:35:25: error: unused variable 'emptyJsonList' [-Werror,-Wunused-const-variable]
35 | const std::vector<J

host-bmc: host_pdr_handler: Drop unused emptyJsonList

```
../host-bmc/host_pdr_handler.cpp:35:25: error: unused variable 'emptyJsonList' [-Werror,-Wunused-const-variable]
35 | const std::vector<Json> emptyJsonList{};
| ^~~~~~~~~~~~~
```

Change-Id: I25d48daea746ab61caa5c582225ef5ae7ae1c4a3
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

Adding exception handling while hosting Dbus path

This commit add support to check if Dbus interface are hosted by other
application or not. If Dbus interface hosted by other app then PLDM
will skip

Adding exception handling while hosting Dbus path

This commit add support to check if Dbus interface are hosted by other
application or not. If Dbus interface hosted by other app then PLDM
will skip the hosting and take existing path.

Tested:
Tested motherboard interface which is hosted by other app:
` DICT_ENTRY "sas" {
STRING "xyz.openbmc_project.Inventory.Manager";
ARRAY "s" {
STRING "xyz.openbmc_project.Inventory.Item";
STRING "xyz.openbmc_project.Inventory.Item.Board.Motherboard";
};
};

DICT_ENTRY "sas" {
STRING "xyz.openbmc_project.PLDM";
ARRAY "s" {
STRING "org.freedesktop.DBus.Introspectable";
STRING "org.freedesktop.DBus.Peer";
STRING "org.freedesktop.DBus.Properties";
};
};
};
};
`

Change-Id: Ia0bacf38bf1dc796e649de39169cab5d3526e913
Signed-off-by: Kamalkumar Patel <kamalkumar.patel@ibm.com>

show more ...

Implementing Motherboard interface

This commit adds support to host motherboard interface which can be
used to generate Dbus Object paths. The Dbus object paths will be
represents the hardware compo

Implementing Motherboard interface

This commit adds support to host motherboard interface which can be
used to generate Dbus Object paths. The Dbus object paths will be
represents the hardware components within the system architecture and
help to understand the architecture better way. The motherboard will
represent the system board and other entity are connected to it.
The interface is implemented at:[1]

[1] https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/yaml/xyz/openbmc_project/Inventory/Item/Board/Motherboard.interface.yaml

Change-Id: Ie7987ea0fb03d2d6ffd9e485924cfea7446d97d9
Signed-off-by: Kamalkumar Patel <kamalkumar.patel@ibm.com>

show more ...

Add support for the coreCount property in DBus

This commit introduces support for counting the number of CPU cores
during BMC power-on and populates this information to a DBus property
named coreCou

Add support for the coreCount property in DBus

This commit introduces support for counting the number of CPU cores
during BMC power-on and populates this information to a DBus property
named coreCount. Upon BMC power-on, the remote terminus detects the
number of CPU cores and send this data and PLDM will updates the
coreCount property accordingly.

Tested:
tested on simulator for hosting DBus property

Change-Id: I37adbe399414fcff3f089fb819349ca4bb537edd
Signed-off-by: Kamalkumar Patel <kamalkumar.patel@ibm.com>

show more ...

host-bmc: Logging PEL for PDR Exchange Failure

This commit logs PEL when BMC fails to collect PDR from remote endpoint.
GetPDR returns no response because of BMC PDR exchange failure after
three tri

host-bmc: Logging PEL for PDR Exchange Failure

This commit logs PEL when BMC fails to collect PDR from remote endpoint.
GetPDR returns no response because of BMC PDR exchange failure after
three tries get exhausted and timeout occurs.

Tested: Verified that the new PEL is reported when the pdr response
pointer is null

Change-Id: I862693a7e0fe2405af625010f2862d25af1f11e2
Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>

show more ...

skip asking for PDR's from remote endpoint

The PDR exchange is always triggered from the remote end point. Hence
BMC should never ask for GetPDR by itself.

Change-Id: Ibc90cdd5118ad1bc7665bc681b0aa

skip asking for PDR's from remote endpoint

The PDR exchange is always triggered from the remote end point. Hence
BMC should never ask for GetPDR by itself.

Change-Id: Ibc90cdd5118ad1bc7665bc681b0aa89994a5e400
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

pldm: Implement Cable interface

Adding support to host Cable dbus interface.
Based on the PDRs received from remote PLDM terminus,
PLDM hosts the dbus interface based on the entity type.
The Cable i

pldm: Implement Cable interface

Adding support to host Cable dbus interface.
Based on the PDRs received from remote PLDM terminus,
PLDM hosts the dbus interface based on the entity type.
The Cable interface is defined at [1].

[1]: https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/yaml/xyz/openbmc_project/Inventory/Item/Cable.interface.yaml

Change-Id: I23f02387c1d50ce8d9c5921760740760cea2cd47
Signed-off-by: Archana Kakani <archana.kakani@ibm.com>

show more ...

pldm: Implement PCIeDevice interface

Adding support to host PCIeDevice dbus interface.
Based on the PDRs received from remote PLDM terminus,
PLDM hosts the dbus interface based on the entity type.
T

pldm: Implement PCIeDevice interface

Adding support to host PCIeDevice dbus interface.
Based on the PDRs received from remote PLDM terminus,
PLDM hosts the dbus interface based on the entity type.
The PCIe Device interface is defined at [1].

Tested:
Functional test passed

[1]: https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/yaml/xyz/openbmc_project/Inventory/Item/PCIeDevice.interface.yaml

Change-Id: I69472efef33c3ad030ba4c831f07f60833b2c40b
Signed-off-by: Archana Kakani <archana.kakani@ibm.com>

show more ...

pldm: Implement PCIeSlot interface

Adding support to host dbus PCIeSlot interface.
Based on the PDRs received from remote PLDM terminus,
PLDM hosts the dbus interface based on the entity type.
The S

pldm: Implement PCIeSlot interface

Adding support to host dbus PCIeSlot interface.
Based on the PDRs received from remote PLDM terminus,
PLDM hosts the dbus interface based on the entity type.
The Slot interface is defined at [1].

Tested:
Functional test passed.

[1]: https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/yaml/xyz/openbmc_project/Inventory/Item/PCIeSlot.interface.yaml

Change-Id: I98db6c31ddcb35e5c124d060c4ee0ab0f8819e72
Signed-off-by: Archana Kakani <archana.kakani@ibm.com>

show more ...

Adding CPUCore interface support

This commit introduces essential D-Bus infrastructure support for
hosting the `Item.CPUCore` D-Bus object. Additionally, it includes
getter and setter functions to e

Adding CPUCore interface support

This commit introduces essential D-Bus infrastructure support for
hosting the `Item.CPUCore` D-Bus object. Additionally, it includes
getter and setter functions to enable get/set properties within the
`CPUCore` interface, such as core count and microcode.

Testing:
Unit test passed

Change-Id: I728522b34e96ee7d6609efb5746b40cf923812e8
Signed-off-by: Kamalkumar Patel <kamalkumar.patel@ibm.com>

show more ...

pldm: Use system include directives for libpldm headers

libpldm is now an external dependency rather than an in-tree library.
Adjust the includes accordingly.

Change-Id: I97218ec9cf7ffb7afa98e78c01

pldm: Use system include directives for libpldm headers

libpldm is now an external dependency rather than an in-tree library.
Adjust the includes accordingly.

Change-Id: I97218ec9cf7ffb7afa98e78c01dc9d030271c3f4
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...