pldm: Implement PCIeSlot interface

Adding support to host dbus PCIeSlot interface.
Based on the PDRs received from remote PLDM terminus,
PLDM hosts the dbus interface based on the entity type.
The S

pldm: Implement PCIeSlot interface

Adding support to host dbus PCIeSlot interface.
Based on the PDRs received from remote PLDM terminus,
PLDM hosts the dbus interface based on the entity type.
The Slot interface is defined at [1].

Tested:
Functional test passed.

[1]: https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/yaml/xyz/openbmc_project/Inventory/Item/PCIeSlot.interface.yaml

Change-Id: I98db6c31ddcb35e5c124d060c4ee0ab0f8819e72
Signed-off-by: Archana Kakani <archana.kakani@ibm.com>

show more ...

Adding CPUCore interface support

This commit introduces essential D-Bus infrastructure support for
hosting the `Item.CPUCore` D-Bus object. Additionally, it includes
getter and setter functions to e

Adding CPUCore interface support

This commit introduces essential D-Bus infrastructure support for
hosting the `Item.CPUCore` D-Bus object. Additionally, it includes
getter and setter functions to enable get/set properties within the
`CPUCore` interface, such as core count and microcode.

Testing:
Unit test passed

Change-Id: I728522b34e96ee7d6609efb5746b40cf923812e8
Signed-off-by: Kamalkumar Patel <kamalkumar.patel@ibm.com>

show more ...

host-bmc: migrate dbus hosting logic into dbus folder

This commit aims at migrating the custom_dbus files from the host_bmc
directory to the host-bmc/dbus directory. This makes the code cleaner
sinc

host-bmc: migrate dbus hosting logic into dbus folder

This commit aims at migrating the custom_dbus files from the host_bmc
directory to the host-bmc/dbus directory. This makes the code cleaner
since it abstracts all the dbus objects hosting code to the dbus folder

Change-Id: Ia310e8a16f9489060ef228496d364c602a4fa6a8
Signed-off-by: Kamalkumar Patel <kamalkumar.patel@ibm.com>

show more ...

pldm: Rearranging datatype declaration

This commit adds support to eliminating duplication of datatypes which
enhancing clarity and manageability throughout the pldm repository.
This is rearrangemen

pldm: Rearranging datatype declaration

This commit adds support to eliminating duplication of datatypes which
enhancing clarity and manageability throughout the pldm repository.
This is rearrangement of declaration of data types so it can be used
host-bmc and oem layer both the places.

Change-Id: Ieb1232884b8e2128e8bf97dafd01e4ad5524ede0
Signed-off-by: Kamalkumar Patel <kamalkumar.patel@ibm.com>

show more ...

oem-ibm: Adding entity path correction function

This commit introduces enhancements to rectify entity paths over DBus.
Formerly, the conventional DBus path involved appending an instance
number, suc

oem-ibm: Adding entity path correction function

This commit introduces enhancements to rectify entity paths over DBus.
Formerly, the conventional DBus path involved appending an instance
number, such as 'system' becoming 'system1', 'motherboard' becoming
'motherboard1', and 'chassis' becoming 'chassis1'. This function is
designed to align with IBM's specific use case, ensuring the numbering
system adheres appropriately.

Testing:
Unit tests passed

Change-Id: I671f8486078054b44110ffa2cbf169c63d164cf1
Signed-off-by: Kamalkumar Patel <kamalkumar.patel@ibm.com>

show more ...

Add Json Config support for entity to DBus string

The entity map comprises both entity types and their corresponding
names, essential for generating unique D-Bus paths for each entity.
However, chal

Add Json Config support for entity to DBus string

The entity map comprises both entity types and their corresponding
names, essential for generating unique D-Bus paths for each entity.
However, challenges arise due to variations in path generation across
companies, often dictated by differing entity types. To address this,
enabling configurability of EntityID becomes imperative, empowering
communities to tailor configurations to their specific use cases.

Testing:
Unit tests passed

Change-Id: I3981fde64bd00940caa5067a9472fd948e74cbf0
Signed-off-by: Kamalkumar Patel <kamalkumar.patel@ibm.com>

show more ...

host-bmc: refine remote terminus functionality

This commit introduces support for migrating remote terminus-related
functionalities into the host-bmc directory, a move aimed at optimizing
remote ter

host-bmc: refine remote terminus functionality

This commit introduces support for migrating remote terminus-related
functionalities into the host-bmc directory, a move aimed at optimizing
remote terminus operations for future endeavors. By consolidating these
functionalities, tracking and implementing future enhancements become
more streamlined and manageable.

Change-Id: I52b6ced7acacb004b6055ae710193a959d986659
Signed-off-by: Kamalkumar Patel <kamalkumar.patel@ibm.com>

show more ...

Deprecate the support for x86 sdk

OpenBMC as a project has moved away from using yocto x86 sdks for unit
testing. Instead now the preferred way to build and test code is by two
ways:

1. Leveraging

Deprecate the support for x86 sdk

OpenBMC as a project has moved away from using yocto x86 sdks for unit
testing. Instead now the preferred way to build and test code is by two
ways:

1. Leveraging the meson subproject support
2. Using openbmc docker container

Since x86 sdks needed some weird hacks in the code base like figuring
out the linker arguments ourselves & running custom bash commands from
the meson build files. Also with changing yocto code base, its a large
maintainer burden to make sure this support works.

Tested:
Code builds & unit tests are passed with both the approaches mentioned
above.

Change-Id: Iaf55e2c003ffd9ee1a295de5bdfd14d81222e94b
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Remove iostream references

With the adoption of LG2 we do not need iostream
prints to the journal. The library was referred but
never used in these cases.

Signed-off-by: Sagar Srinivas <sagar.srini

Remove iostream references

With the adoption of LG2 we do not need iostream
prints to the journal. The library was referred but
never used in these cases.

Signed-off-by: Sagar Srinivas <sagar.srinivas@ibm.com>
Change-Id: I11d3f00284e4f16b63cddb8da2fed14d59672ba1

show more ...

pldm: Use system include directives for libpldm

libpldm is no-longer a subproject, so let's stop treating it like it is
one by default.

Fixed with:

```
$ sed -Ei 's/#include "libpldm\/([^"]+).h"/#

pldm: Use system include directives for libpldm

libpldm is no-longer a subproject, so let's stop treating it like it is
one by default.

Fixed with:

```
$ sed -Ei 's/#include "libpldm\/([^"]+).h"/#include <libpldm\/\1.h>/' $(git grep -lF '"libpldm/')
```

Change-Id: I9be54661dcee1bdf2575aece8ff250424b4b7b56
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

meson: adjust nlohmann-json dependency

Simplify the meson dependency for nlohmann-json, use the consistent
dependency name, and align the wrap file name with other repositories.

Signed-off-by: Patr

meson: adjust nlohmann-json dependency

Simplify the meson dependency for nlohmann-json, use the consistent
dependency name, and align the wrap file name with other repositories.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I3a682a3e07e38d0a1bfe35858e24f1bb74b4ec34

show more ...

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer retur

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and auto.

Switch all uses of `enabled` to `allowed`.

Change-Id: I794c658531483266bfce6f9b28127a166ed01490
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Handle FRU records from host

- Get FRU record table from host and traverse the entity structure
from the FRU record set PDR, and create D-Bus object.

- When the FRU field type is a PLDM_OEM_FRU_F

Handle FRU records from host

- Get FRU record table from host and traverse the entity structure
from the FRU record set PDR, and create D-Bus object.

- When the FRU field type is a PLDM_OEM_FRU_FIELD_TYPE_LOCATION_CODE
, the location code is used to populate the
xyz.openbmc_project.Inventory.Decorator.LocationCode D-Bus
interface for the corresponding FRU.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I482c4d371f76b4881109ef420dfd9543e1aa810b

show more ...

Update pldm_entity_association_tree_add method

Update to the signature changes for
pldm_entity_association_tree_add method to
pldm_entity_association_tree_add_entity and add necessary
arguments for

Update pldm_entity_association_tree_add method

Update to the signature changes for
pldm_entity_association_tree_add method to
pldm_entity_association_tree_add_entity and add necessary
arguments for the same as per the libpldm changes done for
the method.

Reference: https://gerrit.openbmc.org/c/openbmc/libpldm/+/65484

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Iaf233da29d4250c9139d2dd7e630fe796a62719c

show more ...

Handle entity association records from host

- Get the PDRs from host, traverse the entity association structure
and construct the D-Bus object path according to the entity type ID
and container

Handle entity association records from host

- Get the PDRs from host, traverse the entity association structure
and construct the D-Bus object path according to the entity type ID
and container type ID.

- eg:
/xyz/openbmc_project/inventory/system1/chassis1/io_board1/powersupply1
/xyz/openbmc_project/inventory/system1/chassis1/io_board1/powersupply2
/xyz/openbmc_project/inventory/system1/chassis2/io_board2/powersupply1
/xyz/openbmc_project/inventory/system1/chassis2/io_board2/powersupply2

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I1c606ea943624f2601be4f5f6b5c30d1bf71cd11

show more ...

clang-error: fix clang-diagnostic-overloaded-virtual error

The error clang-diagnostic-overloaded-virtual is generated
when a function hides the overloaded virtual function.

Change-Id: I87fdabb4ea9

clang-error: fix clang-diagnostic-overloaded-virtual error

The error clang-diagnostic-overloaded-virtual is generated
when a function hides the overloaded virtual function.

Change-Id: I87fdabb4ea9efd0c69d1b030127a6a9782cd3b23
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

show more ...

pldmd: Migrate instance ID allocation to pldm::InstanceIdDb

This removes use of `pldm::dbus_api::Requester` from around the
code-base. This makes progress towards removing the DBus API entirely
once

pldmd: Migrate instance ID allocation to pldm::InstanceIdDb

This removes use of `pldm::dbus_api::Requester` from around the
code-base. This makes progress towards removing the DBus API entirely
once all its consumers are converted to the libpldm instance ID APIs.

There was never a good reason for the code using the class to have
knowledge that it was related to DBus anyway, so this is, in-effect, a
double clean up improving separation of concerns.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I2d9397cae1b3c8c251c32e36ca520aad9c9b8cf6

show more ...

pldmd: move to libpldm instance ID alloc/free

Refactor the dbus_api::Requester class to be implemented in terms of
libpldm's instance ID database. To make that easier to deal with we
introduce a lig

pldmd: move to libpldm instance ID alloc/free

Refactor the dbus_api::Requester class to be implemented in terms of
libpldm's instance ID database. To make that easier to deal with we
introduce a light-weight RAII C++ binding along with a helper class for
unit tests.

Change-Id: Ia03de8245dfb114e6266ba36dcf26ca4398a4ce0
Signed-off-by: Rashmica Gupta <rashmica@linux.ibm.com>
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

host-bmc: test: Avoid -Werror=overloaded-virtual

Drop the const qualifier for the createHostEffecterMatch() mock to
resolve the following error:

```
In file included from ../host-bmc/test/dbus_to_h

host-bmc: test: Avoid -Werror=overloaded-virtual

Drop the const qualifier for the createHostEffecterMatch() mock to
resolve the following error:

```
In file included from ../host-bmc/test/dbus_to_host_effecter_test.cpp:3:
../host-bmc/dbus_to_host_effecters.hpp:169:18: error: ‘virtual void pldm::host_effecters::HostEffecterParser::createHostEffecterMatch(const std::string&, const std::string&, size_t, size_t, uint16_t)’ was hidden [-Werror=overloaded-virtual=]
169 | virtual void createHostEffecterMatch(const std::string& objectPath,
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from ../subprojects/googletest/googlemock/include/gmock/gmock-actions.h:147,
from ../subprojects/googletest/googlemock/include/gmock/gmock.h:56,
from ../common/test/mocked_utils.hpp:3,
from ../host-bmc/test/dbus_to_host_effecter_test.cpp:1:
../host-bmc/test/dbus_to_host_effecter_test.cpp:28:23: note: by ‘testing::internal::Function<void(const std::__cxx11::basic_string<char>&, const std::__cxx11::basic_string<char>&, long unsigned int, long unsigned int, short unsigned int)>::Result MockHostEffecterParser::createHostEffecterMatch(testing::internal::ElemFromList<0, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, long unsigned int, long unsigned int, short unsigned int>::type, testing::internal::ElemFromList<1, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, long unsigned int, long unsigned int, short unsigned int>::type, testing::internal::ElemFromList<2, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, long unsigned int, long unsigned int, short unsigned int>::type, testing::internal::ElemFromList<3, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, long unsigned int, long unsigned int, short unsigned int>::type, testing::internal::ElemFromList<4, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, long unsigned int, long unsigned int, short unsigned int>::type) const’
28 | MOCK_METHOD(void, createHostEffecterMatch,
| ^~~~~~~~~~~~~~~~~~~~~~~
../subprojects/googletest/googlemock/include/gmock/internal/gmock-pp.h:17:31: note: in definition of macro ‘GMOCK_PP_IDENTITY’
17 | #define GMOCK_PP_IDENTITY(_1) _1
| ^~
../subprojects/googletest/googlemock/include/gmock/gmock-function-mocker.h:132:3: note: in expansion of macro ‘GMOCK_INTERNAL_MOCK_METHOD_IMPL’
132 | GMOCK_INTERNAL_MOCK_METHOD_IMPL( \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../subprojects/googletest/googlemock/include/gmock/internal/gmock-pp.h:152:39: note: in expansion of macro ‘GMOCK_INTERNAL_MOCK_METHOD_ARG_4’
152 | #define GMOCK_PP_INTERNAL_CAT(_1, _2) _1##_2
| ^~
../subprojects/googletest/googlemock/include/gmock/gmock-function-mocker.h:114:3: note: in expansion of macro ‘GMOCK_PP_VARIADIC_CALL’
114 | GMOCK_PP_VARIADIC_CALL(GMOCK_INTERNAL_MOCK_METHOD_ARG_, __VA_ARGS__) \
| ^~~~~~~~~~~~~~~~~~~~~~
../host-bmc/test/dbus_to_host_effecter_test.cpp:28:5: note: in expansion of macro ‘MOCK_METHOD’
28 | MOCK_METHOD(void, createHostEffecterMatch,
| ^~~~~~~~~~~
../host-bmc/dbus_to_host_effecters.hpp:145:9: error: ‘virtual int pldm::host_effecters::HostEffecterParser::setHostStateEffecter(size_t, std::vector<state_field_for_state_effecter_set>&, uint16_t)’ was hidden [-Werror=overloaded-virtual=]
145 | setHostStateEffecter(size_t effecterInfoIndex,
| ^~~~~~~~~~~~~~~~~~~~
../host-bmc/test/dbus_to_host_effecter_test.cpp:24:23: note: by ‘testing::internal::Function<void(long unsigned int, std::vector<state_field_for_state_effecter_set>&, short unsigned int)>::Result MockHostEffecterParser::setHostStateEffecter(testing::internal::ElemFromList<0, long unsigned int, std::vector<state_field_for_state_effecter_set, std::allocator<state_field_for_state_effecter_set> >&, short unsigned int>::type, testing::internal::ElemFromList<1, long unsigned int, std::vector<state_field_for_state_effecter_set, std::allocator<state_field_for_state_effecter_set> >&, short unsigned int>::type, testing::internal::ElemFromList<2, long unsigned int, std::vector<state_field_for_state_effecter_set, std::allocator<state_field_for_state_effecter_set> >&, short unsigned int>::type) const’
24 | MOCK_METHOD(void, setHostStateEffecter,
| ^~~~~~~~~~~~~~~~~~~~
../subprojects/googletest/googlemock/include/gmock/internal/gmock-pp.h:17:31: note: in definition of macro ‘GMOCK_PP_IDENTITY’
17 | #define GMOCK_PP_IDENTITY(_1) _1
| ^~
../subprojects/googletest/googlemock/include/gmock/gmock-function-mocker.h:132:3: note: in expansion of macro ‘GMOCK_INTERNAL_MOCK_METHOD_IMPL’
132 | GMOCK_INTERNAL_MOCK_METHOD_IMPL( \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../subprojects/googletest/googlemock/include/gmock/internal/gmock-pp.h:152:39: note: in expansion of macro ‘GMOCK_INTERNAL_MOCK_METHOD_ARG_4’
152 | #define GMOCK_PP_INTERNAL_CAT(_1, _2) _1##_2
| ^~
../subprojects/googletest/googlemock/include/gmock/gmock-function-mocker.h:114:3: note: in expansion of macro ‘GMOCK_PP_VARIADIC_CALL’
114 | GMOCK_PP_VARIADIC_CALL(GMOCK_INTERNAL_MOCK_METHOD_ARG_, __VA_ARGS__) \
| ^~~~~~~~~~~~~~~~~~~~~~
../host-bmc/test/dbus_to_host_effecter_test.cpp:24:5: note: in expansion of macro ‘MOCK_METHOD’
24 | MOCK_METHOD(void, setHostStateEffecter,
| ^~~~~~~~~~~
```

The warning was triggered by g++ on Fedora 38:

```
$ ( . /etc/os-release && echo $PRETTY_NAME )
Fedora Linux 38 (Server Edition)
$ g++ --version
g++ (GCC) 13.0.1 20230401 (Red Hat 13.0.1-0)
Copyright (C) 2023 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
```

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I138e73d733f9c220e62534815b5a2d1ddcb85b8a

show more ...

PLDM: Implementing Phosphor-Logging/LG2 logging

This commit adds changes in PLDM for implementing
structured LG2 logging, thereby moving away from
std::cout/cerr practice of logging which are
output

PLDM: Implementing Phosphor-Logging/LG2 logging

This commit adds changes in PLDM for implementing
structured LG2 logging, thereby moving away from
std::cout/cerr practice of logging which are
output streams and not logging mechanism.

PLDM now can make use of lg2 features like accurate
CODE LINE Number and CODE_FUNCTION Name and better
detailing in json object values which can be used in
log tracking.

More detailed logging change:
https://gist.github.com/riyadixitagra/c251685c1ba84248181891f7bc282395

Tested:
Ran a power off, on, cycle, and reset-reload.

Change-Id: I0485035f15f278c3fd172f0581b053c1c37f3a5b
Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>

show more ...

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: I0d25f27a5e449578967915d9f570cc29246927d7
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: add missing nlohmann dependencies to tests

Without it there are build failures because the include search path is
wrong in subproject mode.

Change-Id: I49ee9aab900a41ae91dccc43eccc68321f9d97

meson: add missing nlohmann dependencies to tests

Without it there are build failures because the include search path is
wrong in subproject mode.

Change-Id: I49ee9aab900a41ae91dccc43eccc68321f9d973a
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

implement async handlers for all requester commands

this commit makes use of 74f27c730ef3925a0f2a3adfaa04f8790f931372 to
convert the existing blocking requester commands in pldm to async
ones.
this

implement async handlers for all requester commands

this commit makes use of 74f27c730ef3925a0f2a3adfaa04f8790f931372 to
convert the existing blocking requester commands in pldm to async
ones.
this is tested with Host code and seems to work fine

Change-Id: I8d4762c3cd5bce49f854b30f8325bfcd1dcb4ff9
Signed-off-by: Sampa Misra <sampmisr@in.ibm.com>

show more ...

tests: Organize the test code to make it modular

The unit test code for libpldmresponder, host-bmc and common is
in a shared test directory. This patch separates the test code
to the respective dire

tests: Organize the test code to make it modular

The unit test code for libpldmresponder, host-bmc and common is
in a shared test directory. This patch separates the test code
to the respective directory.

Tested: Ran the unit test and tests passed.

Signed-off-by: Tom Joseph <rushtotom@gmail.com>
Change-Id: I31d53681fa6c0d8bc6eb7c4e3341aaff4bc341ee

show more ...