pldm: Document BIOS support

The BIOS attributes supported by OpenBMC systems are added in JSON
files, adhering to the specifications outlined in the PLDM BIOS
Specification [1]. Since a single BIOS

pldm: Document BIOS support

The BIOS attributes supported by OpenBMC systems are added in JSON
files, adhering to the specifications outlined in the PLDM BIOS
Specification [1]. Since a single BIOS attribute may have different
values for different variants of systems, creating different json files
for each of the system type supported. To enable this optional feature
within PLDM, creating meson option system-specific-bios-json.

System specific bios attributes support in PLDM is added in below
commits [2], [3], [4]

[1]: https://www.dmtf.org/sites/default/files/standards/documents/DSP0247_1.0.0.pdf
[2]: https://github.com/openbmc/pldm/tree/963c0fdf1aef305f266e00b2321fc244f89d0fa7
[3]: https://github.com/openbmc/pldm/tree/62dd8ff2f106c0eb80e8c1e79adfa99e093d1cf6
[4]: https://github.com/openbmc/pldm/tree/46f352ed2426368185f3bd36fd6bf88f15fa5111

Change-Id: Ieffdca541d1ff8489911b02c178f85d3b1b84a5c
Signed-off-by: Archana Kakani <archana.kakani@ibm.com>

show more ...

fix markdownlint issues reported in CI

There are a lot of warnings reported by markdownlint in the CI, this
commit aims at fixing all of them.

Tested :

No more warnings reported by markdownlint in

fix markdownlint issues reported in CI

There are a lot of warnings reported by markdownlint in the CI, this
commit aims at fixing all of them.

Tested :

No more warnings reported by markdownlint in the CI.

Change-Id: I92d24bc0efd230dd0974ff49853ef928caf1febd
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Deprecate the support for x86 sdk

OpenBMC as a project has moved away from using yocto x86 sdks for unit
testing. Instead now the preferred way to build and test code is by two
ways:

1. Leveraging

Deprecate the support for x86 sdk

OpenBMC as a project has moved away from using yocto x86 sdks for unit
testing. Instead now the preferred way to build and test code is by two
ways:

1. Leveraging the meson subproject support
2. Using openbmc docker container

Since x86 sdks needed some weird hacks in the code base like figuring
out the linker arguments ourselves & running custom bash commands from
the meson build files. Also with changing yocto code base, its a large
maintainer burden to make sure this support works.

Tested:
Code builds & unit tests are passed with both the approaches mentioned
above.

Change-Id: Iaf55e2c003ffd9ee1a295de5bdfd14d81222e94b
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

README: Move to "meson setup [options]"

Fixes the warning:
WARNING: Running the setup command as `meson [options]` instead of
`meson setup [options]` is ambiguous and deprecated.

Tested: The follow

README: Move to "meson setup [options]"

Fixes the warning:
WARNING: Running the setup command as `meson [options]` instead of
`meson setup [options]` is ambiguous and deprecated.

Tested: The following work:
meson setup build
ninja -C build

Change-Id: I4d45fab5eb25d9355f21a8da260ee52b5ed4ba18
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

show more ...

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: I0d25f27a5e449578967915d9f570cc29246927d7
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Remove libpldm documentation from pldm

As libpldm is being migrated to openbmc/libpldm, the documentation of
libpldm is also migrated, so removing it from pldm repository.

Signed-off-by: Manojkiran

Remove libpldm documentation from pldm

As libpldm is being migrated to openbmc/libpldm, the documentation of
libpldm is also migrated, so removing it from pldm repository.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: Iafe87e6e0ccea56ff92843c4c0130b120e81e7d0

show more ...

Fix pldmd verbosity command line argument

This commit would attempt to fix the command line argument --verbose.

The fact that verbose option requires an argument 0 or 1 is not
particularly intuitiv

Fix pldmd verbosity command line argument

This commit would attempt to fix the command line argument --verbose.

The fact that verbose option requires an argument 0 or 1 is not
particularly intuitive and a documented OpenBMC anti-pattern.

https://github.com/openbmc/docs/blob/master/anti-patterns.md#non-standard-debug-application-options-and-logging

Resolves : https://github.com/openbmc/pldm/issues/7
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I50d82ce492bd815b589627d3713b1a7fc1db997b

show more ...

readme: add another method for running unit tests

Now that we have subprojects for all the OpenBMC based dependencies, the
tests should build and run natively using any reasonably modern

readme: add another method for running unit tests

Now that we have subprojects for all the OpenBMC based dependencies, the
tests should build and run natively using any reasonably modern Linux
distro with the correct build dependencies installed. Add this as a
third mode for running the tests. Add wording that indicates this is
the "preferred" mode since this is how everyone expects to run unit
tests in the first place.

Change-Id: I75e2841b224dc0e61cd3d877a8ef571167181dad
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

readme: remove redundant meson directive

Specifying -Dtests=enabled is redundant - tests are enabled by default.

Change-Id: I8d8b57c270bac7e4914c84781b61a34790a006ca
Signed-off-

readme: remove redundant meson directive

Specifying -Dtests=enabled is redundant - tests are enabled by default.

Change-Id: I8d8b57c270bac7e4914c84781b61a34790a006ca
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Document README for pldmtool.

Resolves openbmc/pldm/issues/#20

Signed-off-by: Sridevi Ramesh <sridevra@in.ibm.com>
Change-Id: I2f07ff506d24d9caec45e56fd6817b87e59b195e

Rectify the README with the latest details

- The readme document in the repo seems to have a small
section which still refers to the older build system
used by pldm.

- N

Rectify the README with the latest details

- The readme document in the repo seems to have a small
section which still refers to the older build system
used by pldm.

- Now that, the repo is migrated to meson, this commit
would attempt to rectify it.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I470d477261758ca4443697812bca36e790c98641

show more ...

meson: add alternative build system

Enable meson build for the pldm project (by default). The autotools
support will be eventually removed. This change is aligned with other
OpenBMC

meson: add alternative build system

Enable meson build for the pldm project (by default). The autotools
support will be eventually removed. This change is aligned with other
OpenBMC repos, and besides for pldm meson seems to be significantly
faster (see times below to build and run tests on an x86 OpenBMC sdk).

time sh -c './bootstrap.sh ; ./configure ${CONFIGURE_FLAGS}
--enable-oe-sdk --enable-oem-ibm ; make ; make check'
real 3m49.495s

time sh -c 'meson -Doe-sdk=enabled -Dtests=enabled -Doem-ibm=enabled
build/ ; ninja -C build test'
real 0m14.940s

With the currently used warning level in the meson config (the highest
level is used), certain warnings had to be fixed in this commit
(warnings are treated as errors).

Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
Change-Id: I9022417c8fa218d3c2c2f786502caa815af2f832

show more ...

PDR: implement generation framework

This commit implements a framework that allows describing
platform/system specific PDR information in JSON files, which the PLDM
responder library

PDR: implement generation framework

This commit implements a framework that allows describing
platform/system specific PDR information in JSON files, which the PLDM
responder library parses and builds a PDR out of.

Separate JSON files are expected per PDR type. This commit also adds the
code to build a state effecter PDR. PDR record handles are implemented
as incrementing indices, starting at 1, but this commit enables
implementing other type of record handles (for eg offset based).

This commit doesn't handle merging of PDRs received from other terminii,
so the PDR that's generated now is for the BMC. Merging of PDRs will be
implemented in future commits.

Change-Id: I005b08c5d29d12fc2459ca8d6e18547107a3da7d
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>

show more ...

Enable IBM PLDM OEM commands support

Create folder structure (oem/ibm) for ibm pldm oem commands. Move the
files from the ibm-pldm-oem repo [https://github.com/openbmc/ibm-pldm-oem]

Enable IBM PLDM OEM commands support

Create folder structure (oem/ibm) for ibm pldm oem commands. Move the
files from the ibm-pldm-oem repo [https://github.com/openbmc/ibm-pldm-oem]
to the folder oem/ibm/ under the pldm repo and enable conditional
compilation for it. The test files are also conditionally compiled.

You would need to provide --enable-oem-ibm to configure.

This is done to simplify the build time and runtime dependencies between the
standard and oem implementations.

Signed-off-by: Jinu Joy Thomas <jinu.joy.thomas@in.ibm.com>
Change-Id: Iaa93c73faff87290e3d3d5d155d9ecae6e7ee6f9

show more ...

README: remove section about pldm daemon

The section describing the pldm daemon was added a bit prematurely. This
is still work in progress alongwith the MCTP design. This will be
de

README: remove section about pldm daemon

The section describing the pldm daemon was added a bit prematurely. This
is still work in progress alongwith the MCTP design. This will be
described later on once the design is finalised.

Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
Change-Id: I0a13c8e561acce64b74ec5f69e6dcab881d087b7

show more ...

README: Document responder library registration

Document high level API for responder's message handler registration
with the PLDM daemon.

Change-Id: I4c388cefbde7d6599ced214c1e

README: Document responder library registration

Document high level API for responder's message handler registration
with the PLDM daemon.

Change-Id: I4c388cefbde7d6599ced214c1e8633b8980da944
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>

show more ...

README: Add missing newlines

Change-Id: I22014a2aa7ad18972c509162cba846047300457a
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>

README: add high level flows

Add requester and responder flows.

Change-Id: I57ef227b1db52b42c9de26a84f1051b2772b6da8
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>

Add README

Describe code organization in the README.

Change-Id: Iaa180fd5663c9f7fa0eba4778cb2ae7bc936a369
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>