Order hardware components

Lists hardware components by depth, and
within those with the same depth, orders
the components alphanumerically. Places child
components beneath their parent compenent.

R

Order hardware components

Lists hardware components by depth, and
within those with the same depth, orders
the components alphanumerically. Places child
components beneath their parent compenent.

Resolves openbmc/openbmc#3386

Change-Id: I4b0e63164fbc9bd24078b9e36c6dc7788be06744
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Functional version font color

Blue makes the text appear to be a link.
Updated text color to dark grey.

Resolves openbmc/phosphor-webui#22

Change-Id: I5950473844d2edfeaf5ede80b46984bc152d7483
Sign

Functional version font color

Blue makes the text appear to be a link.
Updated text color to dark grey.

Resolves openbmc/phosphor-webui#22

Change-Id: I5950473844d2edfeaf5ede80b46984bc152d7483
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Update code styling for network page

Now that the following style guide is being
used:
https://google.github.io/styleguide/jsguide.html#naming
Some of the variable naming in this class needs to be u

Update code styling for network page

Now that the following style guide is being
used:
https://google.github.io/styleguide/jsguide.html#naming
Some of the variable naming in this class needs to be updated.

Change-Id: I6ca7a0ea7255ab2314bb4b5fc2d89cff9006039a
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

login-controller.html: Fix indents

Change-Id: Ie6867b29eb7e785ad48c918d605ccfff955e3102
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Add and Update IPV4 address

This allows user to add IPV4 addresses
and updates logic for editing IPV4
addresses.

Resolves openbmc/phosphor-webui#12

Tested: Added, removed and modified IPV4
ad

Add and Update IPV4 address

This allows user to add IPV4 addresses
and updates logic for editing IPV4
addresses.

Resolves openbmc/phosphor-webui#12

Tested: Added, removed and modified IPV4
addresses, called API to verify that
addresses had been correctly modified.
Verified that if address had not been
modified, no change was made for that
address.

Change-Id: I3dd25565f4f610dce2023e23348f6eb8d00add3d
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Fix setting image priority

Let's say there are 2 images, A and B. A has a priority of 0
and B has a priority of 50. Lowest priority is the image used
to boot from and appears at the top of the image

Fix setting image priority

Let's say there are 2 images, A and B. A has a priority of 0
and B has a priority of 50. Lowest priority is the image used
to boot from and appears at the top of the image tables
(A in this case). If the user wanted image B to be the image
with the lowest priority, they would have to hit the up arrow
50 times in the old logic.

Move to setting the priority based on the image above, for
the up arrow, or below, for the down arrow.

If 2 images have the same priority, the image whose priority is
being updated wins and the image who already has that priority
gets bumped up 1, this is why when moving an image down we set
to the below image's priority +1, but don't need this -1 when
moving an image up in the table.

Tested: Can still change the priority.
Change-Id: If87e1d863ab909c276247072cc45e40b67cf686b
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add "(Primary)" to first NTP Server

The IBM design team though adding "(Primary)" to the first
NTP Server made it more clear that this NTP server is the
first NTP server the time manager talks to.

Add "(Primary)" to first NTP Server

The IBM design team though adding "(Primary)" to the first
NTP Server made it more clear that this NTP server is the
first NTP server the time manager talks to.

Change-Id: Iaadbc4958621146db072541668a7a6f0a8834de4
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Set Host Time from correct fields

In all cases except when the time owner is "Split", Host and BMC
time share fields. Make sure to set the Host time from the
correct fields, which is these shared fi

Set Host Time from correct fields

In all cases except when the time owner is "Split", Host and BMC
time share fields. Make sure to set the Host time from the
correct fields, which is these shared fields in all cases
except when time owner is "Split".

Resolves openbmc/phosphor-webui#20

Tested: Able to set the Host and BMC time
Change-Id: I69985fd2de08fe71c62fd57dd1fa872f7f33ba09
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Set the Host Time if "Split" and "NTP"

From: https://github.com/openbmc/phosphor-time-manager
Mode Owner Set BMC Time Set Host Time
NTP SPLIT Fail to set OK

Resolves openbmc/phosphor-webui#19

Chan

Set the Host Time if "Split" and "NTP"

From: https://github.com/openbmc/phosphor-time-manager
Mode Owner Set BMC Time Set Host Time
NTP SPLIT Fail to set OK

Resolves openbmc/phosphor-webui#19

Change-Id: I72f5617581533a2bb17d415b45bdf7ec6372ecab
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

User Management: Do not autocomplete passwords

Security scanners list autocomplete on as a medium priority
issue. The concern being someone could use it to compromise
a BMC with a password saved on

User Management: Do not autocomplete passwords

Security scanners list autocomplete on as a medium priority
issue. The concern being someone could use it to compromise
a BMC with a password saved on a compromised computer.

Change-Id: Ibefa75af19046e056955406c1e4d31331d82f19f
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove IPV4 addresses

Tested: Able to remove existing IPV4
addresses.

Change-Id: I772bee6ad6b68bc0a69351f3e5386acc659241ef
Signed-off-by: beccabroek <beccabroek@gmail.com>

Date-time: Change h2 title

This title is more clear.

Change-Id: I8e4f89b1d2d91fe0745dedfcea1af124033d5cca
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

log-search-control.html: Fix indenting

Change-Id: I11074705553aba7b1b8a8ebc1a97b472a5fb1de5
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Revert "Remove unused dataService"

This reverts commit e13275b837ed38b7e8553316accedb51b32ef37b.
dataService is used in powerOn(), warmReboot() and
isServerOff().

Change-Id: I8635ac88f93b6354ea7d35

Revert "Remove unused dataService"

This reverts commit e13275b837ed38b7e8553316accedb51b32ef37b.
dataService is used in powerOn(), warmReboot() and
isServerOff().

Change-Id: I8635ac88f93b6354ea7d352f92c9a7f4281e21a5
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove unused dataService

Change-Id: I99e0d16a56908beb1397bb4c15390c72c3b2f3f5
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Remove tabs from HTML files

From https://google.github.io/styleguide/htmlcssguide.html
"Indentation
Indent by 2 spaces at a time.

Don't use tabs or mix tabs and spaces for indentation."

Tested: Ma

Remove tabs from HTML files

From https://google.github.io/styleguide/htmlcssguide.html
"Indentation
Indent by 2 spaces at a time.

Don't use tabs or mix tabs and spaces for indentation."

Tested: Manual regression testing on a Witherspoon.
Change-Id: Ief7137dabc869b73b73f9947337fbb0abb5ca497
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Resizing SOL console

Makes no changes to how the
console currently looks, but makes
overriding the css height of the
terminal easier.

Resolves openbmc/phosphor-webui#8

Change-Id: Ie198462eaf42578c

Resizing SOL console

Makes no changes to how the
console currently looks, but makes
overriding the css height of the
terminal easier.

Resolves openbmc/phosphor-webui#8

Change-Id: Ie198462eaf42578c848fe9285c3065ef6e26b1b2
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Do not autocomplete username and password

Security scanners list autocomplete on as a medium priority
issue. The concern being someone could use it to compromise
a bmc with a password saved on a com

Do not autocomplete username and password

Security scanners list autocomplete on as a medium priority
issue. The concern being someone could use it to compromise
a bmc with a password saved on a compromised computer.

Resolves openbmc/phosphor-webui#18

Change-Id: Ie6936d84a0b94a81781a077d1542a6ce1d413d6d
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add Redfish into the web-ui

Currently only GET is supported, but to add PATCH
in the future for redfish, support should be moved from
being hosted directly by bmcweb into the webui.

Tested-by:
Navi

Add Redfish into the web-ui

Currently only GET is supported, but to add PATCH
in the future for redfish, support should be moved from
being hosted directly by bmcweb into the webui.

Tested-by:
Navigated to http://localhost:8080/#/redfish/v1/ with
bmc attached and was able to view all of redfish. Also
tested on platform.

Change-Id: I1dc3936b6b48835a1f69698fcb4fd6fcdb6d91ac
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Make wording consistent

The IBM design team identified this wording as inconsistent.
In the tables below the "running" image is called "Functional",
here it is called "In-memory".

Change to "Functi

Make wording consistent

The IBM design team identified this wording as inconsistent.
In the tables below the "running" image is called "Functional",
here it is called "In-memory".

Change to "Functional" to match the table below.

Change-Id: I4b1a45f3cbcc578b0f807577dd2c3a9c54714a02
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Activate image and reboot host

When activating a host image, gives the option to:
a) Activate image without booting
b) Activate image and boot host. If server is
in 'off' status the option

Activate image and reboot host

When activating a host image, gives the option to:
a) Activate image without booting
b) Activate image and boot host. If server is
in 'off' status the option is to power on.
If the server is in 'unavailable', 'on', or
'error' status the option is to reboot
Also updated polling during boot and reboot to use
/subscribe API.

Resolves openbmc/openbmc#3323

Tested: The GUI displays the options and boots /
reboots appropriately based on server status.

Change-Id: I62c19e094ecc7112263c26844fcd30b2bf3c2b84
Signed-off-by: beccabroek <rebecca.shaw@ibm.com>

show more ...

Button to remove NTP server

Change-Id: I58a3a894c192fafb551e07302b107bcd776e4901
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Button to remove DNS server

Added button to remove DNS server from
Nameservers list.

Resolves openbmc/phosphor-webui#11

Tested: Added and was able to remove DNS servers
from list. Page updated a

Button to remove DNS server

Added button to remove DNS server from
Nameservers list.

Resolves openbmc/phosphor-webui#11

Tested: Added and was able to remove DNS servers
from list. Page updated appropriately.

Change-Id: I64e9d2499465f1aa5f9f34c831961578abf32b2b
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

MAINTAINERS: Update my email and IRC

Updated to correct IRC username and preferred email address.

Change-Id: I2a959f3e33c4f9c0364043e2eac21c2f93dcc561
Signed-off-by: Gunnar Mills <gmills@us.ibm.co

MAINTAINERS: Update my email and IRC

Updated to correct IRC username and preferred email address.

Change-Id: I2a959f3e33c4f9c0364043e2eac21c2f93dcc561
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Set time fields

Squashed 5 commits to set the date-time fields:
time mode, time owner, BMC time, and host time.
Also included is a commit to display the timezone.

Set time mode

Moved the selection

Set time fields

Squashed 5 commits to set the date-time fields:
time mode, time owner, BMC time, and host time.
Also included is a commit to display the timezone.

Set time mode

Moved the selection of NTP vs Manual (time mode) to a radio
button.
Added code to allow the user set it.

Tested: Set the time mode on a Witherspoon.
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Set time owner

The time owner is now a dropdown and is set when "Save settings"
is pressed.

Tested: Set the time owner on a Witherspoon
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Set the BMC and Host time

The BMC and host have the same time except when time mode is split.
Only need to set BMC or host time when time mode is not split.
When time mode is split, set both. Use time owner to determine
which to set.
https://github.com/openbmc/phosphor-time-manager#time-settings

Have date and time as two separate inputs, this is due to Firefox
not supporting "datetime-local". The "date" and "time" input
fields are more widely supported.
https://caniuse.com/#feat=input-datetime

The idea for 2 separate input fields came from:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/datetime-local

Must set the time mode and time owner before setting the time,
this is due to permissions of who can set the time.

Tested: Set the date and time on a Witherspoon.
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Add NTP Servers

The user can now view and set NTP Servers.

Moved setFocusOnNewInput to a common directive since it is used
on the NTP Servers and the DNS Servers on the network page.

Even though NTPServers is a network interface specific path
(e.g. /xyz/openbmc_project/network/eth0/attr/NTPServers) it acts
like a global setting, openbmc/phosphor-time-manager#4.
Using eth0 for setting and getting the NTP Servers until
NTPServers is moved to a non-network interface specific path.

In Redfish, NTPServers is a non-network interface specific.

Tested: Set NTP Servers on a Witherspoon.
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Add timezone

Added the timezone for the host and bmc date time.

The timezone looks like "GMT-0400 (EDT)" or "GMT-0500 (CDT)".
I got this from
https://stackoverflow.com/questions/1091372/getting-the-clients-timezone-in-javascript
and choose this formatting over something like "America/Chicago".

Tested: See the timezone on a Witherspoon
Change-Id: I59a4449d63f73a6ed14cb934f3d8577e46620c4e
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...