MAINTAINERS: remove file

The MAINTAINERS file is deprecated in favor of OWNERS.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I3e9c69d157606fcd1f4010a8c561d9777a9fb9c8

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have the correct field.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I7805fb77d1ba9e6ef007827d197fe9aced3a784d

show more ...

More strongly recommend switching to webui-vue

AngularJS has gone End of Life.
REST D-BUS API has been disabled by default in bmcweb.
At a later date phosphor-webui will move to ReadOnly.

Signed-of

More strongly recommend switching to webui-vue

AngularJS has gone End of Life.
REST D-BUS API has been disabled by default in bmcweb.
At a later date phosphor-webui will move to ReadOnly.

Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
Change-Id: I37408f0e8cc41a8eb5bd17afdbfef75ab15afef6

show more ...

Remove Derick as a Reviewer

Derick is no longer working on phoshor-webui.

Change-Id: I268a9e4ac983ed909dc9ae94bdb5628d7da8bd11
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Hack webpack to not use MD4

OpenSSL 3 removed support for MD4, the default hashFunction.
As the issue describes, the proper fix here is to move to webpack 5.

Moving to webpack 5 requires numerous c

Hack webpack to not use MD4

OpenSSL 3 removed support for MD4, the default hashFunction.
As the issue describes, the proper fix here is to move to webpack 5.

Moving to webpack 5 requires numerous changes.

Attempted moving to webpack 5 but migration requires a ton of changes.

This solution is from:
https://github.com/webpack/webpack/issues/13572#issuecomment-923736472

This should enable the new Yocto bump to pass.

Tested: npm install && npm run-script build and loaded those onto a
Witherspoon system. Yocto bump with this change built.

Change-Id: I5818fc49c8e0f0df7911edc069ff75a9b047dd21
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add OWNERS file

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I3d51fa1903126130e7045d88aa6a1a5f501af9df

Make SOL layout responsive to the window changes

The current version of a SOL window layout have several
downsides:
-terminal content doesn't resize with the window changes
-when opened in a separat

Make SOL layout responsive to the window changes

The current version of a SOL window layout have several
downsides:
-terminal content doesn't resize with the window changes
-when opened in a separate window terminal content doesn't
use full viewport space
-when opened in a separate window terminal viewport takes
only a small part of the window

Screenshots with the problems descriptions are documented in
the github issue:
https://github.com/openbmc/phosphor-webui/issues/125

This commit adds responsiveness to the SOL layout.
The main SOL tab:
-terminal content automatically resizes with the viewport changes

The separate SOL window:
-XTERM always use full terminal viewport space
-terminal viewport width always equals window space width
-terminal viewport automatically resizes on window size changes
-terminal content automatically resizes with the viewport changes

As SOL UI is resposive now, this commit also removes fixed size
configurations for the SOL terminal via JSON 'customConsoleDisplaySize'
variable. It is worth noting that in reality it wasn't really
used anyway.

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Change-Id: Ia5d929e9a309281366a9d3119ac326ebd73c73f0

show more ...

clang-format-11: reformat

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I74d01806faf1884b8077c6c5c841ef194ff0b021

server-overview: supporting all MACs and IPs

Show MAC and IP address information for all the present
ethernet interfaces on the server overview page.

Tested: the `webui`-overview page on a system h

server-overview: supporting all MACs and IPs

Show MAC and IP address information for all the present
ethernet interfaces on the server overview page.

Tested: the `webui`-overview page on a system having
2 physical ethernet interfaces shows all IP addresses
assigned to the interface and also shows MAC addresses
for each interface

```
ETH0 IP ADDRESSES
IPv4: 172.17.26.67
IPv4: 169.254.28.79
IPv6: FE80::702C:BFFF:FEDE:DEC3

ETH1 IP ADDRESSES
IPv4: 169.254.51.25
IPv6: FE80::14B7:7EFF:FEF1:2EF

ETH0 MAC ADDRESS
72:2C:BF:DE:DE:C3

ETH1 MAC ADDRESS
16:B7:7E:F1:02:EF
```

End-user-impact: The server-overview page is now able to
display information about each ethernet's
MAC, IPv4 and IPv6 adresses.

Signed-off-by: Igor Kononenko <i.kononenko@yadro.com>
Change-Id: I677b645cc33bfc49c2dd91f4acc743973dc29998

show more ...

Relace node-sass with dart-sass

This patchset moves phosphor-webui away from node-sass. This is a good
thing overall, and should make phosphor-webui build a little faster,
given it doesn't have to

Relace node-sass with dart-sass

This patchset moves phosphor-webui away from node-sass. This is a good
thing overall, and should make phosphor-webui build a little faster,
given it doesn't have to compile libsass. It also dumps a significant
number of dependencies from the tree.

webui-vue has a similar patch:
https://gerrit.openbmc-project.xyz/c/openbmc/webui-vue/+/35663

Tested:
Build phosphor-webui with changes. Builds as expected.

Change-Id: I30537284518ebf2e0816568e25320a55ade323e4
Signed-off-by: Ed Tanous <ed@tanous.net>

show more ...

Fix Internet Explorer

Looks like this got merged before it got tested, and broke IE. Apparently
we still have users using it, as they noticed pretty quick. we might
want to keep that in mind for t

Fix Internet Explorer

Looks like this got merged before it got tested, and broke IE. Apparently
we still have users using it, as they noticed pretty quick. we might
want to keep that in mind for the future.

A short note on the failure, this snippet contained a section that
enabled use scrict on the code, which accidentally allowed babel to
enable it everywhere. So far as I can tell, the existing code doesn't
follow strict (although there's only one outlier).

in short, this fixes IE.

Tested:
Launched webui in IE11 with debug console open. Observed UI launches
with no unexpected warnings.

Signed-off-by: Ed Tanous <ed@tanous.net>
Change-Id: I85cc83b34f4f5906e827ea55c4b4fb4bda0fe6ac

show more ...

Remove scaled

Scale was removed from phosphor-dbus-interfaces when moving to a
double.
https://github.com/openbmc/phosphor-dbus-interfaces/commit/4ec6587fa908fe9df41cc0962ab6ff6446fbd54f

A future i

Remove scaled

Scale was removed from phosphor-dbus-interfaces when moving to a
double.
https://github.com/openbmc/phosphor-dbus-interfaces/commit/4ec6587fa908fe9df41cc0962ab6ff6446fbd54f

A future improvement could be some sort of rounding.

Tested: Loaded GUI on a Witherspoon
Change-Id: I771e575c85cc97196678a1da8e01d1fdb96ddf8c
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

README: Mention AngularJS EOL and webui-vue

Mention AngularJS going End of Life and webui-vue as a possible
replacement.

Change-Id: Ib17eb112a8823f2637f0afc135e022ad930da3ab
Signed-off-by: Gunnar M

README: Mention AngularJS EOL and webui-vue

Mention AngularJS going End of Life and webui-vue as a possible
replacement.

Change-Id: Ib17eb112a8823f2637f0afc135e022ad930da3ab
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Drop encoding library

Commit f4a43cca440535a63592877c9bdbbe28636d803c attempted to fix a IE
bug in the SOL library. Unfortunately, it did it by pulling in the
entire NPM encoding library, which is

Drop encoding library

Commit f4a43cca440535a63592877c9bdbbe28636d803c attempted to fix a IE
bug in the SOL library. Unfortunately, it did it by pulling in the
entire NPM encoding library, which is insanely large (190kb after
minification and compression). This is almost equivalent to the rest of
our javascript put together! That's nuts, and I don't think anyone
would argue that's a binary hit worth taking for IE9 support.

This commit removes it, and swaps in an inline polyfill from the mozilla
recommendations, that compresses much....much smaller.

Before this patchset build prints:
app.bundle.js.gz 522 KiB [emitted] [big]

After this patchset:
app.bundle.js.gz 332 KiB [emitted] [big]

If you don't want to break out a calculator, that's 190KB savings in the
root filesystem, and should cut the initial page load time (on slow
connections) by nearly 30 percent.

Note: text-encodings was never pinned in the package-lock.json, hence
why you don't see a diff removing it from package lock. This was a miss
on the original commiters part, although it doesn't really matter, as
it's now removed.

PS: A reviewer may note, I could've moved the polyfill into its own
file. Considering the serial console is the only page that uses that,
and it's not that big I elected not to, to make removing it analagous
with removing xterm/the serial console.

Bonus content!
Added a (commented out) webpack config that allows you to generate the
webui as individual gzipped fragments, instead of one bundle. This
allows you to see file sizes on a package by package basis, and was how
I found this commit in question.

Testing:
This is where this patchset gets hairy. I dont' have an IE9 instance to
test on. Given it's low usage, and the fact that it's a relatively
straightforward change we can probably just wait for someone to tell us
it's broken again.

Enjoy the sweet sweet savings.

Signed-off-by: Ed Tanous <ed@tanous.net>
Change-Id: I2820ff1c4b33d725ebc63490793a72fe600b8ed3
Signed-off-by: Ed Tanous <ed@tanous.net>

show more ...

Fix SENSOR_SORT_ORDER array

'Meters' entry had been duplicated; 'Watts' was missing.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Change-Id: I836efa74120dd427253a4aee817216d37a93049a

Fix layout bugs on server power operations page

Add missing closing div tag that caused strange column layout
breaks.

Resolves openbmc/phosphor-webui#112

Tested: No longer see the problem on a Wit

Fix layout bugs on server power operations page

Add missing closing div tag that caused strange column layout
breaks.

Resolves openbmc/phosphor-webui#112

Tested: No longer see the problem on a Witherspoon.

Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I87f4947f60f95c7991df3f7c429ac51726a894b9

show more ...

Enable clang-format-10

Move away from hardcoding the version of clang-format.

Took from:
https://github.com/openbmc/libmctp/blob/f5afcd7e6597dcdeaa475aa7194ecfae2e82d114/format-code.sh#L3

Change-I

Enable clang-format-10

Move away from hardcoding the version of clang-format.

Took from:
https://github.com/openbmc/libmctp/blob/f5afcd7e6597dcdeaa475aa7194ecfae2e82d114/format-code.sh#L3

Change-Id: I574d6ea2f1221001754aef36aa8627d270dff178
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add CSRF check to more websockets

This adds the token to more websockets that were
missing it.

Change-Id: I633ce28ec9602d33a79d613f94582ba0ff265368
Signed-off-by: James Feist <james.feist@linux.int

Add CSRF check to more websockets

This adds the token to more websockets that were
missing it.

Change-Id: I633ce28ec9602d33a79d613f94582ba0ff265368
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Pass cookies into function

This was missed in the websocket upgrade.

Change-Id: Id2256fa87d728d71790d3046d280449feefe326c
Signed-off-by: James Feist <james.feist@linux.intel.com>

Python3 Support: Force node-gyp to 6.1.0

The version of node-gyp, ^3.8.0, used by node-sass does not support
Python 3 only environments.

Starting with node-gyp 5.0.0, support for Python 3 only was

Python3 Support: Force node-gyp to 6.1.0

The version of node-gyp, ^3.8.0, used by node-sass does not support
Python 3 only environments.

Starting with node-gyp 5.0.0, support for Python 3 only was added.

Added node-gyp 6.1.0 to package.json and edited the node-sass
"requires" in package-lock.json to force node-sass to use this
version.

This problem can be seen if building an image or the webui
recipe with the meta-oe and poky subtree bumps:
https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/31299
https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/31297

This poky refresh deprecates python2. From the mailing list:
https://lists.ozlabs.org/pipermail/openbmc/2020-February/020421.html

node-sass knows of this issue and has a fix, same fix as this,
move node-gyp to 6.1.0, but that fix isn't in a release yet.
Asked for a timeline of when a release with this fix will
happen. This change can be removed after moving to a
version of node-sass with this fix.
https://github.com/sass/node-sass/issues/2877

Considered using https://www.npmjs.com/package/npm-force-resolutions
but required more packages and wasn't simple to make work.

Modifying package-lock.json manually is not recommended but
in this case until fixed upstream, not a better solution.

Tested: Built for a Witherspoon and no regression.
Was able to build the GUI with change and 31299 / 31297.
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
Change-Id: I514395ca0ae2fda6d46cb7a2a3e70cc5b92be58d

show more ...

Update packages and fix vulnerabilities

Ran "npm-check --update-all --save-exact"
then "npm audit fix".
Rolled back to xterm 3, since problems building xterm 4.

Tested: Built the GUI and loaded on

Update packages and fix vulnerabilities

Ran "npm-check --update-all --save-exact"
then "npm audit fix".
Rolled back to xterm 3, since problems building xterm 4.

Tested: Built the GUI and loaded on a Witherspoon.

Change-Id: Ibe86fba54090bfa8b4ef0a6d87baf3dd4f88d48f
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

NoVNC: Changes to package-lock.json

Changes added to package-lock.json from building.

Change-Id: Idb1af188e312e5aae808948871f2c867b594b1d1
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Add CSRF to all remaining websockets

This passes the CSRF with the websocket so that
the pages continue to work after CSRF is added.

Tested: Verified SOL still worked

Change-Id: I8f1066c2769f92034

Add CSRF to all remaining websockets

This passes the CSRF with the websocket so that
the pages continue to work after CSRF is added.

Tested: Verified SOL still worked

Change-Id: I8f1066c2769f92034c349e7112ebc1070adcd35b
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Add XSRF token into websocket request

Add XSRF token so we can implement CRSF checking
on websockets.

Tested: Saw it in bmcweb logs

Change-Id: Ie9479508bc69fad631f66fb282133ad18d025300
Signed-off-

Add XSRF token into websocket request

Add XSRF token so we can implement CRSF checking
on websockets.

Tested: Saw it in bmcweb logs

Change-Id: Ie9479508bc69fad631f66fb282133ad18d025300
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Improve blocking of non local urls

It was found that the original check didn't stop
http:www.google.com forwards. This fixes that issue.

Tested: Verified that the url forward didn't work

Change-Id

Improve blocking of non local urls

It was found that the original check didn't stop
http:www.google.com forwards. This fixes that issue.

Tested: Verified that the url forward didn't work

Change-Id: I44a9b84218e15ddd0d37d5fbda633b66326da1f4
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...