Fix always loading issue on IE11

In some pages like server view page, always in loading status.

Import babel-polyfill to solve cross browser issue on HTML5/CSS3,
especially for the older browsers.

Fix always loading issue on IE11

In some pages like server view page, always in loading status.

Import babel-polyfill to solve cross browser issue on HTML5/CSS3,
especially for the older browsers.

Tested:
launch IE11 visit https://BMC_IP_ADDR

Change-Id: Ib8e59e236171fff595ac1e5df3a9111005b39268
Signed-off-by: Kuiying Wang <kuiying.wang@intel.com>

show more ...

Center modals and fix sizing

Previously the modals were not centered on the screen and the size
of the modal was set to 50% of the screen, leading to a lot of white
space within modals with less con

Center modals and fix sizing

Previously the modals were not centered on the screen and the size
of the modal was set to 50% of the screen, leading to a lot of white
space within modals with less content. This sizes the modal based on
the amount of content within and centers the modal. Also adds the grey
modal overlay to the 'confirm network settings' modal to be consistent
with the other pages.

Resolves openbmc/phosphor-webui#35

Tested: Viewed all modals currently in GUI (Firmware page, network page,
and overview page) and modals were sized correctly and appeared
with the modal overlay in the background.

Change-Id: Ie35d179810d36b8bcbbf39dc1302e773387fa788
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

WebUI: Adding Filters support to system logs

Adding Filter support to system logs page
- Severity filter.
- Date filter with start and end date.
- Filter by Sensort Type.

Tested By:
Loaded Sys

WebUI: Adding Filters support to system logs

Adding Filter support to system logs page
- Severity filter.
- Date filter with start and end date.
- Filter by Sensort Type.

Tested By:
Loaded System logs page with type selection
'Event' and check all filters.

Change-Id: I41eba4cd59c0f3c2933637bf0e207a3eca3214f1
Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>

show more ...

WebUI system logs implementation

This commit implements the webui logs page
which will show all system logs depends
on user selection( SEL or Event or Oem). This
is based out of redfish systems log

WebUI system logs implementation

This commit implements the webui logs page
which will show all system logs depends
on user selection( SEL or Event or Oem). This
is based out of redfish systems log services.
- View logs with pagination.
- Search filter for logs view.
- Sort option with Type, Id, Severity, Date.
- Clear logs.
- Export logs.

UnitTest:
- Existing bmcweb send the system logs of EntryType
"Event". So Loaded UI, selected Type "Event" and
validated all the above mentioned operations.

Change-Id: I0384e475f7913ca66b6db5d64831583fb382f8d5
Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>

show more ...

Checkbox disabled when 0 event logs

The 'select all' box on event log page should be disabled when
there are no event logs presented to the user. Also adds a
message to the user when there are no lo

Checkbox disabled when 0 event logs

The 'select all' box on event log page should be disabled when
there are no event logs presented to the user. Also adds a
message to the user when there are no logs or there are no logs
with their selected filters applied.

Resolves openbmc/phosphor-webui#44

Tested: Checked that correct user message appears when there are
no logs and when the logs are all filtered out. Also that
when there are no logs presented to the user, the select
all box is disabled.

Change-Id: I3106426a72d2148a323ceed978bcdd5515096e2b
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Secondary button text color

Changes color of secondary button text to be more readable.

Resolves openbmc/phosphor-webui#66

Change-Id: I3d7622a3556139a8c984590bcc8db5c34cefc73e
Signed-off-by: becca

Secondary button text color

Changes color of secondary button text to be more readable.

Resolves openbmc/phosphor-webui#66

Change-Id: I3d7622a3556139a8c984590bcc8db5c34cefc73e
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Set SOL Screen dynamically

To make EWS SOL Screen size match the real BIOS console, need to
set the screen dynamically. Web page get terminal resolution from
config.json and calculate frame width an

Set SOL Screen dynamically

To make EWS SOL Screen size match the real BIOS console, need to
set the screen dynamically. Web page get terminal resolution from
config.json and calculate frame width and height base on the
resolution and fontsize. Web page use this width and height to
change the screen size. If no related configuration in config.json
the SOL Screen will keep the original size before this code change.

Tested By:
Add "customConsoleDisplaySize": {"width": 100, "height": 32} to
config.json, and open EWS Server Serial over LAN console page, the
size of console client can match 100*32 characters. Set console
redirection to 100*32 in BIOS setup page, the page show correctly
in this SOL client in EWS. After enter OS, the linux console can
show correctly in SOL client.
After remove "customConsoleDisplaySize" in config.json, the size
of console client in EWS show the same as the code change in this
patch.

Change-Id: I09bfe4e67db1387abcd57ee3a13b912957cf95b0
Signed-off-by: Yang Cheng <cheng.c.yang@linux.intel.com>

show more ...

Hardware: Filter out associations

Don't display associations on the "Hardware status" page.
All and only associations have the "endpoints" property,
use this is to filter.
An example of an associati

Hardware: Filter out associations

Don't display associations on the "Hardware status" page.
All and only associations have the "endpoints" property,
use this is to filter.
An example of an association is from the BMC inventory item
to BMC software images.

Tested: Loaded on a Witherspoon and no longer see the "Activation"
item on the page. This "Activation" item was an
association. All other items appear as normal.

Change-Id: I6e6e24737b0a19e91dbd7eb691dd3d78f1b4c12c
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add Custom Key for SOL on webui

To support VT100+ extensions for SOL on webui, add custom key
into xtermjs to handle key Backspace, DEL, HOME, END, INSERT,
PAGE UP, PAGE DOWN, F1 - F12.

Tested By:

Add Custom Key for SOL on webui

To support VT100+ extensions for SOL on webui, add custom key
into xtermjs to handle key Backspace, DEL, HOME, END, INSERT,
PAGE UP, PAGE DOWN, F1 - F12.

Tested By:
After added item "customKeyEnable": true, "keyType" : "VT100+" into
iconfig.json.
Under EFI SHELL: Backspace, DEL, HOME, END, INSERT, PAGE UP, PAGE DOWN,
F1 - F12 keys can work as local keyboard in Web SOL.
Under linux with $TERM=vt100+: Backspace, DEL, HOME, END, INSERT,
PAGE UP, PAGE DOWN, F1 - F12 keys can work as local keyboard in Web SOL.
If not add "customKeyEnable" or "keyType", into config.json, Backspace,
DEL, HOME, END, INSERT, PAGE UP, PAGE DOWN, F1 - F12 keys can work
correctly in linux OS with $TERM=vt220 in SOL.
Other keys such as a-z can always work in SOL no matter "customKeyEnable"
or "keyType" is inserted into config.json.

Change-Id: Ifb196ec37080781033c0d6a3b0688baa7d0080b5
Signed-off-by: Cheng C Yang <cheng.c.yang@linux.intel.com>

show more ...

Fix inventory dropdown

Dropdown on hardware page was cutting off text. Changes styling
so that table is in line and all information is displayed as
expected. If information exceeds dropdown size, a

Fix inventory dropdown

Dropdown on hardware page was cutting off text. Changes styling
so that table is in line and all information is displayed as
expected. If information exceeds dropdown size, a scroll bar
appears.

Tested: Appears to be displaying correctly using Chrome, Firefox
and Safari.

Change-Id: Ib1531c59865a7d7bf4ea1ded7277702e9cd53b8b
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Clean up headers

Updates headers to match style guide and makes them consistent
throughout pages in the GUI. Removes instances where a header
element existed and a different header style was being a

Clean up headers

Updates headers to match style guide and makes them consistent
throughout pages in the GUI. Removes instances where a header
element existed and a different header style was being applied.
For example, <h2 class="h4">

Tested: Ran GUI locally and verified that headers look consistent
and have the appropriate sizing while using Chrome, Firefox and
Safari.

Change-Id: I187136298ed2bfd36c40c2b80d5a4f20947cbe56
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Fix layout for responsive design: Header

Get rid of "BMC host/IP address" & "server info" text, make the
buttons tighter and make more buttons visible in header so that
the information is more usefu

Fix layout for responsive design: Header

Get rid of "BMC host/IP address" & "server info" text, make the
buttons tighter and make more buttons visible in header so that
the information is more useful to users in tablet view.

Change-Id: I6b4166390b1828fca265e7bb56f51106b4e6f21b
Signed-off-by: Ryan Arnell <iffy.ryan@ibm.com>

show more ...

Remove angular-websocket dependency

The WebUI does not use angular-websocket for websockets instead
uses https://developer.mozilla.org/en-US/docs/Web/API/WebSocket/WebSocket
https://github.com/openb

Remove angular-websocket dependency

The WebUI does not use angular-websocket for websockets instead
uses https://developer.mozilla.org/en-US/docs/Web/API/WebSocket/WebSocket
https://github.com/openbmc/phosphor-webui/blob/457ca04073ff10cb1df2e7c5ab5192430a2ac6a9/app/common/directives/serial-console.js#L38

This unused dependency was found with depcheck.

Tested: Built this code and loaded it onto a Witherspoon.
Still see the SOL console.
Change-Id: Iffc1f31f94ae0ff5bf7173d06208b1c7bef6ca2a
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Make default redfishSupportEnabled

redfishSupportEnabled now defaults to true.
The standard rest-server is bmcweb which has redfish support
included.

Creating a new user and chanding a users passwo

Make default redfishSupportEnabled

redfishSupportEnabled now defaults to true.
The standard rest-server is bmcweb which has redfish support
included.

Creating a new user and chanding a users password on the
user management does not work with
redfishSupportEnabled = false. This is due to neither bmcweb
or phosphor-rest-server having a SetPassword API.

Resolves openbmc/openbmc#3454

Tested: The user management page on Witherspoon.
Change-Id: I35f6b6b644cddb4135ff5b41c3a3b74134eb6ecb
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

NPM update

Observed this security vulnerability in the phosphor-webui
repo on GitHub:
"We found a potential security vulnerability in one of your
dependencies.
lodash vulnerability found in package-

NPM update

Observed this security vulnerability in the phosphor-webui
repo on GitHub:
"We found a potential security vulnerability in one of your
dependencies.
lodash vulnerability found in package-lock.json
Upgrade lodash to version 4.17.11 or later."

See https://nvd.nist.gov/vuln/detail/CVE-2018-16487 for more
information.
Ran "NPM update" && "npm install lodash@latest --save".

Tested: Built the GUI and loaded it on a Witherspoon. No
regressions observed

Change-Id: I0b848a6aedea699a1b1a26f58c342ff781618a3d
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Fix login and overview pages in Safari

Bootstrap 4 columns in Safari are not working as expected,
causing issues with the layout on the login and overview
pages. Small CSS change resolves issue, see

Fix login and overview pages in Safari

Bootstrap 4 columns in Safari are not working as expected,
causing issues with the layout on the login and overview
pages. Small CSS change resolves issue, see
https://github.com/twbs/bootstrap/issues/24219

Tested: Layout appears to be fixed using Safari. No pages
are affected visually by the change when using Chrome or
Firefox.

Change-Id: I79bf6ef3734703e4f610ee7f95b75625538761c2
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Add role alert to toasts

For accessibility reasons, 'role="alert" is required for toast
messages. This notifies screen readers that an error or success
message has appeared. Adds a service layer for

Add role alert to toasts

For accessibility reasons, 'role="alert" is required for toast
messages. This notifies screen readers that an error or success
message has appeared. Adds a service layer for toast messages
that adds the role attribute to the message.

Change-Id: Ic4dbf5556337eea589de5692c1b4c3323e771813
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Form validation on login page

Using ngMessages, adds form validation to login page. Also creates a
directive, hasError, to be used to validate form field by passing
in a boolean. This is a proposed

Form validation on login page

Using ngMessages, adds form validation to login page. Also creates a
directive, hasError, to be used to validate form field by passing
in a boolean. This is a proposed pattern to be used moving forward,
as form validation is added to additional pages.

Validation error messages are shown on $touched and on submit.
Unreachable Server and Invalid username and password error messages
remain until input is no longer $pristine after form submission.

In addition, this removes unneeded and unused css styling

Resolves openbmc/phosphor-webui#47

Change-Id: I7a067af67ac74d4cf2977d10f66445720ecae9eb
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Fix table header

Makes the table header in sensor page stay fixed after scrolling.
Fixes the allignment of filter button.

Resolves openbmc/phosphor-webui#28

Change-Id: If9b8b0848169b5924b811e67588

Fix table header

Makes the table header in sensor page stay fixed after scrolling.
Fixes the allignment of filter button.

Resolves openbmc/phosphor-webui#28

Change-Id: If9b8b0848169b5924b811e67588ff57c8dae7c5c
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>

show more ...

Add ngMessages

Brings in the angular ngMessages directive to be used for form
validation.

Adds 1.057KB to finished javascript package

Change-Id: I367672c4871040e92cd530abb6f23a5f86912f5f
Signed-of

Add ngMessages

Brings in the angular ngMessages directive to be used for form
validation.

Adds 1.057KB to finished javascript package

Change-Id: I367672c4871040e92cd530abb6f23a5f86912f5f
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Fix issue for responsive design: Login screen

This push fixes the issue of the logo and input alignment in login
screen on tablets portrait and landscape mode. They are centrally
aligned in these vi

Fix issue for responsive design: Login screen

This push fixes the issue of the logo and input alignment in login
screen on tablets portrait and landscape mode. They are centrally
aligned in these views. Gets rid of the unwanted horizontal scrollbar
in tablets.

Change-Id: I31fd9caa881e0ffb6b1cd58701d911ee916dd419
Signed-off-by: Ryan Arnell <iffy.ryan@ibm.com>

show more ...

Fix error log resolve

logging/entry/<entryId>/attr/Resolved is a boolean as such
send true when resolving.

Before the function was always returning successful, fixed this
and log to the console whe

Fix error log resolve

logging/entry/<entryId>/attr/Resolved is a boolean as such
send true when resolving.

Before the function was always returning successful, fixed this
and log to the console when it fails.

Tested: Resolved multiple error logs and see the fail in the
console on a fail.
Change-Id: I60496f30f9241ffb6b6b73cf87b7481bea10b24f
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

webui: user management bug fixes

Bug fixes in user management
- Removed granular error messages which is causing
issues in non-redfish (rest api) case.
- Set default password show button state.

webui: user management bug fixes

Bug fixes in user management
- Removed granular error messages which is causing
issues in non-redfish (rest api) case.
- Set default password show button state.
- Delete button missing in table issue fix.
- Role dropdown not proper issue fix.
- Associating label element with 'for' attributes.

Change-Id: I6c5bb25837bb2fcbcb131a88060e6acf603ca5a2
Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>

show more ...

Firmware: Remove unnecessary promises

From the firmware functions in api-utils.js, don't create a new
promise.

Tested: Changed Priority, deleted, and activated images.
Change-Id: I53e4def6dda2e1868

Firmware: Remove unnecessary promises

From the firmware functions in api-utils.js, don't create a new
promise.

Tested: Changed Priority, deleted, and activated images.
Change-Id: I53e4def6dda2e1868f65ccd365510cd84d01a065
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add toast to Firmware page

Replace error and success messages with toast notifications.

Change-Id: I6c68568b7c9db4fd1f85b3de843289cf1bfba376
Signed-off-by: beccabroek <beccabroek@gmail.com>