eda6e2b0 | 20-May-2019 |
Gunnar Mills <gmills@us.ibm.com> |
NPM update to address TAR vulnerability
This security vulnerability is in the phosphor-webui repo: "We found a potential security vulnerability in one of your dependencies. tar Upgrade tar to vers
NPM update to address TAR vulnerability
This security vulnerability is in the phosphor-webui repo: "We found a potential security vulnerability in one of your dependencies. tar Upgrade tar to version 4.4.2 or later."
See https://nvd.nist.gov/vuln/detail/CVE-2018-20834 for more information.
Ran "NPM update" && "npm install node-sass@latest --save".
Before:
bash-4.1$ npm audit
....
found 3 high severity vulnerabilities in 12118 scanned packages run `npm audit fix` to fix 3 of them.
After:
bash-4.1$ npm audit
=== npm audit security report ===
found 0 vulnerabilities in 12124 scanned packages
Resolves https://github.com/openbmc/phosphor-webui/issues/85
Tested: Built the GUI and loaded it on a Witherspoon. No regressions observed.
Change-Id: I67cf4111021d7097a4a0726fecc320853810c6fd Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
a1b5fb6a | 17-May-2019 |
Gunnar Mills <gmills@us.ibm.com> |
Remove unused interpolate
Interpolate was used prior to the ngToast. https://github.com/openbmc/phosphor-webui/commit/92d13b62f56fa302a8231690e7371c6ae04f50ba#diff-bbc57e73eb8aa4f1c2de7b8e033393e3 m
Remove unused interpolate
Interpolate was used prior to the ngToast. https://github.com/openbmc/phosphor-webui/commit/92d13b62f56fa302a8231690e7371c6ae04f50ba#diff-bbc57e73eb8aa4f1c2de7b8e033393e3 moved to ngToast and removed the use of interpolate.
Tested: Build this and the commits below and loaded onto a Witherspoon system. Did a power on, warm reboot, and immediate shutdown. Change-Id: I99c2f3705df413fc744066dd34ba38a383c174fc Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
aa4734d5 | 17-May-2019 |
Gunnar Mills <gmills@us.ibm.com> |
Added comments to help clarify "confirm"
For the next person digging in this code. :)
Change-Id: Ib6c21da3fb53a4277a90bf2e5cab90ed29496724 Signed-off-by: Gunnar Mills <gmills@us.ibm.com> |
f61631eb | 17-May-2019 |
Gunnar Mills <gmills@us.ibm.com> |
Remove done TODO
This TODO is complete, remote it.
Change-Id: Ifb775aa932bf54e790ff60352611a716f2d7fb02 Signed-off-by: Gunnar Mills <gmills@us.ibm.com> |
834eb010 | 17-May-2019 |
Gunnar Mills <gmills@us.ibm.com> |
Remove unused testState
Change-Id: I9235c146fcd1288add4eeaa209d0f7b12f4d394e Signed-off-by: Gunnar Mills <gmills@us.ibm.com> |
11f36032 | 17-May-2019 |
Gunnar Mills <gmills@us.ibm.com> |
Remove unused powerOnConfirm and powerConfirm
There is no confirm for Powering on the system. These were unused.
Change-Id: I4f5c3eb0a7676877ccbb0fef687ab525e585e428 Signed-off-by: Gunnar Mills <gm
Remove unused powerOnConfirm and powerConfirm
There is no confirm for Powering on the system. These were unused.
Change-Id: I4f5c3eb0a7676877ccbb0fef687ab525e585e428 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
6af5d294 | 17-May-2019 |
Gunnar Mills <gmills@us.ibm.com> |
Rename variables to follow lowerCamelCase
OpenBMC follows Google JavaScript Style Guide. https://google.github.io/styleguide/jsguide.html#naming-local-variable-names
https://github.com/openbmc/docs
Rename variables to follow lowerCamelCase
OpenBMC follows Google JavaScript Style Guide. https://google.github.io/styleguide/jsguide.html#naming-local-variable-names
https://github.com/openbmc/docs/blob/master/CONTRIBUTING.md#javascript
Change-Id: I0be270d8cb8f219f048626591e6b623c4307eef7 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
8e1bb0a9 | 17-May-2019 |
Gunnar Mills <gmills@us.ibm.com> |
Remove unused hostShutdown
hostShutdown in api-utils is not used. The Orderly shutdown on the power operations page calls APIUtils.hostPowerOff.
The immediate shutdown calls APIUtils.chassisPowerOf
Remove unused hostShutdown
hostShutdown in api-utils is not used. The Orderly shutdown on the power operations page calls APIUtils.hostPowerOff.
The immediate shutdown calls APIUtils.chassisPowerOff.
Tested: Did not. Searched the code and double checked the firmware panel and power operations panel. Change-Id: I6f0d209c3d2f13539bbe3ed2405221e902aaf590 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
c57ec32f | 26-Apr-2019 |
Dixsie Wolmers <dixsiew@gmail.com> |
Fix activate image and reboot BMC
- Change bmcReboot callback in apiutils.js to HTTP request that returns a promise that is resolved with response object - Remove emitted 'user-logged-in' as it is n
Fix activate image and reboot BMC
- Change bmcReboot callback in apiutils.js to HTTP request that returns a promise that is resolved with response object - Remove emitted 'user-logged-in' as it is not needed to reboot BMC on firmware controller and bmc reboot controller - Add toast message for visual confirmation of successful BMC reboot
Tested: On Server Configuration > Firmware page uploaded new image to activate and automatically reboot. After 2-3 minutes confirmed image activated and then BMC rebooted after image activation. Tested Server Control > Reboot BMC page by selecting Reboot BMC, confirmed BMC rebooted.
Resolves openbmc/phosphor-webui#79
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: Ied6809ad1ed6cc3c73ac5c818c7a06607810c396
show more ...
|
565efda5 | 16-Apr-2019 |
dixsie <dixsiew@gmail.com> |
Fix system overview edit hostname form validation
- Add pattern for no spaces - Fix character count - Prepopulate hostname in input field - Show error for invalid input - Improve form accessibility
Fix system overview edit hostname form validation
- Add pattern for no spaces - Fix character count - Prepopulate hostname in input field - Show error for invalid input - Improve form accessibility - Correct global disabled primary button style
Resolves openbmc/phosphor-webui#71
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: Ia0601ac7c52229d0606dc5b13397b468fa81426d
show more ...
|
de382089 | 30-Apr-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Add dropdown caret to time owner dropdown on Date and Time Settings
- Use background-image strategy to add caret to dropdowns - Standardize implementation by including mixin to dropdown__button cl
Add dropdown caret to time owner dropdown on Date and Time Settings
- Use background-image strategy to add caret to dropdowns - Standardize implementation by including mixin to dropdown__button class and removing styled pseudo element
Resolves ibm-openbmc/dev#478
Tested: Running locally on Chrome only. Ran into network request errors for newly added svg assets when mounting overlay
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I714c2515282676f368eafb2560177d2935680e23
show more ...
|
15486772 | 03-May-2019 |
Gunnar Mills <gmills@us.ibm.com> |
NPM update to partially address vulnerability
Observed this security vulnerability in the phosphor-webui repo on GitHub: "We found a potential security vulnerability in one of your dependencies. ta
NPM update to partially address vulnerability
Observed this security vulnerability in the phosphor-webui repo on GitHub: "We found a potential security vulnerability in one of your dependencies. tar Upgrade tar to version 4.4.2 or later."
See https://nvd.nist.gov/vuln/detail/CVE-2018-20834 for more information. Ran "NPM update" && "npm install tar@latest --save".
Unfortunately, this only addresses one of the packages that uses tar, the other, node-sass, has not published a release to fix this vulnerability. See https://github.com/sass/node-sass/issues/2625 Not a easy fix for node-sass.
Opened https://github.com/openbmc/phosphor-webui/issues/85 to track this work.
Tested: Built the GUI and loaded it on a Witherspoon. No regressions observed.
Change-Id: I9e06d77a03dff4a3d12f472fd18671cc8c41fcd4 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
615a2f89 | 17-Apr-2019 |
Gunnar Mills <gmills@us.ibm.com> |
Revert "WebUI: Sensors page modifications"
This reverts commit 2f481e4cb83f0c72a9f3aad11431e4abcf5d632c.
"/xyz/openbmc_project/sensors/power/" sensors (e.g. p0_vcs_power) and "/xyz/openbmc_project/
Revert "WebUI: Sensors page modifications"
This reverts commit 2f481e4cb83f0c72a9f3aad11431e4abcf5d632c.
"/xyz/openbmc_project/sensors/power/" sensors (e.g. p0_vcs_power) and "/xyz/openbmc_project/sensors/current/" sensors (e.g. p0_vcs_current) are no longer on the GUI Sensors Page.
Since all sensors do not map to Thermal or Power, the SensorCollection, /redfish/v1/Chassis/{ChassisId}/Sensors, needs to be implemented before we move the GUI sensors page over to Redfish.
The SensorCollection contains all sensors not covered elsewhere in the model.
The SensorCollection will contain all sensors under /current and all non-powersupply sensors under /power.
IBM is planning on working on the SensorCollection, it will be sometime before the code is in because of this, reverting moving the GUI sensor page over to Redfish.
Apologies on not catching this in the review.
For more information see: https://redfishforum.com/thread/190/sensorcollection-contain-all-sensors-chassis https://redfish.dmtf.org/schemas/SensorCollection.json
Tested: The current and power sensors are back on the Sensor page. Change-Id: Ia818fc05b49a8181b71f8756a6066c27e94dc46e Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
e5fb403d | 19-Apr-2019 |
Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> |
Pull the latest novnc package
Investigated that IKVM issues on Windows browsers were caused by old novnc package. Currently, webui downloads novnc 1.0.0 from npm but the version was released a year
Pull the latest novnc package
Investigated that IKVM issues on Windows browsers were caused by old novnc package. Currently, webui downloads novnc 1.0.0 from npm but the version was released a year ago so it doesn't have lots of bug fixes. Since novnc team published v1.1.0 recently so this commit updates novnc version to fix the Windows browser issue.
Tested: From Windows FireFox or Chrome browser, Navigated to 'Server control -> KVM'. KVM worked stably.
Change-Id: Iaf415f57678573fbbb7c2f33234a63da6c50acd9 Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
show more ...
|
e9211cb3 | 22-Apr-2018 |
Ed tanous <ed@tanous.net> |
Implement KVM in webui
This patchset adds the infrastructure to allow KVM sessions through the webui. A websocket capable VNC/RFB connection on the BMC is needed for KVM sessions.
To access, naviga
Implement KVM in webui
This patchset adds the infrastructure to allow KVM sessions through the webui. A websocket capable VNC/RFB connection on the BMC is needed for KVM sessions.
To access, navigate to Server control -> KVM.
Tested: Ran obmc-ikvm on the BMC, added a KVM Handler to Phosphor Rest Server, and was able to establish a KVM session in the webui on a Witherspoon. Change-Id: I7dda5bec41d270ae8d0913697714d4df4ec3a257 Signed-off-by: Ed Tanous <ed.tanous@intel.com> Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
4733a11b | 10-Apr-2019 |
beccabroek <beccabroek@gmail.com> |
Firmware page upload not working in some cases
Upload was not working in some cases because of two separate issues. Inline onchange is no longer executed in Chrome. This removes the inline onchange
Firmware page upload not working in some cases
Upload was not working in some cases because of two separate issues. Inline onchange is no longer executed in Chrome. This removes the inline onchange event since it was updating a variable not being used anyway. This also updates the click-outside directive as it was missing [ ] brackets that were necessary and throwing an error in the console when loaded onto a witherspoon.
see https://developer.chrome.com/extensions/contentSecurityPolicy
and
https://stackoverflow.com/questions/35126898/error-after-minifica tion-of-angular-js-error-injectorunpr-unknown-provider
Resolves openbmc/phosphor-webui#77
Tested: Able to upload image onto Witherspoon. Click-outside directive worked when GUI was mounted on a Witherspoon
Change-Id: I7b1c385751e114b2d31f516e391dd0737117ab42 Signed-off-by: beccabroek <beccabroek@gmail.com>
show more ...
|
1ffa209e | 01-Apr-2019 |
Derick Montague <derick.montague@ibm.com> |
Resolve accessibility isssues
- Remove unecessary aria-roles - Associate label elements with form elements - Remove extraneous markup on Network settings page - Update generic markup to use definiti
Resolve accessibility isssues
- Remove unecessary aria-roles - Associate label elements with form elements - Remove extraneous markup on Network settings page - Update generic markup to use definition list when appropriate - Add aria-labels and aria-expanded to accordion triggers
Tested: Accessibility issues tested in using Lighthouse in Chrome Developer tools Audit section and Dequeue Axe extension. Manually tested clicking on labels set focus on the form elements. Visually tested of the Network Settings page in Chrome, Firefox, and Safari to verify layout changes.
Resolves openbmc/phosphor-webui#76
Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: Ib974c623e9d3b74e74e1f374c21e8191732ec26a
show more ...
|
a5deeeaf | 22-Mar-2019 |
beccabroek <beccabroek@gmail.com> |
Add form validation and toast messages to user mgmt
Adds form field validation with ng-messages and toast messages with toast service to the User management page. Also adds check that the number of
Add form validation and toast messages to user mgmt
Adds form field validation with ng-messages and toast messages with toast service to the User management page. Also adds check that the number of users does not exceed 15 and that the username does not already exist prior to sending call to the backend.
Resolves openbmc/phosphor-webui#73 Resolves openbmc/phosphor-webui#74
Tested: Able to add/delete/edit users as before. Page presents appropriate message to user upon creating or updating a user when: 1. A field is missing 2. Passwords don't match 3. Password is longer than max or shorter than min 4. Username already exists when creating new user 5. User tries to create the 16th user
Change-Id: I5ae1a7979f7a396b0fb2ea280b875afc805a7f9f Signed-off-by: beccabroek <beccabroek@gmail.com>
show more ...
|
2f481e4c | 29-Jan-2019 |
AppaRao Puli <apparao.puli@linux.intel.com> |
WebUI: Sensors page modifications
Modified sensors page to use Redfish as backend. Also added threshold sensor values in page view.
Tested By: Loaded webui page and tested all operations. - Sens
WebUI: Sensors page modifications
Modified sensors page to use Redfish as backend. Also added threshold sensor values in page view.
Tested By: Loaded webui page and tested all operations. - Sensors page load and layout. - Search Filter and Severity filters. - Export functionality.
Change-Id: Ic799453ffcd17e9a69e073a12173b4e97a928458 Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>
show more ...
|
3bf7b0c8 | 02-Apr-2019 |
dixsie <dixsiew@gmail.com> |
Correct typo on stylesheet comment
Signed-off-by: dixsie <dixsiew@gmail.com> Change-Id: I30023fe18310631132c232e94baba5d0445f5f55 |
ddda4dec | 28-Jan-2019 |
beccabroek <beccabroek@gmail.com> |
SNMP page visual redesign
Adds form validation to SNMP page. Also adds new icons to page for edit and delete. Validation messages for inputs appear after input has been touched or if the user attemp
SNMP page visual redesign
Adds form validation to SNMP page. Also adds new icons to page for edit and delete. Validation messages for inputs appear after input has been touched or if the user attempts to submit the form with validation errors.
Tested: Add, remove, and update SNMP was successful and functionality unchanged. Form did not allow invalid or empty values to submitted. Used Chrome, Safari, and Firefox to verify that visual design looked as expected.
Resolves openbmc/phosphor-webui#37
Change-Id: I7a97d80724e56d2f22c74ac1251041270bbc35ad Signed-off-by: beccabroek <beccabroek@gmail.com>
show more ...
|
4693ddb2 | 27-Mar-2019 |
Gunnar Mills <gmills@us.ibm.com> |
User management: Remove disable redfish support
Removed redfishSupportEnabled = false for the user management page. The default is redfishSupportEnabled = true and no meta layers have redfishSupport
User management: Remove disable redfish support
Removed redfishSupportEnabled = false for the user management page. The default is redfishSupportEnabled = true and no meta layers have redfishSupportEnabled = false so unused upstream.
When redfishSupportEnabled = false, the /xyz/openbmc_project/user/<user>/action/SetPassword API is called.
Neither bmcweb or phosphor-rest-server have a SetPassword API and so the user management page did not work when redfishSupportEnabled = false.
The SetPassword API was removed when the new backend user management code was added, it was removed for security concerns.
See https://github.com/openbmc/openbmc/issues/3454 for more info.
Tested: On a Witherspoon, added users, updated roles and passwords, and deleted users. Change-Id: I3d9e30c0fc655fb23dee38fa5eeb52239c9faa64 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
f41ca4e6 | 28-Mar-2019 |
Derick Montague <derick.montague@ibm.com> |
Update hex values to meet WCAG AA Guidelines for color contrast
- Change #3C6DF0 to #2D60E5 - Change #E62325 to #DA1416
Tested: I spot tested the Server Overview, the Event log and
Update hex values to meet WCAG AA Guidelines for color contrast
- Change #3C6DF0 to #2D60E5 - Change #E62325 to #DA1416
Tested: I spot tested the Server Overview, the Event log and System logs pages to verify color changes and overall validate the update does not negatively impact the visual integrity of the app.
Resolves openbmc/phosphor-webui#70
Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: I2315527a98937176b3e3a2a2118e1798fa4c9e5d
show more ...
|
b1e7c863 | 12-Mar-2019 |
AppaRao Puli <apparao.puli@linux.intel.com> |
WebUI: Support for configure failed login attempts
This commit adds the support for failed login attempts configuration. With this user can configure the number of failed login attempts and account
WebUI: Support for configure failed login attempts
This commit adds the support for failed login attempts configuration. With this user can configure the number of failed login attempts and account lockout duration. This also adds provision to view other user account properties like MaxPassword, MinPassword etc.
Tested By: Loaded the Webui and modified values like Failed login Attempts and Account lockout duration. Also tested other account properties view.
Change-Id: I6abd5a16771956640ba6b6d81c1c7ad9503067b1 Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>
show more ...
|
b5c5dc5d | 21-Mar-2019 |
beccabroek <beccabroek@gmail.com> |
Fix login error message
Respose for invalid credentials changed and login page was no longer displaying the correct error message to the user when invalid credentials were entered.
Resolves openbmc
Fix login error message
Respose for invalid credentials changed and login page was no longer displaying the correct error message to the user when invalid credentials were entered.
Resolves openbmc/phosphor-webui#72
Tested: Logged in with incorrect credentials and saw the correct message. Also logged in with an unreachable host and saw that that message was displaying correctly.
Change-Id: I65cc6d6a061986568aded09555c5f75bcd59fe56 Signed-off-by: beccabroek <beccabroek@gmail.com>
show more ...
|