4b366b5a | 24-Sep-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Clean up icons
Clean up duplicate svg icons from assets directory. Created a statusIcon component to dynamically render status icons instead of using background-image in scss files.
- Moved/removed
Clean up icons
Clean up duplicate svg icons from assets directory. Created a statusIcon component to dynamically render status icons instead of using background-image in scss files.
- Moved/removed on, off, critical, warning svg icons from assets directory - Updated background-image status icons to use <icon> or <status-icon> directive
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: Ic0f06d78b0861d6f60d40b2dcc0b80fd6dad2a88
show more ...
|
4986603e | 18-Sep-2019 |
Derick Montague <derick.montague@ibm.com> |
Add error messaging for error log date filtering and Safari support
- Updated filters to use semantic markup (fieldset) - Added check for input date type support and updated expected date format t
Add error messaging for error log date filtering and Safari support
- Updated filters to use semantic markup (fieldset) - Added check for input date type support and updated expected date format to the legend - Added error message if date format is invalid - Updated layout to support error message
Tested the changes in the following browsers: - Safari - IE 11 - Chrome - Edge - Firefox
Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: If0b874644b80640dc5bfd8211459c012807ea492
show more ...
|
e368108f | 21-Jun-2019 |
Dixsie Wolmers <dixsiew@gmail.com> |
Add boot option override and TPM enable toggle
- Adds ability to set a bootsource override to allowable target value - Adds ability to enable or disable TPM required policy - Replaces power operatio
Add boot option override and TPM enable toggle
- Adds ability to set a bootsource override to allowable target value - Adds ability to enable or disable TPM required policy - Replaces power operations confirm directive with bootstrap modal
Tested: Confirmed override settings saved to redfish but unable to verify if settings are automatically set to disabled by petitboot after a one time boot. Passes DAP.
Resolves openbmc/phosphor-webui#82 Resolves openbmc/phosphor-webui#90
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: If0ffd6f9328939d70c7958ee11fb90bd20a1e685 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
30d7c637 | 31-Jul-2019 |
Derick Montague <derick.montague@ibm.com> |
Update overview page to use new UI patterns
- Use page, section, list-pair to establish consistent layout - Update header and overview page to use new caret icon - Reordered Server and BMC infor
Update overview page to use new UI patterns
- Use page, section, list-pair to establish consistent layout - Update header and overview page to use new caret icon - Reordered Server and BMC information to accomodate small screen views - Added chevron icons to create consistency between header and server overview page quick links - Changed edit hostname text to use the standard icon - Added OR operator to short circuit the server model, server serial number, and server manufacturer to display N/A if the information is not available
Change-Id: I6619f5369ff290555142e85aa432e901c4f93d2d Signed-off-by: Derick Montague <derick.montague@ibm.com>
show more ...
|
6f7ec80e | 24-Jun-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Clean up color values
This update will clean up slight color variations in the code base by creating and using Sass color variables instead of hex values. Available colors are defined in colors.scss
Clean up color values
This update will clean up slight color variations in the code base by creating and using Sass color variables instead of hex values. Available colors are defined in colors.scss. Any usage of CSS color properties should refer to the mapped color variables in colors.scss.
- Removed tags.scss file since tag components no longer used
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I045030a158469e59d07a9fa8cd8aa9f125f0d383
show more ...
|
1f690f3e | 23-Jun-2019 |
Derick Montague <derick.montague@ibm.com> |
Fix sensors table header and body alignment
- Update markup to use semenatic table - Update table to flex based layout to support responsive table design
Tested: Small screen and large screen lay
Fix sensors table header and body alignment
- Update markup to use semenatic table - Update table to flex based layout to support responsive table design
Tested: Small screen and large screen layout in Chrome, Firefox, and Safari. Safari has issues with the sticky header, which is an acceptable trade off and meets cross-browser standards.
Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: I8ea323e45a2659562f229d4fd6d4e53887664cad
show more ...
|
c86ce3c9 | 05-Jun-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Consolidate button styles
This patchset will create consistent button styling according to the styleguide and remove redundant button styles by creating reusable button classes.
This patchset also
Consolidate button styles
This patchset will create consistent button styling according to the styleguide and remove redundant button styles by creating reusable button classes.
This patchset also implements a consistent strategy for including icon assets. Currently, svg icons are imported as CSS background images or inlined into the markup. Inlining an svg is preferred, especially when used with buttons or links so the colors can be easily changed for different states (hover, focus, disabled) without having to request variants. The icon provider allows us to inline svgs without cluttering the markup. Webpack config was adjusted to use svg-inline-loader when resolving svgs that are used by the icon provider directive.
- All svgs were optimized to remove unncessary information. - Removed unused svg color variants - Moved icons used by icon provider to separate directory to avoid Webpack parsing the files twice - Small changes to navigation icons
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I1ca214b74fc502e6b6e760cfee88b48110237c43
show more ...
|
e4194ce0 | 24-May-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Add remote logging server
Remote logging enables the user to configure a remote server to stream out local logs. This feature will be available on the Event Log page. The user can add a remote serve
Add remote logging server
Remote logging enables the user to configure a remote server to stream out local logs. This feature will be available on the Event Log page. The user can add a remote server, edit/change an existing server configuration and remove/disable the remote server.
Resolves openbmc/phosphor-webui#68
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I8284cbdbdaaf85f5c95f237efc72290c66904b40
show more ...
|
5bd1dec7 | 16-May-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Change button styles from rounded to straight corners
This will create more visual consistency between the components in the GUI since there are elements, such as text fields and dropdowns that are
Change button styles from rounded to straight corners
This will create more visual consistency between the components in the GUI since there are elements, such as text fields and dropdowns that are styled with straight corners.
- Removes border radius from buttons - Removes some redundant styles - Adds input types that aren't currently inheriting defined styles
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I6ff1bde91e2e57df01484dd20003925cd914ffa2
show more ...
|
6a3b3b2c | 16-May-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Fix tablet alignment issues for event logs
This will make sure our event log content is properly aligned on tablet and desktop views. It will also make the date/time value on the server overview pag
Fix tablet alignment issues for event logs
This will make sure our event log content is properly aligned on tablet and desktop views. It will also make the date/time value on the server overview page always display underneath the 'BMC time' label in a destkop view–currently the date value will wrap to a new line if the string is too long.
- Update markup to use Foundation grid layout classes on the server overview event log table
Tested: Event log tables on server overview page and event log page
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I7d765ebbe679f954e606d1d25e2182d983a7b3f3
show more ...
|
615a2f89 | 17-Apr-2019 |
Gunnar Mills <gmills@us.ibm.com> |
Revert "WebUI: Sensors page modifications"
This reverts commit 2f481e4cb83f0c72a9f3aad11431e4abcf5d632c.
"/xyz/openbmc_project/sensors/power/" sensors (e.g. p0_vcs_power) and "/xyz/openbmc_project/
Revert "WebUI: Sensors page modifications"
This reverts commit 2f481e4cb83f0c72a9f3aad11431e4abcf5d632c.
"/xyz/openbmc_project/sensors/power/" sensors (e.g. p0_vcs_power) and "/xyz/openbmc_project/sensors/current/" sensors (e.g. p0_vcs_current) are no longer on the GUI Sensors Page.
Since all sensors do not map to Thermal or Power, the SensorCollection, /redfish/v1/Chassis/{ChassisId}/Sensors, needs to be implemented before we move the GUI sensors page over to Redfish.
The SensorCollection contains all sensors not covered elsewhere in the model.
The SensorCollection will contain all sensors under /current and all non-powersupply sensors under /power.
IBM is planning on working on the SensorCollection, it will be sometime before the code is in because of this, reverting moving the GUI sensor page over to Redfish.
Apologies on not catching this in the review.
For more information see: https://redfishforum.com/thread/190/sensorcollection-contain-all-sensors-chassis https://redfish.dmtf.org/schemas/SensorCollection.json
Tested: The current and power sensors are back on the Sensor page. Change-Id: Ia818fc05b49a8181b71f8756a6066c27e94dc46e Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
2f481e4c | 29-Jan-2019 |
AppaRao Puli <apparao.puli@linux.intel.com> |
WebUI: Sensors page modifications
Modified sensors page to use Redfish as backend. Also added threshold sensor values in page view.
Tested By: Loaded webui page and tested all operations. - Sens
WebUI: Sensors page modifications
Modified sensors page to use Redfish as backend. Also added threshold sensor values in page view.
Tested By: Loaded webui page and tested all operations. - Sensors page load and layout. - Search Filter and Severity filters. - Export functionality.
Change-Id: Ic799453ffcd17e9a69e073a12173b4e97a928458 Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>
show more ...
|
a2e36e0f | 31-Dec-2018 |
AppaRao Puli <apparao.puli@linux.intel.com> |
WebUI: Adding Filters support to system logs
Adding Filter support to system logs page - Severity filter. - Date filter with start and end date. - Filter by Sensort Type.
Tested By: Loaded Sys
WebUI: Adding Filters support to system logs
Adding Filter support to system logs page - Severity filter. - Date filter with start and end date. - Filter by Sensort Type.
Tested By: Loaded System logs page with type selection 'Event' and check all filters.
Change-Id: I41eba4cd59c0f3c2933637bf0e207a3eca3214f1 Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>
show more ...
|
b1289ec9 | 14-Nov-2018 |
AppaRao Puli <apparao.puli@linux.intel.com> |
WebUI system logs implementation
This commit implements the webui logs page which will show all system logs depends on user selection( SEL or Event or Oem). This is based out of redfish systems log
WebUI system logs implementation
This commit implements the webui logs page which will show all system logs depends on user selection( SEL or Event or Oem). This is based out of redfish systems log services. - View logs with pagination. - Search filter for logs view. - Sort option with Type, Id, Severity, Date. - Clear logs. - Export logs.
UnitTest: - Existing bmcweb send the system logs of EntryType "Event". So Loaded UI, selected Type "Event" and validated all the above mentioned operations.
Change-Id: I0384e475f7913ca66b6db5d64831583fb382f8d5 Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>
show more ...
|
dde251d5 | 13-Mar-2019 |
beccabroek <beccabroek@gmail.com> |
Checkbox disabled when 0 event logs
The 'select all' box on event log page should be disabled when there are no event logs presented to the user. Also adds a message to the user when there are no lo
Checkbox disabled when 0 event logs
The 'select all' box on event log page should be disabled when there are no event logs presented to the user. Also adds a message to the user when there are no logs or there are no logs with their selected filters applied.
Resolves openbmc/phosphor-webui#44
Tested: Checked that correct user message appears when there are no logs and when the logs are all filtered out. Also that when there are no logs presented to the user, the select all box is disabled.
Change-Id: I3106426a72d2148a323ceed978bcdd5515096e2b Signed-off-by: beccabroek <beccabroek@gmail.com>
show more ...
|
129779dd | 14-Feb-2019 |
beccabroek <beccabroek@gmail.com> |
Fix inventory dropdown
Dropdown on hardware page was cutting off text. Changes styling so that table is in line and all information is displayed as expected. If information exceeds dropdown size, a
Fix inventory dropdown
Dropdown on hardware page was cutting off text. Changes styling so that table is in line and all information is displayed as expected. If information exceeds dropdown size, a scroll bar appears.
Tested: Appears to be displaying correctly using Chrome, Firefox and Safari.
Change-Id: Ib1531c59865a7d7bf4ea1ded7277702e9cd53b8b Signed-off-by: beccabroek <beccabroek@gmail.com>
show more ...
|
97280b3e | 16-Nov-2018 |
Iftekharul Islam <iffy.ryan@ibm.com> |
Fix table header
Makes the table header in sensor page stay fixed after scrolling. Fixes the allignment of filter button.
Resolves openbmc/phosphor-webui#28
Change-Id: If9b8b0848169b5924b811e67588
Fix table header
Makes the table header in sensor page stay fixed after scrolling. Fixes the allignment of filter button.
Resolves openbmc/phosphor-webui#28
Change-Id: If9b8b0848169b5924b811e67588ff57c8dae7c5c Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
show more ...
|
0b0e26de | 15-Nov-2018 |
Iftekharul Islam <iffy.ryan@ibm.com> |
Make actions visible in a disabled state
In event log page, main actions are made visible all the time in a disabled state. Once select a log item is selected, the corresponding actions become activ
Make actions visible in a disabled state
In event log page, main actions are made visible all the time in a disabled state. Once select a log item is selected, the corresponding actions become active.
Resolves openbmc/phosphor-webui#26
Change-Id: Idd7dced5984b7d103a706abc12c1e4889710d420 Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
show more ...
|
84e114a4 | 14-Nov-2018 |
Gunnar Mills <gmills@us.ibm.com> |
Move to Bootstrap 4
Bootstrap < 4.1.2 has the following CVE: https://nvd.nist.gov/vuln/detail/CVE-2018-14041
Removed bootstrap-theme.css due to "Replaced the separate optional theme with configurab
Move to Bootstrap 4
Bootstrap < 4.1.2 has the following CVE: https://nvd.nist.gov/vuln/detail/CVE-2018-14041
Removed bootstrap-theme.css due to "Replaced the separate optional theme with configurable options via SCSS variables (e.g., $enable-gradients: true)."
Added "width: 100%" to a few places where width 100% was no longer getting inherited. Moved a few elements and adjusted styles to get the same look as before.
See https://getbootstrap.com/docs/4.0/migration/ for more information.
Tested: Manually on a Witherspoon. Change-Id: I0a72665ac1ca6eacd0b553a585b1fb15e14ae62c Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
569ccf66 | 29-Oct-2018 |
beccabroek <beccabroek@gmail.com> |
Display log events in user time
Allows user to display events in their timezone or in UTC. Previously allowed either ETC or UTC, but listed ETC as 'user timezone'. Updates date time page from GMT o
Display log events in user time
Allows user to display events in their timezone or in UTC. Previously allowed either ETC or UTC, but listed ETC as 'user timezone'. Updates date time page from GMT offset to UTC offset for overall consistency. Also updates overview page to list critical events in user timezone
Resolves openbmc/phosphor-webui#36
Tested: changed timezone settings locally and validated that correct timezone and UTC offset was presented in the UI.
Change-Id: I89ca5045eeb789527aa07f5b1baebaa3fbd6b1fa Signed-off-by: beccabroek <beccabroek@gmail.com>
show more ...
|
52b8bde9 | 21-Jun-2018 |
Gunnar Mills <gmills@us.ibm.com> |
Add Power Usage Page
Created a new page, "Manage Power Usage". This page is under the "Server control" tab. This new page currently just displays the power consumption. Future commits will allow the
Add Power Usage Page
Created a new page, "Manage Power Usage". This page is under the "Server control" tab. This new page currently just displays the power consumption. Future commits will allow the user to set the power cap from this page. One day, things like power consumption trending data could also be on this page.
There was a blank unused controller which was for similar things, removed it.
Tested: See the page and the consumption data. Uploaded screenshots to openbmc/openbmc#3221 Change-Id: I9f97c58a086f34c1c1990c03d5e05b081619bd5c Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
fc0cfc59 | 18-Jul-2018 |
Gunnar Mills <gmills@us.ibm.com> |
Remove diagnostics page
This page was unused and unreachable from the menu. Cleaning up the code base.
Change-Id: Icebccb111f0d775cc6bd2c95a5588f67a75af9cf Signed-off-by: Gunnar Mills <gmills@us.ib
Remove diagnostics page
This page was unused and unreachable from the menu. Cleaning up the code base.
Change-Id: Icebccb111f0d775cc6bd2c95a5588f67a75af9cf Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
4b1f24c7 | 11-Jul-2018 |
Gunnar Mills <gmills@us.ibm.com> |
Move server LED files
The WebUI has a main menu with 5 options: Server overview, Server health, Server control, Server Configuration, Users.
These 5 main menu items each have a directory in /app/,
Move server LED files
The WebUI has a main menu with 5 options: Server overview, Server health, Server control, Server Configuration, Users.
These 5 main menu items each have a directory in /app/, although the directory names differ slightly. These 5 main menu items are also modules whose content includes their sub-menu items (again names differ slightly).
E.g. "Firmware" and "Network settings" are sub-menu items of the main menu item "Server configuration" which is located in the app/configuration dir and part of the app.configuration module.
The Server LED sub menu item did not follow this pattern and was under the wrong directory and in the wrong module. Moved it. In a future commit I renamed it from unit-id.
Tested: Verified server LED still works. Change-Id: I02e3a7995cf8ccc5b487c345866651d984c8d70c Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
13ac3af4 | 20-Mar-2018 |
Iftekharul Islam <iffy.ryan@ibm.com> |
Adding new button 'Normal' in sensors page
- Adding a 3rd option called Normal in addition to Critical and Warning based on the discussion in openbmc/openbmc#2750
Fixes openbmc/openbmc#2750
Teste
Adding new button 'Normal' in sensors page
- Adding a 3rd option called Normal in addition to Critical and Warning based on the discussion in openbmc/openbmc#2750
Fixes openbmc/openbmc#2750
Tested: Verified the 'Normal' button works. Change-Id: Ied4d37aa9284392f08818f8111ebbcc677234586 Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com> Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
db28a387 | 02-Nov-2017 |
Iftekharul Islam <iffy.ryan@ibm.com> |
Updating images and stles
Updating images and styles after code merge conflicts
Change-Id: I96490926caa41d13e4d625ff67f6a463d7819d34 Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com> |