Clean up icons

Clean up duplicate svg icons from assets directory.
Created a statusIcon component to dynamically render
status icons instead of using background-image in
scss files.

- Moved/removed

Clean up icons

Clean up duplicate svg icons from assets directory.
Created a statusIcon component to dynamically render
status icons instead of using background-image in
scss files.

- Moved/removed on, off, critical, warning svg icons from
assets directory
- Updated background-image status icons to use <icon>
or <status-icon> directive

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ic0f06d78b0861d6f60d40b2dcc0b80fd6dad2a88

show more ...

Fix filter bar clear filter button

Makes filter button screen reader friendly
and accessible.

- Adds icon directive for close icon
- Adds button type
- Icon is aria-hidden and uses an aria-label at

Fix filter bar clear filter button

Makes filter button screen reader friendly
and accessible.

- Adds icon directive for close icon
- Adds button type
- Icon is aria-hidden and uses an aria-label attribute with
the value set to clear filter

Tested:
- Filter inputs clear on close button click

Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: Ifcbe603c2771156fe7a03359b144e0a0acd5e3f1

show more ...

Fix sensors table header and body alignment

- Update markup to use semenatic table
- Update table to flex based layout to support responsive
table design

Tested: Small screen and large screen lay

Fix sensors table header and body alignment

- Update markup to use semenatic table
- Update table to flex based layout to support responsive
table design

Tested: Small screen and large screen layout in Chrome,
Firefox, and Safari. Safari has issues with the
sticky header, which is an acceptable trade off
and meets cross-browser standards.

Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I8ea323e45a2659562f229d4fd6d4e53887664cad

show more ...

Consolidate button styles

This patchset will create consistent button styling according
to the styleguide and remove redundant button styles by creating
reusable button classes.

This patchset also

Consolidate button styles

This patchset will create consistent button styling according
to the styleguide and remove redundant button styles by creating
reusable button classes.

This patchset also implements a consistent strategy for including
icon assets. Currently, svg icons are imported as CSS background
images or inlined into the markup. Inlining an svg is preferred,
especially when used with buttons or links so the colors can
be easily changed for different states (hover, focus, disabled)
without having to request variants.
The icon provider allows us to inline svgs without cluttering
the markup. Webpack config was adjusted to use svg-inline-loader
when resolving svgs that are used by the icon provider directive.

- All svgs were optimized to remove unncessary information.
- Removed unused svg color variants
- Moved icons used by icon provider to separate directory to
avoid Webpack parsing the files twice
- Small changes to navigation icons

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I1ca214b74fc502e6b6e760cfee88b48110237c43

show more ...

Revert "WebUI: Sensors page modifications"

This reverts commit 2f481e4cb83f0c72a9f3aad11431e4abcf5d632c.

"/xyz/openbmc_project/sensors/power/" sensors (e.g. p0_vcs_power)
and "/xyz/openbmc_project/

Revert "WebUI: Sensors page modifications"

This reverts commit 2f481e4cb83f0c72a9f3aad11431e4abcf5d632c.

"/xyz/openbmc_project/sensors/power/" sensors (e.g. p0_vcs_power)
and "/xyz/openbmc_project/sensors/current/" sensors
(e.g. p0_vcs_current) are no longer on the GUI Sensors Page.

Since all sensors do not map to Thermal or Power, the
SensorCollection, /redfish/v1/Chassis/{ChassisId}/Sensors,
needs to be implemented before we move the GUI sensors page
over to Redfish.

The SensorCollection contains all sensors not covered elsewhere
in the model.

The SensorCollection will contain all sensors under
/current and all non-powersupply sensors under /power.

IBM is planning on working on the SensorCollection, it will be
sometime before the code is in because of this, reverting
moving the GUI sensor page over to Redfish.

Apologies on not catching this in the review.

For more information see:
https://redfishforum.com/thread/190/sensorcollection-contain-all-sensors-chassis
https://redfish.dmtf.org/schemas/SensorCollection.json

Tested: The current and power sensors are back on the Sensor page.
Change-Id: Ia818fc05b49a8181b71f8756a6066c27e94dc46e
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

WebUI: Sensors page modifications

Modified sensors page to use Redfish as backend.
Also added threshold sensor values in page view.

Tested By:
Loaded webui page and tested all operations.
- Sens

WebUI: Sensors page modifications

Modified sensors page to use Redfish as backend.
Also added threshold sensor values in page view.

Tested By:
Loaded webui page and tested all operations.
- Sensors page load and layout.
- Search Filter and Severity filters.
- Export functionality.

Change-Id: Ic799453ffcd17e9a69e073a12173b4e97a928458
Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>

show more ...

Clean up headers

Updates headers to match style guide and makes them consistent
throughout pages in the GUI. Removes instances where a header
element existed and a different header style was being a

Clean up headers

Updates headers to match style guide and makes them consistent
throughout pages in the GUI. Removes instances where a header
element existed and a different header style was being applied.
For example, <h2 class="h4">

Tested: Ran GUI locally and verified that headers look consistent
and have the appropriate sizing while using Chrome, Firefox and
Safari.

Change-Id: I187136298ed2bfd36c40c2b80d5a4f20947cbe56
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Fix table header

Makes the table header in sensor page stay fixed after scrolling.
Fixes the allignment of filter button.

Resolves openbmc/phosphor-webui#28

Change-Id: If9b8b0848169b5924b811e67588

Fix table header

Makes the table header in sensor page stay fixed after scrolling.
Fixes the allignment of filter button.

Resolves openbmc/phosphor-webui#28

Change-Id: If9b8b0848169b5924b811e67588ff57c8dae7c5c
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>

show more ...

Present number of sensors available

- Following the same pattern as event logs
where number count of items are visible all the time

Resolves openbmc/phosphor-webui#29

Change-Id: I1c79c72f9a

Present number of sensors available

- Following the same pattern as event logs
where number count of items are visible all the time

Resolves openbmc/phosphor-webui#29

Change-Id: I1c79c72f9afa98eb834a4504543ed88e3973f034
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>

show more ...

Move to Bootstrap 4

Bootstrap < 4.1.2 has the following CVE:
https://nvd.nist.gov/vuln/detail/CVE-2018-14041

Removed bootstrap-theme.css due to "Replaced the separate optional
theme with configurab

Move to Bootstrap 4

Bootstrap < 4.1.2 has the following CVE:
https://nvd.nist.gov/vuln/detail/CVE-2018-14041

Removed bootstrap-theme.css due to "Replaced the separate optional
theme with configurable options via SCSS variables
(e.g., $enable-gradients: true)."

Added "width: 100%" to a few places where width 100% was no longer
getting inherited.
Moved a few elements and adjusted styles to get the same look as
before.

See https://getbootstrap.com/docs/4.0/migration/ for more
information.

Tested: Manually on a Witherspoon.
Change-Id: I0a72665ac1ca6eacd0b553a585b1fb15e14ae62c
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove tabs from HTML files

From https://google.github.io/styleguide/htmlcssguide.html
"Indentation
Indent by 2 spaces at a time.

Don't use tabs or mix tabs and spaces for indentation."

Tested: Ma

Remove tabs from HTML files

From https://google.github.io/styleguide/htmlcssguide.html
"Indentation
Indent by 2 spaces at a time.

Don't use tabs or mix tabs and spaces for indentation."

Tested: Manual regression testing on a Witherspoon.
Change-Id: Ief7137dabc869b73b73f9947337fbb0abb5ca497
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Adding new button 'Normal' in sensors page

- Adding a 3rd option called Normal in
addition to Critical and Warning based on the
discussion in openbmc/openbmc#2750

Fixes openbmc/openbmc#2750

Teste

Adding new button 'Normal' in sensors page

- Adding a 3rd option called Normal in
addition to Critical and Warning based on the
discussion in openbmc/openbmc#2750

Fixes openbmc/openbmc#2750

Tested: Verified the 'Normal' button works.
Change-Id: Ied4d37aa9284392f08818f8111ebbcc677234586
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Adding user friendly warning message in sensor page

fixes openbmc/openbmc#2748

Change-Id: I4370be0b921e7ba7ecb16afecf59a7246a0a4224
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>

Display order change in sensor overview page based on client feedback

Change-Id: I0930e94f6ac26c0649b44077768ff32c3a48cb3c
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>

Server health icon status on header fixed

Change-Id: I06100d8ffe9e26129585ca9476fa7097ef34a6b4
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>

Added search clear functionality to filtering

Change-Id: Id22b067c8bcc0e05aee6325153154ea7a81f17ae
Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>

Added loader and updated GUI text and style changes from Michael

Change-Id: Id4f8d96b10e429ca469c6169741588dbcc4b5c7a
Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>

loader animation added to pages

Change-Id: Id8c890714d0a90ae913b6581cd655abcf6cd6781
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

changes to global search filter:

- Added clear button to clear input
- changed submit to resize based on content

Change-Id: Ida69f961effc261dc44319ba8710d9b4349ba847
Signed-off-by: Michael Davis <m

changes to global search filter:

- Added clear button to clear input
- changed submit to resize based on content

Change-Id: Ida69f961effc261dc44319ba8710d9b4349ba847
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

show more ...

Fixed sensor page after merge conflicts

Change-Id: I9d4e0fb5d74feb681c9c9708e6efb62602b3e5eb
Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>

Add more examples to sensors page.

Change-Id: I2f0f951d26e22ca2294d873dcc4fe9ffd771ad37
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

Added hardware sensors functionality

Change-Id: I99435613bb77fc0ff72f046c2dc047b13962a7a3
Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>

start on sensors redesign.

Change-Id: Iab823cc3f4643a567b85a036c9dd4d78db02ad05
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

Text style fixes

Numerous minor style corrections (ex. lower vs upper case)

Change-Id: I0c77f590847d4978ac3ffbad82fc2acd481b70f9
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

Set sensor priorities based on threshold values

Change-Id: I8c0ad827937922fe85b030e6938c3c5a439bf6d6
Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>