Fix icon-warning syntax error

There were a few instances of the icon-warning icon that didn't
include the file extenstion needed to when adding the file attribute
property in the ico

Fix icon-warning syntax error

There were a few instances of the icon-warning icon that didn't
include the file extenstion needed to when adding the file attribute
property in the icon directive.

Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: Ib25c28c72285fa214f75258b0b09790d52bb6cc1

show more ...

Clean up icons

Clean up duplicate svg icons from assets directory.
Created a statusIcon component to dynamically render
status icons instead of using background-image in
scss fil

Clean up icons

Clean up duplicate svg icons from assets directory.
Created a statusIcon component to dynamically render
status icons instead of using background-image in
scss files.

- Moved/removed on, off, critical, warning svg icons from
assets directory
- Updated background-image status icons to use <icon>
or <status-icon> directive

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ic0f06d78b0861d6f60d40b2dcc0b80fd6dad2a88

show more ...

Fix filter bar clear filter button

Makes filter button screen reader friendly
and accessible.

- Adds icon directive for close icon
- Adds button type
- Icon is aria-hidd

Fix filter bar clear filter button

Makes filter button screen reader friendly
and accessible.

- Adds icon directive for close icon
- Adds button type
- Icon is aria-hidden and uses an aria-label attribute with
the value set to clear filter

Tested:
- Filter inputs clear on close button click

Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: Ifcbe603c2771156fe7a03359b144e0a0acd5e3f1

show more ...

Consolidate button styles

This patchset will create consistent button styling according
to the styleguide and remove redundant button styles by creating
reusable button classes.

Consolidate button styles

This patchset will create consistent button styling according
to the styleguide and remove redundant button styles by creating
reusable button classes.

This patchset also implements a consistent strategy for including
icon assets. Currently, svg icons are imported as CSS background
images or inlined into the markup. Inlining an svg is preferred,
especially when used with buttons or links so the colors can
be easily changed for different states (hover, focus, disabled)
without having to request variants.
The icon provider allows us to inline svgs without cluttering
the markup. Webpack config was adjusted to use svg-inline-loader
when resolving svgs that are used by the icon provider directive.

- All svgs were optimized to remove unncessary information.
- Removed unused svg color variants
- Moved icons used by icon provider to separate directory to
avoid Webpack parsing the files twice
- Small changes to navigation icons

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I1ca214b74fc502e6b6e760cfee88b48110237c43

show more ...

Resolve accessibility isssues

- Remove unecessary aria-roles
- Associate label elements with form elements
- Remove extraneous markup on Network settings page
- Update generic ma

Resolve accessibility isssues

- Remove unecessary aria-roles
- Associate label elements with form elements
- Remove extraneous markup on Network settings page
- Update generic markup to use definition list when appropriate
- Add aria-labels and aria-expanded to accordion triggers

Tested: Accessibility issues tested in using Lighthouse in Chrome
Developer tools Audit section and Dequeue Axe extension. Manually tested clicking on labels
set focus on the form elements. Visually tested of the Network
Settings page in Chrome, Firefox, and Safari to verify layout changes.

Resolves openbmc/phosphor-webui#76

Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: Ib974c623e9d3b74e74e1f374c21e8191732ec26a

show more ...

Fix inventory dropdown

Dropdown on hardware page was cutting off text. Changes styling
so that table is in line and all information is displayed as
expected. If information exceeds d

Fix inventory dropdown

Dropdown on hardware page was cutting off text. Changes styling
so that table is in line and all information is displayed as
expected. If information exceeds dropdown size, a scroll bar
appears.

Tested: Appears to be displaying correctly using Chrome, Firefox
and Safari.

Change-Id: Ib1531c59865a7d7bf4ea1ded7277702e9cd53b8b
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Clean up headers

Updates headers to match style guide and makes them consistent
throughout pages in the GUI. Removes instances where a header
element existed and a different header s

Clean up headers

Updates headers to match style guide and makes them consistent
throughout pages in the GUI. Removes instances where a header
element existed and a different header style was being applied.
For example, <h2 class="h4">

Tested: Ran GUI locally and verified that headers look consistent
and have the appropriate sizing while using Chrome, Firefox and
Safari.

Change-Id: I187136298ed2bfd36c40c2b80d5a4f20947cbe56
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Remove tabs from HTML files

From https://google.github.io/styleguide/htmlcssguide.html
"Indentation
Indent by 2 spaces at a time.

Don't use tabs or mix tabs and spaces for i

Remove tabs from HTML files

From https://google.github.io/styleguide/htmlcssguide.html
"Indentation
Indent by 2 spaces at a time.

Don't use tabs or mix tabs and spaces for indentation."

Tested: Manual regression testing on a Witherspoon.
Change-Id: Ief7137dabc869b73b73f9947337fbb0abb5ca497
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Display warning icons on non-functional subcomponents

Warning icons are now displayed only in subcomponents that are
present and non-functional. Only "present" subcomponents are
disp

Display warning icons on non-functional subcomponents

Warning icons are now displayed only in subcomponents that are
present and non-functional. Only "present" subcomponents are
displayed so only need to check for functional.
An example of using this is cores of the cpu. Only display
a warning on a present and non-functional core.

Resolves openbmc/openbmc#2989

Tested: Only see a warning on a non-functional core.
Change-Id: Ic22b7531de4dfcc445bfc5eae7dd23b0089f2cdf
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Only display "present" subcomponents

Only display "present" subcomponents of an inventory item.
An example of this would be cores of the cpu. Only display
present cores.

Tes

Only display "present" subcomponents

Only display "present" subcomponents of an inventory item.
An example of this would be cores of the cpu. Only display
present cores.

Tested: See only present cores.
Change-Id: Ib53d72d24e35f17a047baa15b1eaad0e099576a5
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Added search clear functionality to filtering

Change-Id: Id22b067c8bcc0e05aee6325153154ea7a81f17ae
Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>

Added loader and updated GUI text and style changes from Michael

Change-Id: Id4f8d96b10e429ca469c6169741588dbcc4b5c7a
Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>

Accessibility fixes:

- changed buttons to spans since not being used in forms
- added aria roles to html elements
- changed low contrast colors

Chang

Accessibility fixes:

- changed buttons to spans since not being used in forms
- added aria roles to html elements
- changed low contrast colors

Change-Id: I56e784b226baa7f9b24346446a0a023fcea633d4
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

show more ...

loader animation added to pages

Change-Id: Id8c890714d0a90ae913b6581cd655abcf6cd6781
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

removed subcomponent label. User feedback indicated it was unnecessary.

Change-Id: I34b3b27d8ee974d309d8ef11b5e5d4b57aee5bf3
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

changes to global search filter:

- Added clear button to clear input
- changed submit to resize based on content

Change-Id: Ida69f961effc261dc44319ba8710d9b4349ba847
Signed-

changes to global search filter:

- Added clear button to clear input
- changed submit to resize based on content

Change-Id: Ida69f961effc261dc44319ba8710d9b4349ba847
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

show more ...

usability and design changes for inventory

Change-Id: Ibd7f2be5223944646bdbb179673fee29603fa902
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

Add dynamic content to hardware inventory page

Change-Id: I3b34e58ada63c32e2476e37b7116232f5763bbdb
Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>

start on sensors redesign.

Change-Id: Iab823cc3f4643a567b85a036c9dd4d78db02ad05
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

Enhance hardware inventory layout

Change-Id: Ie013fdaa03a03682bb415a34e15155091fa3bf4a
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

Text style fixes

Numerous minor style corrections (ex. lower vs upper case)

Change-Id: I0c77f590847d4978ac3ffbad82fc2acd481b70f9
Signed-off-by: Michael Davis <michael.s.davis@ib

Text style fixes

Numerous minor style corrections (ex. lower vs upper case)

Change-Id: I0c77f590847d4978ac3ffbad82fc2acd481b70f9
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

show more ...

Change navigation structure

Change-Id: I12c819293ce1eda188dc9f257ae9370f1b73cb18
Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>

add inventory templates

Change-Id: I735465dc2d6ab0583586ece23380ea8570f024fa
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>