Make SOL layout responsive to the window changes

The current version of a SOL window layout have several
downsides:
-terminal content doesn't resize with the window changes
-when opened in a separat

Make SOL layout responsive to the window changes

The current version of a SOL window layout have several
downsides:
-terminal content doesn't resize with the window changes
-when opened in a separate window terminal content doesn't
use full viewport space
-when opened in a separate window terminal viewport takes
only a small part of the window

Screenshots with the problems descriptions are documented in
the github issue:
https://github.com/openbmc/phosphor-webui/issues/125

This commit adds responsiveness to the SOL layout.
The main SOL tab:
-terminal content automatically resizes with the viewport changes

The separate SOL window:
-XTERM always use full terminal viewport space
-terminal viewport width always equals window space width
-terminal viewport automatically resizes on window size changes
-terminal content automatically resizes with the viewport changes

As SOL UI is resposive now, this commit also removes fixed size
configurations for the SOL terminal via JSON 'customConsoleDisplaySize'
variable. It is worth noting that in reality it wasn't really
used anyway.

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Change-Id: Ia5d929e9a309281366a9d3119ac326ebd73c73f0

show more ...

Fix layout bugs on server power operations page

Add missing closing div tag that caused strange column layout
breaks.

Resolves openbmc/phosphor-webui#112

Tested: No longer see the problem on a Wit

Fix layout bugs on server power operations page

Add missing closing div tag that caused strange column layout
breaks.

Resolves openbmc/phosphor-webui#112

Tested: No longer see the problem on a Witherspoon.

Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I87f4947f60f95c7991df3f7c429ac51726a894b9

show more ...

Add CSRF check to more websockets

This adds the token to more websockets that were
missing it.

Change-Id: I633ce28ec9602d33a79d613f94582ba0ff265368
Signed-off-by: James Feist <james.feist@linux.int

Add CSRF check to more websockets

This adds the token to more websockets that were
missing it.

Change-Id: I633ce28ec9602d33a79d613f94582ba0ff265368
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Pass cookies into function

This was missed in the websocket upgrade.

Change-Id: Id2256fa87d728d71790d3046d280449feefe326c
Signed-off-by: James Feist <james.feist@linux.intel.com>

Add XSRF token into websocket request

Add XSRF token so we can implement CRSF checking
on websockets.

Tested: Saw it in bmcweb logs

Change-Id: Ie9479508bc69fad631f66fb282133ad18d025300
Signed-off-

Add XSRF token into websocket request

Add XSRF token so we can implement CRSF checking
on websockets.

Tested: Saw it in bmcweb logs

Change-Id: Ie9479508bc69fad631f66fb282133ad18d025300
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Fix icon-warning syntax error

There were a few instances of the icon-warning icon that didn't
include the file extenstion needed to when adding the file attribute
property in the icon directive.

Si

Fix icon-warning syntax error

There were a few instances of the icon-warning icon that didn't
include the file extenstion needed to when adding the file attribute
property in the icon directive.

Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: Ib25c28c72285fa214f75258b0b09790d52bb6cc1

show more ...

Update KVM layout and add open in new window functionality

-Adds heading with new layout consistency class name
-Adds open in new window functionality

Resolves: openbmc/phosphor-webui#81

Tested on

Update KVM layout and add open in new window functionality

-Adds heading with new layout consistency class name
-Adds open in new window functionality

Resolves: openbmc/phosphor-webui#81

Tested on a Witherspoon with power on and with build
that allows up to 4 kvm sessions connected
at a time https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/25231.

KVM console loads in firefox, chrome, safari, edge and IE11.
Opening new window and returning to parent window is
functional across all browsers.

Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I32cda025bdd459740ca2b42d573b431fac687860

show more ...

Clean up icons

Clean up duplicate svg icons from assets directory.
Created a statusIcon component to dynamically render
status icons instead of using background-image in
scss files.

- Moved/removed

Clean up icons

Clean up duplicate svg icons from assets directory.
Created a statusIcon component to dynamically render
status icons instead of using background-image in
scss files.

- Moved/removed on, off, critical, warning svg icons from
assets directory
- Updated background-image status icons to use <icon>
or <status-icon> directive

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ic0f06d78b0861d6f60d40b2dcc0b80fd6dad2a88

show more ...

Fix SoL and KVM refresh bug

Clicking the refresh button in the app header on the SoL and
KVM pages would fail to reload because the wrong element reference
is passed to the contructor after the relo

Fix SoL and KVM refresh bug

Clicking the refresh button in the app header on the SoL and
KVM pages would fail to reload because the wrong element reference
is passed to the contructor after the reload. Angular recommends
using directives for any DOM manipulation.

- Use the $element ref availble in serial-console.js directive to
select DOM element to open the terminal
- Switch kvm controller to directive to be able to use element ref
in the link function to select DOM element to pass as target

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ia7391e42bf335b8c3558d25df15c052db245ee3d

show more ...

Fix rounded button styling

Add 'btn' class on Reboot and Shutdown buttons on
power operations page to make sure borders aren't
rounded.

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Cha

Fix rounded button styling

Add 'btn' class on Reboot and Shutdown buttons on
power operations page to make sure borders aren't
rounded.

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I3369acd52ad1992d4340ef6c194b81b5dc0ce001

show more ...

Update boot override UI messaging visibility

When a user changes the boot setting override option
to 'None' on the Server power operations page, the
Enable one time boot checkbox should not be check

Update boot override UI messaging visibility

When a user changes the boot setting override option
to 'None' on the Server power operations page, the
Enable one time boot checkbox should not be checked and
'Pending one time boot' message should not be displayed.

- Removed duplicate id and unused ng-change attributes

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ia8771c2984fe41c64dde9b0c702b82a3d8305d7f

show more ...

Move Virtual Media files and route

"Virtual media" was already part of the "Server control" submenu but
the files were at app/configuration and the route was /configuration.

Marta Mazur did a simil

Move Virtual Media files and route

"Virtual media" was already part of the "Server control" submenu but
the files were at app/configuration and the route was /configuration.

Marta Mazur did a similar file and route move here as part of
supporting multiple Virtual Media endpoints:
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-webui/+/25218

Tested: Built and loaded on a Witherspoon. The VM route is now:
#/server-control/virtual-media. Was able to use the VM
panel.
Change-Id: Iec46a8ece7ddfbc356bc1e71875def70c4418027
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add boot option override and TPM enable toggle

- Adds ability to set a bootsource override to allowable target value
- Adds ability to enable or disable TPM required policy
- Replaces power operatio

Add boot option override and TPM enable toggle

- Adds ability to set a bootsource override to allowable target value
- Adds ability to enable or disable TPM required policy
- Replaces power operations confirm directive with bootstrap modal

Tested: Confirmed override settings saved to redfish but unable to verify
if settings are automatically set to disabled by petitboot after a
one time boot. Passes DAP.

Resolves openbmc/phosphor-webui#82
Resolves openbmc/phosphor-webui#90

Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: If0ffd6f9328939d70c7958ee11fb90bd20a1e685
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Update overview page to use new UI patterns

- Use page, section, list-pair to establish
consistent layout
- Update header and overview page to use new
caret icon
- Reordered Server and BMC infor

Update overview page to use new UI patterns

- Use page, section, list-pair to establish
consistent layout
- Update header and overview page to use new
caret icon
- Reordered Server and BMC information to
accomodate small screen views
- Added chevron icons to create consistency
between header and server overview page
quick links
- Changed edit hostname text to use the
standard icon
- Added OR operator to short circuit the server
model, server serial number, and server manufacturer
to display N/A if the information is not available

Change-Id: I6619f5369ff290555142e85aa432e901c4f93d2d
Signed-off-by: Derick Montague <derick.montague@ibm.com>

show more ...

Update toggle component

- Adds text to indicate the current state of the toggle button to meet
accessibility guidelines
- Update size, color, and focus of toggle component to fix
DAP violations

Update toggle component

- Adds text to indicate the current state of the toggle button to meet
accessibility guidelines
- Update size, color, and focus of toggle component to fix
DAP violations
- Add page, section, and list-pair layout patterns established
on the power usage page to begin a pattern for consistent
page layout
- Add form__field and form__actions to help with form layout
consistency.

Tested: Verified toggle functions in the GUI and tested with screen reader. Passes DAP.

Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: Iaa8646b1179cc307971065c455f4b9448095d1ec

show more ...

Refactor power operations

Refactored power operations to use checkHostStatus function
that checks host_status property provided by dataService,
instead of polling for host/chassis status.
Added prop

Refactor power operations

Refactored power operations to use checkHostStatus function
that checks host_status property provided by dataService,
instead of polling for host/chassis status.
Added property to check when a power operation is in progress.
This property will show/hide the in progress message and make
other operations unavailable until the operation completes.
We were previously checking whether the server_state property
was set to 'Unreachable', which enables the Power on button in
the middle of a reboot, since the server_state changes to 'Off'
during reboot.

- Removed unused $timeout service

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I234749a9a875c7370b52bd23ed74d6e9617cf5e2

show more ...

Clean up color values

This update will clean up slight color variations in the
code base by creating and using Sass color variables
instead of hex values. Available colors are defined in
colors.scss

Clean up color values

This update will clean up slight color variations in the
code base by creating and using Sass color variables
instead of hex values. Available colors are defined in
colors.scss. Any usage of CSS color properties should
refer to the mapped color variables in colors.scss.

- Removed tags.scss file since tag components no longer used

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I045030a158469e59d07a9fa8cd8aa9f125f0d383

show more ...

Fix cold reboot error

Cold reboot will check the host status by referring to the
server_state property in the dataService instead of making
API requests to check host/chassis status.

TODO: Refactor

Fix cold reboot error

Cold reboot will check the host status by referring to the
server_state property in the dataService instead of making
API requests to check host/chassis status.

TODO: Refactor other power control options to follow a
similar pattern.

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I74b1b78fa39caee514fbaea8492c8a5ad6f8145b

show more ...

Consolidate button styles

This patchset will create consistent button styling according
to the styleguide and remove redundant button styles by creating
reusable button classes.

This patchset also

Consolidate button styles

This patchset will create consistent button styling according
to the styleguide and remove redundant button styles by creating
reusable button classes.

This patchset also implements a consistent strategy for including
icon assets. Currently, svg icons are imported as CSS background
images or inlined into the markup. Inlining an svg is preferred,
especially when used with buttons or links so the colors can
be easily changed for different states (hover, focus, disabled)
without having to request variants.
The icon provider allows us to inline svgs without cluttering
the markup. Webpack config was adjusted to use svg-inline-loader
when resolving svgs that are used by the icon provider directive.

- All svgs were optimized to remove unncessary information.
- Removed unused svg color variants
- Moved icons used by icon provider to separate directory to
avoid Webpack parsing the files twice
- Small changes to navigation icons

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I1ca214b74fc502e6b6e760cfee88b48110237c43

show more ...

Change button styles from rounded to straight corners

This will create more visual consistency between the components
in the GUI since there are elements, such as text fields and
dropdowns that are

Change button styles from rounded to straight corners

This will create more visual consistency between the components
in the GUI since there are elements, such as text fields and
dropdowns that are styled with straight corners.

- Removes border radius from buttons
- Removes some redundant styles
- Adds input types that aren't currently inheriting
defined styles

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I6ff1bde91e2e57df01484dd20003925cd914ffa2

show more ...

Remove unused interpolate

Interpolate was used prior to the ngToast.
https://github.com/openbmc/phosphor-webui/commit/92d13b62f56fa302a8231690e7371c6ae04f50ba#diff-bbc57e73eb8aa4f1c2de7b8e033393e3
m

Remove unused interpolate

Interpolate was used prior to the ngToast.
https://github.com/openbmc/phosphor-webui/commit/92d13b62f56fa302a8231690e7371c6ae04f50ba#diff-bbc57e73eb8aa4f1c2de7b8e033393e3
moved to ngToast and removed the use of interpolate.

Tested: Build this and the commits below and loaded onto a Witherspoon
system. Did a power on, warm reboot, and immediate shutdown.
Change-Id: I99c2f3705df413fc744066dd34ba38a383c174fc
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Added comments to help clarify "confirm"

For the next person digging in this code. :)

Change-Id: Ib6c21da3fb53a4277a90bf2e5cab90ed29496724
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Remove done TODO

This TODO is complete, remote it.

Change-Id: Ifb775aa932bf54e790ff60352611a716f2d7fb02
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Remove unused testState

Change-Id: I9235c146fcd1288add4eeaa209d0f7b12f4d394e
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Remove unused powerOnConfirm and powerConfirm

There is no confirm for Powering on the system.
These were unused.

Change-Id: I4f5c3eb0a7676877ccbb0fef687ab525e585e428
Signed-off-by: Gunnar Mills <gm

Remove unused powerOnConfirm and powerConfirm

There is no confirm for Powering on the system.
These were unused.

Change-Id: I4f5c3eb0a7676877ccbb0fef687ab525e585e428
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...