Consolidate button styles

This patchset will create consistent button styling according
to the styleguide and remove redundant button styles by creating
reusable button classes.

Consolidate button styles

This patchset will create consistent button styling according
to the styleguide and remove redundant button styles by creating
reusable button classes.

This patchset also implements a consistent strategy for including
icon assets. Currently, svg icons are imported as CSS background
images or inlined into the markup. Inlining an svg is preferred,
especially when used with buttons or links so the colors can
be easily changed for different states (hover, focus, disabled)
without having to request variants.
The icon provider allows us to inline svgs without cluttering
the markup. Webpack config was adjusted to use svg-inline-loader
when resolving svgs that are used by the icon provider directive.

- All svgs were optimized to remove unncessary information.
- Removed unused svg color variants
- Moved icons used by icon provider to separate directory to
avoid Webpack parsing the files twice
- Small changes to navigation icons

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I1ca214b74fc502e6b6e760cfee88b48110237c43

show more ...

Form validation on login page

Using ngMessages, adds form validation to login page. Also creates a
directive, hasError, to be used to validate form field by passing
in a boolean. Thi

Form validation on login page

Using ngMessages, adds form validation to login page. Also creates a
directive, hasError, to be used to validate form field by passing
in a boolean. This is a proposed pattern to be used moving forward,
as form validation is added to additional pages.

Validation error messages are shown on $touched and on submit.
Unreachable Server and Invalid username and password error messages
remain until input is no longer $pristine after form submission.

In addition, this removes unneeded and unused css styling

Resolves openbmc/phosphor-webui#47

Change-Id: I7a067af67ac74d4cf2977d10f66445720ecae9eb
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Fix issue for responsive design: Login screen

This push fixes the issue of the logo and input alignment in login
screen on tablets portrait and landscape mode. They are centrally
ali

Fix issue for responsive design: Login screen

This push fixes the issue of the logo and input alignment in login
screen on tablets portrait and landscape mode. They are centrally
aligned in these views. Gets rid of the unwanted horizontal scrollbar
in tablets.

Change-Id: I31fd9caa881e0ffb6b1cd58701d911ee916dd419
Signed-off-by: Ryan Arnell <iffy.ryan@ibm.com>

show more ...

login-controller.html: Fix indents

Change-Id: Ie6867b29eb7e785ad48c918d605ccfff955e3102
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Do not autocomplete username and password

Security scanners list autocomplete on as a medium priority
issue. The concern being someone could use it to compromise
a bmc with a passwor

Do not autocomplete username and password

Security scanners list autocomplete on as a medium priority
issue. The concern being someone could use it to compromise
a bmc with a password saved on a compromised computer.

Resolves openbmc/phosphor-webui#18

Change-Id: Ie6936d84a0b94a81781a077d1542a6ce1d413d6d
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Highlight correct fields on errors

If the error is 'Invalid username or password', the 'Username'
and 'Password' fields now becomes red.
On any other error (e.g. Server unreachable)

Highlight correct fields on errors

If the error is 'Invalid username or password', the 'Username'
and 'Password' fields now becomes red.
On any other error (e.g. Server unreachable) the
'BMC Host or BMC IP Address' field is red.

Before the 'BMC Host or BMC IP Address' and 'Username'
were red on all errors.

Resolves openbmc/phosphor-webui#17

Tested: See correct fields highlighted.
Change-Id: I55514cfb428170cd125ec01eb4c7184fbadd3894
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Rename BMC Host/IP field on login

Renamed the BMC Host/BMC IP Address field:
"BMC Host or BMC IP Address".
Like Password and Username, this is displayed as all caps.
We got feedb

Rename BMC Host/IP field on login

Renamed the BMC Host/BMC IP Address field:
"BMC Host or BMC IP Address".
Like Password and Username, this is displayed as all caps.
We got feedback that "Host" could mean a lot of things
and should specify this is the BMC.

Closes openbmc/openbmc#3147

Change-Id: If8b4e7b8a8bf912631fb39cc271ee87ce38c470d
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Move login error to common error style

Created a generic error class, have the login error inherit it.

Tested: Verified the login error looks the same.
Change-Id: Ief373fa37ea65

Move login error to common error style

Created a generic error class, have the login error inherit it.

Tested: Verified the login error looks the same.
Change-Id: Ief373fa37ea655cfcb544861a4e540abbe65f77e
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Show error message received from server side

When an error occurs during authorization, display the error message
received from server side instead hardcoded message.

Partially

Show error message received from server side

When an error occurs during authorization, display the error message
received from server side instead hardcoded message.

Partially resolves openbmc/openbmc#2974
Resolves openbmc/openbmc#3024

Tested: Enter invalid username or password and verify error message
Change-Id: I91ca29d5a69e12e12ce490ce3206173de7d41f09
Signed-off-by: Alexander Filippov <a.filippov@yadro.com>

show more ...

Remove reference to IBM in phosphor-webui

As phosphor webui is supposed to be the reference implementation, it
should not reference IBM, nor have IBM copywritten logos contained
with

Remove reference to IBM in phosphor-webui

As phosphor webui is supposed to be the reference implementation, it
should not reference IBM, nor have IBM copywritten logos contained
within it. If these are neccesary for IBM platforms, they should be
done in a bbappend in the bitbake layer, or in a way that doesn't put
copywritten materials on BMCs that may not have permission to use and
release it.

I'm hoping to generate ddiscussion on how the best way to handle this
from a build perspective would be, but for now, references should be to
the OpenBmc project, not IBM to avoid copyright issues.

Change-Id: I73efda399e967ca4446b8df403e94e14ab24aff8
Signed-off-by: Ed Tanous <ed.tanous@intel.com>

show more ...

Modernize web GUI and make it installable on BMC

1. Move from gulp server to webpack. This allows the proper
compression to allow the webui to be embedded in the BMC.
2. Update js p

Modernize web GUI and make it installable on BMC

1. Move from gulp server to webpack. This allows the proper
compression to allow the webui to be embedded in the BMC.
2. Update js paths to use requires, not hardcoded paths. This was
required to make the packaging work correctly.
3. Add babel config to do translation.
4. Update angularjs directive calls to use the angular 1.6 syntax for
promises intead of success and fail.

https://docs.angularjs.org/guide/migration#migrate1.5to1.6-ng-services-$http

5. As a consequence of using NPM/webpack, the versions of angular and
associated modules that were checked in have been updated.

Change-Id: Icb71e2eedb0d9a8943fc914f9dc4be11d0983c00
Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Updating login structure

Updated login structure with a field where user can manually add server hostname if it is not populated automatically

Change-Id: I147c2c15869131540e327bda26

Updating login structure

Updated login structure with a field where user can manually add server hostname if it is not populated automatically

Change-Id: I147c2c15869131540e327bda26c05b59d78e01d5
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>

show more ...

Updating firmware update pages functionality

Change-Id: Ie82640d47108e8367409d669a7ea72d38598443f
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>

Changed title and info labels copy. Based on design changes and user feedback.

Change-Id: Id546bf09b6790d5f12212493c215bf03e11cde15
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

Added hardware sensors functionality

Change-Id: I99435613bb77fc0ff72f046c2dc047b13962a7a3
Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>

Minor usability fixes

- Set default focus to 'username' field on login.
- Add default sorting of event logs.

Change-Id: I677cc12a41313e14cd22c3128240d271dfc7796f
Signe

Minor usability fixes

- Set default focus to 'username' field on login.
- Add default sorting of event logs.

Change-Id: I677cc12a41313e14cd22c3128240d271dfc7796f
Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>

show more ...

Misc CSS fixes

* set max content width to 960px
* created mixin for bold font
* move app-header content to global header
* minor global changes
* changed input alig

Misc CSS fixes

* set max content width to 960px
* created mixin for bold font
* move app-header content to global header
* minor global changes
* changed input alignment for network config inputs
* added pop-out button class
* changed lightgrey color
* fixed accordion header actions responsiveness
* fixed input box border colors

Change-Id: Iffe26d526439d7f2bb6808528a975ab7374ff1b2
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

show more ...

Change navigation structure

Change-Id: I12c819293ce1eda188dc9f257ae9370f1b73cb18
Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>

Major update to code structure

* Split files into independent files based on functionality.
* Switch to bower/gulp for build.

Change-Id: Ibc775dd9b7f6a0a49f63c22162b7582e7

Major update to code structure

* Split files into independent files based on functionality.
* Switch to bower/gulp for build.

Change-Id: Ibc775dd9b7f6a0a49f63c22162b7582e781e2d9c
Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>

show more ...