Update code styling for network page

Now that the following style guide is being
used:
https://google.github.io/styleguide/jsguide.html#naming
Some of the variable naming in this class needs to be u

Update code styling for network page

Now that the following style guide is being
used:
https://google.github.io/styleguide/jsguide.html#naming
Some of the variable naming in this class needs to be updated.

Change-Id: I6ca7a0ea7255ab2314bb4b5fc2d89cff9006039a
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Add and Update IPV4 address

This allows user to add IPV4 addresses
and updates logic for editing IPV4
addresses.

Resolves openbmc/phosphor-webui#12

Tested: Added, removed and modified IPV4
ad

Add and Update IPV4 address

This allows user to add IPV4 addresses
and updates logic for editing IPV4
addresses.

Resolves openbmc/phosphor-webui#12

Tested: Added, removed and modified IPV4
addresses, called API to verify that
addresses had been correctly modified.
Verified that if address had not been
modified, no change was made for that
address.

Change-Id: I3dd25565f4f610dce2023e23348f6eb8d00add3d
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Add "(Primary)" to first NTP Server

The IBM design team though adding "(Primary)" to the first
NTP Server made it more clear that this NTP server is the
first NTP server the time manager talks to.

Add "(Primary)" to first NTP Server

The IBM design team though adding "(Primary)" to the first
NTP Server made it more clear that this NTP server is the
first NTP server the time manager talks to.

Change-Id: Iaadbc4958621146db072541668a7a6f0a8834de4
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Set Host Time from correct fields

In all cases except when the time owner is "Split", Host and BMC
time share fields. Make sure to set the Host time from the
correct fields, which is these shared fi

Set Host Time from correct fields

In all cases except when the time owner is "Split", Host and BMC
time share fields. Make sure to set the Host time from the
correct fields, which is these shared fields in all cases
except when time owner is "Split".

Resolves openbmc/phosphor-webui#20

Tested: Able to set the Host and BMC time
Change-Id: I69985fd2de08fe71c62fd57dd1fa872f7f33ba09
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Set the Host Time if "Split" and "NTP"

From: https://github.com/openbmc/phosphor-time-manager
Mode Owner Set BMC Time Set Host Time
NTP SPLIT Fail to set OK

Resolves openbmc/phosphor-webui#19

Chan

Set the Host Time if "Split" and "NTP"

From: https://github.com/openbmc/phosphor-time-manager
Mode Owner Set BMC Time Set Host Time
NTP SPLIT Fail to set OK

Resolves openbmc/phosphor-webui#19

Change-Id: I72f5617581533a2bb17d415b45bdf7ec6372ecab
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove IPV4 addresses

Tested: Able to remove existing IPV4
addresses.

Change-Id: I772bee6ad6b68bc0a69351f3e5386acc659241ef
Signed-off-by: beccabroek <beccabroek@gmail.com>

Date-time: Change h2 title

This title is more clear.

Change-Id: I8e4f89b1d2d91fe0745dedfcea1af124033d5cca
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Revert "Remove unused dataService"

This reverts commit e13275b837ed38b7e8553316accedb51b32ef37b.
dataService is used in powerOn(), warmReboot() and
isServerOff().

Change-Id: I8635ac88f93b6354ea7d35

Revert "Remove unused dataService"

This reverts commit e13275b837ed38b7e8553316accedb51b32ef37b.
dataService is used in powerOn(), warmReboot() and
isServerOff().

Change-Id: I8635ac88f93b6354ea7d352f92c9a7f4281e21a5
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove unused dataService

Change-Id: I99e0d16a56908beb1397bb4c15390c72c3b2f3f5
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Remove tabs from HTML files

From https://google.github.io/styleguide/htmlcssguide.html
"Indentation
Indent by 2 spaces at a time.

Don't use tabs or mix tabs and spaces for indentation."

Tested: Ma

Remove tabs from HTML files

From https://google.github.io/styleguide/htmlcssguide.html
"Indentation
Indent by 2 spaces at a time.

Don't use tabs or mix tabs and spaces for indentation."

Tested: Manual regression testing on a Witherspoon.
Change-Id: Ief7137dabc869b73b73f9947337fbb0abb5ca497
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Activate image and reboot host

When activating a host image, gives the option to:
a) Activate image without booting
b) Activate image and boot host. If server is
in 'off' status the option

Activate image and reboot host

When activating a host image, gives the option to:
a) Activate image without booting
b) Activate image and boot host. If server is
in 'off' status the option is to power on.
If the server is in 'unavailable', 'on', or
'error' status the option is to reboot
Also updated polling during boot and reboot to use
/subscribe API.

Resolves openbmc/openbmc#3323

Tested: The GUI displays the options and boots /
reboots appropriately based on server status.

Change-Id: I62c19e094ecc7112263c26844fcd30b2bf3c2b84
Signed-off-by: beccabroek <rebecca.shaw@ibm.com>

show more ...

Button to remove NTP server

Change-Id: I58a3a894c192fafb551e07302b107bcd776e4901
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Button to remove DNS server

Added button to remove DNS server from
Nameservers list.

Resolves openbmc/phosphor-webui#11

Tested: Added and was able to remove DNS servers
from list. Page updated a

Button to remove DNS server

Added button to remove DNS server from
Nameservers list.

Resolves openbmc/phosphor-webui#11

Tested: Added and was able to remove DNS servers
from list. Page updated appropriately.

Change-Id: I64e9d2499465f1aa5f9f34c831961578abf32b2b
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Set time fields

Squashed 5 commits to set the date-time fields:
time mode, time owner, BMC time, and host time.
Also included is a commit to display the timezone.

Set time mode

Moved the selection

Set time fields

Squashed 5 commits to set the date-time fields:
time mode, time owner, BMC time, and host time.
Also included is a commit to display the timezone.

Set time mode

Moved the selection of NTP vs Manual (time mode) to a radio
button.
Added code to allow the user set it.

Tested: Set the time mode on a Witherspoon.
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Set time owner

The time owner is now a dropdown and is set when "Save settings"
is pressed.

Tested: Set the time owner on a Witherspoon
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Set the BMC and Host time

The BMC and host have the same time except when time mode is split.
Only need to set BMC or host time when time mode is not split.
When time mode is split, set both. Use time owner to determine
which to set.
https://github.com/openbmc/phosphor-time-manager#time-settings

Have date and time as two separate inputs, this is due to Firefox
not supporting "datetime-local". The "date" and "time" input
fields are more widely supported.
https://caniuse.com/#feat=input-datetime

The idea for 2 separate input fields came from:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/datetime-local

Must set the time mode and time owner before setting the time,
this is due to permissions of who can set the time.

Tested: Set the date and time on a Witherspoon.
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Add NTP Servers

The user can now view and set NTP Servers.

Moved setFocusOnNewInput to a common directive since it is used
on the NTP Servers and the DNS Servers on the network page.

Even though NTPServers is a network interface specific path
(e.g. /xyz/openbmc_project/network/eth0/attr/NTPServers) it acts
like a global setting, openbmc/phosphor-time-manager#4.
Using eth0 for setting and getting the NTP Servers until
NTPServers is moved to a non-network interface specific path.

In Redfish, NTPServers is a non-network interface specific.

Tested: Set NTP Servers on a Witherspoon.
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Add timezone

Added the timezone for the host and bmc date time.

The timezone looks like "GMT-0400 (EDT)" or "GMT-0500 (CDT)".
I got this from
https://stackoverflow.com/questions/1091372/getting-the-clients-timezone-in-javascript
and choose this formatting over something like "America/Chicago".

Tested: See the timezone on a Witherspoon
Change-Id: I59a4449d63f73a6ed14cb934f3d8577e46620c4e
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Create new SNMP Settings page

Created new page to display SNMP Managers.
Display the SNMP Manager's IP and port.
https://github.com/openbmc/phosphor-snmp/blob/master/docs/snmp-configuration.md

Futu

Create new SNMP Settings page

Created new page to display SNMP Managers.
Display the SNMP Manager's IP and port.
https://github.com/openbmc/phosphor-snmp/blob/master/docs/snmp-configuration.md

Future commits will allow the user to add and delete SNMP
managers.

Change-Id: Ia5d633c11728a580c06b25c412e8673925cdc597
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add Host Time

If the Time Owner is 'BMC', 'Host', or 'Both' a single time field
is present with a title of "BMC and Host Time".
If the Time Owner is 'Split', meaning the BMC and Host have separate t

Add Host Time

If the Time Owner is 'BMC', 'Host', or 'Both' a single time field
is present with a title of "BMC and Host Time".
If the Time Owner is 'Split', meaning the BMC and Host have separate times,
2 time fields are present "BMC Time" and "Host Time".

Tested: Set Time Owner to "BMC" and Time Owner to "Split".
Change-Id: I6399fa30e4489d4bd62250b639e66e60cf9c2426
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add Time Owner and Time Mode

Added the Time Owner and the Time Mode
Created a new function that enumerates /xyz/openbmc_project/time.

Tested: See Time Mode and Time Owner
Change-Id: I3d1788bdb87b99

Add Time Owner and Time Mode

Added the Time Owner and the Time Mode
Created a new function that enumerates /xyz/openbmc_project/time.

Tested: See Time Mode and Time Owner
Change-Id: I3d1788bdb87b99028000d13c868b4a0cbfbc3006
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Create "Date and time settings" page

There was a Date and time page in the GUI. Enhanced it to
display the BMC time and added it to the menu so users
could navigate to it.

Future things planned for

Create "Date and time settings" page

There was a Date and time page in the GUI. Enhanced it to
display the BMC time and added it to the menu so users
could navigate to it.

Future things planned for this page:
Setting the time, time mode, and time owner.
Adding a NTP server.

More information can be found in the time manager README:
https://github.com/openbmc/phosphor-time-manager/blob/master/README.md

Tested: See the BMC time.
Change-Id: Ia3ac2385cb45ec8009ed6df0899c3410fe18ef64
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove hack for 1/0 booleans

With
https://github.com/openbmc/phosphor-rest-server/commit/6691e7ca4e2adf52bac1fc3a82ed35adfce4349c
and
https://github.com/openbmc/bmcweb/commit/b79d4eef01f5fd2a24bb8dd

Remove hack for 1/0 booleans

With
https://github.com/openbmc/phosphor-rest-server/commit/6691e7ca4e2adf52bac1fc3a82ed35adfce4349c
and
https://github.com/openbmc/bmcweb/commit/b79d4eef01f5fd2a24bb8dd28792810aa718cdee
merged, this is no longer needed.
This code removed here was breaking displaying the DHCP value.

Change-Id: I465908190b1254238da8699a324a31a51771dace
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Move to clang-format-6.0

The docker image moved from clang-format-5.0 to clang-format-6.0.

Change-Id: I3c615d7df1f21569531b4dc2cb0bc4f425cb43f8
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Focus on newly created DNS server field

Got feedback from IBM's design team that to help usability after adding
a DNS Server field, focus on the newly created DNS server field.

Decided to go with a

Focus on newly created DNS server field

Got feedback from IBM's design team that to help usability after adding
a DNS Server field, focus on the newly created DNS server field.

Decided to go with a directive instead of putting this in a controller
after reading:

https://stackoverflow.com/questions/22292832/angular-ng-init-pass-element-to-scope,
https://github.com/angular/angular.js/issues/9031,
https://groups.google.com/forum/#!topic/angular/6uxWl8Z0DPw

Having dom manipulation code in the controller is frowned upon.

Tested: Verified the field is in focus (i.e. the cursor is in the
textbox).
Change-Id: Ia548361e7ac47363e05ea2963807bca0c5bf51e2
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove file page

This page was unused and unreachable from the menu.
Cleaning up the code base.

Change-Id: Id2529d95768d3885448efebb6d24833ffe35c3b6
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Remove security page

This page was unused and haven't heard of any plans to implement it.
Cleaning up the code base.

Change-Id: Ie4fadc57e42f9b1c8fbc7f4c848f001ff062210f
Signed-off-by: Gunnar Mills

Remove security page

This page was unused and haven't heard of any plans to implement it.
Cleaning up the code base.

Change-Id: Ie4fadc57e42f9b1c8fbc7f4c848f001ff062210f
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Fixed spelling errors

Change-Id: I4b668b6246508d3bedda75ca179da1615516bad4
Signed-off-by: Rebecca Shaw <rebecca.shaw@ibm.com>

Add TODO for openbmc/openbmc#3240

Change-Id: I2dcd3625cf72c774d84399e35d3c7be19f744d5c
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>