Fix truncated button icons on Safari

Removing margin offset to fix issue with button icons being
visually truncated on Safari. Removing additional redundant
code around same icon/buttons.

Signed-of

Fix truncated button icons on Safari

Removing margin offset to fix issue with button icons being
visually truncated on Safari. Removing additional redundant
code around same icon/buttons.

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ie1ef89023a043a70a0126a21be57febb9afae19a

show more ...

Create firmware-card component

Create reusable firmware card component that will be
used in the updated firmware page:
https://ibm.invisionapp.com/share/4XNZ0JAMJ7B#/screens/319212821_4-8-D-1_Home

Create firmware-card component

Create reusable firmware card component that will be
used in the updated firmware page:
https://ibm.invisionapp.com/share/4XNZ0JAMJ7B#/screens/319212821_4-8-D-1_Home

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I86e526c59ac5c2e2c011aed0ce4bc3d82db63b5e

show more ...

Remove firmware reboot timeout

A 10 second timeout was used as a tempoary work-around
before rebooting the BMC on the firmware page–removing
the timeout since it is no longer needed.

Signed-off-by:

Remove firmware reboot timeout

A 10 second timeout was used as a tempoary work-around
before rebooting the BMC on the firmware page–removing
the timeout since it is no longer needed.

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I6a95d5f5bb377d3fd3cc0802f7fb3d6d0f177870

show more ...

NTP: Remove workaround for empty list array

This workaround is no longer needed with bmcweb.

curl -k -H "Content-Type: application/json" -X PUT \
-d '{"data": [] }' \
https://${bmc}/xyz/openbmc_pr

NTP: Remove workaround for empty list array

This workaround is no longer needed with bmcweb.

curl -k -H "Content-Type: application/json" -X PUT \
-d '{"data": [] }' \
https://${bmc}/xyz/openbmc_project/network/eth0/attr/NTPServers

See https://github.com/openbmc/openbmc/issues/3240

Tested: Built and loaded on a Witherspoon. Added, removed, and
edited NTP servers.
Change-Id: Ia106067a479c63a5761b1f62c624d3ccc6df55c7
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

DNS: Remove workaround for empty list array

This workaround is no longer needed with bmcweb.

curl -k -H "Content-Type: application/json" -X PUT \
-d '{"data": [] }' \
https://${bmc}/xyz/openbmc_pr

DNS: Remove workaround for empty list array

This workaround is no longer needed with bmcweb.

curl -k -H "Content-Type: application/json" -X PUT \
-d '{"data": [] }' \
https://${bmc}/xyz/openbmc_project/network/eth0/attr/Nameservers
{
"data": null,
"message": "200 OK",
"status": "ok"

and actually casues an error now do to
https://github.com/openbmc/phosphor-networkd/commit/5fb6c33a49ee2b9718cc9ce0f921d3b6cf38a463

curl -k -H "Content-Type: application/json" -X PUT \
-d '{"data": [""] }' \
https://${bmc}/xyz/openbmc_project/network/eth0/attr/Nameservers
"data": {
"description": "xyz.openbmc_project.Common.Error.InvalidArgument"
},
"message": "Invalid argument was given.",

See https://github.com/openbmc/openbmc/issues/3240

Tested: Built and loaded on a Witherspoon. Added, removed,
and edited DNS servers.
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
Change-Id: I278489a8c4682641b61a0e5ab08fd714603b0234

show more ...

Fix SNMP multiple calls bug

- Added a call to reload the route in the promise success callback. This
assures that a newly added manager has a path.
- Update the use of var in for blocks to scope

Fix SNMP multiple calls bug

- Added a call to reload the route in the promise success callback. This
assures that a newly added manager has a path.
- Update the use of var in for blocks to scope the variable to the
block rather than overwriting the i variable that is hoisted and
scoped to the setSNMP function.
- Change i variable name to managerLength to improve readability

Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I18fe9ecc3ca7cca29781a5c24caca73bda71ee43

show more ...

Add error message when image fails to activate

If an image fails to activate a toast message is displayed.

Tested on Witherspoon with master build image and
field mode turned on. When image fails t

Add error message when image fails to activate

If an image fails to activate a toast message is displayed.

Tested on Witherspoon with master build image and
field mode turned on. When image fails to activate,
the failed activation status response returns a 200
ok and an error toast is displayed. Tested with field
mode turned off to verify image activates and BMC reboots.
Tested on all browsers.

Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I517f184549673e7b807cc0a553a728d05d6dbba1

show more ...

Fix invalid gateway toast message

Add check for gateway value before testing if the string is valid.
The backend seems to handle an empty gateway the same as sending
0.0.0.0. When the GET call is ma

Fix invalid gateway toast message

Add check for gateway value before testing if the string is valid.
The backend seems to handle an empty gateway the same as sending
0.0.0.0. When the GET call is made after sending 0.0.0.0 as the
gateway value, the response returns an empty string. This field
seems to be an override for the default gateway input for the
interface.

Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: Id6a5575e73a7c8adfff052c89bb4e8ca986d45f9

show more ...

Fix icon-warning syntax error

There were a few instances of the icon-warning icon that didn't
include the file extenstion needed to when adding the file attribute
property in the icon directive.

Si

Fix icon-warning syntax error

There were a few instances of the icon-warning icon that didn't
include the file extenstion needed to when adding the file attribute
property in the icon directive.

Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: Ib25c28c72285fa214f75258b0b09790d52bb6cc1

show more ...

Fix date and time settings bug

When time mode is initially set to Manual from NTP,
NTP service is disabled and the NTP service is stopping
but not stopped, setting time will return an error.
There a

Fix date and time settings bug

When time mode is initially set to Manual from NTP,
NTP service is disabled and the NTP service is stopping
but not stopped, setting time will return an error.
There are no response messages to notify when
NTP is completely stopped.

To work around, a timeout is set to allow NTP to fully stop
before saving date/time changes.

https://github.com/openbmc/phosphor-time-manager/blob/master/README.md

Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: Icb86dfe339a10567aecf9aedd9b0dd696937a398

show more ...

Clean up icons

Clean up duplicate svg icons from assets directory.
Created a statusIcon component to dynamically render
status icons instead of using background-image in
scss files.

- Moved/removed

Clean up icons

Clean up duplicate svg icons from assets directory.
Created a statusIcon component to dynamically render
status icons instead of using background-image in
scss files.

- Moved/removed on, off, critical, warning svg icons from
assets directory
- Updated background-image status icons to use <icon>
or <status-icon> directive

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ic0f06d78b0861d6f60d40b2dcc0b80fd6dad2a88

show more ...

Update users navigation section

- Changed the section name to be access-control
- Moved LDAP Settings and Certificate Management to access-control navigation
- Changed Manage User Account subsection

Update users navigation section

- Changed the section name to be access-control
- Moved LDAP Settings and Certificate Management to access-control navigation
- Changed Manage User Account subsection name to Local User Management

Resolves: openbmc/phosphor-webui#619

Signed-off-by: Mira Murali <miramurali23@gmail.com>
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I0d94c80c295b997d94c04330fd87f4fc4d229bf8

show more ...

LDAP configuration and user groups

Adds LDAP page and ability to add and change configuration settings.
Adds ability to add, remove and edit user groups for LDAP.

Resolves openbmc/phosphor-webui#38

LDAP configuration and user groups

Adds LDAP page and ability to add and change configuration settings.
Adds ability to add, remove and edit user groups for LDAP.

Resolves openbmc/phosphor-webui#38
Resolves openbmc/phosphor-webui#39

Tested: Loaded on to a witherspoon and able to add initial LDAP config
as well us update the configuration and role groups. Appropriate messages displayed
to user when required fields are missing or in the incorrect format.

Change-Id: If8a21f3f9d9334415ead73472e90b2a0823bf9ea
Signed-off-by: beccabroek <beccabroek@gmail.com>
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Signed-off-by: Derick Montague <derick.montague@ibm.com>

show more ...

Move Virtual Media files and route

"Virtual media" was already part of the "Server control" submenu but
the files were at app/configuration and the route was /configuration.

Marta Mazur did a simil

Move Virtual Media files and route

"Virtual media" was already part of the "Server control" submenu but
the files were at app/configuration and the route was /configuration.

Marta Mazur did a similar file and route move here as part of
supporting multiple Virtual Media endpoints:
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-webui/+/25218

Tested: Built and loaded on a Witherspoon. The VM route is now:
#/server-control/virtual-media. Was able to use the VM
panel.
Change-Id: Iec46a8ece7ddfbc356bc1e71875def70c4418027
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Certificate management alert icons implementation and alignment

- Replaces background image icons with icon directive
- Sizes and aligns icons in certificate table

TODO:
- Remove critical icon back

Certificate management alert icons implementation and alignment

- Replaces background image icons with icon directive
- Sizes and aligns icons in certificate table

TODO:
- Remove critical icon background image in separate commit

Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I2e10bc3f3432331b6dd9354dbcd0e32480894ece

show more ...

Update SNMP page layout

This change applies global styles to improve
page layout consistency and removes unnecessary
custom styling.

- Adds page, section, form field and actions styles
- Removes un

Update SNMP page layout

This change applies global styles to improve
page layout consistency and removes unnecessary
custom styling.

- Adds page, section, form field and actions styles
- Removes unused styles

Tested:
- Passes DAP

Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I96bb4732fdf160b2cc9eff0ad3ed9309ab1b9ea4

show more ...

Fix IE11 SNMP edit bug

- Removes edit button from form
- Removes focus-within (not compatible with IE11 and Edge)
and pointer-event

Tested:
- Input fields are editable and can be saved
- DAP viol

Fix IE11 SNMP edit bug

- Removes edit button from form
- Removes focus-within (not compatible with IE11 and Edge)
and pointer-event

Tested:
- Input fields are editable and can be saved
- DAP violations and page layout consistency will be addressed
in separate commit

Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I2ccd06802137c2969fec686abc5b5f8e785725b6

show more ...

Fix missing expiring/expired icons and warnning messages in certificate table

- Confirmed with backend developer that we should be checking certificate expiration date with bmc date/time set
- Conve

Fix missing expiring/expired icons and warnning messages in certificate table

- Confirmed with backend developer that we should be checking certificate expiration date with bmc date/time set
- Converted both certificate expiration date and bmc date/time to EPOCH time to fix the bug

Tested: Go to Date and Time settings and change BMC time to be after or 30 days before a certificate expiration date.
Then either a warning or expiration icon and message will be displayed next to the date and message on top of the table.
To remove the expiration or warning date, upload a certificate that has an expiration date greater than 30 days after bmc time
set. The icon and warning message should now disappear.

Signed-off-by: Mira Murali <miramurali23@gmail.com>
Change-Id: I9389fe3cce5a555945adf9c56180897a6be047bf

show more ...

Fix IE11 remove button on network settings

- Adds button type to buttons for IPv4 and DNS

Tested: Verified remove button deletes IPv4 and DNS server

Signed-off-by: Dixsie Wolmers <dixsiew@gmail.co

Fix IE11 remove button on network settings

- Adds button type to buttons for IPv4 and DNS

Tested: Verified remove button deletes IPv4 and DNS server

Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I7827f49a910c14b9df0575f678d8f121258446f6

show more ...

Enable CA certificate upload

This patchset enables CA certificate type to be uploaded
in the GUI.

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I52953933f6fd3dbd363c42b887996

Enable CA certificate upload

This patchset enables CA certificate type to be uploaded
in the GUI.

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I52953933f6fd3dbd363c42b887996942b99b358e

show more ...

Create csr modal

The CSR Modal allows users to generate a CSR code. Once the user
types in the necessary information to generate the CSR code, that modal
will then render the code and the user will

Create csr modal

The CSR Modal allows users to generate a CSR code. Once the user
types in the necessary information to generate the CSR code, that modal
will then render the code and the user will be able to either copy the
code or download the code in a txt file.

Tested: loaded onto Witherspoon and able to view on certificate
management page. Click on generate csr and type in necessary
(or any additional info), then click on generate CSR. The CSR
code is then visible and is able to be copied or downloaded. In
error state in which CSR code is unable to generate, the modal
closes and an error toast message appears. FYI: Sometimes you
have to reboot system in order for csr to successfully generate.y

Signed-off-by: Mira Murali <miramurali23@gmail.com>
Change-Id: I3cca09c494357496166164b5ee8ff99250ef981d

show more ...

Extending certificate table with Issuer and Subject columns.

This commit introduce two new columns on certificate table.
It should help user to differentiate multiple mTLS certificates.

Date format

Extending certificate table with Issuer and Subject columns.

This commit introduce two new columns on certificate table.
It should help user to differentiate multiple mTLS certificates.

Date format was changed to 'medium' one to accommodate two new columns.
Small corrections were made to action button paddings to make the icon better centered.

Tested: GUI tests were done on Chromium v74.0.3729 browser. Desktop and mobile version.

Signed-off-by: Zbigniew Kurzynski <zbigniew.kurzynski@intel.com>
Change-Id: I660b74dd8b50f854ebbdad1890bbf99b3675f4cd

show more ...

Clean up color values

This update will clean up slight color variations in the
code base by creating and using Sass color variables
instead of hex values. Available colors are defined in
colors.scss

Clean up color values

This update will clean up slight color variations in the
code base by creating and using Sass color variables
instead of hex values. Available colors are defined in
colors.scss. Any usage of CSS color properties should
refer to the mapped color variables in colors.scss.

- Removed tags.scss file since tag components no longer used

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I045030a158469e59d07a9fa8cd8aa9f125f0d383

show more ...

Create certificate management page

Displays certificates and the ability to add up to one
of each type of certificate (as limited by the backend
implementation). HTTPS certificate and LDAP client ce

Create certificate management page

Displays certificates and the ability to add up to one
of each type of certificate (as limited by the backend
implementation). HTTPS certificate and LDAP client cert
are implemented in this commit, with the ability to add
more types as needed by adding them to the constants.js
CERTIFICATE_TYPES array.

Also provides the ability to replace a certificate once
it is added.

Resolves openbmc/phosphor-webui#43

Tested: loaded onto a witherspoon and able to view and
replace both the HTTPS certificate and the
LDAP certificate. GUI only allows to upload an
LDAP certificate if one doesn't already exist.
The GUI limits the user to one file per type as
expected at this time and provides the
appropriate validation messages. Alert messages
appear above the table if the certificate is
expired or within 30 days of expiring.

Change-Id: I345267280ecd3cb257e9304886cde9ebb69b1240
Signed-off-by: beccabroek <beccabroek@gmail.com>
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>

show more ...

Consolidate button styles

This patchset will create consistent button styling according
to the styleguide and remove redundant button styles by creating
reusable button classes.

This patchset also

Consolidate button styles

This patchset will create consistent button styling according
to the styleguide and remove redundant button styles by creating
reusable button classes.

This patchset also implements a consistent strategy for including
icon assets. Currently, svg icons are imported as CSS background
images or inlined into the markup. Inlining an svg is preferred,
especially when used with buttons or links so the colors can
be easily changed for different states (hover, focus, disabled)
without having to request variants.
The icon provider allows us to inline svgs without cluttering
the markup. Webpack config was adjusted to use svg-inline-loader
when resolving svgs that are used by the icon provider directive.

- All svgs were optimized to remove unncessary information.
- Removed unused svg color variants
- Moved icons used by icon provider to separate directory to
avoid Webpack parsing the files twice
- Small changes to navigation icons

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I1ca214b74fc502e6b6e760cfee88b48110237c43

show more ...