Display error if TFTP post fails

Display an error if the DownloadViaTFTP returns an
error code. This code replaces some unused code.

Resolves openbmc/openbmc#3029

Tested: Verified I see this error

Display error if TFTP post fails

Display an error if the DownloadViaTFTP returns an
error code. This code replaces some unused code.

Resolves openbmc/openbmc#3029

Tested: Verified I see this error if the DownloadViaTFTP call
returns an error code.
Change-Id: I1547689059f45953b29aedda75c0599aec30079d
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Display error if TFTP field empty

If either TFTP Server IP Address or File Name is empty for the
"Download image file from TFTP server" function, return and
display an error.

Tested: Verified I see

Display error if TFTP field empty

If either TFTP Server IP Address or File Name is empty for the
"Download image file from TFTP server" function, return and
display an error.

Tested: Verified I see this error if either field is empty.

Change-Id: I3da3353dad7cfb0f765d8a662412c3adb3fa4efd
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add Activate firmware and reboot button

Added a radio button to activate firmware and reboot the BMC.
If the "Activate firmware and reboot" option is selected, reboot
the BMC after activating the fi

Add Activate firmware and reboot button

Added a radio button to activate firmware and reboot the BMC.
If the "Activate firmware and reboot" option is selected, reboot
the BMC after activating the firmware. The user is then logged
out.

Resolves openbmc/openbmc#3027

Tested: When "Activate firmware and reboot" option is selected,
the BMC reboots after activating. When it is not selected,
the BMC image just activates.
Change-Id: I07293dc8a6ddfac4cf58ba2c1d1352c9afd6fa8d
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Update the GUI after an image activated

When activating an image the firmware page does not refresh
after the image is activated and show the image as "Active".
To get the image to show as "Active",

Update the GUI after an image activated

When activating an image the firmware page does not refresh
after the image is activated and show the image as "Active".
To get the image to show as "Active", a user must refresh the
page.

The activating image code now waits until the image is activated
and the REST call returns "Active" or "Failed" and then refreshes
the page.

Resolves openbmc/openbmc#2966

Tested: Activated an image and verfied it refreshed after
"Active".
Change-Id: Ic68e3c9e6cb5c2ea4f5d66f48fd09252c4807f26
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add server confirm activation modal

Added text specific to server images that appears in the
activation modal when a "server" image is activated.
The "server" and "BMC" images use the same modal, bu

Add server confirm activation modal

Added text specific to server images that appears in the
activation modal when a "server" image is activated.
The "server" and "BMC" images use the same modal, but the text
and if radio buttons appear differ.

Resolves openbmc/openbmc#2967

Tested: Activated both a server and BMC image on a Witherspoon.
Change-Id: I83693641ebfef802d403141ade55a950f359ba6e
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove "reboot" modal

This modal was not used.

Tested: Uploaded and activated an image on a Witherspoon.
Change-Id: I3eb549b04f09565da06a28815b2b3843dd72cafb
Signed-off-by: Gunnar Mills <gmills@us.

Remove "reboot" modal

This modal was not used.

Tested: Uploaded and activated an image on a Witherspoon.
Change-Id: I3eb549b04f09565da06a28815b2b3843dd72cafb
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Move from "Preserve settings" to "Confirm Activation"

The "Preserve settings" popup that showed when a user activated
an image was not useful and did not do anything. Saving network
settings prior t

Move from "Preserve settings" to "Confirm Activation"

The "Preserve settings" popup that showed when a user activated
an image was not useful and did not do anything. Saving network
settings prior to activation is not needed so moved to a
"Confirm Activation" modal.
This modal will eventually include an
"activate BMC firmware and reboot" selection,
openbmc/openbmc#3027, for now it only holds the one selection.
The "Preserve settings" and now this "Confirm Activation"
modal both appear on "server" and "BMC" images, this is a bug
that is fixed in a later commit.

Tested: Activated an image on a Witherspoon machine.
Change-Id: I7176d5a314ea325e6e94606ef07b32786ede64e9
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Confirm changing priority on all priority changes

Before the confirm priority change modal would only appear if
the user is changing the priority from priority "1" to "0"
or priority "0" to "1".

Th

Confirm changing priority on all priority changes

Before the confirm priority change modal would only appear if
the user is changing the priority from priority "1" to "0"
or priority "0" to "1".

This doesn't work because if two images existed, a
"functional" priority "1" image and an "active" priority
"2" image the confirm would not appear on a priority change
and it should.

I believe this logic came from the belief that the "functional"
image is always priority "0" and therefore only display
this confirm when the "functional" image is affected by the
change. The functional image is not always priority "0" and
with only 2 "active" images supported (only "active" images have
a priority) (the "functional" image is an "active" image) all
priority changes affect the functional image so adding this
confirm for all priority changes.

Tested: See this confirm on every priority change.
Change-Id: Icd113686f15a2e82ead72d04677335ee635cf668
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Update firmware text

The software image at the top of the table (i.e. the one with
the highest priority) is used the next time the device is
booted. Update the text to reflect this.
More information

Update firmware text

The software image at the top of the table (i.e. the one with
the highest priority) is used the next time the device is
booted. Update the text to reflect this.
More information on Priority can be found here:

github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/Software/RedundancyPriority.interface.yaml

Tested: Verified I see the text.
Change-Id: I95bc9070f5d18f566dd84d3f57948ea2b41506e6
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Have the "action" table cell flex

Let the action table cell flex to fit 2 buttons, "Activate"
and "Delete". This happens on a "Ready" image.

Resolves openbmc/openbmc#2964

Tested: See both "Activat

Have the "action" table cell flex

Let the action table cell flex to fit 2 buttons, "Activate"
and "Delete". This happens on a "Ready" image.

Resolves openbmc/openbmc#2964

Tested: See both "Activate" and "Delete" on a "Ready" image.
Change-Id: I1a91ed83f2f99983795baea9f59bbc0dd4749c0e
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Display the version when confirming "Delete"

When confirming an image delete the GUI now displays
"Delete firmware v2.0-165-ge571670?"

Resolves openbmc/openbmc#2961

Tested: Confirmed text is corre

Display the version when confirming "Delete"

When confirming an image delete the GUI now displays
"Delete firmware v2.0-165-ge571670?"

Resolves openbmc/openbmc#2961

Tested: Confirmed text is correct and delete works
Change-Id: Iad23908fbafc9514044be7770d269e723b35cb58
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Display Version when confirming changing priority

Before the GUI displayed when changing the priority:
"Change firmware e129c45b priority?"

It now displays:

"Change firmware v2.0-165-ge571670 prio

Display Version when confirming changing priority

Before the GUI displayed when changing the priority:
"Change firmware e129c45b priority?"

It now displays:

"Change firmware v2.0-165-ge571670 priority?"

This is important since the user never sees the
image ID (e.g. e129c45b) and always sees the
image version (e.g. v2.0-165-ge571670).

Tested: confirmed text is correct and change priority works
Change-Id: Ie9403aaade8a307b6de54feef20adc2b04e2b80b
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove trailing spaces from files

Tested: Manually tested GUI for any regressions
Change-Id: I8c0922b7bd67b03b07e8880bc4dba3b862220b33
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Fix the "Upload firmware" button

The "Upload firmware" button was not calling the uploadImage()
function in api-utils.js.
The uploadImage() function was not making the correct call to
the /upload/im

Fix the "Upload firmware" button

The "Upload firmware" button was not calling the uploadImage()
function in api-utils.js.
The uploadImage() function was not making the correct call to
the /upload/image REST API.
Removed the confirmUpload function since not needed on a
upload since the user has already selected the file they
want to upload, pressed "Open", and then pressed the
"Upload firmware" button.

Resolves openbmc/openbmc#2770

Tested: Uploaded several images to a Witherspoon system.
Change-Id: Ia0e0ffba501066f59a4355b8f61595e30aea3f98
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Modernize web GUI and make it installable on BMC

1. Move from gulp server to webpack. This allows the proper
compression to allow the webui to be embedded in the BMC.
2. Update js paths to use requ

Modernize web GUI and make it installable on BMC

1. Move from gulp server to webpack. This allows the proper
compression to allow the webui to be embedded in the BMC.
2. Update js paths to use requires, not hardcoded paths. This was
required to make the packaging work correctly.
3. Add babel config to do translation.
4. Update angularjs directive calls to use the angular 1.6 syntax for
promises intead of success and fail.

https://docs.angularjs.org/guide/migration#migrate1.5to1.6-ng-services-$http

5. As a consequence of using NPM/webpack, the versions of angular and
associated modules that were checked in have been updated.

Change-Id: Icb71e2eedb0d9a8943fc914f9dc4be11d0983c00
Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Updating network settings

Adding display network settings info in network settings page

Change-Id: I5ab3b399445b8d2d6422f907dc4c5a477bfc794d
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>

Updating login structure

Updated login structure with a field where user can manually add server hostname if it is not populated automatically

Change-Id: I147c2c15869131540e327bda26c05b59d78e01d5
S

Updating login structure

Updated login structure with a field where user can manually add server hostname if it is not populated automatically

Change-Id: I147c2c15869131540e327bda26c05b59d78e01d5
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>

show more ...

Updating images and stles

Updating images and styles after code merge conflicts

Change-Id: I96490926caa41d13e4d625ff67f6a463d7819d34
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>

added confirmation modal

Change-Id: If1bdfd21b34cba5944c1acc69e90ca35ea0189c0
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

network settings modal template added

Change-Id: If4612da39126fbfbaaebc915c59b4404092f05e1
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

fixed content errors

Change-Id: I9bccc9c728bb40925bf4072bb9440b506efb014f
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

Revisiting log status info in header with better styes

Change-Id: I0b2ee399243f0bc3e5ed44bc578a0d153486ed55
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>

moved code from index-controller to multi-server-controller

Change-Id: Id97de89d646bc0c980fd4f0849109047906383e1
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

cleaned up empty class attributes

Change-Id: Ic285c863194da08ebc7ae683fc4247527bed4db8
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

accessibility fixes and minor css changes.

- added aria-hidden = "true" to prevent icons to be read by screen readers
- moved code on pages into "page-header" for better consistency

Change-Id: I3f4

accessibility fixes and minor css changes.

- added aria-hidden = "true" to prevent icons to be read by screen readers
- moved code on pages into "page-header" for better consistency

Change-Id: I3f497b2707991f7f628892a05734eea183a0d01d
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

show more ...