| 27915d2f | 15-Nov-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Fix truncated button icons on Safari
Removing margin offset to fix issue with button icons being
visually truncated on Safari. Removing additional redundant
code around same icon/buttons.
Signed-of
Fix truncated button icons on Safari
Removing margin offset to fix issue with button icons being
visually truncated on Safari. Removing additional redundant
code around same icon/buttons.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ie1ef89023a043a70a0126a21be57febb9afae19a
show more ...
|
| 1ab0f7c1 | 24-Oct-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Create firmware-card component
Create reusable firmware card component that will be
used in the updated firmware page:
https://ibm.invisionapp.com/share/4XNZ0JAMJ7B#/screens/319212821_4-8-D-1_Home
Create firmware-card component
Create reusable firmware card component that will be
used in the updated firmware page:
https://ibm.invisionapp.com/share/4XNZ0JAMJ7B#/screens/319212821_4-8-D-1_Home
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I86e526c59ac5c2e2c011aed0ce4bc3d82db63b5e
show more ...
|
| afc8a799 | 17-Jun-2019 |
miramurali23 <miramurali23@gmail.com> |
Update users navigation section
- Changed the section name to be access-control
- Moved LDAP Settings and Certificate Management to access-control navigation
- Changed Manage User Account subsection
Update users navigation section
- Changed the section name to be access-control
- Moved LDAP Settings and Certificate Management to access-control navigation
- Changed Manage User Account subsection name to Local User Management
Resolves: openbmc/phosphor-webui#619
Signed-off-by: Mira Murali <miramurali23@gmail.com>
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I0d94c80c295b997d94c04330fd87f4fc4d229bf8
show more ...
|
| 5e258e43 | 07-Nov-2018 |
beccabroek <beccabroek@gmail.com> |
LDAP configuration and user groups
Adds LDAP page and ability to add and change configuration settings.
Adds ability to add, remove and edit user groups for LDAP.
Resolves openbmc/phosphor-webui#38
LDAP configuration and user groups
Adds LDAP page and ability to add and change configuration settings.
Adds ability to add, remove and edit user groups for LDAP.
Resolves openbmc/phosphor-webui#38
Resolves openbmc/phosphor-webui#39
Tested: Loaded on to a witherspoon and able to add initial LDAP config
as well us update the configuration and role groups. Appropriate messages displayed
to user when required fields are missing or in the incorrect format.
Change-Id: If8a21f3f9d9334415ead73472e90b2a0823bf9ea
Signed-off-by: beccabroek <beccabroek@gmail.com>
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Signed-off-by: Derick Montague <derick.montague@ibm.com>
show more ...
|
| 418db63c | 19-Sep-2019 |
Gunnar Mills <gmills@us.ibm.com> |
Move Virtual Media files and route
"Virtual media" was already part of the "Server control" submenu but
the files were at app/configuration and the route was /configuration.
Marta Mazur did a simil
Move Virtual Media files and route
"Virtual media" was already part of the "Server control" submenu but
the files were at app/configuration and the route was /configuration.
Marta Mazur did a similar file and route move here as part of
supporting multiple Virtual Media endpoints:
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-webui/+/25218
Tested: Built and loaded on a Witherspoon. The VM route is now:
#/server-control/virtual-media. Was able to use the VM
panel.
Change-Id: Iec46a8ece7ddfbc356bc1e71875def70c4418027
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
| 1a2bd74d | 09-Sep-2019 |
Dixsie Wolmers <dixsiew@gmail.com> |
Certificate management alert icons implementation and alignment
- Replaces background image icons with icon directive
- Sizes and aligns icons in certificate table
TODO:
- Remove critical icon back
Certificate management alert icons implementation and alignment
- Replaces background image icons with icon directive
- Sizes and aligns icons in certificate table
TODO:
- Remove critical icon background image in separate commit
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I2e10bc3f3432331b6dd9354dbcd0e32480894ece
show more ...
|
| 383591af | 07-Sep-2019 |
Dixsie Wolmers <dixsiew@gmail.com> |
Update SNMP page layout
This change applies global styles to improve
page layout consistency and removes unnecessary
custom styling.
- Adds page, section, form field and actions styles
- Removes un
Update SNMP page layout
This change applies global styles to improve
page layout consistency and removes unnecessary
custom styling.
- Adds page, section, form field and actions styles
- Removes unused styles
Tested:
- Passes DAP
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I96bb4732fdf160b2cc9eff0ad3ed9309ab1b9ea4
show more ...
|
| 57ed98ee | 06-Sep-2019 |
Dixsie Wolmers <dixsiew@gmail.com> |
Fix IE11 SNMP edit bug
- Removes edit button from form
- Removes focus-within (not compatible with IE11 and Edge)
and pointer-event
Tested:
- Input fields are editable and can be saved
- DAP viol
Fix IE11 SNMP edit bug
- Removes edit button from form
- Removes focus-within (not compatible with IE11 and Edge)
and pointer-event
Tested:
- Input fields are editable and can be saved
- DAP violations and page layout consistency will be addressed
in separate commit
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: I2ccd06802137c2969fec686abc5b5f8e785725b6
show more ...
|
| 219738d2 | 15-Aug-2019 |
miramurali23 <miramurali23@gmail.com> |
Fix missing expiring/expired icons and warnning messages in certificate table
- Confirmed with backend developer that we should be checking certificate expiration date with bmc date/time set
- Conve
Fix missing expiring/expired icons and warnning messages in certificate table
- Confirmed with backend developer that we should be checking certificate expiration date with bmc date/time set
- Converted both certificate expiration date and bmc date/time to EPOCH time to fix the bug
Tested: Go to Date and Time settings and change BMC time to be after or 30 days before a certificate expiration date.
Then either a warning or expiration icon and message will be displayed next to the date and message on top of the table.
To remove the expiration or warning date, upload a certificate that has an expiration date greater than 30 days after bmc time
set. The icon and warning message should now disappear.
Signed-off-by: Mira Murali <miramurali23@gmail.com>
Change-Id: I9389fe3cce5a555945adf9c56180897a6be047bf
show more ...
|
| 5e8785d3 | 10-Jun-2019 |
miramurali23 <miramurali23@gmail.com> |
Create csr modal
The CSR Modal allows users to generate a CSR code. Once the user
types in the necessary information to generate the CSR code, that modal
will then render the code and the user will
Create csr modal
The CSR Modal allows users to generate a CSR code. Once the user
types in the necessary information to generate the CSR code, that modal
will then render the code and the user will be able to either copy the
code or download the code in a txt file.
Tested: loaded onto Witherspoon and able to view on certificate
management page. Click on generate csr and type in necessary
(or any additional info), then click on generate CSR. The CSR
code is then visible and is able to be copied or downloaded. In
error state in which CSR code is unable to generate, the modal
closes and an error toast message appears. FYI: Sometimes you
have to reboot system in order for csr to successfully generate.y
Signed-off-by: Mira Murali <miramurali23@gmail.com>
Change-Id: I3cca09c494357496166164b5ee8ff99250ef981d
show more ...
|
| c81cdd4a | 25-Jul-2019 |
Zbigniew Kurzynski <zbigniew.kurzynski@intel.com> |
Extending certificate table with Issuer and Subject columns.
This commit introduce two new columns on certificate table.
It should help user to differentiate multiple mTLS certificates.
Date format
Extending certificate table with Issuer and Subject columns.
This commit introduce two new columns on certificate table.
It should help user to differentiate multiple mTLS certificates.
Date format was changed to 'medium' one to accommodate two new columns.
Small corrections were made to action button paddings to make the icon better centered.
Tested: GUI tests were done on Chromium v74.0.3729 browser. Desktop and mobile version.
Signed-off-by: Zbigniew Kurzynski <zbigniew.kurzynski@intel.com>
Change-Id: I660b74dd8b50f854ebbdad1890bbf99b3675f4cd
show more ...
|
| 6f7ec80e | 24-Jun-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Clean up color values
This update will clean up slight color variations in the
code base by creating and using Sass color variables
instead of hex values. Available colors are defined in
colors.scss
Clean up color values
This update will clean up slight color variations in the
code base by creating and using Sass color variables
instead of hex values. Available colors are defined in
colors.scss. Any usage of CSS color properties should
refer to the mapped color variables in colors.scss.
- Removed tags.scss file since tag components no longer used
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I045030a158469e59d07a9fa8cd8aa9f125f0d383
show more ...
|
| 309b5da3 | 07-Nov-2018 |
beccabroek <beccabroek@gmail.com> |
Create certificate management page
Displays certificates and the ability to add up to one
of each type of certificate (as limited by the backend
implementation). HTTPS certificate and LDAP client ce
Create certificate management page
Displays certificates and the ability to add up to one
of each type of certificate (as limited by the backend
implementation). HTTPS certificate and LDAP client cert
are implemented in this commit, with the ability to add
more types as needed by adding them to the constants.js
CERTIFICATE_TYPES array.
Also provides the ability to replace a certificate once
it is added.
Resolves openbmc/phosphor-webui#43
Tested: loaded onto a witherspoon and able to view and
replace both the HTTPS certificate and the
LDAP certificate. GUI only allows to upload an
LDAP certificate if one doesn't already exist.
The GUI limits the user to one file per type as
expected at this time and provides the
appropriate validation messages. Alert messages
appear above the table if the certificate is
expired or within 30 days of expiring.
Change-Id: I345267280ecd3cb257e9304886cde9ebb69b1240
Signed-off-by: beccabroek <beccabroek@gmail.com>
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
show more ...
|
| c86ce3c9 | 05-Jun-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Consolidate button styles
This patchset will create consistent button styling according
to the styleguide and remove redundant button styles by creating
reusable button classes.
This patchset also
Consolidate button styles
This patchset will create consistent button styling according
to the styleguide and remove redundant button styles by creating
reusable button classes.
This patchset also implements a consistent strategy for including
icon assets. Currently, svg icons are imported as CSS background
images or inlined into the markup. Inlining an svg is preferred,
especially when used with buttons or links so the colors can
be easily changed for different states (hover, focus, disabled)
without having to request variants.
The icon provider allows us to inline svgs without cluttering
the markup. Webpack config was adjusted to use svg-inline-loader
when resolving svgs that are used by the icon provider directive.
- All svgs were optimized to remove unncessary information.
- Removed unused svg color variants
- Moved icons used by icon provider to separate directory to
avoid Webpack parsing the files twice
- Small changes to navigation icons
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I1ca214b74fc502e6b6e760cfee88b48110237c43
show more ...
|
| 5bd1dec7 | 16-May-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Change button styles from rounded to straight corners
This will create more visual consistency between the components
in the GUI since there are elements, such as text fields and
dropdowns that are
Change button styles from rounded to straight corners
This will create more visual consistency between the components
in the GUI since there are elements, such as text fields and
dropdowns that are styled with straight corners.
- Removes border radius from buttons
- Removes some redundant styles
- Adds input types that aren't currently inheriting
defined styles
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I6ff1bde91e2e57df01484dd20003925cd914ffa2
show more ...
|
| 44da471f | 20-Mar-2019 |
beccabroek <beccabroek@gmail.com> |
Virtual media page
Adds page to manage virtual media devices. User selects file
and pushes 'start' button to establish websocket connection.
nbdServerService added to provide ability for user to nav
Virtual media page
Adds page to manage virtual media devices. User selects file
and pushes 'start' button to establish websocket connection.
nbdServerService added to provide ability for user to navigate
away from the page and return with the ability to see the current
active sessions.
Currently only supports 1 Virtual Media device.
Resolves openbmc/phosphor-webui#40
Tested: uploaded ubuntu image file, started the connection and
mounted virtual media device from host console. Able to see Ubuntu
image file. Also uploaded file and navigated away from the page,
checking that the websocket remained open and was sending /
recieving messages. Finally, tested that when connection
was stopped, 'USB disconnect' log was present in host console.
Change-Id: Ia3155d27cbcfef94c2753dde1303a151e08847cc
Signed-off-by: beccabroek <beccabroek@gmail.com>
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
Signed-off-by: Derick Montague <derick.montague@ibm.com>
show more ...
|
| de382089 | 30-Apr-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Add dropdown caret to time owner dropdown on Date and Time Settings
- Use background-image strategy to add caret to dropdowns
- Standardize implementation by including mixin to dropdown__button
cl
Add dropdown caret to time owner dropdown on Date and Time Settings
- Use background-image strategy to add caret to dropdowns
- Standardize implementation by including mixin to dropdown__button
class and removing styled pseudo element
Resolves ibm-openbmc/dev#478
Tested: Running locally on Chrome only. Ran into network request
errors for newly added svg assets when mounting overlay
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I714c2515282676f368eafb2560177d2935680e23
show more ...
|
| 1ffa209e | 01-Apr-2019 |
Derick Montague <derick.montague@ibm.com> |
Resolve accessibility isssues
- Remove unecessary aria-roles
- Associate label elements with form elements
- Remove extraneous markup on Network settings page
- Update generic markup to use definiti
Resolve accessibility isssues
- Remove unecessary aria-roles
- Associate label elements with form elements
- Remove extraneous markup on Network settings page
- Update generic markup to use definition list when appropriate
- Add aria-labels and aria-expanded to accordion triggers
Tested: Accessibility issues tested in using Lighthouse in Chrome
Developer tools Audit section and Dequeue Axe extension. Manually tested clicking on labels
set focus on the form elements. Visually tested of the Network
Settings page in Chrome, Firefox, and Safari to verify layout changes.
Resolves openbmc/phosphor-webui#76
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: Ib974c623e9d3b74e74e1f374c21e8191732ec26a
show more ...
|
| ddda4dec | 28-Jan-2019 |
beccabroek <beccabroek@gmail.com> |
SNMP page visual redesign
Adds form validation to SNMP page. Also adds new icons to
page for edit and delete. Validation messages for inputs
appear after input has been touched or if the user attemp
SNMP page visual redesign
Adds form validation to SNMP page. Also adds new icons to
page for edit and delete. Validation messages for inputs
appear after input has been touched or if the user attempts
to submit the form with validation errors.
Tested: Add, remove, and update SNMP was successful and
functionality unchanged. Form did not allow invalid or
empty values to submitted. Used Chrome, Safari, and Firefox
to verify that visual design looked as expected.
Resolves openbmc/phosphor-webui#37
Change-Id: I7a97d80724e56d2f22c74ac1251041270bbc35ad
Signed-off-by: beccabroek <beccabroek@gmail.com>
show more ...
|
| 90ae95eb | 15-Jan-2019 |
beccabroek <beccabroek@gmail.com> |
Add toast to Firmware page
Replace error and success messages with toast notifications.
Change-Id: I6c68568b7c9db4fd1f85b3de843289cf1bfba376
Signed-off-by: beccabroek <beccabroek@gmail.com> |
| 84e114a4 | 14-Nov-2018 |
Gunnar Mills <gmills@us.ibm.com> |
Move to Bootstrap 4
Bootstrap < 4.1.2 has the following CVE:
https://nvd.nist.gov/vuln/detail/CVE-2018-14041
Removed bootstrap-theme.css due to "Replaced the separate optional
theme with configurab
Move to Bootstrap 4
Bootstrap < 4.1.2 has the following CVE:
https://nvd.nist.gov/vuln/detail/CVE-2018-14041
Removed bootstrap-theme.css due to "Replaced the separate optional
theme with configurable options via SCSS variables
(e.g., $enable-gradients: true)."
Added "width: 100%" to a few places where width 100% was no longer
getting inherited.
Moved a few elements and adjusted styles to get the same look as
before.
See https://getbootstrap.com/docs/4.0/migration/ for more
information.
Tested: Manually on a Witherspoon.
Change-Id: I0a72665ac1ca6eacd0b553a585b1fb15e14ae62c
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
| 1cc7021c | 05-Nov-2018 |
beccabroek <beccabroek@gmail.com> |
Move more info icon
Currently, the more info icon (...) is positioned too far
from the server version on the firmware page. This places the
icon 20 px to the right, so that it is clearly associated
Move more info icon
Currently, the more info icon (...) is positioned too far
from the server version on the firmware page. This places the
icon 20 px to the right, so that it is clearly associated
with the version.
Resolves openbmc/phosphor-webui#23
Change-Id: I5d1dc6bf1446c9f10ee0181d9b9fa2eb3e53e498
Signed-off-by: beccabroek <beccabroek@gmail.com>
show more ...
|
| 022b6cf1 | 18-Sep-2018 |
Gunnar Mills <gmills@us.ibm.com> |
Remove SNMP Managers
Allow the user to remove SNMP Managers.
If the SNMP Manager being removed exists in the backend, make a
call to remove it.
Tested: Removed SNMP Managers on a Witherspoon
Change
Remove SNMP Managers
Allow the user to remove SNMP Managers.
If the SNMP Manager being removed exists in the backend, make a
call to remove it.
Tested: Removed SNMP Managers on a Witherspoon
Change-Id: Ib392cda30754adfaa58f6301592c2d666ff2c29e
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
| 854fbba1 | 13-Sep-2018 |
Gunnar Mills <gmills@us.ibm.com> |
Add and modify SNMP Managers
This allows the user to add and edit SNMP managers.
Tested: Added SNMP managers on a Witherspoon.
Change-Id: Iab8d6463b03de75928e4989135172d93ab0f28a3
Signed-off-by: Gu
Add and modify SNMP Managers
This allows the user to add and edit SNMP managers.
Tested: Added SNMP managers on a Witherspoon.
Change-Id: Iab8d6463b03de75928e4989135172d93ab0f28a3
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
| b60f5be1 | 10-Oct-2018 |
beccabroek <beccabroek@gmail.com> |
Functional version font color
Blue makes the text appear to be a link.
Updated text color to dark grey.
Resolves openbmc/phosphor-webui#22
Change-Id: I5950473844d2edfeaf5ede80b46984bc152d7483
Sign
Functional version font color
Blue makes the text appear to be a link.
Updated text color to dark grey.
Resolves openbmc/phosphor-webui#22
Change-Id: I5950473844d2edfeaf5ede80b46984bc152d7483
Signed-off-by: beccabroek <beccabroek@gmail.com>
show more ...
|