Fix icon-warning syntax error

There were a few instances of the icon-warning icon that didn't
include the file extenstion needed to when adding the file attribute
property in the ico

Fix icon-warning syntax error

There were a few instances of the icon-warning icon that didn't
include the file extenstion needed to when adding the file attribute
property in the icon directive.

Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: Ib25c28c72285fa214f75258b0b09790d52bb6cc1

show more ...

Clean up icons

Clean up duplicate svg icons from assets directory.
Created a statusIcon component to dynamically render
status icons instead of using background-image in
scss fil

Clean up icons

Clean up duplicate svg icons from assets directory.
Created a statusIcon component to dynamically render
status icons instead of using background-image in
scss files.

- Moved/removed on, off, critical, warning svg icons from
assets directory
- Updated background-image status icons to use <icon>
or <status-icon> directive

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ic0f06d78b0861d6f60d40b2dcc0b80fd6dad2a88

show more ...

Consolidate button styles

This patchset will create consistent button styling according
to the styleguide and remove redundant button styles by creating
reusable button classes.

Consolidate button styles

This patchset will create consistent button styling according
to the styleguide and remove redundant button styles by creating
reusable button classes.

This patchset also implements a consistent strategy for including
icon assets. Currently, svg icons are imported as CSS background
images or inlined into the markup. Inlining an svg is preferred,
especially when used with buttons or links so the colors can
be easily changed for different states (hover, focus, disabled)
without having to request variants.
The icon provider allows us to inline svgs without cluttering
the markup. Webpack config was adjusted to use svg-inline-loader
when resolving svgs that are used by the icon provider directive.

- All svgs were optimized to remove unncessary information.
- Removed unused svg color variants
- Moved icons used by icon provider to separate directory to
avoid Webpack parsing the files twice
- Small changes to navigation icons

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I1ca214b74fc502e6b6e760cfee88b48110237c43

show more ...

Firmware page upload not working in some cases

Upload was not working in some cases because of two separate
issues. Inline onchange is no longer executed in Chrome. This
removes the

Firmware page upload not working in some cases

Upload was not working in some cases because of two separate
issues. Inline onchange is no longer executed in Chrome. This
removes the inline onchange event since it was updating a variable
not being used anyway. This also updates the click-outside
directive as it was missing [ ] brackets that were necessary and
throwing an error in the console when loaded onto a witherspoon.

see https://developer.chrome.com/extensions/contentSecurityPolicy

and

https://stackoverflow.com/questions/35126898/error-after-minifica
tion-of-angular-js-error-injectorunpr-unknown-provider

Resolves openbmc/phosphor-webui#77

Tested: Able to upload image onto Witherspoon. Click-outside directive
worked when GUI was mounted on a Witherspoon

Change-Id: I7b1c385751e114b2d31f516e391dd0737117ab42
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Clean up headers

Updates headers to match style guide and makes them consistent
throughout pages in the GUI. Removes instances where a header
element existed and a different header s

Clean up headers

Updates headers to match style guide and makes them consistent
throughout pages in the GUI. Removes instances where a header
element existed and a different header style was being applied.
For example, <h2 class="h4">

Tested: Ran GUI locally and verified that headers look consistent
and have the appropriate sizing while using Chrome, Firefox and
Safari.

Change-Id: I187136298ed2bfd36c40c2b80d5a4f20947cbe56
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Add toast to Firmware page

Replace error and success messages with toast notifications.

Change-Id: I6c68568b7c9db4fd1f85b3de843289cf1bfba376
Signed-off-by: beccabroek <beccabroe

Add toast to Firmware page

Replace error and success messages with toast notifications.

Change-Id: I6c68568b7c9db4fd1f85b3de843289cf1bfba376
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Remove tabs from HTML files

From https://google.github.io/styleguide/htmlcssguide.html
"Indentation
Indent by 2 spaces at a time.

Don't use tabs or mix tabs and spaces for i

Remove tabs from HTML files

From https://google.github.io/styleguide/htmlcssguide.html
"Indentation
Indent by 2 spaces at a time.

Don't use tabs or mix tabs and spaces for indentation."

Tested: Manual regression testing on a Witherspoon.
Change-Id: Ief7137dabc869b73b73f9947337fbb0abb5ca497
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Activate image and reboot host

When activating a host image, gives the option to:
a) Activate image without booting
b) Activate image and boot host. If server is
in 'off

Activate image and reboot host

When activating a host image, gives the option to:
a) Activate image without booting
b) Activate image and boot host. If server is
in 'off' status the option is to power on.
If the server is in 'unavailable', 'on', or
'error' status the option is to reboot
Also updated polling during boot and reboot to use
/subscribe API.

Resolves openbmc/openbmc#3323

Tested: The GUI displays the options and boots /
reboots appropriately based on server status.

Change-Id: I62c19e094ecc7112263c26844fcd30b2bf3c2b84
Signed-off-by: beccabroek <rebecca.shaw@ibm.com>

show more ...

Display success message after uploading image

Fix includes:
- Displaying an 'Upload complete' message and clearing the image's
file name if the upload succeeds.
- Displaying an

Display success message after uploading image

Fix includes:
- Displaying an 'Upload complete' message and clearing the image's
file name if the upload succeeds.
- Displaying an error pop-up with reason for failure when the
upload fails.

Change-Id: Id9474b62ed62e1b40ffa018eb273abbf19be26ce
Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>

show more ...

Refresh the firmware page after downloading image

Fix includes
- Polling the number of software objects for a new image. During
which time the 'Downloading in progress' status bar

Refresh the firmware page after downloading image

Fix includes
- Polling the number of software objects for a new image. During
which time the 'Downloading in progress' status bar will be
displayed. A 2-minute timeout is used.
- Displaying a 'Download complete' message if the download succeeds
and refreshing the firmware page to show the new image once it is
downloaded.
- Displaying an error pop-up with reason for failure when the
download fails.

Resolves openbmc/openbmc#3054

Change-Id: I79a8b8c661c01474a12cef4af524cafdc2cee1fe
Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>

show more ...

Display error if TFTP field empty

If either TFTP Server IP Address or File Name is empty for the
"Download image file from TFTP server" function, return and
display an error.

Display error if TFTP field empty

If either TFTP Server IP Address or File Name is empty for the
"Download image file from TFTP server" function, return and
display an error.

Tested: Verified I see this error if either field is empty.

Change-Id: I3da3353dad7cfb0f765d8a662412c3adb3fa4efd
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add Activate firmware and reboot button

Added a radio button to activate firmware and reboot the BMC.
If the "Activate firmware and reboot" option is selected, reboot
the BMC after a

Add Activate firmware and reboot button

Added a radio button to activate firmware and reboot the BMC.
If the "Activate firmware and reboot" option is selected, reboot
the BMC after activating the firmware. The user is then logged
out.

Resolves openbmc/openbmc#3027

Tested: When "Activate firmware and reboot" option is selected,
the BMC reboots after activating. When it is not selected,
the BMC image just activates.
Change-Id: I07293dc8a6ddfac4cf58ba2c1d1352c9afd6fa8d
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add server confirm activation modal

Added text specific to server images that appears in the
activation modal when a "server" image is activated.
The "server" and "BMC" images use th

Add server confirm activation modal

Added text specific to server images that appears in the
activation modal when a "server" image is activated.
The "server" and "BMC" images use the same modal, but the text
and if radio buttons appear differ.

Resolves openbmc/openbmc#2967

Tested: Activated both a server and BMC image on a Witherspoon.
Change-Id: I83693641ebfef802d403141ade55a950f359ba6e
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove "reboot" modal

This modal was not used.

Tested: Uploaded and activated an image on a Witherspoon.
Change-Id: I3eb549b04f09565da06a28815b2b3843dd72cafb
Signed-off-by:

Remove "reboot" modal

This modal was not used.

Tested: Uploaded and activated an image on a Witherspoon.
Change-Id: I3eb549b04f09565da06a28815b2b3843dd72cafb
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Move from "Preserve settings" to "Confirm Activation"

The "Preserve settings" popup that showed when a user activated
an image was not useful and did not do anything. Saving network

Move from "Preserve settings" to "Confirm Activation"

The "Preserve settings" popup that showed when a user activated
an image was not useful and did not do anything. Saving network
settings prior to activation is not needed so moved to a
"Confirm Activation" modal.
This modal will eventually include an
"activate BMC firmware and reboot" selection,
openbmc/openbmc#3027, for now it only holds the one selection.
The "Preserve settings" and now this "Confirm Activation"
modal both appear on "server" and "BMC" images, this is a bug
that is fixed in a later commit.

Tested: Activated an image on a Witherspoon machine.
Change-Id: I7176d5a314ea325e6e94606ef07b32786ede64e9
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Update firmware text

The software image at the top of the table (i.e. the one with
the highest priority) is used the next time the device is
booted. Update the text to reflect this.

Update firmware text

The software image at the top of the table (i.e. the one with
the highest priority) is used the next time the device is
booted. Update the text to reflect this.
More information on Priority can be found here:

github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/Software/RedundancyPriority.interface.yaml

Tested: Verified I see the text.
Change-Id: I95bc9070f5d18f566dd84d3f57948ea2b41506e6
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Display Version when confirming changing priority

Before the GUI displayed when changing the priority:
"Change firmware e129c45b priority?"

It now displays:

"Change fir

Display Version when confirming changing priority

Before the GUI displayed when changing the priority:
"Change firmware e129c45b priority?"

It now displays:

"Change firmware v2.0-165-ge571670 priority?"

This is important since the user never sees the
image ID (e.g. e129c45b) and always sees the
image version (e.g. v2.0-165-ge571670).

Tested: confirmed text is correct and change priority works
Change-Id: Ie9403aaade8a307b6de54feef20adc2b04e2b80b
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Fix the "Upload firmware" button

The "Upload firmware" button was not calling the uploadImage()
function in api-utils.js.
The uploadImage() function was not making the correct call t

Fix the "Upload firmware" button

The "Upload firmware" button was not calling the uploadImage()
function in api-utils.js.
The uploadImage() function was not making the correct call to
the /upload/image REST API.
Removed the confirmUpload function since not needed on a
upload since the user has already selected the file they
want to upload, pressed "Open", and then pressed the
"Upload firmware" button.

Resolves openbmc/openbmc#2770

Tested: Uploaded several images to a Witherspoon system.
Change-Id: Ia0e0ffba501066f59a4355b8f61595e30aea3f98
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Updating login structure

Updated login structure with a field where user can manually add server hostname if it is not populated automatically

Change-Id: I147c2c15869131540e327bda26

Updating login structure

Updated login structure with a field where user can manually add server hostname if it is not populated automatically

Change-Id: I147c2c15869131540e327bda26c05b59d78e01d5
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>

show more ...

fixed content errors

Change-Id: I9bccc9c728bb40925bf4072bb9440b506efb014f
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

Revisiting log status info in header with better styes

Change-Id: I0b2ee399243f0bc3e5ed44bc578a0d153486ed55
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>

moved code from index-controller to multi-server-controller

Change-Id: Id97de89d646bc0c980fd4f0849109047906383e1
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

accessibility fixes and minor css changes.

- added aria-hidden = "true" to prevent icons to be read by screen readers
- moved code on pages into "page-header" for better consistency

accessibility fixes and minor css changes.

- added aria-hidden = "true" to prevent icons to be read by screen readers
- moved code on pages into "page-header" for better consistency

Change-Id: I3f497b2707991f7f628892a05734eea183a0d01d
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

show more ...

bug fixes and copy changes based on user feedback

Change-Id: I2dd2cc6168d86676ab7ada9b389cb86cee9b3dae
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

changing styles and html to match design changes

Change-Id: I2b5f24ca8421f5097c3733bc235e7cadf252d1fb
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>