Fix date and time settings bug

When time mode is initially set to Manual from NTP,
NTP service is disabled and the NTP service is stopping
but not stopped, setting time will return a

Fix date and time settings bug

When time mode is initially set to Manual from NTP,
NTP service is disabled and the NTP service is stopping
but not stopped, setting time will return an error.
There are no response messages to notify when
NTP is completely stopped.

To work around, a timeout is set to allow NTP to fully stop
before saving date/time changes.

https://github.com/openbmc/phosphor-time-manager/blob/master/README.md

Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: Icb86dfe339a10567aecf9aedd9b0dd696937a398

show more ...

Consolidate button styles

This patchset will create consistent button styling according
to the styleguide and remove redundant button styles by creating
reusable button classes.

Consolidate button styles

This patchset will create consistent button styling according
to the styleguide and remove redundant button styles by creating
reusable button classes.

This patchset also implements a consistent strategy for including
icon assets. Currently, svg icons are imported as CSS background
images or inlined into the markup. Inlining an svg is preferred,
especially when used with buttons or links so the colors can
be easily changed for different states (hover, focus, disabled)
without having to request variants.
The icon provider allows us to inline svgs without cluttering
the markup. Webpack config was adjusted to use svg-inline-loader
when resolving svgs that are used by the icon provider directive.

- All svgs were optimized to remove unncessary information.
- Removed unused svg color variants
- Moved icons used by icon provider to separate directory to
avoid Webpack parsing the files twice
- Small changes to navigation icons

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I1ca214b74fc502e6b6e760cfee88b48110237c43

show more ...

Resolve accessibility isssues

- Remove unecessary aria-roles
- Associate label elements with form elements
- Remove extraneous markup on Network settings page
- Update generic ma

Resolve accessibility isssues

- Remove unecessary aria-roles
- Associate label elements with form elements
- Remove extraneous markup on Network settings page
- Update generic markup to use definition list when appropriate
- Add aria-labels and aria-expanded to accordion triggers

Tested: Accessibility issues tested in using Lighthouse in Chrome
Developer tools Audit section and Dequeue Axe extension. Manually tested clicking on labels
set focus on the form elements. Visually tested of the Network
Settings page in Chrome, Firefox, and Safari to verify layout changes.

Resolves openbmc/phosphor-webui#76

Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: Ib974c623e9d3b74e74e1f374c21e8191732ec26a

show more ...

Clean up headers

Updates headers to match style guide and makes them consistent
throughout pages in the GUI. Removes instances where a header
element existed and a different header s

Clean up headers

Updates headers to match style guide and makes them consistent
throughout pages in the GUI. Removes instances where a header
element existed and a different header style was being applied.
For example, <h2 class="h4">

Tested: Ran GUI locally and verified that headers look consistent
and have the appropriate sizing while using Chrome, Firefox and
Safari.

Change-Id: I187136298ed2bfd36c40c2b80d5a4f20947cbe56
Signed-off-by: beccabroek <beccabroek@gmail.com>

show more ...

Add toast to Date Time page

Change-Id: I0c0912f9d18fbb170ccf4863366b5973eb25050a
Signed-off-by: beccabroek <beccabroek@gmail.com>

Date-time: Use lowerCamelCase for vars

Following https://google.github.io/styleguide/jsguide.html.
Also, added a comment to clarify a variable.

Change-Id: I27dd8c0af6187ccd3f809

Date-time: Use lowerCamelCase for vars

Following https://google.github.io/styleguide/jsguide.html.
Also, added a comment to clarify a variable.

Change-Id: I27dd8c0af6187ccd3f8093b88ebe2674fd42747b
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add "(Primary)" to first NTP Server

The IBM design team though adding "(Primary)" to the first
NTP Server made it more clear that this NTP server is the
first NTP server the time man

Add "(Primary)" to first NTP Server

The IBM design team though adding "(Primary)" to the first
NTP Server made it more clear that this NTP server is the
first NTP server the time manager talks to.

Change-Id: Iaadbc4958621146db072541668a7a6f0a8834de4
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Date-time: Change h2 title

This title is more clear.

Change-Id: I8e4f89b1d2d91fe0745dedfcea1af124033d5cca
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Remove tabs from HTML files

From https://google.github.io/styleguide/htmlcssguide.html
"Indentation
Indent by 2 spaces at a time.

Don't use tabs or mix tabs and spaces for i

Remove tabs from HTML files

From https://google.github.io/styleguide/htmlcssguide.html
"Indentation
Indent by 2 spaces at a time.

Don't use tabs or mix tabs and spaces for indentation."

Tested: Manual regression testing on a Witherspoon.
Change-Id: Ief7137dabc869b73b73f9947337fbb0abb5ca497
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Button to remove NTP server

Change-Id: I58a3a894c192fafb551e07302b107bcd776e4901
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Set time fields

Squashed 5 commits to set the date-time fields:
time mode, time owner, BMC time, and host time.
Also included is a commit to display the timezone.

Set time m

Set time fields

Squashed 5 commits to set the date-time fields:
time mode, time owner, BMC time, and host time.
Also included is a commit to display the timezone.

Set time mode

Moved the selection of NTP vs Manual (time mode) to a radio
button.
Added code to allow the user set it.

Tested: Set the time mode on a Witherspoon.
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Set time owner

The time owner is now a dropdown and is set when "Save settings"
is pressed.

Tested: Set the time owner on a Witherspoon
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Set the BMC and Host time

The BMC and host have the same time except when time mode is split.
Only need to set BMC or host time when time mode is not split.
When time mode is split, set both. Use time owner to determine
which to set.
https://github.com/openbmc/phosphor-time-manager#time-settings

Have date and time as two separate inputs, this is due to Firefox
not supporting "datetime-local". The "date" and "time" input
fields are more widely supported.
https://caniuse.com/#feat=input-datetime

The idea for 2 separate input fields came from:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/datetime-local

Must set the time mode and time owner before setting the time,
this is due to permissions of who can set the time.

Tested: Set the date and time on a Witherspoon.
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Add NTP Servers

The user can now view and set NTP Servers.

Moved setFocusOnNewInput to a common directive since it is used
on the NTP Servers and the DNS Servers on the network page.

Even though NTPServers is a network interface specific path
(e.g. /xyz/openbmc_project/network/eth0/attr/NTPServers) it acts
like a global setting, openbmc/phosphor-time-manager#4.
Using eth0 for setting and getting the NTP Servers until
NTPServers is moved to a non-network interface specific path.

In Redfish, NTPServers is a non-network interface specific.

Tested: Set NTP Servers on a Witherspoon.
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Add timezone

Added the timezone for the host and bmc date time.

The timezone looks like "GMT-0400 (EDT)" or "GMT-0500 (CDT)".
I got this from
https://stackoverflow.com/questions/1091372/getting-the-clients-timezone-in-javascript
and choose this formatting over something like "America/Chicago".

Tested: See the timezone on a Witherspoon
Change-Id: I59a4449d63f73a6ed14cb934f3d8577e46620c4e
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add Host Time

If the Time Owner is 'BMC', 'Host', or 'Both' a single time field
is present with a title of "BMC and Host Time".
If the Time Owner is 'Split', meaning the BMC and Host

Add Host Time

If the Time Owner is 'BMC', 'Host', or 'Both' a single time field
is present with a title of "BMC and Host Time".
If the Time Owner is 'Split', meaning the BMC and Host have separate times,
2 time fields are present "BMC Time" and "Host Time".

Tested: Set Time Owner to "BMC" and Time Owner to "Split".
Change-Id: I6399fa30e4489d4bd62250b639e66e60cf9c2426
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add Time Owner and Time Mode

Added the Time Owner and the Time Mode
Created a new function that enumerates /xyz/openbmc_project/time.

Tested: See Time Mode and Time Owner
Ch

Add Time Owner and Time Mode

Added the Time Owner and the Time Mode
Created a new function that enumerates /xyz/openbmc_project/time.

Tested: See Time Mode and Time Owner
Change-Id: I3d1788bdb87b99028000d13c868b4a0cbfbc3006
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Create "Date and time settings" page

There was a Date and time page in the GUI. Enhanced it to
display the BMC time and added it to the menu so users
could navigate to it.

F

Create "Date and time settings" page

There was a Date and time page in the GUI. Enhanced it to
display the BMC time and added it to the menu so users
could navigate to it.

Future things planned for this page:
Setting the time, time mode, and time owner.
Adding a NTP server.

More information can be found in the time manager README:
https://github.com/openbmc/phosphor-time-manager/blob/master/README.md

Tested: See the BMC time.
Change-Id: Ia3ac2385cb45ec8009ed6df0899c3410fe18ef64
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Change navigation structure

Change-Id: I12c819293ce1eda188dc9f257ae9370f1b73cb18
Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>