clang-format-11: reformat

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I74d01806faf1884b8077c6c5c841ef194ff0b021

server-overview: supporting all MACs and IPs

Show MAC and IP address information for all the present
ethernet interfaces on the server overview page.

Tested: the `webui`-overview page on a system h

server-overview: supporting all MACs and IPs

Show MAC and IP address information for all the present
ethernet interfaces on the server overview page.

Tested: the `webui`-overview page on a system having
2 physical ethernet interfaces shows all IP addresses
assigned to the interface and also shows MAC addresses
for each interface

```
ETH0 IP ADDRESSES
IPv4: 172.17.26.67
IPv4: 169.254.28.79
IPv6: FE80::702C:BFFF:FEDE:DEC3

ETH1 IP ADDRESSES
IPv4: 169.254.51.25
IPv6: FE80::14B7:7EFF:FEF1:2EF

ETH0 MAC ADDRESS
72:2C:BF:DE:DE:C3

ETH1 MAC ADDRESS
16:B7:7E:F1:02:EF
```

End-user-impact: The server-overview page is now able to
display information about each ethernet's
MAC, IPv4 and IPv6 adresses.

Signed-off-by: Igor Kononenko <i.kononenko@yadro.com>
Change-Id: I677b645cc33bfc49c2dd91f4acc743973dc29998

show more ...

Remove scaled

Scale was removed from phosphor-dbus-interfaces when moving to a
double.
https://github.com/openbmc/phosphor-dbus-interfaces/commit/4ec6587fa908fe9df41cc0962ab6ff6446fbd54f

A future i

Remove scaled

Scale was removed from phosphor-dbus-interfaces when moving to a
double.
https://github.com/openbmc/phosphor-dbus-interfaces/commit/4ec6587fa908fe9df41cc0962ab6ff6446fbd54f

A future improvement could be some sort of rounding.

Tested: Loaded GUI on a Witherspoon
Change-Id: I771e575c85cc97196678a1da8e01d1fdb96ddf8c
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Fix SENSOR_SORT_ORDER array

'Meters' entry had been duplicated; 'Watts' was missing.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Change-Id: I836efa74120dd427253a4aee817216d37a93049a

Add CSRF to all remaining websockets

This passes the CSRF with the websocket so that
the pages continue to work after CSRF is added.

Tested: Verified SOL still worked

Change-Id: I8f1066c2769f92034

Add CSRF to all remaining websockets

This passes the CSRF with the websocket so that
the pages continue to work after CSRF is added.

Tested: Verified SOL still worked

Change-Id: I8f1066c2769f92034c349e7112ebc1070adcd35b
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

Fix "Clear Oem Logs" functionality in System Logs

Issue Symptom:
1. "Clear Oem Logs" button didn't show on webui when type select to "Oem".
2. "Clear Oem Logs" button was showed on then pressed with

Fix "Clear Oem Logs" functionality in System Logs

Issue Symptom:
1. "Clear Oem Logs" button didn't show on webui when type select to "Oem".
2. "Clear Oem Logs" button was showed on then pressed with fix, but the function didn't work correctly.
Event logs were deleted instead of Oem logs.

Root cause:
1. getSystemLogs() always get Event logs by default no matter type be selected to "Oem".
2. clearSystemLogs() always clear Event logs by default no matter type be selected to "Oem".

Solution:
1. According "recordType" to get Oem logs from uri:
'/redfish/v1/Systems/' + DataService.systemName + '/LogServices/Crashdump/Entries'
2. According "selectedRecordType" to clear Oem logs by action: uri = '/redfish/v1/Systems/' +
DataService.systemName + '/LogServices/Crashdump/Actions/LogService.ClearLog'

Modified files:
webui/app/common/services/api-utils.js
webui/app/server-health/controllers/syslog-controller.html
webui/app/server-health/controllers/syslog-controller.js

Tested by:
1. In WebUI/Server health/System Logs, select system log type as "Oem", then click "Clear Oem Logs" button.
The Oem logs (CPU Crashdump log) all were deleted.
2. Select system log type as "Event", then click "Clear Event Logs" button.
The System Event Log all were deleted.

Signed-off-by: Tim Lee <timlee660101@gmail.com>
Change-Id: I2a3d42a61f53df84b88585cf7c65a10688eaef05

show more ...

User logged in when IsAuthenticated cookie is set.

Related to https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/27270

Currently the only condition checked when user is logged in was the
"LOGIN_

User logged in when IsAuthenticated cookie is set.

Related to https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/27270

Currently the only condition checked when user is logged in was the
"LOGIN_ID" value in browser session storage. The only place in the code
where it is set is the Basic Authorization flow.

In case of mTLS authentication, we are not able to set session storage
value. This is why additional 'IsAuthenticated' cookie is added.

In the case when user session expires, the failing XHR should cause the
page to redirect to the login prompt. Additionally, IsAuthenticated
cookie is removed to disable redirection.

Tested: verified the flow with the mTLS changes. User is put in the
webUI interface without login prompt when using mTLS authentication. If
the authentication fails, browser redirects to the login page.

Signed-off-by: Wiktor Gołgowski <wiktor.golgowski@intel.com>
Change-Id: Ia7061f3e146c6547d4bfdf42940150b1a5c06903

show more ...

Certificate delete API – frontend

With introducing option to add multiple certificates there is a need to give
user a possibility to remove selected certificates, for example when they
expire.
This

Certificate delete API – frontend

With introducing option to add multiple certificates there is a need to give
user a possibility to remove selected certificates, for example when they
expire.
This commit adds implementation of DELETE function to GUI.
A new icon will appear in action section on certificate table.
The delete icon will be enabled only for TrustStore certificates and disabled
for others which does not have support for delete option.
When user clicks on the delete icon then ‘user prompt’ is displayed and after
confirmation, proper redfish action is used to delete the certificate.

Middlewere implementation is here:
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/25281

Backend implementation is here:
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-certificate-manager/+/25268

Tested on Chrome and Mozilla.
New icon appears in action section.
The delete option is available only for TrustStore certificates.
User is able to delete selected certificate.

Depends-On: I9781c5c79288ec5d080e80e42c63a55e471ddb77
Signed-off-by: Zbigniew Kurzynski <zbigniew.kurzynski@intel.com>
Change-Id: I68c5f54767d6982ae3cb00830b3a1b4f5e237bea

show more ...

Update toast notification

Added new toast notification types, warn and info,
and updated visual styling. All toasts will need
to be manually closed by clicking the 'X' close icon,
except a success t

Update toast notification

Added new toast notification types, warn and info,
and updated visual styling. All toasts will need
to be manually closed by clicking the 'X' close icon,
except a success toast which will be dismissed
automatically after 10 secs.

- Small updates to critical and success/on icon
- Added new colors for toast status background colors

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I9077109042621b2d3346b4121d6344da502b6b26

show more ...

Update object-mapper.md link

object-mapper.md is moving under architecture/ as part of
https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/26250/

26250 should merge before this is merged.

Change-I

Update object-mapper.md link

object-mapper.md is moving under architecture/ as part of
https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/26250/

26250 should merge before this is merged.

Change-Id: Ie2372690faf6af9629a15badccb4af31da9041bb
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Inventory: Remove old associations interface

Moved to the new associations interface here:
https://github.com/openbmc/openbmc/issues/3584

Tested: Loaded on a Witherspoon
Change-Id: I2065f0919c8cc9d

Inventory: Remove old associations interface

Moved to the new associations interface here:
https://github.com/openbmc/openbmc/issues/3584

Tested: Loaded on a Witherspoon
Change-Id: I2065f0919c8cc9d9dd219a1f9d8d0fc75265fa6f
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Logs: Move over to new Associations

Logging moved over to the new Associations interface here:
https://github.com/openbmc/phosphor-logging/commit/27d82814c3e79865221f599b98ce069c31c4d60a

Without th

Logs: Move over to new Associations

Logging moved over to the new Associations interface here:
https://github.com/openbmc/phosphor-logging/commit/27d82814c3e79865221f599b98ce069c31c4d60a

Without this change was seeing:
TypeError: "r.data[h].associations is undefined"
getLogs https://w81.aus.stglabs.ibm.com/app.bundle.js:41
d https://w81.aus.stglabs.ibm.com/app.bundle.js:6
d https://w81.aus.stglabs.ibm.com/app.bundle.js:6
$digest https://w81.aus.stglabs.ibm.com/app.bundle.js:6
$apply https://w81.aus.stglabs.ibm.com/app.bundle.js:6
y https://w81.aus.stglabs.ibm.com/app.bundle.js:6
C https://w81.aus.stglabs.ibm.com/app.bundle.js:6
onload https://w81.aus.stglabs.ibm.com/app.bundle.js:6
Possibly unhandled rejection: {}

Added an hasOwnProperty before the foreach.

Tested: No longer see the error. See the "Related items:" on the
event log panel.
Change-Id: I60be885feea72b1388b7cbf4c3a7b9df7dbb9a02
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add searchable properties to event log filter

The current event log search doesn't match inputs like
the event id, severity or priority.
This commit will add additional searchable log properties
to

Add searchable properties to event log filter

The current event log search doesn't match inputs like
the event id, severity or priority.
This commit will add additional searchable log properties
to the search filter so users can enter search terms like
'High' or 'Error' or other visible keywords.

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I569112468a9f97034449799f407137f1651cec16

show more ...

LDAP configuration and user groups

Adds LDAP page and ability to add and change configuration settings.
Adds ability to add, remove and edit user groups for LDAP.

Resolves openbmc/phosphor-webui#38

LDAP configuration and user groups

Adds LDAP page and ability to add and change configuration settings.
Adds ability to add, remove and edit user groups for LDAP.

Resolves openbmc/phosphor-webui#38
Resolves openbmc/phosphor-webui#39

Tested: Loaded on to a witherspoon and able to add initial LDAP config
as well us update the configuration and role groups. Appropriate messages displayed
to user when required fields are missing or in the incorrect format.

Change-Id: If8a21f3f9d9334415ead73472e90b2a0823bf9ea
Signed-off-by: beccabroek <beccabroek@gmail.com>
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Signed-off-by: Derick Montague <derick.montague@ibm.com>

show more ...

Remove Purpose property from inventory item

The Purpose property is not useful in the inventory item.
The field overflows to another line.

The Purpose property under a power supply inventory item:

Remove Purpose property from inventory item

The Purpose property is not useful in the inventory item.
The field overflows to another line.

The Purpose property under a power supply inventory item:
PURPOSE
xyz.openbmc_project.Software.Version.VersionPurpose.Other

When we move to Redfish, this can be removed.

An alternatives considered was only using the last part of the
purpose property (e.g. Other). Still didn not find this userful
to customers so just removed.

https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/Software/Version.interface.yaml#L14

Tested: Built and loaded on a Witherspoon. Don't see the property.
Change-Id: Ie004c90f6a5e625cfa65ba39ab2be97e5e256705
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add local user manual unlock

Enables manual unlock from the GUI when a user is locked out
due to failed login attempts above allowed threshold.

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.

Add local user manual unlock

Enables manual unlock from the GUI when a user is locked out
due to failed login attempts above allowed threshold.

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I63e28a4d6feed9eb6d4d09c0431d31e7bd6924c2

show more ...

Enable CA certificate upload

This patchset enables CA certificate type to be uploaded
in the GUI.

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I52953933f6fd3dbd363c42b887996

Enable CA certificate upload

This patchset enables CA certificate type to be uploaded
in the GUI.

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I52953933f6fd3dbd363c42b887996942b99b358e

show more ...

Create csr modal

The CSR Modal allows users to generate a CSR code. Once the user
types in the necessary information to generate the CSR code, that modal
will then render the code and the user will

Create csr modal

The CSR Modal allows users to generate a CSR code. Once the user
types in the necessary information to generate the CSR code, that modal
will then render the code and the user will be able to either copy the
code or download the code in a txt file.

Tested: loaded onto Witherspoon and able to view on certificate
management page. Click on generate csr and type in necessary
(or any additional info), then click on generate CSR. The CSR
code is then visible and is able to be copied or downloaded. In
error state in which CSR code is unable to generate, the modal
closes and an error toast message appears. FYI: Sometimes you
have to reboot system in order for csr to successfully generate.y

Signed-off-by: Mira Murali <miramurali23@gmail.com>
Change-Id: I3cca09c494357496166164b5ee8ff99250ef981d

show more ...

Add boot option override and TPM enable toggle

- Adds ability to set a bootsource override to allowable target value
- Adds ability to enable or disable TPM required policy
- Replaces power operatio

Add boot option override and TPM enable toggle

- Adds ability to set a bootsource override to allowable target value
- Adds ability to enable or disable TPM required policy
- Replaces power operations confirm directive with bootstrap modal

Tested: Confirmed override settings saved to redfish but unable to verify
if settings are automatically set to disabled by petitboot after a
one time boot. Passes DAP.

Resolves openbmc/phosphor-webui#82
Resolves openbmc/phosphor-webui#90

Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com>
Change-Id: If0ffd6f9328939d70c7958ee11fb90bd20a1e685
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Update local user table to new design

This commit will introduce a reusable data table component.
By creating a reusable component, we can ensure tables in the
GUI will look consistent and common ta

Update local user table to new design

This commit will introduce a reusable data table component.
By creating a reusable component, we can ensure tables in the
GUI will look consistent and common table actions (sort, select row)
are shared.

- Created new components directory to store shared components
- Add password-confirmation directive
- Remove some error handling from API utils so it can be
handled in the UI

TODO:
- Add show/hide toggle to password fields
- Enhance table component with icons
- Manual user unlock
- Batch table actions
- Role table

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I03c95874d2942a2450a5da2f1d2a8bb895aa1746

show more ...

Remove Associations property from inventory item

If the inventory item had a Assocations interface, it would have
a Assocations property. This Assocations property showed
on the inventory panel unde

Remove Associations property from inventory item

If the inventory item had a Assocations interface, it would have
a Assocations property. This Assocations property showed
on the inventory panel under the individual inventory item
dropdown.

There can be a lot of Associations, the chassis for example associates
to a lot of sensors, and they are long, full D-Bus paths. Not
very useful and can overwhelm the dropdown so remove the property.

One day we might want something to associate an inventory item to
an object (e.g. sensors). This would require design changes to
accommodate this.

Support both the old and new Associations interface.
See https://github.com/openbmc/openbmc/issues/3584

Tested: Built an image and loaded on a Witherspoon. No longer see
this property.
Change-Id: Ib67e36c7536a42eb56e65b6dbe6fd8798976ee08
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Refactor power operations

Refactored power operations to use checkHostStatus function
that checks host_status property provided by dataService,
instead of polling for host/chassis status.
Added prop

Refactor power operations

Refactored power operations to use checkHostStatus function
that checks host_status property provided by dataService,
instead of polling for host/chassis status.
Added property to check when a power operation is in progress.
This property will show/hide the in progress message and make
other operations unavailable until the operation completes.
We were previously checking whether the server_state property
was set to 'Unreachable', which enables the Power on button in
the middle of a reboot, since the server_state changes to 'Off'
during reboot.

- Removed unused $timeout service

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I234749a9a875c7370b52bd23ed74d6e9617cf5e2

show more ...

Add 403 $location redirect to http interceptor service

This is a temporary solution to redirect any 403 responses to
a dedicated 403 'Unauthorized' page. This could occur on inital
navigation to a p

Add 403 $location redirect to http interceptor service

This is a temporary solution to redirect any 403 responses to
a dedicated 403 'Unauthorized' page. This could occur on inital
navigation to a page or while attempting an operation.

Once permission role mapping is defined, the code should be updated
to handle 403 responses in context of user attempted actions.

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ia207f2bcdd87fb20888fe6a1588d0ccd310e484c

show more ...

Fix array index out of bounds exception

We should be verified string length when the phosphor-webui calls the
getFirmwares function to handle the property value of ExtenVersion.
because it is risky

Fix array index out of bounds exception

We should be verified string length when the phosphor-webui calls the
getFirmwares function to handle the property value of ExtenVersion.
because it is risky to get the first address of array when that is empty

Tested: Built phosphor-webui and get a effective array of titlePart via
console from WEBUI.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Ife08d208eb7fbeb71284ae0700fb5d871343a298

show more ...

Create certificate management page

Displays certificates and the ability to add up to one
of each type of certificate (as limited by the backend
implementation). HTTPS certificate and LDAP client ce

Create certificate management page

Displays certificates and the ability to add up to one
of each type of certificate (as limited by the backend
implementation). HTTPS certificate and LDAP client cert
are implemented in this commit, with the ability to add
more types as needed by adding them to the constants.js
CERTIFICATE_TYPES array.

Also provides the ability to replace a certificate once
it is added.

Resolves openbmc/phosphor-webui#43

Tested: loaded onto a witherspoon and able to view and
replace both the HTTPS certificate and the
LDAP certificate. GUI only allows to upload an
LDAP certificate if one doesn't already exist.
The GUI limits the user to one file per type as
expected at this time and provides the
appropriate validation messages. Alert messages
appear above the table if the certificate is
expired or within 30 days of expiring.

Change-Id: I345267280ecd3cb257e9304886cde9ebb69b1240
Signed-off-by: beccabroek <beccabroek@gmail.com>
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>

show more ...