Consolidate button styles

This patchset will create consistent button styling according
to the styleguide and remove redundant button styles by creating
reusable button classes.

Consolidate button styles

This patchset will create consistent button styling according
to the styleguide and remove redundant button styles by creating
reusable button classes.

This patchset also implements a consistent strategy for including
icon assets. Currently, svg icons are imported as CSS background
images or inlined into the markup. Inlining an svg is preferred,
especially when used with buttons or links so the colors can
be easily changed for different states (hover, focus, disabled)
without having to request variants.
The icon provider allows us to inline svgs without cluttering
the markup. Webpack config was adjusted to use svg-inline-loader
when resolving svgs that are used by the icon provider directive.

- All svgs were optimized to remove unncessary information.
- Removed unused svg color variants
- Moved icons used by icon provider to separate directory to
avoid Webpack parsing the files twice
- Small changes to navigation icons

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I1ca214b74fc502e6b6e760cfee88b48110237c43

show more ...

Fix issue about menu not disappearing on firmware page

In firmware update page "More info” dialog did not disappear until
it is clicked again. With this push users can click anywhere ou

Fix issue about menu not disappearing on firmware page

In firmware update page "More info” dialog did not disappear until
it is clicked again. With this push users can click anywhere outside
the menu and it disappears.

Resolves openbmc/phosphor-webui#32

Change-Id: I1519caf2428c702af03fb0e4dd8a08d0c0588abf
Signed-off-by: Ryan Arnell <iffy.ryan@ibm.com>

show more ...

Fix setting image priority

Let's say there are 2 images, A and B. A has a priority of 0
and B has a priority of 50. Lowest priority is the image used
to boot from and appears at the

Fix setting image priority

Let's say there are 2 images, A and B. A has a priority of 0
and B has a priority of 50. Lowest priority is the image used
to boot from and appears at the top of the image tables
(A in this case). If the user wanted image B to be the image
with the lowest priority, they would have to hit the up arrow
50 times in the old logic.

Move to setting the priority based on the image above, for
the up arrow, or below, for the down arrow.

If 2 images have the same priority, the image whose priority is
being updated wins and the image who already has that priority
gets bumped up 1, this is why when moving an image down we set
to the below image's priority +1, but don't need this -1 when
moving an image up in the table.

Tested: Can still change the priority.
Change-Id: If87e1d863ab909c276247072cc45e40b67cf686b
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove tabs from HTML files

From https://google.github.io/styleguide/htmlcssguide.html
"Indentation
Indent by 2 spaces at a time.

Don't use tabs or mix tabs and spaces for i

Remove tabs from HTML files

From https://google.github.io/styleguide/htmlcssguide.html
"Indentation
Indent by 2 spaces at a time.

Don't use tabs or mix tabs and spaces for indentation."

Tested: Manual regression testing on a Witherspoon.
Change-Id: Ief7137dabc869b73b73f9947337fbb0abb5ca497
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Make wording consistent

The IBM design team identified this wording as inconsistent.
In the tables below the "running" image is called "Functional",
here it is called "In-memory".

Make wording consistent

The IBM design team identified this wording as inconsistent.
In the tables below the "running" image is called "Functional",
here it is called "In-memory".

Change to "Functional" to match the table below.

Change-Id: I4b1a45f3cbcc578b0f807577dd2c3a9c54714a02
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Fix change priority down arrow logic

If the Boot priority was an "Active" image then a "Functional" image.
The down arrow would be grayed out on the "Active" image.
It should not hav

Fix change priority down arrow logic

If the Boot priority was an "Active" image then a "Functional" image.
The down arrow would be grayed out on the "Active" image.
It should not have been grayed out, i.e. the user should be able to
lower the priority on an "Active" image if there is a functional
image below it in the table.

Resolves openbmc/openbmc#3228

Tested: Tested this case and uploaded an image of the result to 3228.
Change-Id: I6033886354f76671a4d33c4d8a79097428311e93
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Allow a "Failed" image to be "Activated"

A failed image is an image that was unsuccess during activation.
The firmware code allows these images to be activated so should the
GUI.

Allow a "Failed" image to be "Activated"

A failed image is an image that was unsuccess during activation.
The firmware code allows these images to be activated so should the
GUI.

Resolves openbmc/openbmc#3144

Tested: Verified I see an "Activate" button on a "Failed" image.
Change-Id: I3a5623d186dafd7656a045ba28e6bd636ee39420
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Gray out the 'Boot priority' down arrow key

Gray out (disable) the 'Boot priority' down arrow key for a
'Functional' or 'Active' image if the remaining images are
'Ready' images.

Gray out the 'Boot priority' down arrow key

Gray out (disable) the 'Boot priority' down arrow key for a
'Functional' or 'Active' image if the remaining images are
'Ready' images.

Resolves openbmc/openbmc#2965

Change-Id: Id8dad6b5a8d7376fe2c1f167a2043aae87916884
Signed-off-by: CamVan Nguyen <ctnguyen@us.ibm.com>

show more ...

Add server confirm activation modal

Added text specific to server images that appears in the
activation modal when a "server" image is activated.
The "server" and "BMC" images use th

Add server confirm activation modal

Added text specific to server images that appears in the
activation modal when a "server" image is activated.
The "server" and "BMC" images use the same modal, but the text
and if radio buttons appear differ.

Resolves openbmc/openbmc#2967

Tested: Activated both a server and BMC image on a Witherspoon.
Change-Id: I83693641ebfef802d403141ade55a950f359ba6e
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Move from "Preserve settings" to "Confirm Activation"

The "Preserve settings" popup that showed when a user activated
an image was not useful and did not do anything. Saving network

Move from "Preserve settings" to "Confirm Activation"

The "Preserve settings" popup that showed when a user activated
an image was not useful and did not do anything. Saving network
settings prior to activation is not needed so moved to a
"Confirm Activation" modal.
This modal will eventually include an
"activate BMC firmware and reboot" selection,
openbmc/openbmc#3027, for now it only holds the one selection.
The "Preserve settings" and now this "Confirm Activation"
modal both appear on "server" and "BMC" images, this is a bug
that is fixed in a later commit.

Tested: Activated an image on a Witherspoon machine.
Change-Id: I7176d5a314ea325e6e94606ef07b32786ede64e9
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Have the "action" table cell flex

Let the action table cell flex to fit 2 buttons, "Activate"
and "Delete". This happens on a "Ready" image.

Resolves openbmc/openbmc#2964

Have the "action" table cell flex

Let the action table cell flex to fit 2 buttons, "Activate"
and "Delete". This happens on a "Ready" image.

Resolves openbmc/openbmc#2964

Tested: See both "Activate" and "Delete" on a "Ready" image.
Change-Id: I1a91ed83f2f99983795baea9f59bbc0dd4749c0e
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Fix "Boot priority" down arrow

The way free priority works is if an image is set to a
priority another image has, that other image's priority
is increased by 1.

Let's say th

Fix "Boot priority" down arrow

The way free priority works is if an image is set to a
priority another image has, that other image's priority
is increased by 1.

Let's say there are 2 images, x and y. x has a priority of
2, and y has a priority of 3.
x gets set to priority 3 (this is how the down arrow works,
it sets the priority to the current priority + 1) now x
has a priority of 3 and y gets increased to a priority of 4.
x and y in this case never switched priority order (i.e. x
still boots first).

To get the down arrow to work currently, set the priority
to + 2 on the down arrow. In the case above this would make
x and y 4 and 3, respectfully, therefore, changing their
priority order (i.e. y boots first now).

This change is not needed for the up arrow, can you figure
out why?

Tested: Down arrow works now.
Change-Id: Ia01dba6694b8c3b68f43fab78d8f0ae022ccb82c
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Remove "Ready" image boot priority arrows

Ready images do not have a priority.
Priority is for "Active" images to determine which image to boot from.
Only images on the GUI that are

Remove "Ready" image boot priority arrows

Ready images do not have a priority.
Priority is for "Active" images to determine which image to boot from.
Only images on the GUI that are "Active" or "Functional" (on the GUI
we call "Active" images that have the functional association
"Functional") should have a Boot Priority.

Tested: Verified no priority on Ready images.
Change-Id: I5a527ed4bed9d686a746e3759f50fa9bb8b7988a
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Display the version when confirming "Delete"

When confirming an image delete the GUI now displays
"Delete firmware v2.0-165-ge571670?"

Resolves openbmc/openbmc#2961

Tes

Display the version when confirming "Delete"

When confirming an image delete the GUI now displays
"Delete firmware v2.0-165-ge571670?"

Resolves openbmc/openbmc#2961

Tested: Confirmed text is correct and delete works
Change-Id: Iad23908fbafc9514044be7770d269e723b35cb58
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Display Version when confirming changing priority

Before the GUI displayed when changing the priority:
"Change firmware e129c45b priority?"

It now displays:

"Change fir

Display Version when confirming changing priority

Before the GUI displayed when changing the priority:
"Change firmware e129c45b priority?"

It now displays:

"Change firmware v2.0-165-ge571670 priority?"

This is important since the user never sees the
image ID (e.g. e129c45b) and always sees the
image version (e.g. v2.0-165-ge571670).

Tested: confirmed text is correct and change priority works
Change-Id: Ie9403aaade8a307b6de54feef20adc2b04e2b80b
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Add additional "Image States"

Added the following Activation States or as they are known
on the GUI, "Image States": "NotReady", "Invalid", "Activating",
and "Failed".
Instead of

Add additional "Image States"

Added the following Activation States or as they are known
on the GUI, "Image States": "NotReady", "Invalid", "Activating",
and "Failed".
Instead of having a variable for each state, these "Image States"
are now tracked under one variable.
Also, moved to looking at the value of "Activation",
github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/Software/Activation.interface.yaml#L17,
so if more states are added in the future they will
be picked up.

Resolves openbmc/openbmc#2928

Tested: Verified when I activated an image I see the
"Activating" state.
Change-Id: I1f5e408ebe31f3eb6c3f0417d6605bff06c9ac19
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Updating login structure

Updated login structure with a field where user can manually add server hostname if it is not populated automatically

Change-Id: I147c2c15869131540e327bda26

Updating login structure

Updated login structure with a field where user can manually add server hostname if it is not populated automatically

Change-Id: I147c2c15869131540e327bda26c05b59d78e01d5
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>

show more ...

fixed version dropdown bugs

Change-Id: Ia64dfd7ae7e1fb3081d0d5de680b9afa3cab669d
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

firmware: added new icons to match designs. minor fixes to button styling

Change-Id: If77d9119bc9335b5bd5e94ec1d201f6aa8969d0d
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

UI changes and fixes based on QA feedback

Change-Id: I13bae30e86330a8831d35f1d8a2f7da821324e37
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

active class toggle added. Removed ImageID column based on user feedback

Change-Id: Ief575b5ca21536cb79b4b4b319567cdcf9147046
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>

Implement firmware upload function

Change-Id: Ie89793ec9add1fc9e5241b422cfff64784f7b078
Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>