51229f80 | 06-Nov-2020 |
Konstantin Aladyshev <aladyshev22@gmail.com> |
Make SOL layout responsive to the window changes
The current version of a SOL window layout have several downsides: -terminal content doesn't resize with the window changes -when opened in a separat
Make SOL layout responsive to the window changes
The current version of a SOL window layout have several downsides: -terminal content doesn't resize with the window changes -when opened in a separate window terminal content doesn't use full viewport space -when opened in a separate window terminal viewport takes only a small part of the window
Screenshots with the problems descriptions are documented in the github issue: https://github.com/openbmc/phosphor-webui/issues/125
This commit adds responsiveness to the SOL layout. The main SOL tab: -terminal content automatically resizes with the viewport changes
The separate SOL window: -XTERM always use full terminal viewport space -terminal viewport width always equals window space width -terminal viewport automatically resizes on window size changes -terminal content automatically resizes with the viewport changes
As SOL UI is resposive now, this commit also removes fixed size configurations for the SOL terminal via JSON 'customConsoleDisplaySize' variable. It is worth noting that in reality it wasn't really used anyway.
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com> Change-Id: Ia5d929e9a309281366a9d3119ac326ebd73c73f0
show more ...
|
339db9a4 | 22-Feb-2021 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format-11: reformat
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I74d01806faf1884b8077c6c5c841ef194ff0b021 |
d10511f2 | 12-Sep-2020 |
Igor Kononenko <i.kononenko@yadro.com> |
server-overview: supporting all MACs and IPs
Show MAC and IP address information for all the present ethernet interfaces on the server overview page.
Tested: the `webui`-overview page on a system h
server-overview: supporting all MACs and IPs
Show MAC and IP address information for all the present ethernet interfaces on the server overview page.
Tested: the `webui`-overview page on a system having 2 physical ethernet interfaces shows all IP addresses assigned to the interface and also shows MAC addresses for each interface
``` ETH0 IP ADDRESSES IPv4: 172.17.26.67 IPv4: 169.254.28.79 IPv6: FE80::702C:BFFF:FEDE:DEC3
ETH1 IP ADDRESSES IPv4: 169.254.51.25 IPv6: FE80::14B7:7EFF:FEF1:2EF
ETH0 MAC ADDRESS 72:2C:BF:DE:DE:C3
ETH1 MAC ADDRESS 16:B7:7E:F1:02:EF ```
End-user-impact: The server-overview page is now able to display information about each ethernet's MAC, IPv4 and IPv6 adresses.
Signed-off-by: Igor Kononenko <i.kononenko@yadro.com> Change-Id: I677b645cc33bfc49c2dd91f4acc743973dc29998
show more ...
|
6bb1f476 | 06-Aug-2020 |
Ed Tanous <ed@tanous.net> |
Fix Internet Explorer
Looks like this got merged before it got tested, and broke IE. Apparently we still have users using it, as they noticed pretty quick. we might want to keep that in mind for t
Fix Internet Explorer
Looks like this got merged before it got tested, and broke IE. Apparently we still have users using it, as they noticed pretty quick. we might want to keep that in mind for the future.
A short note on the failure, this snippet contained a section that enabled use scrict on the code, which accidentally allowed babel to enable it everywhere. So far as I can tell, the existing code doesn't follow strict (although there's only one outlier).
in short, this fixes IE.
Tested: Launched webui in IE11 with debug console open. Observed UI launches with no unexpected warnings.
Signed-off-by: Ed Tanous <ed@tanous.net> Change-Id: I85cc83b34f4f5906e827ea55c4b4fb4bda0fe6ac
show more ...
|
7bb1d9e6 | 28-Jul-2020 |
Gunnar Mills <gmills@us.ibm.com> |
Remove scaled
Scale was removed from phosphor-dbus-interfaces when moving to a double. https://github.com/openbmc/phosphor-dbus-interfaces/commit/4ec6587fa908fe9df41cc0962ab6ff6446fbd54f
A future i
Remove scaled
Scale was removed from phosphor-dbus-interfaces when moving to a double. https://github.com/openbmc/phosphor-dbus-interfaces/commit/4ec6587fa908fe9df41cc0962ab6ff6446fbd54f
A future improvement could be some sort of rounding.
Tested: Loaded GUI on a Witherspoon Change-Id: I771e575c85cc97196678a1da8e01d1fdb96ddf8c Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
d8713594 | 16-Jul-2020 |
Ed Tanous <ed@tanous.net> |
Drop encoding library
Commit f4a43cca440535a63592877c9bdbbe28636d803c attempted to fix a IE bug in the SOL library. Unfortunately, it did it by pulling in the entire NPM encoding library, which is
Drop encoding library
Commit f4a43cca440535a63592877c9bdbbe28636d803c attempted to fix a IE bug in the SOL library. Unfortunately, it did it by pulling in the entire NPM encoding library, which is insanely large (190kb after minification and compression). This is almost equivalent to the rest of our javascript put together! That's nuts, and I don't think anyone would argue that's a binary hit worth taking for IE9 support.
This commit removes it, and swaps in an inline polyfill from the mozilla recommendations, that compresses much....much smaller.
Before this patchset build prints: app.bundle.js.gz 522 KiB [emitted] [big]
After this patchset: app.bundle.js.gz 332 KiB [emitted] [big]
If you don't want to break out a calculator, that's 190KB savings in the root filesystem, and should cut the initial page load time (on slow connections) by nearly 30 percent.
Note: text-encodings was never pinned in the package-lock.json, hence why you don't see a diff removing it from package lock. This was a miss on the original commiters part, although it doesn't really matter, as it's now removed.
PS: A reviewer may note, I could've moved the polyfill into its own file. Considering the serial console is the only page that uses that, and it's not that big I elected not to, to make removing it analagous with removing xterm/the serial console.
Bonus content! Added a (commented out) webpack config that allows you to generate the webui as individual gzipped fragments, instead of one bundle. This allows you to see file sizes on a package by package basis, and was how I found this commit in question.
Testing: This is where this patchset gets hairy. I dont' have an IE9 instance to test on. Given it's low usage, and the fact that it's a relatively straightforward change we can probably just wait for someone to tell us it's broken again.
Enjoy the sweet sweet savings.
Signed-off-by: Ed Tanous <ed@tanous.net> Change-Id: I2820ff1c4b33d725ebc63490793a72fe600b8ed3 Signed-off-by: Ed Tanous <ed@tanous.net>
show more ...
|
2e1eec80 | 11-Jun-2020 |
Zev Weiss <zev@bewilderbeest.net> |
Fix SENSOR_SORT_ORDER array
'Meters' entry had been duplicated; 'Watts' was missing.
Signed-off-by: Zev Weiss <zev@bewilderbeest.net> Change-Id: I836efa74120dd427253a4aee817216d37a93049a |
4a16a026 | 24-Apr-2020 |
James Feist <james.feist@linux.intel.com> |
Add CSRF check to more websockets
This adds the token to more websockets that were missing it.
Change-Id: I633ce28ec9602d33a79d613f94582ba0ff265368 Signed-off-by: James Feist <james.feist@linux.int
Add CSRF check to more websockets
This adds the token to more websockets that were missing it.
Change-Id: I633ce28ec9602d33a79d613f94582ba0ff265368 Signed-off-by: James Feist <james.feist@linux.intel.com>
show more ...
|
6a8d180f | 08-Apr-2020 |
James Feist <james.feist@linux.intel.com> |
Add CSRF to all remaining websockets
This passes the CSRF with the websocket so that the pages continue to work after CSRF is added.
Tested: Verified SOL still worked
Change-Id: I8f1066c2769f92034
Add CSRF to all remaining websockets
This passes the CSRF with the websocket so that the pages continue to work after CSRF is added.
Tested: Verified SOL still worked
Change-Id: I8f1066c2769f92034c349e7112ebc1070adcd35b Signed-off-by: James Feist <james.feist@linux.intel.com>
show more ...
|
494c6edb | 18-Mar-2020 |
Tim Lee <timlee660101@gmail.com> |
Fix "Clear Oem Logs" functionality in System Logs
Issue Symptom: 1. "Clear Oem Logs" button didn't show on webui when type select to "Oem". 2. "Clear Oem Logs" button was showed on then pressed with
Fix "Clear Oem Logs" functionality in System Logs
Issue Symptom: 1. "Clear Oem Logs" button didn't show on webui when type select to "Oem". 2. "Clear Oem Logs" button was showed on then pressed with fix, but the function didn't work correctly. Event logs were deleted instead of Oem logs.
Root cause: 1. getSystemLogs() always get Event logs by default no matter type be selected to "Oem". 2. clearSystemLogs() always clear Event logs by default no matter type be selected to "Oem".
Solution: 1. According "recordType" to get Oem logs from uri: '/redfish/v1/Systems/' + DataService.systemName + '/LogServices/Crashdump/Entries' 2. According "selectedRecordType" to clear Oem logs by action: uri = '/redfish/v1/Systems/' + DataService.systemName + '/LogServices/Crashdump/Actions/LogService.ClearLog'
Modified files: webui/app/common/services/api-utils.js webui/app/server-health/controllers/syslog-controller.html webui/app/server-health/controllers/syslog-controller.js
Tested by: 1. In WebUI/Server health/System Logs, select system log type as "Oem", then click "Clear Oem Logs" button. The Oem logs (CPU Crashdump log) all were deleted. 2. Select system log type as "Event", then click "Clear Event Logs" button. The System Event Log all were deleted.
Signed-off-by: Tim Lee <timlee660101@gmail.com> Change-Id: I2a3d42a61f53df84b88585cf7c65a10688eaef05
show more ...
|
4148f2ee | 29-Jan-2020 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Create profile settings page
Adding a profile settings page so readonly and operator roles are able to change their own password.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id
Create profile settings page
Adding a profile settings page so readonly and operator roles are able to change their own password.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: Iee9536255ad47f4df4af8746c1e01da37c407f2b
show more ...
|
cee23d93 | 11-Nov-2019 |
kathy <kathryn.elainex.pine@intel.com> |
Update navigation to accordian-style menu
- New navigation provides intuitive structure for showing relationship between sections and pages - Menu keeps an open state, which allows easy clicking to
Update navigation to accordian-style menu
- New navigation provides intuitive structure for showing relationship between sections and pages - Menu keeps an open state, which allows easy clicking to sibling pages - Ability to preview all page sections w/o hover over blocking page content - Allows user to see where they are within navigation at all times
Tested: Opened each page and confirmed new navigation worked, clicked through to all pages successfully.
Change-Id: Ie10dc95d8e15ee9bf89a3bec9ff231c0a7065ed9 Signed-off-by: Kathy Pine <kathryn.elainex.pine@intel.com>
show more ...
|
f2127efa | 10-Dec-2019 |
Wiktor Gołgowski <wiktor.golgowski@intel.com> |
User logged in when IsAuthenticated cookie is set.
Related to https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/27270
Currently the only condition checked when user is logged in was the "LOGIN_
User logged in when IsAuthenticated cookie is set.
Related to https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/27270
Currently the only condition checked when user is logged in was the "LOGIN_ID" value in browser session storage. The only place in the code where it is set is the Basic Authorization flow.
In case of mTLS authentication, we are not able to set session storage value. This is why additional 'IsAuthenticated' cookie is added.
In the case when user session expires, the failing XHR should cause the page to redirect to the login prompt. Additionally, IsAuthenticated cookie is removed to disable redirection.
Tested: verified the flow with the mTLS changes. User is put in the webUI interface without login prompt when using mTLS authentication. If the authentication fails, browser redirects to the login page.
Signed-off-by: Wiktor Gołgowski <wiktor.golgowski@intel.com> Change-Id: Ia7061f3e146c6547d4bfdf42940150b1a5c06903
show more ...
|
5fcee5ab | 19-Nov-2019 |
Dixsie Wolmers <dixsiew@gmail.com> |
Add file upload component
Created reusuable file upload component to be used on updated firmware page. Component can: -Upload file -Display status icon -Clear upload field
Made minor style change t
Add file upload component
Created reusuable file upload component to be used on updated firmware page. Component can: -Upload file -Display status icon -Clear upload field
Made minor style change to file upload on certificate management.
Tested in GUI.
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: I09bf56eee4d670681ea5e95c1807f8177c0e4c08
show more ...
|
d4a5d6f4 | 17-Nov-2019 |
Dixsie Wolmers <dixsiew@gmail.com> |
Update loading spinner
Loader was updated with loading icon svg. Added inline style for loading icon and added loader svg to status-icon directive. Status icons will be used in file-upload component
Update loading spinner
Loader was updated with loading icon svg. Added inline style for loading icon and added loader svg to status-icon directive. Status icons will be used in file-upload component for firmware page update.
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: I15e6f9fa39a08fcc8cfe354f8ed4447aab6425a9
show more ...
|
27915d2f | 15-Nov-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Fix truncated button icons on Safari
Removing margin offset to fix issue with button icons being visually truncated on Safari. Removing additional redundant code around same icon/buttons.
Signed-of
Fix truncated button icons on Safari
Removing margin offset to fix issue with button icons being visually truncated on Safari. Removing additional redundant code around same icon/buttons.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: Ie1ef89023a043a70a0126a21be57febb9afae19a
show more ...
|
0d11902c | 04-Nov-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Create alert banner component
This reusuable component will help to make sure banner implementations are consistent and will help reduce redundant code.
Signed-off-by: Yoshie Muranaka <yoshiemurana
Create alert banner component
This reusuable component will help to make sure banner implementations are consistent and will help reduce redundant code.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I3a16f65d36c2d61abf54c300e2ed5defeadee298
show more ...
|
432f02cd | 11-Nov-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Fix table-actions error
When using the table component with table actions enabled, if an icon file name isn't provided, the action type should display in the table. This will fix the webpack error w
Fix table-actions error
When using the table component with table actions enabled, if an icon file name isn't provided, the action type should display in the table. This will fix the webpack error when compiling the table component without an icon to display by changing the ng-if directive to check for falsy values instead of just 'null' to also catch 'undefined' values.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I72daeb035e4e5f0391953f9f2ae042d0b9fc2b99
show more ...
|
f70f4255 | 23-Oct-2019 |
Zbigniew Kurzynski <zbigniew.kurzynski@intel.com> |
Certificate delete API – frontend
With introducing option to add multiple certificates there is a need to give user a possibility to remove selected certificates, for example when they expire. This
Certificate delete API – frontend
With introducing option to add multiple certificates there is a need to give user a possibility to remove selected certificates, for example when they expire. This commit adds implementation of DELETE function to GUI. A new icon will appear in action section on certificate table. The delete icon will be enabled only for TrustStore certificates and disabled for others which does not have support for delete option. When user clicks on the delete icon then ‘user prompt’ is displayed and after confirmation, proper redfish action is used to delete the certificate.
Middlewere implementation is here: https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/25281
Backend implementation is here: https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-certificate-manager/+/25268
Tested on Chrome and Mozilla. New icon appears in action section. The delete option is available only for TrustStore certificates. User is able to delete selected certificate.
Depends-On: I9781c5c79288ec5d080e80e42c63a55e471ddb77 Signed-off-by: Zbigniew Kurzynski <zbigniew.kurzynski@intel.com> Change-Id: I68c5f54767d6982ae3cb00830b3a1b4f5e237bea
show more ...
|
5e930c0a | 16-Oct-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Update toast notification
Added new toast notification types, warn and info, and updated visual styling. All toasts will need to be manually closed by clicking the 'X' close icon, except a success t
Update toast notification
Added new toast notification types, warn and info, and updated visual styling. All toasts will need to be manually closed by clicking the 'X' close icon, except a success toast which will be dismissed automatically after 10 secs.
- Small updates to critical and success/on icon - Added new colors for toast status background colors
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I9077109042621b2d3346b4121d6344da502b6b26
show more ...
|
c15f66b0 | 11-Sep-2019 |
Dixsie Wolmers <dixsiew@gmail.com> |
Update certificate management page consistency
This change applies global styles to improve page layout consistency and modal management
- Adds page and section styles - Removes unused styles - Cre
Update certificate management page consistency
This change applies global styles to improve page layout consistency and modal management
- Adds page and section styles - Removes unused styles - Creates individual html files for modals - Updates certificate modals to bootstrap modal - Updates global styles for input file field in file-upload.scss
TODO: - Update certificate table with table component in separate commit - Update CSR modal to use global form-field styles in separate commit
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: I9b800cb684740da1a9168294433e726efb0f9d0e
show more ...
|
2ac4eda3 | 17-Oct-2019 |
Gunnar Mills <gmills@us.ibm.com> |
Update object-mapper.md link
object-mapper.md is moving under architecture/ as part of https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/26250/
26250 should merge before this is merged.
Change-I
Update object-mapper.md link
object-mapper.md is moving under architecture/ as part of https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/26250/
26250 should merge before this is merged.
Change-Id: Ie2372690faf6af9629a15badccb4af31da9041bb Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
81ad97e4 | 07-Oct-2019 |
Yoshie Muranaka <yoshiemuranaka@gmail.com> |
Add tooltip styles
Adding styles to make sure the Bootstrap tooltip directive works by adding opacity to 'in' class that is added to the tooltip when triggered. This commit also includes additional
Add tooltip styles
Adding styles to make sure the Bootstrap tooltip directive works by adding opacity to 'in' class that is added to the tooltip when triggered. This commit also includes additional custom styles to override defaults. We will need these styles to implement tooltips which are included in upcoming changes like the firmware page redesign.
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I08e8f1f1762dcc24f8a803b87348a5bff25bd65b
show more ...
|
50c1aa1d | 14-Oct-2019 |
Dixsie Wolmers <dixsiew@gmail.com> |
Fix IE11 icon alignment on header and system overview
Made height and width changes to icons on app header and system overview to properly align icons in IE11. Removes additional space in system ove
Fix IE11 icon alignment on header and system overview
Made height and width changes to icons on app header and system overview to properly align icons in IE11. Removes additional space in system overview quick links.
Tested in Chrome, IE11, Safari, Edge.
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: I7ae24df3fe73ea3502565ed3ee2ccabb2506e098
show more ...
|
2cc89bf3 | 07-Oct-2019 |
Dixsie Wolmers <dixsiew@gmail.com> |
Fix IE 11 primary navigation icon positioning
Added height value of 100% to nav-icon in order to properly align in IE11.
Tested on Chrome, Firefox, Safari, Edge and IE11.
Signed-off-by: Dixsie Wol
Fix IE 11 primary navigation icon positioning
Added height value of 100% to nav-icon in order to properly align in IE11.
Tested on Chrome, Firefox, Safari, Edge and IE11.
Signed-off-by: Dixsie Wolmers <dixsiew@gmail.com> Change-Id: I66b2d4de1b67f546e0709eab70a780a297efbb7a
show more ...
|