watchdog: Rewrite timeoutHandler() to make disabling part of the timeout

This makes no functional changes to the user interface but make future code
reworks shorter.

Change-Id: Ibd57a5d1090588c8a7b

watchdog: Rewrite timeoutHandler() to make disabling part of the timeout

This makes no functional changes to the user interface but make future code
reworks shorter.

Change-Id: Ibd57a5d1090588c8a7b2a67730660c3cf47c832e
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

tests/watchdog: Cleanup our use of durations

We have lots of unnecessary constructors and forced duration casts.
This change makes all of that logic simpler.

Change-Id: Icfc6d51d75dfb67b3b4c252fbc3

tests/watchdog: Cleanup our use of durations

We have lots of unnecessary constructors and forced duration casts.
This change makes all of that logic simpler.

Change-Id: Icfc6d51d75dfb67b3b4c252fbc32beeeded299ca
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

tests/watchdog: Make sure the watchdog can be configured while disabled

Change-Id: If25a533fd23ede502df402d021742aa19f64d2f6
Signed-off-by: William A. Kennington III <wak@google.com>

tests/watchdog: Add a helper for counting down with the watchdog

This reduces a bunch of duplicate code that loops through an event loop
to try and guage how long it took for the watchdog to expire.

tests/watchdog: Add a helper for counting down with the watchdog

This reduces a bunch of duplicate code that loops through an event loop
to try and guage how long it took for the watchdog to expire.

Change-Id: Ib3b33e250b157df02eff39751277c564ea40705c
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

watchdog: Add a function to tell us if the timer is running

This helps us refactor some of our existing code and will be useful for
future changes.

Change-Id: Ifa1547f09997d6824f726fc5f46e15eed4c1e

watchdog: Add a function to tell us if the timer is running

This helps us refactor some of our existing code and will be useful for
future changes.

Change-Id: Ifa1547f09997d6824f726fc5f46e15eed4c1e8c1
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

tests: Make private members protected

Googletest derived classes should never have private members unless they
are inteded to not be accessible to class functions. Since class
functions are derived

tests: Make private members protected

Googletest derived classes should never have private members unless they
are inteded to not be accessible to class functions. Since class
functions are derived from the provided class, the private members are
unable to be accessed by the test cases. In a future change we need access
to one of these members so make them protected.

Change-Id: Iadbb53adc748d02168a1fc83f738f86437a1d15c
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

test/watchdog: Use a unique_ptr for the watchdog

This lets us change out the watchdog with a watchdog constructed using
different parameters. Currently this functionality is not used, but it
is need

test/watchdog: Use a unique_ptr for the watchdog

This lets us change out the watchdog with a watchdog constructed using
different parameters. Currently this functionality is not used, but it
is needed for a future change.

Change-Id: Ie1e7fbf2c7fc8bf2949237f2535177ecd46944a0
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

tests: Convert EXPECT_EQ(bool -> EXPECT_{TRUE,FALSE}

This is more in line with normal gtest code style.

Change-Id: If49f700f756ad8d278927baae4e934ef7aa399d7
Signed-off-by: William A. Kennington III

tests: Convert EXPECT_EQ(bool -> EXPECT_{TRUE,FALSE}

This is more in line with normal gtest code style.

Change-Id: If49f700f756ad8d278927baae4e934ef7aa399d7
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

test/Makefile: Build test sources using automake targets

If you specify object files for LDADD it will use some kind of built in
rules for building those objects instead of adding the proper CFLAGS

test/Makefile: Build test sources using automake targets

If you specify object files for LDADD it will use some kind of built in
rules for building those objects instead of adding the proper CFLAGS to
the compile process. This results in build failures if the CFLAGS were
actually needed to compile those objects.

Change-Id: I1b7837c41fb5fc840d8b913802cfcdc0ee800455
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

argument: Support multiple arguments

This will be used in future patches. Right now this should retain
similar behavior to the current argument parsing semantics. The
difference is we now require ar

argument: Support multiple arguments

This will be used in future patches. Right now this should retain
similar behavior to the current argument parsing semantics. The
difference is we now require arguments to be specified only once and
error if they are specified multiple times.

Change-Id: I21e4cf9734f045c2b0991f7ed0ec6e6a569eec7d
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

argument: Implement test cases

The argument parser had a few subtle bugs and could use some tests.

Change-Id: I0adbc507a822a6887fbf02b888b1f678b3cc7b35
Signed-off-by: William A. Kennington III <wak

argument: Implement test cases

The argument parser had a few subtle bugs and could use some tests.

Change-Id: I0adbc507a822a6887fbf02b888b1f678b3cc7b35
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

configure/make: Allow googletest from pkg-config

Change-Id: I2eb526827987dd2361d35fd782229b1461d49d01
Signed-off-by: William A. Kennington III <wak@google.com>

Spelling fixes

Change-Id: I3a85e921f87401701f3ebb22e972e0d3f9cf19c1
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

Don't set Interval by setting TimeRemaining

This change allows one to set the TimeRemaining as a one-time shot,
and also allows more straightforward control.

-Changing the Interval doesn't reset th

Don't set Interval by setting TimeRemaining

This change allows one to set the TimeRemaining as a one-time shot,
and also allows more straightforward control.

-Changing the Interval doesn't reset the watchdog or update the
TimeRemaining.
-Changing the TimeRemaining doesn't set the Interval for future
cycles.

Change-Id: I03a3cdb9cc9e5c4bc034dc86d2b4324a5a4b7243
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

Update Interval when timeRemaining is updated

A typical watchdog implementation would give these 2 features:
- Setting the interval
- Resetting the timer which also means poke

This watchdog imp

Update Interval when timeRemaining is updated

A typical watchdog implementation would give these 2 features:
- Setting the interval
- Resetting the timer which also means poke

This watchdog implementation does not provide a poke function
and the same can be achieved by clients making these dbus calls
in that order.

1) Get the Last set Interval
2) Set TimeRemaining field to result from #1

To achieve #1, this commit adds the support.

This would make sure that the new timer would expire after last
updated user interval from that time.

Fixes openbmc/openbmc#767

Change-Id: I7393eb32992d7a08518ef463fd0a442df0772392
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

show more ...

Commit error and exit the application on error scenarios

Typically sd_event* calls can not go wrong and if they do, better
would be to terminate the application so we get a coredump.

Change-Id: I89

Commit error and exit the application on error scenarios

Typically sd_event* calls can not go wrong and if they do, better
would be to terminate the application so we get a coredump.

Change-Id: I899177c369332cabf6d9bc22daaa142b50d758d0
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

show more ...

Add Gtest to test watchdog

Change-Id: Ia0268b6b18999b6dd6cfd26bcadcff25734306f0
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>