Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: Ib222566e157068f36e05e75f74e8381a75c8c0a7
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ia06580233fef9cef24843e1e3ff6b5a3f522852a
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I592583489212a3a7d3fc48cedac2a97489aa149b

show more ...

phosphor-watchdog: Cleanup CodeChecker Errors

Removed the following error messages:
bugprone-unused-raii
- object destroyed immediately after creation; did you mean to name
the object
performanc

phosphor-watchdog: Cleanup CodeChecker Errors

Removed the following error messages:
bugprone-unused-raii
- object destroyed immediately after creation; did you mean to name
the object
performance-move-const-arg
- std::move of the variable 'maybeFallback' of the trivially-copyable
type 'std::optional' has no effect; remove std::move()
clang-diagnostic-inconsistent-missing-override
- 'interval' overrides a member function but is not marked 'override'

Change-Id: I0f6ab3002b7175a73449d58ea6ae6b66f7c851ef
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

test/watchdog: Remove separate header

The header contents are not being shared anywhere and the name collides
with the source header.

Change-Id: I2ddfd4488e2318b9fdd34cc1663044dbe413f4f1
Signed-off

test/watchdog: Remove separate header

The header contents are not being shared anywhere and the name collides
with the source header.

Change-Id: I2ddfd4488e2318b9fdd34cc1663044dbe413f4f1
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

meson: Use subprojects where possible

Change-Id: Id49b7db21f7f44d5183549430988fd33b9166edb
Signed-off-by: William A. Kennington III <wak@google.com>

meson: Propagate watchdog library dependencies

Change-Id: I0d5d52ef456ca829b759c65c6fd7e30eb8270744
Signed-off-by: William A. Kennington III <wak@google.com>

meson: Fixup formatting

Change-Id: Ia948e7605bead1ddfb17b8071cd39cc28353eadc
Signed-off-by: William A. Kennington III <wak@google.com>

test/watchdog: Fix multi-object acquisition

The tests were mistakenly trying to acquire the same DBus path for
watchdog objects while older versions of the objects were still alive.
This fixes the i

test/watchdog: Fix multi-object acquisition

The tests were mistakenly trying to acquire the same DBus path for
watchdog objects while older versions of the objects were still alive.
This fixes the issue by purging the old objects before creating new
ones.

Change-Id: I65bef2f0edab7057c05af9ecd31e554da6565184
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Test min interval is used when setting remaining time

Test that min interval is used when setting remaining time by extending
the existing test case.

Signed-off-by: Kun Yi <kunyi731@gmail.com>
Chan

Test min interval is used when setting remaining time

Test that min interval is used when setting remaining time by extending
the existing test case.

Signed-off-by: Kun Yi <kunyi731@gmail.com>
Change-Id: I595464b5b6e4c1ef9968849ca63d09a7665d9190

show more ...

Add a test for the fallback reset timer case

Add a test to verify that reset timer enable will set the timer to the primary
interval.

Tested: tests pass

Signed-off-by: Kun Yi <kunyi731@gmail.com>

Add a test for the fallback reset timer case

Add a test to verify that reset timer enable will set the timer to the primary
interval.

Tested: tests pass

Signed-off-by: Kun Yi <kunyi731@gmail.com>
Change-Id: I0c74b250d1ca2ff20c4a331de9290d73db2774d8

show more ...

Implementation of minimum watchdog interval.

Tested: phosphor-watchdog CI unittest - set interval to value smaller than
the minimum interval and test that the minimum interval was set as the
interva

Implementation of minimum watchdog interval.

Tested: phosphor-watchdog CI unittest - set interval to value smaller than
the minimum interval and test that the minimum interval was set as the
interval.
Change-Id: I88d7ca865ce57eaccea8aaf50396dbb50bd396fb
Signed-off-by: Ofer Yehielli <ofery@google.com>

show more ...

autotools: Remove

Meson is now used to build this package in all of the necessary places.

Change-Id: I7fec7c28defc8b5f6aeb2384dd984ee6278a4bcb
Signed-off-by: William A. Kennington III <wak@google.c

autotools: Remove

Meson is now used to build this package in all of the necessary places.

Change-Id: I7fec7c28defc8b5f6aeb2384dd984ee6278a4bcb
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

meson: Add alternate build system

For now we will support both the autotools and meson build systems
alongside each other, until support for meson is ready across the
ecosystem.

Tested:
Run thr

meson: Add alternate build system

For now we will support both the autotools and meson build systems
alongside each other, until support for meson is ready across the
ecosystem.

Tested:
Run through build and unit tests that leverage the new build system
and all of the tests pass and the install puts phosphor-watchdog in
the correct location.

Change-Id: I0454e763acc648ac76efd7728f6da498d9acf5dd
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

test/watchdog: Change the time quantum to 0.1s instead of 1s

This improves the runtime of the test suite from 60s down to 6s or less.

Tested:
Run multiple times through the unit test suite with

test/watchdog: Change the time quantum to 0.1s instead of 1s

This improves the runtime of the test suite from 60s down to 6s or less.

Tested:
Run multiple times through the unit test suite without any
flakiness.

Change-Id: Ib7d97ed62b45501db9cf15dba01e33f8f9d07b5d
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

test/watchdog: Define a time quantum type

This will allow us to change the size of the windows of time we wait for
watchdog events to happen. Right now this doesn't actually change any
behavior it j

test/watchdog: Define a time quantum type

This will allow us to change the size of the windows of time we wait for
watchdog events to happen. Right now this doesn't actually change any
behavior it just makes it easier to tweak.

Tested:
Run through the build and unit test suite.

Change-Id: If5b351574346426aff6499701164a3d5ebf9db7c
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

test/watchdog: Don't use designated initializers

gcc supported this in c++ even though it was non-standard until c++2a is
complete. This change removes designated initializers to make our tests
comp

test/watchdog: Don't use designated initializers

gcc supported this in c++ even though it was non-standard until c++2a is
complete. This change removes designated initializers to make our tests
compliant with std++17.

Tested:
Built and run through unit tests.

Change-Id: I846394c633c0396518db6ed41682bbcf05b890c6
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

test: Rename watchdog_test to watchdog

Tested:
Ran through build and unit test suite.

Change-Id: I3a906ac26c43ac419eef8a98b20a498fe22f942b
Signed-off-by: William A. Kennington III <wak@google.c

test: Rename watchdog_test to watchdog

Tested:
Ran through build and unit test suite.

Change-Id: I3a906ac26c43ac419eef8a98b20a498fe22f942b
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Convert to standard CLI11 argument parser

This simplifies the argument parsing logic drastically and still
provides the same error handling as before.

Tested:
Ran through unit test suite and ma

Convert to standard CLI11 argument parser

This simplifies the argument parsing logic drastically and still
provides the same error handling as before.

Tested:
Ran through unit test suite and manually verified that the command
line functions as expected on a real BMC.

Change-Id: Ic5d69adf5359f9f64f2ada17e6a8f3242ca03e25
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Convert to using sdeventplus

This gets rid of the ad-hoc timer class in favor of using the timer
source built into sdeventplus.

Tested:
Unit tests pass and everything still builds. Manually ver

Convert to using sdeventplus

This gets rid of the ad-hoc timer class in favor of using the timer
source built into sdeventplus.

Tested:
Unit tests pass and everything still builds. Manually verified the
functionality is still in tact on a zaius machine.

Change-Id: I90619f0fe5a9fdfcecd24a49de672c0c99dc95e9
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

test/watchdog: Test interval update

Adds a test to ensure that setting the interval on the watchdog affects
subsequent resetTimeRemaining() calls.

Tested:
Ran through a unit test run

Change-Id

test/watchdog: Test interval update

Adds a test to ensure that setting the interval on the watchdog affects
subsequent resetTimeRemaining() calls.

Tested:
Ran through a unit test run

Change-Id: Ibff14bbb40d5b93ffd5eaa5149f5cc9822e21d1e
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Standardize Action -> Target Map Type

This change refactors the watchdog header to export the type of watchdog
action to systemd target map, so it can be directly used by other files.
This makes enu

Standardize Action -> Target Map Type

This change refactors the watchdog header to export the type of watchdog
action to systemd target map, so it can be directly used by other files.
This makes enumerating the map type more trivial.

Also convert to an unordered_map instead of map since we don't need the
ordering guarantees.

Tested:
Builds and tests still pass

Change-Id: I77d315210ec27fde295589479c50d46dc5d1b32a
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

add .clang-format

Change-Id: I6d9ec8401dcd46781ea258bf8998faa2507fa91d
Signed-off-by: Patrick Venture <venture@google.com>

Implement a flag to enable fallback always

On some machines we want our watchdog running as long as the
phosphor-watchdog daemon is alive. This patch adds an option to enter
fallback mode any time t

Implement a flag to enable fallback always

On some machines we want our watchdog running as long as the
phosphor-watchdog daemon is alive. This patch adds an option to enter
fallback mode any time the watchdog expires or is set to be disabled.

Change-Id: Ic96d2f15c761aeb4e25158c5bd861076cca6497d
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Implement a fallback watchdog option

Sometimes our initial watchdog action is not enough to recover the host
from the state it transitioned into. However, always using a more power
form of power cyc

Implement a fallback watchdog option

Sometimes our initial watchdog action is not enough to recover the host
from the state it transitioned into. However, always using a more power
form of power cycle is not desirable as we can lose useful CPU crash
state. It is desirable in this case to have two levels of watchog
timers.

This patch implements the ability for the service to specify a fallback
watchdog action and interval. After the initial watchdog timeout is
encountered, the watchdog will be re-armed with the new parameters. Once
the watchdog times out again it will execute the fallback action.
Attempts to update the timeRemaining will reset the fallback just in
case something is still alive.

Change-Id: I69f4422c7e3963f02200815f3cef620af9e6cf8b
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...