clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ia06580233fef9cef24843e1e3ff6b5a3f522852a
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I592583489212a3a7d3fc48cedac2a97489aa149b

show more ...

phosphor-watchdog: Cleanup CodeChecker Errors

Removed the following error messages:
bugprone-unused-raii
- object destroyed immediately after creation; did you mean to name
t

phosphor-watchdog: Cleanup CodeChecker Errors

Removed the following error messages:
bugprone-unused-raii
- object destroyed immediately after creation; did you mean to name
the object
performance-move-const-arg
- std::move of the variable 'maybeFallback' of the trivially-copyable
type 'std::optional' has no effect; remove std::move()
clang-diagnostic-inconsistent-missing-override
- 'interval' overrides a member function but is not marked 'override'

Change-Id: I0f6ab3002b7175a73449d58ea6ae6b66f7c851ef
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

test/watchdog: Remove separate header

The header contents are not being shared anywhere and the name collides
with the source header.

Change-Id: I2ddfd4488e2318b9fdd34cc1663044d

test/watchdog: Remove separate header

The header contents are not being shared anywhere and the name collides
with the source header.

Change-Id: I2ddfd4488e2318b9fdd34cc1663044dbe413f4f1
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

test/watchdog: Fix multi-object acquisition

The tests were mistakenly trying to acquire the same DBus path for
watchdog objects while older versions of the objects were still alive.

test/watchdog: Fix multi-object acquisition

The tests were mistakenly trying to acquire the same DBus path for
watchdog objects while older versions of the objects were still alive.
This fixes the issue by purging the old objects before creating new
ones.

Change-Id: I65bef2f0edab7057c05af9ecd31e554da6565184
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Test min interval is used when setting remaining time

Test that min interval is used when setting remaining time by extending
the existing test case.

Signed-off-by: Kun Yi <kuny

Test min interval is used when setting remaining time

Test that min interval is used when setting remaining time by extending
the existing test case.

Signed-off-by: Kun Yi <kunyi731@gmail.com>
Change-Id: I595464b5b6e4c1ef9968849ca63d09a7665d9190

show more ...

Add a test for the fallback reset timer case

Add a test to verify that reset timer enable will set the timer to the primary
interval.

Tested: tests pass

Signed-off-by:

Add a test for the fallback reset timer case

Add a test to verify that reset timer enable will set the timer to the primary
interval.

Tested: tests pass

Signed-off-by: Kun Yi <kunyi731@gmail.com>
Change-Id: I0c74b250d1ca2ff20c4a331de9290d73db2774d8

show more ...

Implementation of minimum watchdog interval.

Tested: phosphor-watchdog CI unittest - set interval to value smaller than
the minimum interval and test that the minimum interval was set as

Implementation of minimum watchdog interval.

Tested: phosphor-watchdog CI unittest - set interval to value smaller than
the minimum interval and test that the minimum interval was set as the
interval.
Change-Id: I88d7ca865ce57eaccea8aaf50396dbb50bd396fb
Signed-off-by: Ofer Yehielli <ofery@google.com>

show more ...

test/watchdog: Define a time quantum type

This will allow us to change the size of the windows of time we wait for
watchdog events to happen. Right now this doesn't actually change any

test/watchdog: Define a time quantum type

This will allow us to change the size of the windows of time we wait for
watchdog events to happen. Right now this doesn't actually change any
behavior it just makes it easier to tweak.

Tested:
Run through the build and unit test suite.

Change-Id: If5b351574346426aff6499701164a3d5ebf9db7c
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

test/watchdog: Don't use designated initializers

gcc supported this in c++ even though it was non-standard until c++2a is
complete. This change removes designated initializers to make ou

test/watchdog: Don't use designated initializers

gcc supported this in c++ even though it was non-standard until c++2a is
complete. This change removes designated initializers to make our tests
compliant with std++17.

Tested:
Built and run through unit tests.

Change-Id: I846394c633c0396518db6ed41682bbcf05b890c6
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

test: Rename watchdog_test to watchdog

Tested:
Ran through build and unit test suite.

Change-Id: I3a906ac26c43ac419eef8a98b20a498fe22f942b
Signed-off-by: William A. Kenn

test: Rename watchdog_test to watchdog

Tested:
Ran through build and unit test suite.

Change-Id: I3a906ac26c43ac419eef8a98b20a498fe22f942b
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...