clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I968e50d74cce0077d58d658c645fff74dde2254a
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ia06580233fef9cef24843e1e3ff6b5a3f522852a
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

main: Leverage common function for loop

sdeventplus now has a common function that works around dbus memory
leaks when being used with sdbus.

Change-Id: Id4a405508296c63158abfa28c4063a386704480b
Si

main: Leverage common function for loop

sdeventplus now has a common function that works around dbus memory
leaks when being used with sdbus.

Change-Id: Id4a405508296c63158abfa28c4063a386704480b
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I592583489212a3a7d3fc48cedac2a97489aa149b

show more ...

mainapp: Fix potential bus leak

If we allow the event loop to begin processing outstadning bus events
like bus hello, we can end up with a libsystemd bug that leaks handles
to future bus events, cau

mainapp: Fix potential bus leak

If we allow the event loop to begin processing outstadning bus events
like bus hello, we can end up with a libsystemd bug that leaks handles
to future bus events, causing the watchdog and broker to fill up their
memory spaces.

Change-Id: I642cf6f24e687eac05b60acd0dac008297f20de9
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

mainapp: Terminate cleanly for TERM and INT

This makes it possible to instrument the application for memory leaks
and other required sanitization at termination.

Change-Id: If83

mainapp: Terminate cleanly for TERM and INT

This makes it possible to instrument the application for memory leaks
and other required sanitization at termination.

Change-Id: If83bf7b5151231e8db35bf2e2f2d5ddc74b9627d
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

phosphor-watchdog: Cleanup CodeChecker Errors

Removed the following error messages:
bugprone-unused-raii
- object destroyed immediately after creation; did you mean to name
t

phosphor-watchdog: Cleanup CodeChecker Errors

Removed the following error messages:
bugprone-unused-raii
- object destroyed immediately after creation; did you mean to name
the object
performance-move-const-arg
- std::move of the variable 'maybeFallback' of the trivially-copyable
type 'std::optional' has no effect; remove std::move()
clang-diagnostic-inconsistent-missing-override
- 'interval' overrides a member function but is not marked 'override'

Change-Id: I0f6ab3002b7175a73449d58ea6ae6b66f7c851ef
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I873cbdcd8d4e7f553efbde0d667293d36ba5dfa4

Fix klocwork issues

Klockwork reports these issues:
1. phosphor-watchdog/src/mainapp.cpp:119 | main()
'fallbackAlways' is used uninitialized in this function.
2. phosphor-watc

Fix klocwork issues

Klockwork reports these issues:
1. phosphor-watchdog/src/mainapp.cpp:119 | main()
'fallbackAlways' is used uninitialized in this function.
2. phosphor-watchdog/src/mainapp.cpp:129 | main()
'watchPostcodes' is used uninitialized in this function.
3. phosphor-watchdog/src/mainapp.cpp:80 | main()
'continueAfterTimeout' is used uninitialized in this function.

This commit adds default values to resolve these issues.

Tested: Watchdog service worked well.

Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Change-Id: Ib88afb60e801c3f90e039cca99dca5409e896fc1

show more ...

watchdog: support a default interval parameter

IBM has a desire to be able to define a Interval value different then
the default on watchdog startup. Some systems need a larger starting

watchdog: support a default interval parameter

IBM has a desire to be able to define a Interval value different then
the default on watchdog startup. Some systems need a larger starting
value and it's easiest to pass this in at watchdog startup time.

Tested:
- Verified when new parameter is not passed, the standard 30000 default
is used.
- Verified when the new --default_interval is passed in that it is used

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I51908f69b4f9af26a7bb49101c4ca2ee97ef555c

show more ...

mainapp: Fix postcode path

This was changed from /raw to /raw0

Change-Id: Idf99ffa36aca41ff5da5bab357ab6446cff737ee
Signed-off-by: William A. Kennington III <wak@google.com>

Move source into src directory

This makes the source more distinguishable from top-level metadata.

Change-Id: I5e41186d4606422937ec7d37402a3031d3f776b6
Signed-off-by: William A.

Move source into src directory

This makes the source more distinguishable from top-level metadata.

Change-Id: I5e41186d4606422937ec7d37402a3031d3f776b6
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...