clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I373c511cbbae05929e24811c7ad8a607594024e8
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I968e50d74cce0077d58d658c645fff74dde2254a
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ia06580233fef9cef24843e1e3ff6b5a3f522852a
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

main: Leverage common function for loop

sdeventplus now has a common function that works around dbus memory
leaks when being used with sdbus.

Change-Id: Id4a405508296c63158abfa28c4063a386704480b
Si

main: Leverage common function for loop

sdeventplus now has a common function that works around dbus memory
leaks when being used with sdbus.

Change-Id: Id4a405508296c63158abfa28c4063a386704480b
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

build: Fixups for local building

Change-Id: I38cc5c0afc57f10a5cae61ca1c72e838c58ba33b
Signed-off-by: William A. Kennington III <wak@google.com>

phosphor-watchdog: Send Signal None for timout

As per IPMI specification signal should be send
for action "None" when no timout action
configured. Because TimerExpired also a event.

00h - Timer exp

phosphor-watchdog: Send Signal None for timout

As per IPMI specification signal should be send
for action "None" when no timout action
configured. Because TimerExpired also a event.

00h - Timer expired
01h - Hard reset
02h - Power down
03h - Power cycle

Tested:
Successfully build and tested in reference
platform.
Signal received when action configured as None.

Signed-off-by: selvaganapathi <selvaganapathim@ami.com>
Change-Id: I9a0ee11c31a6dc3992f0b6689753b468cf78a095

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I592583489212a3a7d3fc48cedac2a97489aa149b

show more ...

meson: simplify dependencies

Leverage wrapfile `[provide]` directives to simplify the dependency
searching in the meson.build.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id97da9

meson: simplify dependencies

Leverage wrapfile `[provide]` directives to simplify the dependency
searching in the meson.build.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id97da97371cf4b8f526f0cc1ca4e4151c466fadf

show more ...

mainapp: Fix potential bus leak

If we allow the event loop to begin processing outstadning bus events
like bus hello, we can end up with a libsystemd bug that leaks handles
to future bus events, cau

mainapp: Fix potential bus leak

If we allow the event loop to begin processing outstadning bus events
like bus hello, we can end up with a libsystemd bug that leaks handles
to future bus events, causing the watchdog and broker to fill up their
memory spaces.

Change-Id: I642cf6f24e687eac05b60acd0dac008297f20de9
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

mainapp: Terminate cleanly for TERM and INT

This makes it possible to instrument the application for memory leaks
and other required sanitization at termination.

Change-Id: If83bf7b5151231e8db35bf2

mainapp: Terminate cleanly for TERM and INT

This makes it possible to instrument the application for memory leaks
and other required sanitization at termination.

Change-Id: If83bf7b5151231e8db35bf2e2f2d5ddc74b9627d
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

phosphor-watchdog: Cleanup CodeChecker Errors

Removed the following error messages:
bugprone-unused-raii
- object destroyed immediately after creation; did you mean to name
the object
performanc

phosphor-watchdog: Cleanup CodeChecker Errors

Removed the following error messages:
bugprone-unused-raii
- object destroyed immediately after creation; did you mean to name
the object
performance-move-const-arg
- std::move of the variable 'maybeFallback' of the trivially-copyable
type 'std::optional' has no effect; remove std::move()
clang-diagnostic-inconsistent-missing-override
- 'interval' overrides a member function but is not marked 'override'

Change-Id: I0f6ab3002b7175a73449d58ea6ae6b66f7c851ef
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I873cbdcd8d4e7f553efbde0d667293d36ba5dfa4

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id531dea23a3084fc0d1e4c5e0504e944bd619b05

show more ...

watchdog: Add signal for timeout event

Send out Timeout signal to indicate timeout event.

The new signal will be sent to the object path of the watchdog with
`xyz.openbmc_project.Watchdog` as the i

watchdog: Add signal for timeout event

Send out Timeout signal to indicate timeout event.

The new signal will be sent to the object path of the watchdog with
`xyz.openbmc_project.Watchdog` as the interface and the "Timeout"
as Member.

The first argument of signal will be the action taken by the timeout
event to help indicate the event type.

This allow the us to know that the timeout event happened and the action
taken. The action taken might not be the same as expiredAction due to
fallback mode.

Tested:
```
$ ipmitool sel list
3c | Pre-Init |0000000173| Watchdog2 #0xf9 | Power cycle | Asserted
3d | Pre-Init |0000000175| Watchdog2 #0xf9 | Power cycle | Asserted
3e | Pre-Init |0000000176| Watchdog2 #0xf9 | Power cycle | Asserted
3f | Pre-Init |0000000178| Watchdog2 #0xf9 | Power cycle | Asserted
```

Change-Id: I88b3e837c0e011fc6c2a0537bfd98b0720716076
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

Fix klocwork issues

Klockwork reports these issues:
1. phosphor-watchdog/src/mainapp.cpp:119 | main()
'fallbackAlways' is used uninitialized in this function.
2. phosphor-watchdog/src/mainapp.cpp

Fix klocwork issues

Klockwork reports these issues:
1. phosphor-watchdog/src/mainapp.cpp:119 | main()
'fallbackAlways' is used uninitialized in this function.
2. phosphor-watchdog/src/mainapp.cpp:129 | main()
'watchPostcodes' is used uninitialized in this function.
3. phosphor-watchdog/src/mainapp.cpp:80 | main()
'continueAfterTimeout' is used uninitialized in this function.

This commit adds default values to resolve these issues.

Tested: Watchdog service worked well.

Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Change-Id: Ib88afb60e801c3f90e039cca99dca5409e896fc1

show more ...

build: Subproject support

Change-Id: I4451ad2b516d585a71f74e2897548d22ac5d0472
Signed-off-by: William A. Kennington III <wak@google.com>

watchdog: support a default interval parameter

IBM has a desire to be able to define a Interval value different then
the default on watchdog startup. Some systems need a larger starting
value and it

watchdog: support a default interval parameter

IBM has a desire to be able to define a Interval value different then
the default on watchdog startup. Some systems need a larger starting
value and it's easiest to pass this in at watchdog startup time.

Tested:
- Verified when new parameter is not passed, the standard 30000 default
is used.
- Verified when the new --default_interval is passed in that it is used

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I51908f69b4f9af26a7bb49101c4ca2ee97ef555c

show more ...

mainapp: Fix postcode path

This was changed from /raw to /raw0

Change-Id: Idf99ffa36aca41ff5da5bab357ab6446cff737ee
Signed-off-by: William A. Kennington III <wak@google.com>

Move source into src directory

This makes the source more distinguishable from top-level metadata.

Change-Id: I5e41186d4606422937ec7d37402a3031d3f776b6
Signed-off-by: William A. Kennington III <wak

Move source into src directory

This makes the source more distinguishable from top-level metadata.

Change-Id: I5e41186d4606422937ec7d37402a3031d3f776b6
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...