| #
6b6f2d80 |
| 24-Oct-2022 |
Nan Zhou <nanzhoumails@gmail.com> |
userEnable: fix bug and add unit test
This commit adds unit tests for the |userEnable| function. To make it
happen, a new overload of |executeUserModify| is introduced. The idea
is the same as previ
userEnable: fix bug and add unit test
This commit adds unit tests for the |userEnable| function. To make it
happen, a new overload of |executeUserModify| is introduced. The idea
is the same as previous commits where we add sudo in unit tests.
Thanks to this unit test, this commit fixes an existing bug where the
corresponding user's |userEnabled| attribute isn't updated.
Tested: unit test passed
Coverage:
lines......: 81.3% (1918 of 2359 lines)
functions..: 93.9% (400 of 426 functions)
branches...: 32.0% (3029 of 9469 branches)
Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: I89752e5fcfc1aabb4090b0b2e8faf5f1b5ee5e76
show more ...
|
| #
fef63038 |
| 24-Oct-2022 |
Nan Zhou <nanzhoumails@gmail.com> |
updateGroupsAndPriv: fix bugs and add tests
This commit adds a unit test for the |updateGroupsAndPriv| function.
Thanks to the test case, I found a bug that the exsting codes don't
updat the groups
updateGroupsAndPriv: fix bugs and add tests
This commit adds a unit test for the |updateGroupsAndPriv| function.
Thanks to the test case, I found a bug that the exsting codes don't
updat the groups and privilege of the user after updating.
Added several neccessary functions to add unit test and fix bugs.
Tested: unit test passed.
Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: Ifcf88505f10b6bfdcca2de31a29ce055153463e8
show more ...
|
| #
f3fb77c0 |
| 29-Aug-2022 |
Nan Zhou <nanzhoumails@gmail.com> |
treewide: make code compie on clang
This patch fixed several minor issues that clang14 complains about.
1. clang-diagnostic-inconsistent-missing-override
2. clang-diagnostic-defaulted-function-dele
treewide: make code compie on clang
This patch fixed several minor issues that clang14 complains about.
1. clang-diagnostic-inconsistent-missing-override
2. clang-diagnostic-defaulted-function-deleted
3. clang-diagnostic-unused-const-variable
Tested:
1. it builds with clang14
2. tested on hardware, ldap config daemon and user manager daemon are
both good. Tested DBus APIs (e.g., create config) as well.
Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: Idf8d0481fc05735b4b3d021f30aa44272f2369bf
show more ...
|
| #
b3ef4e1a |
| 22-Jul-2022 |
Patrick Williams <patrick@stwcx.xyz> |
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I19e094a2a99893627dbb82b615f630b87ad90fdd
show more ...
|
| #
9638afb9 |
| 22-Feb-2021 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format-11: reformat
The .clang-format file here is an old version of the common one.
Upgrade to the latest and reformat.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz
clang-format-11: reformat
The .clang-format file here is an old version of the common one.
Upgrade to the latest and reformat.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I0d532aa88d650e9c7664e07abfc8c4fdf0dd3df4
show more ...
|
| #
703131fa |
| 28-Oct-2020 |
Gunnar Mills <gmills@us.ibm.com> |
c++17: drop experimental::filesystem
Use std::filesystem, and drop support for building with experimental
under c++14.
Tested: Build the repo.
Change-Id: I4af0d9c034dbfef5a6
c++17: drop experimental::filesystem
Use std::filesystem, and drop support for building with experimental
under c++14.
Tested: Build the repo.
Change-Id: I4af0d9c034dbfef5a65153ba5447b86c961aebf1
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
show more ...
|
| #
3ab6cc28 |
| 03-Mar-2020 |
Joseph Reynolds <joseph-reynolds@charter.net> |
Add UserPasswordExpired for local users
Adds a new UserPasswordExpired property to local User.Attributes which
represents if the account's password is expired and must be changed.
Th
Add UserPasswordExpired for local users
Adds a new UserPasswordExpired property to local User.Attributes which
represents if the account's password is expired and must be changed.
The value corresponds to the `chage` command.
Note this is distinct from UserLockedForFailedAttempt which represents
a locked account due to unsuccessful authentication atttempts.
Tested: Via busctl
- Checked local and LDAP users.
- Expired password via `passwd --expire USER`.
- Aged password via `chage USER`.
- Changed password via REST API and via the `passwd USER` command.
Signed-off-by: Joseph Reynolds <joseph-reynolds@charter.net>
Change-Id: I44585559509a422bb91c83a2a853c1a033594350
show more ...
|
| #
1af12233 |
| 02-Nov-2018 |
Ratan Gupta <ratagupt@linux.vnet.ibm.com> |
Fix emit interface added signal
Send the interface added signal once the object is fully
populated.
Here we are fixing this behaviour for two D-bus objects
1) Root Dbus obje
Fix emit interface added signal
Send the interface added signal once the object is fully
populated.
Here we are fixing this behaviour for two D-bus objects
1) Root Dbus object for user manager app.
2) Individual user D-bus object.
Before this fix was getting two signals for creation of user/manager
signal time=1562577322.850104 sender=:1.57 -> destination=(null destination) serial=346
path=/xyz/openbmc_project/user; interface=org.freedesktop.DBus.ObjectManager; member=InterfacesAdded
signal time=1562577322.897089 sender=:1.57 -> destination=(null destination) serial=347
path=/xyz/openbmc_project/user; interface=org.freedesktop.DBus.ObjectManager; member=InterfacesAdded
After the fix was getting single signal
signal time=1562577775.550198 sender=:1.156 -> destination=(null destination) serial=27
path=/xyz/openbmc_project/user; interface=org.freedesktop.DBus.ObjectManager; member=InterfacesAdded
Change-Id: I20ac168fe4fc7cd94cd2032db6ebc1623af5943d
Signed-off-by: Ratan Gupta <ratagupt@linux.vnet.ibm.com>
show more ...
|
| #
c704519e |
| 13-Jun-2018 |
Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com> |
Add support for user locked state property
Support for user locked state property using
pam_tally2 application added.
Change-Id: Ia77ff6527c15c93ac272110950e99fff56dcbaa6
Si
Add support for user locked state property
Support for user locked state property using
pam_tally2 application added.
Change-Id: Ia77ff6527c15c93ac272110950e99fff56dcbaa6
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
show more ...
|
| #
9f630d9e |
| 24-May-2018 |
Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com> |
Basic support for User manager service
Basic support for User Manager service methods
are implemented.
Change-Id: Id42432ec6dd421b99971268add931dcd70876f7c
Signed-off-by: Ri
Basic support for User manager service
Basic support for User Manager service methods
are implemented.
Change-Id: Id42432ec6dd421b99971268add931dcd70876f7c
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>
show more ...
|