Remove Boost dependency

phosphor-user-manager no longer uses any Boost functionality, so
remove Boost from meson.build and all related includes.

Change-Id: I7432e65c2b91e35892bc587e88dd9bb861843775

Remove Boost dependency

phosphor-user-manager no longer uses any Boost functionality, so
remove Boost from meson.build and all related includes.

Change-Id: I7432e65c2b91e35892bc587e88dd9bb861843775
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

show more ...

Replace boost ends_with with std::string

C++20 introduces std::string::ends_with, which provide standard,
efficient, and header-light ways to check string prefixes and
suffixes. Replacing boost::alg

Replace boost ends_with with std::string

C++20 introduces std::string::ends_with, which provide standard,
efficient, and header-light ways to check string prefixes and
suffixes. Replacing boost::algorithm::ends_with reduces Boost
dependencies, simplifies includes, and improves compilation
performance.

Change-Id: I4dbb849a750f55e3fe7409ba91c63d8a379aae18
Signed-off-by: George Liu <liuxiwei@ieisystem.com>

show more ...

meson: handle missing ldap dependency

Adjust the meson.build so that ldap can be an optional dependency.
This allows out-of-docker builds for environments which might not have
the LDAP libraries ins

meson: handle missing ldap dependency

Adjust the meson.build so that ldap can be an optional dependency.
This allows out-of-docker builds for environments which might not have
the LDAP libraries installed. In the future this could also be
leveraged by a meson.option that would disable LDAP support.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I214b7e69580bd11432f88a85fa760a5e07f7fad2

show more ...

Fix Clang 20 build issues

It is observed that with recent change of clang to 20 there are some CI
build issues found on phosphor-user-manager based on readability and
style. I fixed the same

Change

Fix Clang 20 build issues

It is observed that with recent change of clang to 20 there are some CI
build issues found on phosphor-user-manager based on readability and
style. I fixed the same

Change-Id: Ief2a902b9970c628b26e908b8c784efe9e524bf6
Signed-off-by: Chandramohan Harkude <chandramohan.harkude@gmail.com>

show more ...

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I295ded87d74037b2f4a6c4b85d82af20d49ae4a7
Signed-off-by: Patrick Williams <p

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I295ded87d74037b2f4a6c4b85d82af20d49ae4a7
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: reformat with meson formatter

Apply the `meson format` results.

Change-Id: I73471b8ae6b57b537b4879f52f5db3c7c06f30f0
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I75bbf0de40859a5e507455a52ceaef9be5b686c7
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: I6959d908cd7b216568963488ead0f3d6ed4a6611
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Remove systemd meson configuration variables

This commit removes meson configuration variables which are not actually
configurable and can be hardcoded.

Change-Id: Id9d198bf6562e108b8a7472e770e6d8b

Remove systemd meson configuration variables

This commit removes meson configuration variables which are not actually
configurable and can be hardcoded.

Change-Id: Id9d198bf6562e108b8a7472e770e6d8bb84e2684
Signed-off-by: Ravi Teja <raviteja28031990@gmail.com>

show more ...

meson: Add boost to the dependencies

Since the project uses boost library add it to meson dependencies.

Tested:
Local build no longer fails with a missing boost headers message on the
system withou

meson: Add boost to the dependencies

Since the project uses boost library add it to meson dependencies.

Tested:
Local build no longer fails with a missing boost headers message on the
system without boost, but fails at the "meson setup build" stage with
an appropriate message.

Change-Id: I872159dcec923d289626b532146c9eb8d5461e1c
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

Change authority D-Bus names

Changing authority service references in code from 'ldap' to more
generic name, to comply with change in phosphor-certificate-manager.

Related change:
https://gerrit.op

Change authority D-Bus names

Changing authority service references in code from 'ldap' to more
generic name, to comply with change in phosphor-certificate-manager.

Related change:
https://gerrit.openbmc.org/c/openbmc/phosphor-certificate-manager/+/65458

Tested:
Adding, reading and removal of CA Certificate via Redfish works without
any noticeable regression.

Change-Id: Ia0517844c5f1d8eb55c4dec156f409fd6875a502
Signed-off-by: Michal Orzel <michalx.orzel@intel.com>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I913685cddaf9a2256b3edcd3ced8e89a32386394
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

ldap-config: Include phosphor-logging in source files

It is recommendded to include the phosphor-logging and related headers
in source files instead of header files.

Tested:
Build and unit test pas

ldap-config: Include phosphor-logging in source files

It is recommendded to include the phosphor-logging and related headers
in source files instead of header files.

Tested:
Build and unit test pass.

Change-Id: I880d8a3bf8dd850af300806da0d17357407632fd
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>

show more ...

Switch to lg2 for logging

After enabling C++20, lg2 is preferred for logging. This patch replaces
all phosphor::logging::log calls to lg2 calls.

Tested:
Build pass.

Change-Id: Ic37bc36f43c2b3a1c61

Switch to lg2 for logging

After enabling C++20, lg2 is preferred for logging. This patch replaces
all phosphor::logging::log calls to lg2 calls.

Tested:
Build pass.

Change-Id: Ic37bc36f43c2b3a1c61b1328af95e3a41c8d6d40
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>

show more ...

Remove support for priv-noaccess role

This change is made w.r.t the discussions in:
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/49295

An authenticated user with the NoAccess role can logi

Remove support for priv-noaccess role

This change is made w.r.t the discussions in:
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/49295

An authenticated user with the NoAccess role can login but they cannot
logout.

This commit is to block the login for a user with priv-noaccess
Details are at https://github.com/openbmc/bmcweb/issues/227

Tested By:
1. Create an LDAP user with priv-noaccess. Verify the login attempt
fails with accessDenied error
2. Verified the other role users can login

Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: I86f554460e224d6d6e70652c08b32f994194494d

show more ...

build tool: remove autotools

Meson is fully working now, remove autotools completely. See
[1] https://gerrit.openbmc.org/c/openbmc/openbmc/+/56842

Tested: see testing performed in the recipe change

build tool: remove autotools

Meson is fully working now, remove autotools completely. See
[1] https://gerrit.openbmc.org/c/openbmc/openbmc/+/56842

Tested: see testing performed in the recipe change.

Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: I679e085cbc1bc59421781fe54e33b1813ef166a1

show more ...

clang-tidy: enable clang-tidy

Enable the first check: readability-identifier-naming

Also fixed all check failures.

Tested:
1. compiles, no clang-tidy failures
2. the two daemons work correctly on

clang-tidy: enable clang-tidy

Enable the first check: readability-identifier-naming

Also fixed all check failures.

Tested:
1. compiles, no clang-tidy failures
2. the two daemons work correctly on hardware regarding DBus APIs

Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: Ic415e857726e8f521c1d61a3e7f0c85121c0d284

show more ...

treewide: make code compie on clang

This patch fixed several minor issues that clang14 complains about.

1. clang-diagnostic-inconsistent-missing-override
2. clang-diagnostic-defaulted-function-dele

treewide: make code compie on clang

This patch fixed several minor issues that clang14 complains about.

1. clang-diagnostic-inconsistent-missing-override
2. clang-diagnostic-defaulted-function-deleted
3. clang-diagnostic-unused-const-variable

Tested:
1. it builds with clang14
2. tested on hardware, ldap config daemon and user manager daemon are
both good. Tested DBus APIs (e.g., create config) as well.

Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: Idf8d0481fc05735b4b3d021f30aa44272f2369bf

show more ...

Set default shell to /bin/sh for ldap users

Change the default shell of ldap users to /bin/sh to make it consistent
with local users.

Tested:
* `getent.ldap passwd` shows the default shell is /bin/

Set default shell to /bin/sh for ldap users

Change the default shell of ldap users to /bin/sh to make it consistent
with local users.

Tested:
* `getent.ldap passwd` shows the default shell is /bin/sh

Change-Id: I3f8071172e20be54c46df2717e005c25f9da19a1
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>

show more ...

meson: find ldap instead of link flags

The current meson adds link flags for libldap directly. This makes that
meson doesn't error out until compilation (e.g., report missing ldap.h).

This commit a

meson: find ldap instead of link flags

The current meson adds link flags for libldap directly. This makes that
meson doesn't error out until compilation (e.g., report missing ldap.h).

This commit adds the ldap dependency explicitly and makes it required.

Tested:
1. CI works
2. bitbake works

Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: I7513a1a825b28c85afc51248e5b93d69a34e82f4

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I19e094a2a99893627dbb82b615f630b87ad90fdd

show more ...

Add port validation for ldap server uri

When a user sets the LDAP server URI with invalid port - value
either less than 0 or greater than 65536, the service should
return error instead of accepting

Add port validation for ldap server uri

When a user sets the LDAP server URI with invalid port - value
either less than 0 or greater than 65536, the service should
return error instead of accepting invalid values.

The error that will be returned in this scenario:
Failed to set property LDAPServerURI on interface \
xyz.openbmc_project.User.Ldap.Config: Invalid argument was given.

Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: Ie9ff263310fbe97298fd6f18b871d82e300189a2

show more ...

meson: ldap-config: add missing cereal dep

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Iff963fc90cc480761da44a2da6a6f6702b450d0a

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications. Map all `true` occurrences to
`action::defer_emit`.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6de31883b9f6a9a3115ae232575dffbdf652e0bd

show more ...

Migrate to Meson build

This commit focuses in enabling the meson build for the
phosphor-snmp repo.

To build and install using meson:
meson build
ninja -C build
ninja -C build install

Tested

Migrate to Meson build

This commit focuses in enabling the meson build for the
phosphor-snmp repo.

To build and install using meson:
meson build
ninja -C build
ninja -C build install

Tested By:
meson -Dtests=enabled build
ninja -C build test

Signed-off-by: Ratan Gupta <ratankgupta31@gmail.com>
Change-Id: I3a79a42d2fed3f39ae218f3e3f81fb165a12ea17

show more ...