Unit Test: Adding unit test cases UsrMgr

This changes set will add needed unit test cases for User Manager

Change-Id: I848cdbde528d41c2a09abcf35527044b6084f023
Signed-off-by: Abhilash Raju <abhilas

Unit Test: Adding unit test cases UsrMgr

This changes set will add needed unit test cases for User Manager

Change-Id: I848cdbde528d41c2a09abcf35527044b6084f023
Signed-off-by: Abhilash Raju <abhilash.kollam@gmail.com>

show more ...

Serialization: Adding Serialization for MFA

This commit will add the persistency of Dbus properties related to MFA.
The configuration file will be stored under
/var/lib/usr_mgr.conf.

Change-Id: Ib7

Serialization: Adding Serialization for MFA

This commit will add the persistency of Dbus properties related to MFA.
The configuration file will be stored under
/var/lib/usr_mgr.conf.

Change-Id: Ib7fdc467c7cb094d328ae670df3bb4352e4a7b91
Signed-off-by: Abhilash Raju <abhilash.kollam@gmail.com>

show more ...

increase maximum username length

This commit is intended to increase the maximum username length.
Currently we set the maximum username length as 30 characters. However
we have usecases where our us

increase maximum username length

This commit is intended to increase the maximum username length.
Currently we set the maximum username length as 30 characters. However
we have usecases where our username are exceeding the limit
(eg: `obmc.svc_openbmc__central_proxy`, length=31). This limitation
prohibit us to create a new account using this username. By increasing
the limit, we now allow creating an account with longer username.

Tested
- Create an account (post request to `/AccountService/Accounts`)
with 31-100 characters -> expect to be success
- Create an account (post request to `/AccountService/Accounts`)
with 101 characters -> expect to be failed

Change-Id: I15c66d2817eb48aea6b3b47be3d5ab85e08b12d0
Signed-off-by: Malik Akbar Hashemi Rafsanjani <malikrafsan@meta.com>

show more ...

MFA feature: Enable google authenticator

Enabling multi-factor authentication for BMC. This feature enables
google authenticator using TOTP method.
This commit implements interface published [here][

MFA feature: Enable google authenticator

Enabling multi-factor authentication for BMC. This feature enables
google authenticator using TOTP method.
This commit implements interface published [here][1]
and [here][2]

The implementation supports features such as create secret key,verify
TOTP token, enable system level MFA, and enable bypass options.

Currently the support is only for GoogleAuthenticator.

[1]: https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/yaml/xyz/openbmc_project/User/MultiFactorAuthConfiguration.interface.yaml

[2]: https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/yaml/xyz/openbmc_project/User/TOTPAuthenticator.interface.yaml

Tested By:
Unit test
https://gerrit.openbmc.org/c/openbmc/phosphor-user-manager/+/78583/1

Change-Id: I053095763c65963ff865b487ab08f05039d2fc3a
Signed-off-by: Abhilash Raju <abhilash.kollam@gmail.com>

show more ...

clang-tidy: Enable bugprone-unchecked-optional-access

Enable bugprone-unchecked-optional-access to detect the case that it
accesses std::optional without checking empty.

See https://gerrit.openbmc.

clang-tidy: Enable bugprone-unchecked-optional-access

Enable bugprone-unchecked-optional-access to detect the case that it
accesses std::optional without checking empty.

See https://gerrit.openbmc.org/c/openbmc/docs/+/78034 for details.

Change-Id: I5c2ccf5a734e9769d77c48e0de725ee87fac01af
Signed-off-by: Lei YU <yulei.sh@bytedance.com>

show more ...

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I295ded87d74037b2f4a6c4b85d82af20d49ae4a7
Signed-off-by: Patrick Williams <p

clang-format: update latest spec and reformat

Copy the latest format file from the docs repository and apply.

Change-Id: I295ded87d74037b2f4a6c4b85d82af20d49ae4a7
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: reformat with meson formatter

Apply the `meson format` results.

Change-Id: I73471b8ae6b57b537b4879f52f5db3c7c06f30f0
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

clang-format: re-format for clang-19

clang-format-19 isn't compatible with the clang-format-18 output, so we
need to reformat the code with the latest version. A few parameters
in clang-tidy have b

clang-format: re-format for clang-19

clang-format-19 isn't compatible with the clang-format-18 output, so we
need to reformat the code with the latest version. A few parameters
in clang-tidy have been deprecated, so adjust the style file
accordingly.

See Ie2f6eb3b043f2d655c9df806815afd7971fd0947 for updated style.
See I88192b41ab7a95599a90915013579608af7bc56f for clang-19 enablement.

Change-Id: I73ef7ee6dc13498d3fcbee4e5971028e61031ad0
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

user_mgr: Fix potential out-of-bounds access

If the sysconf method returns -1, an out-of-bounds access problem
will occur when declaring the following vector:
```
std::vector<char> buffer(buflen);
`

user_mgr: Fix potential out-of-bounds access

If the sysconf method returns -1, an out-of-bounds access problem
will occur when declaring the following vector:
```
std::vector<char> buffer(buflen);
```

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I1887cc418c40b01d839f9c0e25bef09a2605973b

show more ...

Fix MD001 warnings

The following warnings are generated by using markdownlint analysis:
```
docs/README.md:10 MD001/heading-increment Heading levels should only increment by one level at a time [Exp

Fix MD001 warnings

The following warnings are generated by using markdownlint analysis:
```
docs/README.md:10 MD001/heading-increment Heading levels should only increment by one level at a time [Expected: h3; Actual: h4]
```
Refer to markdown-lint [1] to fix MD001
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/001-header-increment.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I55d5132edb76bd2e46ea34d579b6a7b264581059

show more ...

Fix MD041 warnings

The following warnings are generated by using markdownlint analysis:
```
docs/README.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading

Fix MD041 warnings

The following warnings are generated by using markdownlint analysis:
```
docs/README.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "## To Build"]
```
Refer to markdown-lint [1] to fix MD041
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/041-first-line-h1.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I2bdb36a03a1e3d454f30f69ebbb95b21cacd32f8

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I75bbf0de40859a5e507455a52ceaef9be5b686c7
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: Ic3b71f8cc63e423ca725ce0480fa6686340207c9
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
```
Refer

Fix MD040 warnings

The following warnings are generated by using markdownlint analysis:
```
MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
```
Refer to markdown-lint [1] to fix MD040
[1]: https://github.com/updownpress/markdown-lint/blob/master/rules/040-fenced-code-language.md

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ib455fe1ac0113d54115f8a15ecb6cd4bfcc07681

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: I6959d908cd7b216568963488ead0f3d6ed4a6611
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Remove DEFAULT_CRYPT_ALGO meson configuration variables

This commit removes unused DEFAULT_CRYPT_ALGO meson configuration
variable

Change-Id: Ibc517e12f9cec20c951c4193797ff2beaec7e99f
Signed-off-by

Remove DEFAULT_CRYPT_ALGO meson configuration variables

This commit removes unused DEFAULT_CRYPT_ALGO meson configuration
variable

Change-Id: Ibc517e12f9cec20c951c4193797ff2beaec7e99f
Signed-off-by: Ravi Teja <raviteja28031990@gmail.com>

show more ...

OWNERS: Add Ravi Teja as a owner

I have worked on various features and fixed several issues in this
user-manager repository and redfish AccountService

I have a thorough understanding of LDAP and us

OWNERS: Add Ravi Teja as a owner

I have worked on various features and fixed several issues in this
user-manager repository and redfish AccountService

I have a thorough understanding of LDAP and user-manager
Thus, I am applying to be a maintainer of this repo. Hope i can
contribute more and help the OpenBMC community.

Here is my contributions in this repository
[1] https://github.com/openbmc/phosphor-user-manager/commits?author=raviteja-b

Change-Id: I50c689ebf5dbcb9f0ea28d3a8de0decdc0069b9b
Signed-off-by: Ravi Teja <raviteja28031990@gmail.com>

show more ...

Remove systemd meson configuration variables

This commit removes meson configuration variables which are not actually
configurable and can be hardcoded.

Change-Id: Id9d198bf6562e108b8a7472e770e6d8b

Remove systemd meson configuration variables

This commit removes meson configuration variables which are not actually
configurable and can be hardcoded.

Change-Id: Id9d198bf6562e108b8a7472e770e6d8bb84e2684
Signed-off-by: Ravi Teja <raviteja28031990@gmail.com>

show more ...

Remove web user group

This 'web' group is currently not doing anything and is considered to be
equivalent to 'redfish'.

Change-Id: I20a0a7e3a0bff3128e8e391317045a71038d119b
Signed-off-by: Ravi Teja

Remove web user group

This 'web' group is currently not doing anything and is considered to be
equivalent to 'redfish'.

Change-Id: I20a0a7e3a0bff3128e8e391317045a71038d119b
Signed-off-by: Ravi Teja <raviteja28031990@gmail.com>

show more ...

meson: Provide wrap file for boost

Currently local build on the system without boost can fail with
the following message:
"""
meson.build: ERROR: Dependency "boost" not found, tried system
"""
Provi

meson: Provide wrap file for boost

Currently local build on the system without boost can fail with
the following message:
"""
meson.build: ERROR: Dependency "boost" not found, tried system
"""
Provide "boost.wrap" file to fix the issue.

Change-Id: I596524f744cbe4ed0d43f464d23c67fef8886ee9
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

meson: Add boost to the dependencies

Since the project uses boost library add it to meson dependencies.

Tested:
Local build no longer fails with a missing boost headers message on the
system withou

meson: Add boost to the dependencies

Since the project uses boost library add it to meson dependencies.

Tested:
Local build no longer fails with a missing boost headers message on the
system without boost, but fails at the "meson setup build" stage with
an appropriate message.

Change-Id: I872159dcec923d289626b532146c9eb8d5461e1c
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

meson: Fix local cereal build

Currently local build is failing with a message:
"""
cereal| Exception: Failed to configure the CMake subproject: Could NOT
find Boost (missing: Boost_INCLUDE_DIR seria

meson: Fix local cereal build

Currently local build is failing with a message:
"""
cereal| Exception: Failed to configure the CMake subproject: Could NOT
find Boost (missing: Boost_INCLUDE_DIR serialization)
Subproject subprojects/cereal is buildable: NO (disabling)
"""
Since cereal requires boost only for the sandbox build and this
functionality is not needed, add option to skip building performance
sandbox comparison to solve the issue.

Tested:
"meson setup build" no longer fails with the cereal error.

Change-Id: Idbb40f930ee5633b2aac88ab6bd20dbafdbcad4e
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

BugFix: user name contains invalid characters

There is an typo in the policy "[a-zA-z_]" configuration.
It it should be "[a-zA-Z_]"
BTW: Group name has the same issue, fix it by the way.

Tested: Cr

BugFix: user name contains invalid characters

There is an typo in the policy "[a-zA-z_]" configuration.
It it should be "[a-zA-Z_]"
BTW: Group name has the same issue, fix it by the way.

Tested: Create a username contains invalid characters like: ^, [, or ].

Before: invalid character can be added as username
ipmitool user list 1
ID Name Callin
4 ^test true
5 [test true
7 ]test true
8 _test true

After: error will be returned once user name has invalid character.
ipmitool user set name 4 ^test4
Set User Name command failed (user 4, name ^test4): Unspecified error

UnitTest is added.

Change-Id: I86b062faea84906dde7cf37a0d51631d78526cb1
Signed-off-by: nichanghao.nch <nichanghao@linux.alibaba.com>
Signed-off-by: Kwin Wang <wangkuiying.wky@alibaba-inc.com>

show more ...

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer retur

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and auto.

Switch all uses of `enabled` to `allowed`.

Change-Id: I50f949d6323c4ff17e48901a56f7e34a76ca46db
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Update README file

This commit updates meson build steps

Change-Id: Iae3d995e47075fe8d7d31d78afbe91f81183a530
Signed-off-by: Ravi Teja <raviteja28031990@gmail.com>