build: remove explicit C++ standard check

Very few repositories have this extra check that the C++ standard
matches a particular version and instead choose to rely on compiler
header checks to verif

build: remove explicit C++ standard check

Very few repositories have this extra check that the C++ standard
matches a particular version and instead choose to rely on compiler
header checks to verify particular features are present. This
repository itself compiles with C++17 for now, so remove the explicit
check for C++20.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I366dc22f1daff483872db168ed5311233c839bae

show more ...

build: switch to C++20

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8e48e5949e210ef9b77ee9c1438f7b7963a12584

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Idda02eeec799a0d1b8eef474988e7e4c8d4dc65f

show more ...

service: Fix binary name

The meson build uses phosphor-time-manager instead of
phosphor-timemanager now.

Change-Id: I29a26ecc0cba8d9756e2c652bfbd2301627e6ae3
Signed-off-by: William A. Kennington II

service: Fix binary name

The meson build uses phosphor-time-manager instead of
phosphor-timemanager now.

Change-Id: I29a26ecc0cba8d9756e2c652bfbd2301627e6ae3
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

service: Remove waiting on host

Not all of our machines have hosts, and this daemon shouldn't need to
wait for a service that it doesn't directly depend on.

Change-Id: I703282c30555b9f04d96bc0a3b37

service: Remove waiting on host

Not all of our machines have hosts, and this daemon shouldn't need to
wait for a service that it doesn't directly depend on.

Change-Id: I703282c30555b9f04d96bc0a3b37c2ef901fc2df
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Update README

Updating the README with the commands: How to compile & Configure
the phosphor-time-manager with meson.

Signed-off-by: Ratan Gupta <ratagupt@linux.vnet.ibm.com>
Change-Id: Ie977c9b6a8

Update README

Updating the README with the commands: How to compile & Configure
the phosphor-time-manager with meson.

Signed-off-by: Ratan Gupta <ratagupt@linux.vnet.ibm.com>
Change-Id: Ie977c9b6a888a3135aef2db0eeb7fbe6eb766107

show more ...

Move service file into its own repo

Move the service file for phosphor-time-manager from the bitbake recipe to
the source repository.

There is no need of making the root object path and
the busname

Move service file into its own repo

Move the service file for phosphor-time-manager from the bitbake recipe to
the source repository.

There is no need of making the root object path and
the busname as configurable variable,Hence this commit
also removes those configure variables.

Tested: Service file were getting installed where expected.

Signed-off-by: Ratan Gupta <ratagupt@linux.vnet.ibm.com>
Change-Id: Ib297b4a1b35400ce34962b1bdaa59c6441f24b19

show more ...

Removing the autotools build framework

As we have moved to meson, hence removing the
autotools framework.

TestedBy: Code is getting compiled and all the
binaries and lib have been built.

Signed-of

Removing the autotools build framework

As we have moved to meson, hence removing the
autotools framework.

TestedBy: Code is getting compiled and all the
binaries and lib have been built.

Signed-off-by: Ratan Gupta <ratagupt@linux.vnet.ibm.com>
Change-Id: I8d25ab3d23a548be907d592c10449c23ac0ec000

show more ...

bootstrap: fix shellcheck warnings

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I86ef079c9632e5563a1a56d6a2e23aad59ecbc57

Enable Meson Build system for phoshphor-time-manager

- This commit enables the meson build system for the
phoshphor-time-manager repo.

Tested By:
- Code compiles both in arm & x86 sdks without er

Enable Meson Build system for phoshphor-time-manager

- This commit enables the meson build system for the
phoshphor-time-manager repo.

Tested By:
- Code compiles both in arm & x86 sdks without errors or warnings.
- All the unit test cases are getting passed.

Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>
Change-Id: I311bf33f34c6c71860e9c845b6ca3c591af8fa6a

show more ...

Fixing the unused variable compiler issue

- This commit would fix the error that are spotted by meson
when werror=true is enforced.

Tested By:

- Compiled , and unit tests are passed.

Signed

Fixing the unused variable compiler issue

- This commit would fix the error that are spotted by meson
when werror=true is enforced.

Tested By:

- Compiled , and unit tests are passed.

Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>
Change-Id: I330abdba69af36f8e02a1c22b76644beadb1c336

show more ...

clang-format: update to latest from docs repo

Since `Cpp11` is an alias for `Latest` and we should tend towards using the
latest C++ standard, update the C++ standard to Latest.

https://github.com/

clang-format: update to latest from docs repo

Since `Cpp11` is an alias for `Latest` and we should tend towards using the
latest C++ standard, update the C++ standard to Latest.

https://github.com/llvm/llvm-project/commit/e5032567903de19962333c4bf7d2edceaf4f9824#diff-b49a097415dff2837d9626d422c58ba8R82
https://github.com/openbmc/docs/blob/master/style/cpp/.clang-format

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I6bd62f057c6881b4e931c1968d71ce5478832d73

show more ...

Remove Deferred Updates

Remove deferred consumption of settings Manual/NTP and allow instant
consumption.

Tested:
Manually set the timeMode to NTP on the WEB and successfully.
busctl get-property x

Remove Deferred Updates

Remove deferred consumption of settings Manual/NTP and allow instant
consumption.

Tested:
Manually set the timeMode to NTP on the WEB and successfully.
busctl get-property xyz.openbmc_project.Settings
/xyz/openbmc_project/time/sync_method
xyz.openbmc_project.Time.Synchronization TimeSyncMethod
s "xyz.openbmc_project.Time.Synchronization.Method.NTP"

Manually set the date time successfully by D-Bus when timeMode is MANUAL
busctl set-property xyz.openbmc_project.Time.Manager
/xyz/openbmc_project/time/bmc xyz.openbmc_project.Time.EpochTime Elapsed
t 1514765953791262

Manually set the date time failed by D-Bus when timeMode is NTP.
busctl set-property xyz.openbmc_project.Time.Manager
/xyz/openbmc_project/time/bmc xyz.openbmc_project.Time.EpochTime Elapsed
t 1514765953791262
Failed to set property Elapsed on interface
xyz.openbmc_project.TIme.EpochTime: The operation failed

~# journalctl -b | grep timemanager
Jan 01 00:15:26 fp5280g2 phosphor-timemanager[309]: Error in setting
system time
Jan 01 00:15:26 fp5280g2 phosphor-timemanager[309]: The operation
failed

Refer: https://lists.ozlabs.org/pipermail/openbmc/2020-April/021409.html

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I7be25a9d0f56615bad6800a0b07df7f84fc0acc3

show more ...

clang-format: Add AfterCaseLabel option from clang-10

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I09c677d8063ba333bcc5084341b0719796da0f58

Remove TimeOwner Feature

The TimeOwner feature is confusing from feedback from the community and
hence removing the feature.
Remove the TimeOwner feature in the phosphor-time-manager repo and
needed

Remove TimeOwner Feature

The TimeOwner feature is confusing from feedback from the community and
hence removing the feature.
Remove the TimeOwner feature in the phosphor-time-manager repo and
needed settings objects.

Tested: Manually set the date time on the web and successfully update
the date time of BMC (eg: 2020/01/01 08:07:50).
busctrl get-property xyz.openbmc_project.Time.Manager
/xyz/openbmc_project/time/bmc
xyz.openbmc_project.Time.EpochTime Elapsed
t 1577837156385836

Refer: https://lists.ozlabs.org/pipermail/openbmc/2020-April/021409.html

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Id47eb0a03e0e94eeff29d2b77dccefb89cded7b8

show more ...

sdbusplus: replace message::variant with std::variant

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ifeb64ec42f9210b5640754e8a065d954f617ca44

sdbusplus: remove deprecated variant_ns

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4c8f4a9e1d18effb21cbbfe784e695832fa4ff4f

MAINTAINERS: Add Lei's IRC nickname

The IRC nickname for Lei was missing. Add it.

Change-Id: Ic6fa53c1a62d317d7afcfeaeda81d98807c1b589
Signed-off-by: Lei YU <mine260309@gmail.com>

Add vishwa as Maintainer

Change-Id: If9f84a47ee79d1d482163774f2bde28bb930faa7
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>

build: install into bin instead of sbin

Installs into bin instead of sbin per guidelines.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I2f61cbda4721533610516c0c91da4b3a16d15b52

build: pkg anti-pattern: use defaults

Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.

Change-Id: I91e5407066976b4d03e8a6b8d105e

build: pkg anti-pattern: use defaults

Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.

Change-Id: I91e5407066976b4d03e8a6b8d105e9bb8aecf5f7
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

README: Add special note on NTP setting change

Systemd timedated from v236 to v239 introduces a behavior change related
to setting time while NTP setting is changed.
This change causes phosphor-time

README: Add special note on NTP setting change

Systemd timedated from v236 to v239 introduces a behavior change related
to setting time while NTP setting is changed.
This change causes phosphor-time-manager automation test failure.

Add a special note in README to describe the issue, and the test case
will be updated.

Partially resolves openbmc/openbmc#3459

Change-Id: I8ee31e8de95d8b110bf9cbee7973c377a6d4330a
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

Use a single dbus connection object

Starting with sdbusplus 8ca6025, calling bus_new_default multiple times
doesn't seem to work - making calls that generate dbus traffic on one
of the objects resul

Use a single dbus connection object

Starting with sdbusplus 8ca6025, calling bus_new_default multiple times
doesn't seem to work - making calls that generate dbus traffic on one
of the objects results in something like:

sd_bus_call: System.Error.ENOTCONN: Transport endpoint is not connected

This wasn't ideal anyway - move to a single object, shared
application-wide.

Tested: Booted a witherspoon QEMU image and there were no coredumps
Change-Id: I804a1b1438b22f48e45b26d395135e401ca98a06
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

build: Add missing inclusion of phosphor-logging

Phosphor-logging is picked up by the configure_ac.
Include it in the Makefile such that it's available
as defined by the pkgconfig.

Change-Id: I173f

build: Add missing inclusion of phosphor-logging

Phosphor-logging is picked up by the configure_ac.
Include it in the Makefile such that it's available
as defined by the pkgconfig.

Change-Id: I173fa376ab3419155267ab08350d7a7ad2e1a0f0
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

Fix std::variant usage

We need to conform to the std::variant interface instead of the mapbox
specific one.

Change-Id: I3edbcb2682ddfebfcbca6e75284b11f2e18cfd11
Signed-off-by: William A. Kennington

Fix std::variant usage

We need to conform to the std::variant interface instead of the mapbox
specific one.

Change-Id: I3edbcb2682ddfebfcbca6e75284b11f2e18cfd11
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...