Fix getManagedObjects on ObjectManager returning no objects

Currently, when calling getManagedObjects
```
busctl call xyz.openbmc_project.Time.Manager \
/xyz/openbmc_project/time/bmc \
org.freed

Fix getManagedObjects on ObjectManager returning no objects

Currently, when calling getManagedObjects
```
busctl call xyz.openbmc_project.Time.Manager \
/xyz/openbmc_project/time/bmc \
org.freedesktop.DBus.ObjectManager \
GetManagedObjects
```
we end up getting no objects `a{oa{sa{sv}}} 0`. This is incorrect
and we technically should return the managed objects.
Looking further at the spec:
```
All returned object paths are children of the object path implementing
this interface, i.e. their object paths start with the ObjectManager's
object path plus '/'.
```
This implies that the the path owned by the object manager should
not be the bmc sub-entries but `/xyz/openbmc_project/time`

Change-Id: I3f2ee23ecfe745eb2e4e177e044645acc2015d88
Signed-off-by: Amithash Prasasd <amithash@meta.com>

show more ...

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda forma

clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version. The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: Ic2b241b0a752b9d36abdd37e87d9b2047e1211ca
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Synchronize NTP settings with systemd-timedated

Bmcweb get/set the "NTP settings" on phosphor-settings.
phosphor-time-manager and phosphor-settings are responsible to sync the
settings with systemd-

Synchronize NTP settings with systemd-timedated

Bmcweb get/set the "NTP settings" on phosphor-settings.
phosphor-time-manager and phosphor-settings are responsible to sync the
settings with systemd-timedated. So the services like bmcweb and ipmid
will only have to get/set the property on phosphor-settings.

However, in order to avoid a race condition issue with NTP set, bmcweb
now directly uses systemd instead of routing through phosphor-settings.
As a result, there may be differences in the "NTP settings" between
phosphor-setttings and systemd-timedated. To address this, this commit
adds a match to monitor time sync method changes on systemd-timedated
and updates it to phosphor-settings.

Tested:
```
1. Get current NTP setting:
busctl get-property org.freedesktop.timedate1 /org/freedesktop/timedate1 org.freedesktop.timedate1 NTP
b true

busctl get-property xyz.openbmc_project.Settings /xyz/openbmc_project/time/sync_method xyz.openbmc_project.Time.Synchronization TimeSyncMethod -j
{
"type" : "s",
"data" : "xyz.openbmc_project.Time.Synchronization.Method.NTP"
}

2. Call method in systemd timedate, to change NTP setting:
busctl call org.freedesktop.timedate1 /org/freedesktop/timedate1 org.freedesktop.timedate1 SetNTP bb false false

journal log:
phosphor-time-manager[28150]: Time mode has been changed to xyz.openbmc_project.Time.Synchronization.Method.Manual
phosphor-time-manager[28150]: NTP property changed in systemd time service, update to phosphor-settings.
phosphor-time-manager[28150]: NTP mode is already the same, skip setting to systemd time service again.

3. Get NTP setting again, NTP in phosphor-settings is synced with systemd-timedated:
busctl get-property org.freedesktop.timedate1 /org/freedesktop/timedate1 org.freedesktop.timedate1 NTP
b false

busctl get-property xyz.openbmc_project.Settings /xyz/openbmc_project/time/sync_method xyz.openbmc_project.Time.Synchronization TimeSyncMethod -j
{
"type" : "s",
"data" : "xyz.openbmc_project.Time.Synchronization.Method.Manual"
}

4. Set property in phosphor-settings, to change NTP setting:
busctl set-property xyz.openbmc_project.Settings /xyz/openbmc_project/time/sync_method xyz.openbmc_project.Time.Synchronization TimeSyncMethod s "xyz.openbmc_project.Time.Synchronization.Method.NTP"

journal log:
phosphor-time-manager[28150]: Updated NTP setting: True
phosphor-time-manager[28150]: Time mode has been changed to xyz.openbmc_project.Time.Synchronization.Method.NTP
phosphor-time-manager[28150]: NTP property changed in phosphor-settings, update to systemd time service.
phosphor-time-manager[28150]: NTP mode is already the same, skip setting to phosphor-settings again.

5. Get NTP setting again, NTP in phosphor-settings is synced with systemd-timedated:
busctl get-property org.freedesktop.timedate1 /org/freedesktop/timedate1 org.freedesktop.timedate1 NTP
b true

busctl get-property xyz.openbmc_project.Settings /xyz/openbmc_project/time/sync_method xyz.openbmc_project.Time.Synchronization TimeSyncMethod -j
{
"type" : "s",
"data" : "xyz.openbmc_project.Time.Synchronization.Method.NTP"
}
```

Signed-off-by: Jason Zhu <zhujiesen@bytedance.com>
Change-Id: I192d2257569f46aa0f5473331595c5242d816964

show more ...

Remove vishwa from the maintainers list

Vishwa is no longer associated with IBM and appears to have disengaged
from OpenBMC since 2022. Furthermore, his inactivity on Discord suggests
a lack of inte

Remove vishwa from the maintainers list

Vishwa is no longer associated with IBM and appears to have disengaged
from OpenBMC since 2022. Furthermore, his inactivity on Discord suggests
a lack of interest in OpenBMC. Consequently, it seems appropriate to
remove him from the maintainers list.

Vishwa - thankyou for your contributions to openbmc.

Change-Id: Idc8a428193e105ab1c25aab74ee9af39c9946784
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

OWNERS: Add Pavithra as a reviewer

I have been actively contributing to openbmc/phosphor-time-manager
for quite some time now. Attached is a summary of my contributions
to the repository [1].

I wou

OWNERS: Add Pavithra as a reviewer

I have been actively contributing to openbmc/phosphor-time-manager
for quite some time now. Attached is a summary of my contributions
to the repository [1].

I would like to learn & help out on the reviews.

[1]: https://github.com/openbmc/phosphor-time-manager/commits?author=Pavithrab7

Change-Id: I3470840fbf4409749f1139041c6df5d80f31533d
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

owners: updated George email

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I864c7b2131ebc41da6840638e3b1efa0bcc5b26a

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I8e667fbd643689de1ce20c0a024e0b4b50aa05b3
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

guideline: remove 'using namespace' from headers

Using namespace at global scope in a header file violates the cpp core
guidelines. Quoting the guidelines:

"Doing so takes away an #includer’s ab

guideline: remove 'using namespace' from headers

Using namespace at global scope in a header file violates the cpp core
guidelines. Quoting the guidelines:

"Doing so takes away an #includer’s ability to effectively
disambiguate and to use alternatives. It also makes #included headers
order-dependent as they might have different meaning when included in
different orders."

For further reading:
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rs-using-directive

Change-Id: I40fd6b31a94fe9a12426f76fc71d0832125a8740
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

show more ...

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer retur

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and auto.

Switch all uses of `enabled` to `allowed`.

Change-Id: I934c9ef13747134f41da36ee538d094c72fefdce
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

README.md: Replace meson_options.txt to meson.options

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I9db3af66deb7d3334be03606de61186e7a4e50cc

meson_options.txt: Support for reading options from meson.options

Since meson 1.1.0, Support has been added for reading options from
meson.options instead of meson_options.txt[1]. These are equivale

meson_options.txt: Support for reading options from meson.options

Since meson 1.1.0, Support has been added for reading options from
meson.options instead of meson_options.txt[1]. These are equivalent,
but not using the .txt extension for a build file has a few
advantages, chief among them many tools and text editors expect a
file with the .txt extension to be plain text files, not build
scripts.

[1] https://mesonbuild.com/Release-notes-for-1-1-0.html#support-for-reading-options-from-mesonoptions

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I3f82024a310fdb858377066c50711a068d2c8def

show more ...

Fix markdown format error

Run markdownlint, the following warning message appears:
```
README.md:15 MD040/fenced-code-language Fenced code blocks should
have a language specified [Conte

Fix markdown format error

Run markdownlint, the following warning message appears:
```
README.md:15 MD040/fenced-code-language Fenced code blocks should
have a language specified [Context: " ```"]
README.md:22 MD040/fenced-code-language Fenced code blocks should
have a language specified [Context: " ```"]
README.md:29 MD040/fenced-code-language Fenced code blocks should
have a language specified [Context: " ```"]
README.md:47 MD040/fenced-code-language Fenced code blocks should
have a language specified [Context: " ```"]
README.md:58 MD040/fenced-code-language Fenced code blocks should
have a language specified [Context: " ```"]
README.md:88 MD040/fenced-code-language Fenced code blocks should
have a language specified [Context: " ```"]
README.md:103 MD040/fenced-code-language Fenced code blocks should
have a language specified [Context: " ```"]
```

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Id48ba2ebe3c82982f8fcc5d2029324f129249fd7

show more ...

use fs.copyfile instead of deprecated copy

copy arg in configure_file API is deprecated since meson
version 0.64.0. As we moved to meson version 1.1.1 we can
leverage the filesystem module copyfile(

use fs.copyfile instead of deprecated copy

copy arg in configure_file API is deprecated since meson
version 0.64.0. As we moved to meson version 1.1.1 we can
leverage the filesystem module copyfile() to achive the
same result.

Tested:
1. With this change made sure that ninja install copied
the service file into the systemd unit directory on fedora.

```
[manojeda@fedora build]$ ninja install
[0/1] Installing files.
Installation failed due to insufficient permissions.
Attempt to use /usr/bin/sudo to gain elevated privileges? [y/n] y
[sudo] password for manojeda:
Installing xyz.openbmc_project.Time.Manager.service to /usr/lib/systemd/system
Installing phosphor-time-manager to /usr/local/bin
[manojeda@fedora build]$ cat /usr/lib/systemd/system/xyz.openbmc_project.Time.Manager.service
[Unit]
Description=Phosphor Time Manager daemon
Wants=mapper-wait@-xyz-openbmc_project-time-sync_method.service
After=mapper-wait@-xyz-openbmc_project-time-sync_method.service

[Service]
Restart=always
ExecStart=/usr/bin/phosphor-time-manager
Type=dbus
BusName=xyz.openbmc_project.Time.Manager

[Install]
WantedBy=multi-user.target
```

Change-Id: Ie95cd19e2f025ff6b564293fdb1b62a8898a8a40
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

time: changes to support 64bit time

Upstream changed the default of the time_t definition to go from 32bit
to 64bit. Utilize the std::chrono::duration class to abstract the max.

Tested:
- Confirmed

time: changes to support 64bit time

Upstream changed the default of the time_t definition to go from 32bit
to 64bit. Utilize the std::chrono::duration class to abstract the max.

Tested:
- Confirmed it compiles with latest yocto

Change-Id: I78e2b3475810cf0f4d218d7bf7e72be9641a47bf
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Build test cases by default

A default `meson build` does not build the test cases in the repository,
having the test cases built by default is a consistent behaviour across
all the openbmc repos.So

Build test cases by default

A default `meson build` does not build the test cases in the repository,
having the test cases built by default is a consistent behaviour across
all the openbmc repos.So making the change to build the tests by default
unless explicitly disabled.

Change-Id: I999e87a3711bc98f644c77f79700c0d55e5fede2
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I35bca64638976c0e20346

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I35bca64638976c0e20346d78d46311a580245503
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Add default time sync object path

The time sync object path is empty by default and is initialized by a
dbus call at runtime.
It works OK in BMC but the unit tests in the repo is broken due to the
e

Add default time sync object path

The time sync object path is empty by default and is initialized by a
dbus call at runtime.
It works OK in BMC but the unit tests in the repo is broken due to the
empty string used in the sdbus matcht_t.

Add a config option to initialize the default time sync object path, so
that it works both on BMC and in unit tests.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: Iccdaef58434a1227c4ea73230ba23b4e618a2d2d

show more ...

README: Move to "meson setup [options]"

Fixes the warning:
WARNING: Running the setup command as `meson [options]` instead of
`meson setup [options]` is ambiguous and deprecated.

Tested: The follow

README: Move to "meson setup [options]"

Fixes the warning:
WARNING: Running the setup command as `meson [options]` instead of
`meson setup [options]` is ambiguous and deprecated.

Tested: The following work:
meson setup builddir
ninja -C builddir

Change-Id: Idc8a5941e68dfe62395d9751a6c9cc3f3622ee0a
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I23581dad78b692e49f1c316aecf8a2bb7de95035
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Enable bugprone-reserved-identifier check

Change-Id: I76e61af4498468319474184e1f7c2968a1fcaf8e
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

Enable few more misc tidy checks.

Change-Id: Idcf8a74071441f0575c5e8b5179157e0d16a0a0a
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

Enable cppcoreguidelines-special-member-functions checks

Part of enforcing cpp core guidelines involves explicitly including all
constructors required on a non-trivial class. We were missing quite

Enable cppcoreguidelines-special-member-functions checks

Part of enforcing cpp core guidelines involves explicitly including all
constructors required on a non-trivial class. We were missing quite a
few. In all cases, the copy/move/and operator= methods are simply
deleted.

Change-Id: Ib71266e77808d15ae896891eea3e31c5b0394eb1
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

show more ...

Enable cppcoreguidelines check on the repo

This commit adds cppcoreguidelines clang-tidy
checks and make necessary changes.

Change-Id: I402b82f96b7ff82e3ba6d84c9cc50435c1ead6d4
Signed-off-by: Pavit

Enable cppcoreguidelines check on the repo

This commit adds cppcoreguidelines clang-tidy
checks and make necessary changes.

Change-Id: I402b82f96b7ff82e3ba6d84c9cc50435c1ead6d4
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

show more ...

Enable modernize tidy checks on the repo

This commit enables the modernize clang-tidy
checks.

Change-Id: I586303ebc257c6e6e05489247bc75d227b328607
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.

Enable modernize tidy checks on the repo

This commit enables the modernize clang-tidy
checks.

Change-Id: I586303ebc257c6e6e05489247bc75d227b328607
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

show more ...

Enable performance check on the repo

Change-Id: If47741fc93393ba65016ebe45d498e9fed42bb6c
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>