logs: add option to list logging entries

Remembering the busctl commands is a bit onerous so provide a wrapper
to quickly see the logging entries in the system

Tested:
root@witherspoon:~# obmcutil

logs: add option to list logging entries

Remembering the busctl commands is a bit onerous so provide a wrapper
to quickly see the logging entries in the system

Tested:
root@witherspoon:~# obmcutil listlogs
{
"type" : "as",
"data" : [
[
"/xyz/openbmc_project/logging/entry/1",
"/xyz/openbmc_project/logging/entry/2",
"/xyz/openbmc_project/logging/entry/3",
"/xyz/openbmc_project/logging/entry/4",
]
]
}

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ib1e4bb45c20ea487b64b59a8b440f35e0732ce72

show more ...

boot-block: inform user if blocking error present

If a boot blocking error is present then be sure the user is notified
when try a boot operation.

Tested:
root@witherspoon:~# obmcutil poweron
!!!!!

boot-block: inform user if blocking error present

If a boot blocking error is present then be sure the user is notified
when try a boot operation.

Tested:
root@witherspoon:~# obmcutil poweron
!!!!!!!!!!
WARNING! System has blocking errors that will prevent boot
Blocking Error: /xyz/openbmc_project/logging/entry/21
Blocking Error: /xyz/openbmc_project/logging/entry/24
!!!!!!!!!!

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Id856c809e4cd6b6d0621d682d29aec8d72f4b563

show more ...

boot-block: add option to query blocking errors

Being able to easily see if any blocking errors are present in the
system is a useful feature. A future commit will use this new interface
to tell the

boot-block: add option to query blocking errors

Being able to easily see if any blocking errors are present in the
system is a useful feature. A future commit will use this new interface
to tell the user if any blocking errors are present when they request a
boot of the system.

See the following design for more details:
https://github.com/openbmc/docs/blob/master/designs/fail-boot-on-hw-error.md

Tested:
- Verify blocking errors are printed
root@witherspoon:~# obmcutil bootblock
Blocking Error: /xyz/openbmc_project/logging/entry/19
Blocking Error: /xyz/openbmc_project/logging/entry/20

- Verify after resolving them, they are not printed
root@witherspoon:~# busctl set-property xyz.openbmc_project.Logging /xyz/openbmc_project/logging/entry/19 xyz.openbmc_project.Logging.Entry Resolved b 1
root@witherspoon:~# busctl set-property xyz.openbmc_project.Logging /xyz/openbmc_project/logging/entry/20 xyz.openbmc_project.Logging.Entry Resolved b 1
root@witherspoon:~# obmcutil bootblock
No blocking errors present

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I25e9a398a914372a4f051ad2034f2945c776901e

show more ...

boot-block: don't power on if blocking err present

If the user has enabled the setting to block the boot if an error with a
CALLOUT is logged and such an error is logged, ensure the chassis-poweron

boot-block: don't power on if blocking err present

If the user has enabled the setting to block the boot if an error with a
CALLOUT is logged and such an error is logged, ensure the chassis-poweron
target does not complete.

See the following design for more details:
https://github.com/openbmc/docs/blob/master/designs/fail-boot-on-hw-error.md

Tested:
With the following series of commits:
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-logging/+/32155/
- Verified that obmc-chassis-poweron@0.target did not complete when an
unresolved error was present.
- Verified that target did complete once the log was resolved

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: If07993eeaf0d468d12f7872c2ef469f08c90ff70

show more ...

sdbusplus: replace message::variant with std::variant

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If7c54cfe20a84fa91aacc309ebfa804231078bf7

sdbusplus: remove deprecated variant_ns

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie9d2f9838212aba7e3201f8af43586c48e273189

multi-user: do not use wants relationship

The multi-user target is run by systemd when the BMC first boots. It
contains all of the initial startup services. Some OpenBMC targets want
to ensure they

multi-user: do not use wants relationship

The multi-user target is run by systemd when the BMC first boots. It
contains all of the initial startup services. Some OpenBMC targets want
to ensure they are run after the multi-user target completes. A lot of
these targets did both a Wants and After relationship with multi-user.

The latest systemd, version 245, now takes that Wants relationship
seriously and will start any services within multi-user that are
stopped. This includes oneshot services which do not have the
"RemainAfterExit=yes" clause. If these services only expected to be run
once, as a part of multi-user, then they should include this clause but
you can see how they may expected to have only been run once.

The solution is twofold:
1) Fix the oneshot services that fall in the above scenario
2) Change the targets to not Wants=multi-user.target

1 will be changes throughout a few repositories.
2 is fixed in this commit.

Resolves openbmc/phosphor-state-manager#14

Tested:
Provided test image to George and he verified this fixed the above
issue

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I6eb7e5d2cb7d5a3c95f2e8ef6efc708dbb63fd52

show more ...

oneshot: discover-system-state: remain after exit

This service should only ever run once, after a BMC has first booted.
Ensure this is the case by setting RemainAfterExit to yes.

Signed-off-by: And

oneshot: discover-system-state: remain after exit

This service should only ever run once, after a BMC has first booted.
Ensure this is the case by setting RemainAfterExit to yes.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I346ab3588ee210709206a41c5e2acc73222561eb

show more ...

sched-host-tran: code refactor

Move setProperty() and getService() to utils.cpp as public functions
which can be reused.

Change-Id: If62b67978349a80f8bd2026b5a749d5dedc556de
Signed-off-by: Carol Wa

sched-host-tran: code refactor

Move setProperty() and getService() to utils.cpp as public functions
which can be reused.

Change-Id: If62b67978349a80f8bd2026b5a749d5dedc556de
Signed-off-by: Carol Wang <wangkair@cn.ibm.com>

show more ...

sched-host-tran: implement systemd service

Add service file to implement systemd service.

Change-Id: I6ccaad26d5fd6ad5ef6f39b901704835a9a918d3
Signed-off-by: Carol Wang <wangkair@cn.ibm.com>

sched-host-tran: store/restore the value of scheduled time and
requested transition

Store/restore the value of scheduled time and requested transition, in case
BMC is rebooted. After BMC is back, go

sched-host-tran: store/restore the value of scheduled time and
requested transition

Store/restore the value of scheduled time and requested transition, in case
BMC is rebooted. After BMC is back, go on the host transition process based
on the stored values.

Tested:
1. Get current time
# date
Tue Mar 10 08:16:40 UTC 2020
2. Set scheduled time 08:25:00
# busctl set-property xyz.openbmc_project.State.ScheduledHostTransition \
/xyz/openbmc_project/state/host0 \
xyz.openbmc_project.State.ScheduledHostTransition ScheduledTime t 1583828700
3. Reboot BMC
4. Check sheduled time
# busctl get-property xyz.openbmc_project.State.ScheduledHostTransition \
/xyz/openbmc_project/state/host0 \
xyz.openbmc_project.State.ScheduledHostTransition ScheduledTime
t 1583828700
5. Do host transition after the scheduled time is reached.
6. Check the scheduled time again
# busctl get-property xyz.openbmc_project.State.ScheduledHostTransition \
/xyz/openbmc_project/state/host0 \
xyz.openbmc_project.State.ScheduledHostTransition ScheduledTime
t 0

Change-Id: I3bbae19a49e2fe84bf4e297e6daaa0461cbf2cb8
Signed-off-by: Carol Wang <wangkair@cn.ibm.com>

show more ...

sched-host-tran: handle with BMC time changing

Handle with different processes when BMC time is changed after scheduled time
is set.

Tested:
Case1: BMC time is changed to be later than current time

sched-host-tran: handle with BMC time changing

Handle with different processes when BMC time is changed after scheduled time
is set.

Tested:
Case1: BMC time is changed to be later than current time but still earlier than
scheduled time
1. Get current time
# date
Tue Feb 25 07:07:44 UTC 2020
# date +%s
1582614271
2. Schedule time, do host transition after at 07:20:00 around
# busctl get-property xyz.openbmc_project.State.ScheduledHostTransition \
/xyz/openbmc_project/state/host0 \
xyz.openbmc_project.State.ScheduledHostTransition ScheduledTime
t 1582615256
3. Change BMC time to 07:19:00 around
# busctl set-property xyz.openbmc_project.Time.Manager \
/xyz/openbmc_project/time/bmc xyz.openbmc_project.Time.EpochTime Elapsed \
t 1582615136000000
# date
Tue Feb 25 07:19:20 UTC 2020
# date +%s
1582615187
4. Host transition is done after 1 minute around,
instead of waiting 13 mins around.

Case2: BMC time is changed after scheduled time is reached
Following Case1, the scheduled time is reached already,
1. Change BMC time to 07:10:00 around
# busctl set-property xyz.openbmc_project.Time.Manager \
/xyz/openbmc_project/time/bmc xyz.openbmc_project.Time.EpochTime Elapsed \
t 1582614600000000
2. APP shows "The function Scheduled Host Transition is disabled", because
the scheduled time is reached already and the scheduled time has been set
to 0 after host transition is triggered.

Case3: BMC time is changed to be bigger than scheduled time before scheduled
time is reached
1. Set scheduled time 07:08:00 around
# busctl set-property xyz.openbmc_project.State.ScheduledHostTransition \
/xyz/openbmc_project/state/host0 \
xyz.openbmc_project.State.ScheduledHostTransition ScheduledTime t 1582787314
2. Change BMC time to 07:10:00 around
# busctl set-property xyz.openbmc_project.Time.Manager \
/xyz/openbmc_project/time/bmc xyz.openbmc_project.Time.EpochTime Elapsed \
t 1582787434000000
3. It will do host transition as requested.

Case4: BMC time is changed to be earlier than current time
1. Set scheduled time 07:10:00 around
# busctl set-property xyz.openbmc_project.State.ScheduledHostTransition \
/xyz/openbmc_project/state/host0 \
xyz.openbmc_project.State.ScheduledHostTransition ScheduledTime t 1582787434
2. Change BMC time to 07:08:00 around
# busctl set-property xyz.openbmc_project.Time.Manager \
/xyz/openbmc_project/time/bmc xyz.openbmc_project.Time.EpochTime Elapsed \
t 1582787314000000
3. App will wait 2 minutes more to do host transition.

Change-Id: I23228be944d1b2f71161317228c8b16d7f5ca4eb
Signed-off-by: Carol Wang <wangkair@cn.ibm.com>

show more ...

sched-host-tran: implement host transition process

Set the scheduled time and host transition to trigger power on/off.

Tested:
1. Check the state first
$ curl -k -H "X-Auth-Token: $token" https://

sched-host-tran: implement host transition process

Set the scheduled time and host transition to trigger power on/off.

Tested:
1. Check the state first
$ curl -k -H "X-Auth-Token: $token" https://$bmc/xyz/openbmc_project/state/host0
{
"data": {
"AttemptsLeft": 3,
"BootProgress": "xyz.openbmc_project.State.Boot.Progress.ProgressStages.Unspecified",
"CurrentHostState": "xyz.openbmc_project.State.Host.HostState.Off",
"OperatingSystemState": "xyz.openbmc_project.State.OperatingSystem.Status.OSStatus.Inactive",
"RequestedHostTransition": "xyz.openbmc_project.State.Host.Transition.Off",
"RequestedTransition": "xyz.openbmc_project.State.Host.Transition.On",
"ScheduledTime": 0
},
"message": "200 OK",
"status": "ok"
}
2. Set a time in future
# busctl set-property xyz.openbmc_project.State.ScheduledHostTransition \
/xyz/openbmc_project/state/host0 \
xyz.openbmc_project.State.ScheduledHostTransition ScheduledTime t 1582184830
# busctl get-property xyz.openbmc_project.State.ScheduledHostTransition \
/xyz/openbmc_project/state/host0 \
xyz.openbmc_project.State.ScheduledHostTransition ScheduledTime
t 1582184830
3. Check the state again after scheduled time
Jan 15 06:38:20 WS-Seq-FW-2 phosphor-host-state-manager[442]: Host State transaction request
$ curl -k -H "X-Auth-Token: $token" https://$bmc/xyz/openbmc_project/state/host0
{
"data": {
"AttemptsLeft": 3,
"BootProgress": "xyz.openbmc_project.State.Boot.Progress.ProgressStages.Unspecified",
"CurrentHostState": "xyz.openbmc_project.State.Host.HostState.Running",
"OperatingSystemState": "xyz.openbmc_project.State.OperatingSystem.Status.OSStatus.Inactive",
"RequestedHostTransition": "xyz.openbmc_project.State.Host.Transition.On",
"RequestedTransition": "xyz.openbmc_project.State.Host.Transition.On",
"ScheduledTime": 0
},
"message": "200 OK",
"status": "ok"
}
4. Set quested transition to off
# busctl set-property xyz.openbmc_project.State.ScheduledHostTransition \
/xyz/openbmc_project/state/host0 \
xyz.openbmc_project.State.ScheduledHostTransition RequestedTransition \
s "xyz.openbmc_project.State.Host.Transition.Off"
# busctl set-property xyz.openbmc_project.State.ScheduledHostTransition \
/xyz/openbmc_project/state/host0 \
xyz.openbmc_project.State.ScheduledHostTransition ScheduledTime t 1582250580
$ curl -k -H "X-Auth-Token: $token" https://$bmc/xyz/openbmc_project/state/host0
{
"data": {
"AttemptsLeft": 3,
"BootProgress": "xyz.openbmc_project.State.Boot.Progress.ProgressStages.Unspecified",
"CurrentHostState": "xyz.openbmc_project.State.Host.HostState.Off",
"OperatingSystemState": "xyz.openbmc_project.State.OperatingSystem.Status.OSStatus.Inactive",
"RequestedHostTransition": "xyz.openbmc_project.State.Host.Transition.Off"
"RequestedTransition": "xyz.openbmc_project.State.Host.Transition.Off",
"ScheduledTime": 0
},
"message": "200 OK",
"status": "ok"
}

Change-Id: Ib9f3a3984005d9187a9b98603ec1598d8992869e
Signed-off-by: Carol Wang <wangkair@cn.ibm.com>

show more ...

sched-host-tran: handle with the scheduled time

Add the basic process to handle with the scheduled time

Tested:
1. Scheduled time is 0
# busctl set-property xyz.openbmc_project.State.ScheduledHos

sched-host-tran: handle with the scheduled time

Add the basic process to handle with the scheduled time

Tested:
1. Scheduled time is 0
# busctl set-property xyz.openbmc_project.State.ScheduledHostTransition \
/xyz/openbmc_project/state/host0 \
xyz.openbmc_project.State.ScheduledHostTransition ScheduledTime t 1
------
Feb 19 08:09:47 witherspoon phosphor-scheduled-host-transition[28263]: \
The function Scheduled Host Transition is disabled.
2. Scheduled time is the past
# busctl set-property xyz.openbmc_project.State.ScheduledHostTransition \
/xyz/openbmc_project/state/host0 \
xyz.openbmc_project.State.ScheduledHostTransition ScheduledTime t 1582100042
------
Failed to set property ScheduledTime on interface xyz.openbmc_project.State.\
ScheduledHostTransition: Scheduled time is in the past
Feb 19 08:14:42 witherspoon phosphor-scheduled-host-transition[28263]: \
Scheduled time is earlier than current time. Fail to do host transition.
Feb 19 08:14:42 witherspoon phosphor-scheduled-host-transition[28263]: \
Scheduled time is in the past

Change-Id: I0b6a98dcb6d0e70336bf42fc88a633abf3e64633
Signed-off-by: Carol Wang <wangkair@cn.ibm.com>

show more ...

sched-host-tran: add base interfaces for Scheduled Host Transition

Implement interfaces to get/set scheduledTime and requestedTransition.

Tested:
1. Check scheduledTime
# busctl get-property xyz.o

sched-host-tran: add base interfaces for Scheduled Host Transition

Implement interfaces to get/set scheduledTime and requestedTransition.

Tested:
1. Check scheduledTime
# busctl get-property xyz.openbmc_project.State.ScheduledHostTransition \
/xyz/openbmc_project/state/host0 \
xyz.openbmc_project.State.ScheduledHostTransition ScheduledTime
t 0
# busctl set-property xyz.openbmc_project.State.ScheduledHostTransition \
/xyz/openbmc_project/state/host0 \
xyz.openbmc_project.State.ScheduledHostTransition ScheduledTime t 1
# busctl get-property xyz.openbmc_project.State.ScheduledHostTransition \
/xyz/openbmc_project/state/host0 \
xyz.openbmc_project.State.ScheduledHostTransition ScheduledTime
t 1
2. Check requestedTransition
# busctl get-property xyz.openbmc_project.State.ScheduledHostTransition \
/xyz/openbmc_project/state/host0 \
xyz.openbmc_project.State.ScheduledHostTransition RequestedTransition
s "xyz.openbmc_project.State.Host.Transition.On"
# busctl set-property xyz.openbmc_project.State.ScheduledHostTransition \
/xyz/openbmc_project/state/host0 \
xyz.openbmc_project.State.ScheduledHostTransition RequestedTransition \
s "xyz.openbmc_project.State.Host.Transition.Off"
# busctl get-property xyz.openbmc_project.State.ScheduledHostTransition \
/xyz/openbmc_project/state/host0 \
xyz.openbmc_project.State.ScheduledHostTransition RequestedTransition
s "xyz.openbmc_project.State.Host.Transition.Off"

Change-Id: Ie7da8034d37c1069db043772f35982ca821826ae
Signed-off-by: Carol Wang <wangkair@cn.ibm.com>

show more ...

update for new host states and transitions

New host state and transitions have been approved via design docs and
phosphor-dbus-interfaces. Add these to the README.

ref:
https://github.com/openbmc/d

update for new host states and transitions

New host state and transitions have been approved via design docs and
phosphor-dbus-interfaces. Add these to the README.

ref:
https://github.com/openbmc/docs/blob/master/designs/state-management-and-external-interfaces.md
https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/State/Host.interface.yaml

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I1efad5bfdac7f4a3a1c5473e8d3cecbc77ed1095

show more ...

diag-mode: support entry into diagnostic mode

See DiagnosticMode definition in phosphor-dbus-interfaces for more
information:
https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/open

diag-mode: support entry into diagnostic mode

See DiagnosticMode definition in phosphor-dbus-interfaces for more
information:
https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/State/Host.interface.yaml

This target will be started by other software entities within OpenBMC so
phosphor-host-state-manager will monitor for this target to start and
update its state accordingly. System defined behavior will then
transition the system out of this state (quiesce, off, warm-reboot) and
state-manager will update as needed when those are seen.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ide599058dfe5596c3f40c9c295dd1259853b15a7

show more ...

change systemd signal handler to be more specific

Future commits will utilize a new signal handler looking at different
systemd signals so make the existing one more specific.

Signed-off-by: Andrew

change systemd signal handler to be more specific

Future commits will utilize a new signal handler looking at different
systemd signals so make the existing one more specific.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I97da05919b90bba3e2fe512d45767ad4f7e1bfff

show more ...

dead code: remove an unused definition

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I5ab7a638d57ac8a203b6eb7fd0ef6c63d06895e4

diag-mode: create new diagnostic mode target

This target will be used when the host is collecting diagnostic data. In
most cases this data is to help debug a failure of some sort in the host
subsyst

diag-mode: create new diagnostic mode target

This target will be used when the host is collecting diagnostic data. In
most cases this data is to help debug a failure of some sort in the host
subsystem.

phosphor-state-manager will track the entry and exit of this target
within its xyz.openbmc_project.State.Host D-Bus object. It will
correlate to "xyz.openbmc_project.State.Host.HostState.DiagnosticMode"

This target will be driven by other software components which are
communicating with the host and coordinating the diagnostics so the
target itself will have minimal services within it.

The CurrentHostState property within xyz.openbmc_project.State.Host will
be mapped to the InTest state within Redfish when this target is
running. The expectation is the target is only active when the host is
actively collecting diagnostic data.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Iee2f851875f4b029c16d54a5d0ded50953ca4cfb

show more ...

warm-reboot: support new host transitions

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Icc466c659deb88e0475856287ddff764033127c0

warm-reboot: add in new targets

These targets will be used to implement the new Host transitions defined
in the following design doc:
https://github.com/openbmc/docs/blob/master/designs/state-manage

warm-reboot: add in new targets

These targets will be used to implement the new Host transitions defined
in the following design doc:
https://github.com/openbmc/docs/blob/master/designs/state-management-and-external-interfaces.md

They provide the capability to reboot the host without cycling power to
the chassis. This makes reboots faster and can enable other features
where chassis power is needed to preserve certain aspects of the host
state.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I2d0ed226dea05bb4dbf194d04343c82f89316f33

show more ...

move openbmc targets into this repo

OpenBMC is moving towards individual repos hosting and maintaining their
own systemd files. This allows the corresponding maintainer more control
over their syste

move openbmc targets into this repo

OpenBMC is moving towards individual repos hosting and maintaining their
own systemd files. This allows the corresponding maintainer more control
over their systemd files and removes the meta-* layer maintainer from
needing to be involved.

The systemd targets defined and used by OpenBMC are implemented by
phosphor-state-manager code and services so move them into this
repository.

Once this is merged, its bump will need to be combined with a change in
the meta-phosphor layer that removes the target files.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I248bf79c95f66afefffcc152de79cd2791945819

show more ...

ensure reboot service runs after host stopped

OpenBMC has two types of targets, action and synchronization.
obmc-host-stop is an action target. You put services in it that you want
run when the targ

ensure reboot service runs after host stopped

OpenBMC has two types of targets, action and synchronization.
obmc-host-stop is an action target. You put services in it that you want
run when the target is started. obmc-host-stopped is a synchronization
target. You use it to ensure your service runs at the correct time. As a
part of the warm-reboot work, it was found that in certain conditions
this reboot service would run before the host was fully stopped due to
the way the obmc-host-stop action target is setup. Add the
synchronization target Wants/After in here to ensure this service is
only run after the host is stopped.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Id19034adc6309d20e94736948ae70d9cd6044263

show more ...

move state manager service files into its repo

OpenBMC is moving towards individual repos hosting and maintaining their
own service files. This allows the corresponding maintainer more control
over

move state manager service files into its repo

OpenBMC is moving towards individual repos hosting and maintaining their
own service files. This allows the corresponding maintainer more control
over their service file and removes the meta-* layer maintainer from
needing to be involved.

Once this is merged, its bump will need to be combined with a change in
the meta-phosphor layer that removes the service files.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ib9ebfb16e131bc2743b3fc9fcfdfb7370f455f8f

show more ...