Fix hard-coded host ID in HOST_RUNNING_FILE path

Replace hard-coded '0' with instance 'id' variable when formatting
HOST_RUNNING_FILE path. This ensures the correct host running file is
removed in m

Fix hard-coded host ID in HOST_RUNNING_FILE path

Replace hard-coded '0' with instance 'id' variable when formatting
HOST_RUNNING_FILE path. This ensures the correct host running file is
removed in multi-host configurations

related PR:
https://gerrit.openbmc.org/c/openbmc/phosphor-state-manager/+/86843

Change-Id: Ie3dc6c8b8bc7fd176d1e1caa29fe25f1e1b037f1
Signed-off-by: Ramya Sivakumar <sramya@ami.com>

show more ...

host_check: Define constants for mapper retry configuration

Replace hardcoded retry count (5) and delay (1000ms) with named
constants MAX_MAPPER_RETRIES and MAPPER_RETRY_DELAY in the
isHostRunning()

host_check: Define constants for mapper retry configuration

Replace hardcoded retry count (5) and delay (1000ms) with named
constants MAX_MAPPER_RETRIES and MAPPER_RETRY_DELAY in the
isHostRunning() function scope

This improves code maintainability by centralizing the retry
configuration

Change-Id: I3e5c5f6e7cea2d86a973d82ccddeddecb0fe3632
Signed-off-by: Ramya Sivakumar <sramya@ami.com>

show more ...

discover_system_state: Refactor D-Bus interface constant

Define dbusPropertiesInterface constant to avoid repeating the
"org.freedesktop.DBus.Properties" string literal throughout the code.
This imp

discover_system_state: Refactor D-Bus interface constant

Define dbusPropertiesInterface constant to avoid repeating the
"org.freedesktop.DBus.Properties" string literal throughout the code.
This improves maintainability by centralizing the interface name
definition

Changes:
- Added constexpr dbusPropertiesInterface constant in main()
- Replaced 3 hardcoded interface strings with the constant

Tested: Code compiles successfully and no functional change

Change-Id: I99ecae134f48ccde591b064b9296f48d53ebfea6
Signed-off-by: Ramya Sivakumar <sramya@ami.com>

show more ...

host_check: Use id parameter instead of hardcoded 0

The isHostRunning() function was using a hardcoded 0 when creating
the host running file, causing it to always create the file for host
instance 0

host_check: Use id parameter instead of hardcoded 0

The isHostRunning() function was using a hardcoded 0 when creating
the host running file, causing it to always create the file for host
instance 0 regardless of which host id was being checked

Fix by using the id parameter: std::format(HOST_RUNNING_FILE, id)

Tested: Verified correct host instance file is created

Change-Id: Ibde06f59f82a5bbaf7f9761149faa198b9346d21
Signed-off-by: Ramya Sivakumar <sramya@ami.com>

show more ...

obmcutil:refactor: Improve error handling and input validation

Make the script more robust and provide better error messages when
things go wrong

Tested:
- Confirmed obmcutil commands still work as

obmcutil:refactor: Improve error handling and input validation

Make the script more robust and provide better error messages when
things go wrong

Tested:
- Confirmed obmcutil commands still work as expected

Change-Id: I779cfbff2275495c80525447b2fca0c6573c3ba3
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

obmcutil:refactor: Optimize string operations and reduce sys calls

These changes improve performance by avoiding unnecessary subshells
and external process calls

Change-Id: Ibf936611b73eb7b2c64220e

obmcutil:refactor: Optimize string operations and reduce sys calls

These changes improve performance by avoiding unnecessary subshells
and external process calls

Change-Id: Ibf936611b73eb7b2c64220e9a393d5fedfc62b02
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

obmcutil:refactor: Reduce duplication in state query and prop setting

This reduces code duplication from ~40 lines to ~10 lines per operation,
making the code more maintainable and easier to underst

obmcutil:refactor: Reduce duplication in state query and prop setting

This reduces code duplication from ~40 lines to ~10 lines per operation,
making the code more maintainable and easier to understand

Change-Id: Ibb827019875dc85138ea579c53b6ba7874dbb996
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

obmcutil:refactor: Add common service lookup function

Create a common function for service lookup and add a cache to optimize
any repeated lookups

Change-Id: Ia5943f520ba75a15ba8cc0d513c364afcbc068

obmcutil:refactor: Add common service lookup function

Create a common function for service lookup and add a cache to optimize
any repeated lookups

Change-Id: Ia5943f520ba75a15ba8cc0d513c364afcbc068b2
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

obmcutil:refactor: Extract constants and improve code organization

Improve readability and maintainability without changing functionality

Change-Id: I2c4d128bdd8631dd8ca8cc0f4e3278162fe1eb56
Signed

obmcutil:refactor: Extract constants and improve code organization

Improve readability and maintainability without changing functionality

Change-Id: I2c4d128bdd8631dd8ca8cc0f4e3278162fe1eb56
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

systemd_target_signal: Define constants for systemd D-Bus strings

Replace hardcoded systemd D-Bus strings with named constants to
improve code maintainability and reduce duplication.

Added constant

systemd_target_signal: Define constants for systemd D-Bus strings

Replace hardcoded systemd D-Bus strings with named constants to
improve code maintainability and reduce duplication.

Added constants in systemd_target_signal.hpp:
- SYSTEMD_SERVICE: "org.freedesktop.systemd1"
- SYSTEMD_PATH: "/org/freedesktop/systemd1"
- SYSTEMD_MANAGER_IFACE: "org.freedesktop.systemd1.Manager"

Updated both the constructor match rules and all method calls in
startBmcQuiesceTarget(), subscribeToSystemdSignals() and
processNameChangeSignal() to use these constants

Tested:
- Code compiles successfully
- No functional changes, constants resolve to same string values

Change-Id: I7165d05e0380e0d9bed18c55b3171a1c6c058a28
Signed-off-by: Ramya Sivakumar <sramya@ami.com>

show more ...

bmc: state: Emit event for all state changes

Change Ic337969c5d30106495f5949839b7834e5e9e3de2 introduced
using the BMC.StateChanged event for the Quiesce case. Extend
this to be done for all cases.

bmc: state: Emit event for all state changes

Change Ic337969c5d30106495f5949839b7834e5e9e3de2 introduced
using the BMC.StateChanged event for the Quiesce case. Extend
this to be done for all cases.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie2e31226c8a29011e992381501fac15b6d4e2e5b

show more ...

bmc: state: Emit State event on Quiesced

When the BMC enters Quiesced, emit the StateChanged structured event
with STATE=Quiesced.

Motivation:
Provide a clear, structured log entry when the BMC tra

bmc: state: Emit State event on Quiesced

When the BMC enters Quiesced, emit the StateChanged structured event
with STATE=Quiesced.

Motivation:
Provide a clear, structured log entry when the BMC transitions to
Quiesced, ensuring the quiesced state change is explicitly recorded.

Change-Id: Ic337969c5d30106495f5949839b7834e5e9e3de2
Signed-off-by: Eric Yang <eric.yang.wiwynn@gmail.com>

show more ...

remove installs on templated services and targets

New yocto is getting more stringent on installation of templated service
and targets.

Templated services are installed by bitbake recipes so there'

remove installs on templated services and targets

New yocto is getting more stringent on installation of templated service
and targets.

Templated services are installed by bitbake recipes so there's no
need to have the WantedBy/RequiredBy in those services.

Here's a summary of the error we get for packages which have templated
services doing an install:
```
ERROR: obmc-phosphor-image-1.0-r0 do_rootfs: Postinstall scriptlets of
['<package>' 'inst returned 1, marking as unpacked only, configuration
required on target']
If the intention is to defer them to first boot,
then please place them into pkg_postinst_ontarget:${PN} ().
Deferring to first boot via 'exit 1' is no longer supported.
```

Tested:
- Confirmed image builds with new yocto and services are still installed
as expected

Change-Id: I56d9ac7a73dfd6bdaa05eba39d890a8af3605d18
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Add optional reboot on BMC Quiesced

Add a systemd oneshot service (phosphor-bmc-quiesce-reboot.service)
that reboots the BMC. When linked into
obmc-bmc-service-quiesce@0.target.wants, the BMC will r

Add optional reboot on BMC Quiesced

Add a systemd oneshot service (phosphor-bmc-quiesce-reboot.service)
that reboots the BMC. When linked into
obmc-bmc-service-quiesce@0.target.wants, the BMC will reboot upon
entering the BMC Quiesced target.

This change introduces a Meson feature option
"auto-reboot-on-bmc-quiesce" (disabled by default). When enabled, the
build installs a symlink from obmc-bmc-service-quiesce@0.target.wants
to phosphor-bmc-quiesce-reboot.service.

Motivation:
When critical services fail and the BMC enters Quiesced, a full BMC
reboot is often the cleanest recovery path. Making this policy
configurable allows platforms to automatically reboot on Quiesced.

Change-Id: I6c945dd1174723a26d4942b07a8e896131edc993
Signed-off-by: Eric Yang <eric.yang.wiwynn@gmail.com>

show more ...

host-state: make reboot count configurable via recipe

Make reset reboot count configurable via the already existing
boot-count-max-allowed option.

The default value is 3, that it's aligned with the

host-state: make reboot count configurable via recipe

Make reset reboot count configurable via the already existing
boot-count-max-allowed option.

The default value is 3, that it's aligned with the current behavior.

Tested:

On romulus qemu, without modifying the recipe:

- A call obmcutil poweron triggers the boot sequence the default number
of times before quiescing.

- The dbus property RetryAttempts is also set to the default value.

Modifying the recipe, and setting it to another value, e.g. 5

- The boot sequence is triggered up to 5 times before quiescing.

- The dbus property RetryAttemps is set to the correct value (in this
case 5)

Also checked that the phosphor-reset-host-reboot-attempts.service has
the configured value in both scenarios.

Change-Id: I8f999271faa0f1708fcaf8321caffdb38f3d9f39
Signed-off-by: Roger G. Coscojuela <roger.gili-coscojuela@sipearl.com>

show more ...

use sdbusplus unpack syntax

Rather than defining a variable and then reading it from a message,
sdbusplus also supports directly unpack-ing from the message. Use
this syntax instead as it is more e

use sdbusplus unpack syntax

Rather than defining a variable and then reading it from a message,
sdbusplus also supports directly unpack-ing from the message. Use
this syntax instead as it is more efficient and succinct.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I5ff2aa545ba88d06ea6ac95b83a329c7dfe8594e

show more ...

update BootProgressLastUpdate when BootProgress is set

Per the boot-progress.md[1] design document, the BootProgressLastUpdate
property should be updated with the current time since epoch in
microse

update BootProgressLastUpdate when BootProgress is set

Per the boot-progress.md[1] design document, the BootProgressLastUpdate
property should be updated with the current time since epoch in
microseconds whenever the BootProgress property is updated.

Tested:
- Confirmed that when BootProgress is updated, the
BootProgressLastUpdate was updated with the correct time

[1]: https://github.com/openbmc/docs/blob/master/designs/boot-progress.md

Change-Id: I96bc1b03441e14dbb23bb5d175fc480fa25a1d52
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

utils: use PDI constants

Use PDI constants where applicable.

Tested: Inspection only.

Change-Id: I730ef186462f5e8fd60ed4d8c73b29873dc6f769
Signed-off-by: Alexander Hansen <alexander.hansen@9elemen

utils: use PDI constants

Use PDI constants where applicable.

Tested: Inspection only.

Change-Id: I730ef186462f5e8fd60ed4d8c73b29873dc6f769
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

settings: use PDI constants

Use PDI constants where applicable.

Tested: Inspection only.

Change-Id: I2004b17c40dc94c8dab6dd43a1add46f873dad8d
Signed-off-by: Alexander Hansen <alexander.hansen@9ele

settings: use PDI constants

Use PDI constants where applicable.

Tested: Inspection only.

Change-Id: I2004b17c40dc94c8dab6dd43a1add46f873dad8d
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

secure boot check: use PDI constants

Use PDI constants where applicable.

Tested: Inspection only.

Change-Id: I633a1698449b657f3869c05e02460b27a1f762d9
Signed-off-by: Alexander Hansen <alexander.ha

secure boot check: use PDI constants

Use PDI constants where applicable.

Tested: Inspection only.

Change-Id: I633a1698449b657f3869c05e02460b27a1f762d9
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

schedule host transition: use PDI constants

Use PDI constants where applicable.

Tested: Inspection only.

Change-Id: Iee445ef96c91e35c996b139b38319aa256520353
Signed-off-by: Alexander Hansen <alexa

schedule host transition: use PDI constants

Use PDI constants where applicable.

Tested: Inspection only.

Change-Id: Iee445ef96c91e35c996b139b38319aa256520353
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

hypervisor state manager: use PDI constants

Use PDI constants where applicable.

Tested: Inspection only.

Change-Id: I981419a186a31dc3c7f40cc19da9a48d5704f955
Signed-off-by: Alexander Hansen <alexa

hypervisor state manager: use PDI constants

Use PDI constants where applicable.

Tested: Inspection only.

Change-Id: I981419a186a31dc3c7f40cc19da9a48d5704f955
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

host reset recovery: use PDI constants

Use PDI constants where applicable.

Tested: Inspection only.

Change-Id: I1a6eaa5a71ac74767ed9c364345a527e41a02a23
Signed-off-by: Alexander Hansen <alexander.

host reset recovery: use PDI constants

Use PDI constants where applicable.

Tested: Inspection only.

Change-Id: I1a6eaa5a71ac74767ed9c364345a527e41a02a23
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

host check: use PDI constants

Use PDI constants where applicable.

Tested: Inspection only.

Change-Id: I5f910bcb62b32fc5d65f9da536d38a2b7278fef3
Signed-off-by: Alexander Hansen <alexander.hansen@9e

host check: use PDI constants

Use PDI constants where applicable.

Tested: Inspection only.

Change-Id: I5f910bcb62b32fc5d65f9da536d38a2b7278fef3
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

discover system state: use PDI constants

Use PDI constants where applicable.

Tested: Inspection only.

Change-Id: If3c120ea1a9f168d19fae356d269e04fe943dd0f
Signed-off-by: Alexander Hansen <alexande

discover system state: use PDI constants

Use PDI constants where applicable.

Tested: Inspection only.

Change-Id: If3c120ea1a9f168d19fae356d269e04fe943dd0f
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...