beautysh: re-format

beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh
files to have a consistent formatting. Re-run the formatter on the
whole repository.

Signed-off-by: Patric

beautysh: re-format

beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh
files to have a consistent formatting. Re-run the formatter on the
whole repository.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8c4f46426087652161d7cbeab489bfe32d25f17e

show more ...

only quiesce in reboot on host crash

This script was introduced to ensure a system properly halted in
scenarios where the host has crashed (obmc-host-crash@.target). There
was a loophole where the s

only quiesce in reboot on host crash

This script was introduced to ensure a system properly halted in
scenarios where the host has crashed (obmc-host-crash@.target). There
was a loophole where the standard reboot attempt logic check was not
running in this specific path.

Unfortunately, that original change was not done quite right. This
script is actually called on all host reboots so we have run into
situations where the host is being put into quiesce before being given
one last try to boot. That last try in non-host crash scenarios is where
certain recovery actions (like trying alternate boot sources for some
devices) is done.

This commit modifies the script to ensure it only moves the host to the
quiesce state when the cause of the host reboot was a host crash.

Tested:
- Verified in normal reboot path, even if AttemptsLeft is 0, the reboot
is still done
- Verified that if AttemptsLeft is 0 and reboot reason is HostCrash that
host was put in quiesce

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I18e21cc33b3c38334ad760148a0754e2bd7d0780

show more ...

host-reboot: add host instance in get_reboot_count()

Add multi-host support to get_reboot_count()

Signed-off-by: Potin Lai <potin.lai@quantatw.com>
Change-Id: I77c00273bfcf4a45a6e24ac8e1a8540f2d609

host-reboot: add host instance in get_reboot_count()

Add multi-host support to get_reboot_count()

Signed-off-by: Potin Lai <potin.lai@quantatw.com>
Change-Id: I77c00273bfcf4a45a6e24ac8e1a8540f2d609e04

show more ...

host-reboot: enforce host boot count on host crash

The host reboot path can be triggered via paths outside of the normal
RequestedHostTransition property set. For example, if the host crashes,
it ju

host-reboot: enforce host boot count on host crash

The host reboot path can be triggered via paths outside of the normal
RequestedHostTransition property set. For example, if the host crashes,
it just triggers an automatic reboot using the systemd targets, which
means the check to prevent continuous host reboots is not run.

This commit ensures we decrement the reboot counter when a host crash
occurs, and it also ensures we check that count when deciding if a
reboot should occur.

While testing, it was found when we end in the host Quiesce state (after
all reboot attempts have expired), the host stayed in Quiesce, even
after issuing a power off. The fix for that was to ensure the
obmc-host-quiesce@.target conflicted with obmc-host-stop@.target to
ensure it would properly run on the power off request and update the
host state to Off.

Tested:
- Verified that AttemptsLeft was properly decremented on host crashes
- Verified that when AttempsLeft reached 0, the reboot was halted
and the host state was moved to Quiesced
- Verified that once in Quiesced, system could be powered off, and a
boot worked fine (and AttempsLeft was back to 3)

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I8d101b987517e160becc712ed70950f1d3204397

show more ...