prefer std::format over fmt

Now that std::format is implemented we aren't using complex enough fmt
to warrant using it over the std version. Switch to std and remove the
dependency.

Signed-off-by:

prefer std::format over fmt

Now that std::format is implemented we aren't using complex enough fmt
to warrant using it over the std version. Switch to std and remove the
dependency.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib03cdb6a9db4d25de345bdb49b28157880c19bc1

show more ...

reduce dbus string constants

There are a large number of dbus constants scattered throughout the
code that could/should be obtained from phosphor-dbus-interface values.
Perform minor refactoring to

reduce dbus string constants

There are a large number of dbus constants scattered throughout the
code that could/should be obtained from phosphor-dbus-interface values.
Perform minor refactoring to greatly reduce the number of string
constants.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie8700bc90611d21eee7160f4686bc978fe0a0eb4

show more ...

sdbus++: use non-deprecated namespaces

The sdbusplus repository has deprecated some namespaces and they are
currently only enabled with the SDBUSPP_REMOVE_DEPRECATED_NAMESPACE
guard. Switch to the

sdbus++: use non-deprecated namespaces

The sdbusplus repository has deprecated some namespaces and they are
currently only enabled with the SDBUSPP_REMOVE_DEPRECATED_NAMESPACE
guard. Switch to the new namespace names.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9f67e74a02616d8ea2241c18758308f2b669672d

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I41103c892db258a85640aa1442acd9a295c8a847

show more ...

Removed redundant string parsing

Newer sdbusplus builds support the converting of enumerations
to read directly as an std::string which eliminates the need
to unnecessarily parse them as strings.

S

Removed redundant string parsing

Newer sdbusplus builds support the converting of enumerations
to read directly as an std::string which eliminates the need
to unnecessarily parse them as strings.

Signed-off-by: Corey Hardesty <corey.hardesty@icloud.com>
Change-Id: Ic58b0ebac9c4769cc6aff291e9a1a48dcb16ed18

show more ...

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I2afb405177268451e44f0aff8417777a00d292d9

lg2: convert state-manager

This converts the rest of phosphor-state-manager over to the lg2
interface.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I387

lg2: convert state-manager

This converts the rest of phosphor-state-manager over to the lg2
interface.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I3878ec950b6a2b1ada93544cc021cecf14edfb46

show more ...

bmc-reset: move to quiesce if host was running

If the host was booting prior to the BMC reboot and it is no longer
responding, move the host to Quiesce state so recovery actions can be

bmc-reset: move to quiesce if host was running

If the host was booting prior to the BMC reboot and it is no longer
responding, move the host to Quiesce state so recovery actions can be
taken.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I0e441c5932628ee386ad1c7d9d924ff3dd5bd6d9

show more ...

bmc-reset: ensure chassis power on target complete

This logic will potentially launch the obmc-host-quiesce@.target so
ensure the transition to chassis power on has completed before

bmc-reset: ensure chassis power on target complete

This logic will potentially launch the obmc-host-quiesce@.target so
ensure the transition to chassis power on has completed before
initiating this new target.

Its a fairly complex scenario but basically this service is only
launched in scenarios where the BMC comes out of reset and pgood is on.
In that situation, the state management code creates a file,
/run/openbmc/obmc-chassis@0-on, and starts the
obmc-chassis-poweron@.target. Once all services have started as a part
of this target, the /run/openbmc/obmc-chassis@0-on file is deleted and
the CurrentPowerState is set to On. At this point, we want this new
logic to check if a host firmware boot was occurring prior to reboot and
if so, log an error and put system in Quiesce state to run recovery.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Id477557e2bd0bf0ad9ae3486338562961da153b5

show more ...

bmc-reset: create error if host was running

Notify user of system that the host is not responding and firmware will
be taking action.

Signed-off-by: Andrew Geissler <geissonator

bmc-reset: create error if host was running

Notify user of system that the host is not responding and firmware will
be taking action.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Icd2d12581b875bd54e77ebdc2a024efd1d035c64

show more ...

bmc-reset: check host boot progress prior to reset

This series of commits will add logic within the phosphor-state-manager
to log an error and initiate recovery operations when the BMC i

bmc-reset: check host boot progress prior to reset

This series of commits will add logic within the phosphor-state-manager
to log an error and initiate recovery operations when the BMC is
rebooted while the host is booting or if the host shuts itself down
while the BMC is rebooting. If the host continues to boot and
responds to the BMC queries when it comes out of reboot, then this new
service will never run. It is only if the host fails to respond (and it
was booting or booted prior to the BMC reboot) that this service runs.

The goal is to log an error and move the host to the Quiesce state so
the system recovery policy can be checked and executed by the existing
state management code.

Testing statements will be in the final commit of this series.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I18312ac55f0d0c3082992b6aecd10b0620966b20

show more ...